)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5af4826e718da04ebf8b16d361b38451c470785e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"719ee213_175fd866","updated":"2022-06-27 07:12:50.000000000","message":"recheck","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"26470f3c53380f881f5e0b23e546679e9cbacf7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e7a16cc3_23867e89","updated":"2022-06-26 13:52:41.000000000","message":"recheck","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0458b04cf6d39e422c56b66a6900fd53061ec5a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89a76094_935036aa","updated":"2022-06-27 13:17:33.000000000","message":"Ugh. missed the fix proposed here is slightly different from that seprate patch.","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4f03ee0205d9a2d7b96dd4f19bcdafc0c503a4dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e07ea777_2d5a1631","updated":"2022-06-27 12:53:34.000000000","message":"last minute change :)","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a243d25281ed3a37a58c0db18fb1c1561af02f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5adf9ee6_a25066b3","in_reply_to":"e07ea777_2d5a1631","updated":"2022-06-27 13:15:42.000000000","message":"There is a separate patch to fix that part https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847530 , so that we can backport it to further older branches but I\u0027m ok with having it merged to this and do stably-only partial backport.","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ef88f9937402be6c18fb09c90d48d67d6a792a02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9542888c_4501805c","updated":"2022-06-28 14:24:21.000000000","message":"recheck","commit_id":"9f7716584edd6408967b082a0457649016e97fea"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d04a210dde0d7116353e48f256b57844e1fb6aab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f9b9b697_a94bce0d","updated":"2022-07-06 14:09:59.000000000","message":"I thought we\u0027re fixing all is_set conditions as in earlier patch and not part of it (mention libvirt_file_backed_memory_enabled but don\u0027t fix it). I did not see the last line of the commit message.","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e205a7391f7cea4983880603a267e4c154b599f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"22453f4a_42974d43","updated":"2022-07-11 12:45:15.000000000","message":"recheck","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8ead5f02c4077bd28d58fec6522a629dfeac21e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6aa60e68_d36c0907","updated":"2022-07-06 13:33:16.000000000","message":"recheck","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"eeb7857aa17871ee08176452616767ac7d80c209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ceba0ede_60fe9aa3","updated":"2022-07-13 12:14:14.000000000","message":"recheck TestNetworkingBasicOps","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cc53beb442059ac0f1f4db01e2ee0426af69b01a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1a502a3_98632962","updated":"2022-07-08 12:56:06.000000000","message":"recheck post failure","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e56d1fa82da628d45b5bce629a272dd717faf50d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06d43b91_26c171d7","updated":"2022-07-15 15:02:10.000000000","message":"recheck the same","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ef21a04cdee1d6307bf6810deb0c6003cfa75d05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e0bdbee7_a1d1031d","updated":"2022-08-02 18:14:02.000000000","message":"recheck","commit_id":"89cdeb4ea6434ef26c790ecc5bba79651a3b1bf5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"17feb17c3d807d1e12efaad912da1c4707ebbdd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d62f849c_6e21728a","updated":"2022-07-26 07:20:04.000000000","message":"recheck\n\npep8 job has been fixed","commit_id":"89cdeb4ea6434ef26c790ecc5bba79651a3b1bf5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"10451dbcba99acf13936606a97c39e5a833840a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a16c2578_bea92104","updated":"2022-08-09 11:53:58.000000000","message":"recheck tempest","commit_id":"da8d88ae69c9d7eb80116a95ef6bc596b7751608"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b67c73ce9719e011094d46c09dd5a0b4b02fef7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f22649c8_03c389a3","updated":"2022-08-09 05:39:50.000000000","message":"recheck tempest failure","commit_id":"da8d88ae69c9d7eb80116a95ef6bc596b7751608"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b848e69fc6e940b20a0c587e984b093d1afa635d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"500364d3_beab5b18","updated":"2022-08-18 12:12:31.000000000","message":"all tempest tests fail with nova.exception.NoValidHost, but nova.conf contents was not changed by this patch, which is expected to have #max_queues\u003d\u003cNone\u003e","commit_id":"59286edd13760b1e7daa63c4c068963b9e1e5a3b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1e3e3a712f6274e5f59e9d790847e19fc1a97fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"17f5d852_d8fdacca","updated":"2022-08-18 11:53:42.000000000","message":"recheck tempest","commit_id":"59286edd13760b1e7daa63c4c068963b9e1e5a3b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ab61eb030b80495617797e8e65251d2c3d86562f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7c4df1bb_b546d4e4","updated":"2022-08-22 16:45:34.000000000","message":"why on earth this keeps failing...","commit_id":"59286edd13760b1e7daa63c4c068963b9e1e5a3b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cc31ffad3c64fbe3f8896c0636ae044ffefac9b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aa7c73c7_3fd8b0fe","updated":"2022-08-25 15:34:50.000000000","message":"2022-08-23 16:40:09.053 2 CRITICAL nova [None req-cdc29c91-abdc-40f1-bc53-40c336c4ab1a - - - - - -] Unhandled error: oslo_config.cfg.ConfigFileValueError: Value for option max_queues from LocationInfo(location\u003d\u003cLocations.user: (4, True)\u003e, detail\u003d\u0027/etc/nova/nova.conf\u0027) is not valid: Should be greater than or equal to 1\n2022-08-23 16:40:09.053 2 ERROR nova Traceback (most recent call last):\n2022-08-23 16:40:09.053 2 ERROR nova   File \"/usr/lib/python3.9/site-packages/oslo_config/cfg.py\", line 2716\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_28c/847334/10/check/tripleo-ci-centos-9-containers-multinode/28c0617/logs/subnode-1/var/log/containers/nova/nova-compute.log","commit_id":"08b3723915508cc60c4ee5baadad174978537663"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"94fe6362e11082e5771a6ba5318a6bdb94a06c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"95a76f3f_06581d62","updated":"2022-08-23 11:29:20.000000000","message":"Folks, I need help with debugging failing tempest tests.\n\nHiera configuration is unchanged by this patch (which only related to ... hiera data). But here tempest fails each time I recheck with famous no valid host found error.\n\nI took a passed OVB fs039 [0] and compared it to this execution [1]. If you have a clue to what else check there for nova placement or whatnot, please give me a hint\n\n[0] https://logserver.rdoproject.org/52/853952/1/openstack-check/tripleo-ci-centos-9-ovb-3ctlr_1comp_1supp-featureset039/bd31824/logs/undercloud/etc/puppet/hieradata\n\n[1] https://logserver.rdoproject.org/34/847334/9/openstack-check/tripleo-ci-centos-9-ovb-3ctlr_1comp_1supp-featureset039/96ba100/logs/undercloud/etc/puppet/hieradata/","commit_id":"08b3723915508cc60c4ee5baadad174978537663"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd8462a166ddc5df503099d7adad769d88d22824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5e4d7e06_de2487d7","updated":"2022-08-26 12:05:46.000000000","message":"this looks more reasonable\n\nby default we should not be setting this in the config and using \u0027\u0027 sound like a better default to me to model that.","commit_id":"573a9cdb63f9d0a8d3aa50c24c425290389cf1a4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"676ee7d480f2a3fa028f839bad401248a4d558bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"14538e39_8ce67896","in_reply_to":"5e4d7e06_de2487d7","updated":"2022-08-26 12:26:01.000000000","message":"thank you.\nFor backwards-compatibility, I\u0027ve added an extra treatment for \u00270\u0027. I am not certain if types of old values of a number 0 would always be properly provided from yaml inputs into heat values as numbers, or smart-casted into strings. So it\u0027s better to be on the safe path: fail early because of a type mismatch on upgrades, or properly handle \"smart types\" by given it an expected NULL meaning.","commit_id":"573a9cdb63f9d0a8d3aa50c24c425290389cf1a4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"85deb6ccf51fbe6c31384f29b837d1dde2384f38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ae5f67e4_adc16d4d","updated":"2022-08-29 14:09:53.000000000","message":"it worked, PTAL","commit_id":"18824865c03efb702f34164408f2a95b1f58f417"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ec40e78d4acae0af78868dea8d031646f0d946f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e3a566ff_adac0fdf","updated":"2022-08-29 05:42:19.000000000","message":"recheck bug 1986708","commit_id":"18824865c03efb702f34164408f2a95b1f58f417"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"2312e2b6bd7a0610cb01d3c264c3b31ce7eb470b","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, nova_libvirt_max_queues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f1bcdfff_b17e08fc","line":1201,"updated":"2022-06-24 06:52:30.000000000","message":"should be\n                - {get_attr: [RoleParametersValue, value, NovaLibvirtMaxQueues]} ?","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"ba447a955d881793740c2ffdf2f2018344e34081","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, nova_libvirt_max_queues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"68aa0b92_2edd7452","line":1201,"in_reply_to":"23c5f86e_56cf5505","updated":"2022-06-24 07:31:03.000000000","message":"Thank you!","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"75e0c47b2f6b44e1d47b9e11282f89bd1a052a95","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, nova_libvirt_max_queues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f482430a_73e10fc8","line":1201,"in_reply_to":"dd53942a_4b66172e","updated":"2022-06-24 07:14:54.000000000","message":"OK. Let\u0027s fix it separately, because we\u0027d need to backport that to further old stable branches.","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0c8d8c1cb0a05bd954219552ac0240f528299eef","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, nova_libvirt_max_queues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dd53942a_4b66172e","line":1201,"in_reply_to":"e2688c3b_cd2732b1","updated":"2022-06-24 07:05:06.000000000","message":"yes, it\u0027s a bug from https://review.opendev.org/c/openstack/tripleo-heat-templates/+/771365, but not related to this patch I guess.","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d441aa2344a6e16b46030cae6c7b7e187add6fd8","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, nova_libvirt_max_queues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e2688c3b_cd2732b1","line":1201,"in_reply_to":"f1bcdfff_b17e08fc","updated":"2022-06-24 07:00:49.000000000","message":"I\u0027m afraid RoleParametersValue is missing the key for NovaLibvirtMaxQueues parameter now. We should add that nova_libvirt_max_queues key in the hash under map_replace .","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7360dc6326ca40bc13004dbaf531eea46afe1458","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, nova_libvirt_max_queues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"23c5f86e_56cf5505","line":1201,"in_reply_to":"f482430a_73e10fc8","updated":"2022-06-24 07:26:50.000000000","message":"Submitted https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847530","commit_id":"6b3760ddbacd065460e0f028ca934c6302c1bbae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0458b04cf6d39e422c56b66a6900fd53061ec5a5","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, NovaLibvirtMaxQueues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cf7a3e13_156f50f6","line":1201,"range":{"start_line":1201,"start_character":58,"end_line":1201,"end_character":78},"updated":"2022-06-27 13:17:33.000000000","message":"this does not work if the parameter is defined by the global one instead of role specific ones.","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7bd7b0dec7bfb053112d63e751febb5b2af0390b","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, NovaLibvirtMaxQueues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b4cc96a2_e9e13659","line":1201,"range":{"start_line":1201,"start_character":58,"end_line":1201,"end_character":78},"in_reply_to":"4d0588a3_3afb801d","updated":"2022-06-27 13:25:24.000000000","message":"Done","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c01db6120a7718cf179b32ce6bff11b257642aed","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, NovaLibvirtMaxQueues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4d0588a3_3afb801d","line":1201,"range":{"start_line":1201,"start_character":58,"end_line":1201,"end_character":78},"in_reply_to":"7f4b7b1a_f7467155","updated":"2022-06-27 13:25:12.000000000","message":"ok, let\u0027s keep https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847530 as a separated change","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c1d5ac931bff72975b4ecacbd7c711942d753d6a","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, NovaLibvirtMaxQueues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d72818fe_69231582","line":1201,"range":{"start_line":1201,"start_character":58,"end_line":1201,"end_character":78},"in_reply_to":"cf7a3e13_156f50f6","updated":"2022-06-27 13:21:19.000000000","message":"Ack","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d28779bff8ea4c23f54a9a549c313c08ce3a8121","unresolved":true,"context_lines":[{"line_number":1198,"context_line":"            nova::compute::libvirt::max_queues:"},{"line_number":1199,"context_line":"              if:"},{"line_number":1200,"context_line":"                - nova_libvirt_max_queues_set"},{"line_number":1201,"context_line":"                - {get_attr: [RoleParametersValue, value, NovaLibvirtMaxQueues]}"},{"line_number":1202,"context_line":"            # Params to enable service check on FFU"},{"line_number":1203,"context_line":"            nova::workarounds::disable_compute_service_check_for_ffu: {get_param: NovaDisableComputeServiceCheckForFfu}"},{"line_number":1204,"context_line":"          - if:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f4b7b1a_f7467155","line":1201,"range":{"start_line":1201,"start_character":58,"end_line":1201,"end_character":78},"in_reply_to":"cf7a3e13_156f50f6","updated":"2022-06-27 13:22:23.000000000","message":"or maybe it does not work even if the role speficic ones are used.  We need to register this key to the core dict starting from L946, otherwise the subsequent map_replace does not work because the target key does not exist, IIUC.","commit_id":"9dda34ffbf59ac226588a809ae74d757cb9ac9a1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"f14912a785faeb1c3e17931362bc8853be5f065e","unresolved":true,"context_lines":[{"line_number":863,"context_line":"      and:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"238940f1_b1660482","line":866,"updated":"2022-07-04 14:03:09.000000000","message":"Does NovaLibvirtFileBackedMemory being 0 or empty mean libvirt_file_backed_memory_disabled? NovaLibvirtFileBackedMemory can\u0027t be 0 and \u0027\u0027 at the same time so one of these is going to return false isn\u0027t it - and won\u0027t that be interpreted as the value being set?","commit_id":"074416d20a4ff162624fb30b3ba2b0d0980398ba"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1a94a645934580909102d330cdc15e77783d2add","unresolved":true,"context_lines":[{"line_number":863,"context_line":"      and:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"761ebb65_77ff8d95","line":866,"in_reply_to":"238940f1_b1660482","updated":"2022-07-05 15:10:08.000000000","message":"I think you\u0027re right, a more complex check is needed here. I\u0027ll push that away into a follow up. As I have to address the NovaLibvirtMaxQueues problem first","commit_id":"074416d20a4ff162624fb30b3ba2b0d0980398ba"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"918345c3ff95ddf4b7ec951eeacd68b1ade69abd","unresolved":false,"context_lines":[{"line_number":863,"context_line":"      and:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4b902d82_73bb5f44","line":866,"in_reply_to":"761ebb65_77ff8d95","updated":"2022-07-05 15:16:42.000000000","message":"Done","commit_id":"074416d20a4ff162624fb30b3ba2b0d0980398ba"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d1c421f84c7e29dd76da68051addb2ed8f466c7b","unresolved":true,"context_lines":[{"line_number":858,"context_line":"    and:"},{"line_number":859,"context_line":"      - not: {equals: [{get_param: NovaComputeStartupDelay}, 0]}"},{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    not:"},{"line_number":863,"context_line":"      or:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"629fe8b4_687e7656","line":866,"range":{"start_line":861,"start_character":0,"end_line":866,"end_character":62},"updated":"2022-07-06 00:58:14.000000000","message":"This is incorrect.. When NovaLibvirtFileBackedMemory is not in role parameters it would be set to false (inspite of global parameter).\n\nWe can remove L864.. numbers can\u0027t be empty strings and change it to\n\nnot:\n   and:\n     -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]\n     -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]\n     \nIf we still want to check NovaLibvirtFileBackedMemory as 0 in RoleParamter (not required IMO) we\u0027ve rewrite it differently.","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a4ff76735b3140a1f619f68bedfa2b8ddcc7bbbb","unresolved":false,"context_lines":[{"line_number":858,"context_line":"    and:"},{"line_number":859,"context_line":"      - not: {equals: [{get_param: NovaComputeStartupDelay}, 0]}"},{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    not:"},{"line_number":863,"context_line":"      or:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7112fefe_3f615e38","line":866,"range":{"start_line":861,"start_character":0,"end_line":866,"end_character":62},"in_reply_to":"51d53d89_892cdaf5","updated":"2022-07-06 13:32:55.000000000","message":"could you please vote on the top patch? I removed this change from this patch scope","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cb7edc4ffe8792d099fd793b58dfc503db9f4f88","unresolved":true,"context_lines":[{"line_number":858,"context_line":"    and:"},{"line_number":859,"context_line":"      - not: {equals: [{get_param: NovaComputeStartupDelay}, 0]}"},{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    not:"},{"line_number":863,"context_line":"      or:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"51d53d89_892cdaf5","line":866,"range":{"start_line":861,"start_character":0,"end_line":866,"end_character":62},"in_reply_to":"629fe8b4_687e7656","updated":"2022-07-06 13:29:53.000000000","message":"It has the number type, how can it be set to false?\nIs that noEcho takes into play?","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"37e2fddbd2070436672cf0a306d848352fa9297c","unresolved":false,"context_lines":[{"line_number":858,"context_line":"    and:"},{"line_number":859,"context_line":"      - not: {equals: [{get_param: NovaComputeStartupDelay}, 0]}"},{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    not:"},{"line_number":863,"context_line":"      or:"},{"line_number":864,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":865,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":866,"context_line":"      -  equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]"},{"line_number":867,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"},{"line_number":868,"context_line":"  reserved_huge_pages_set:"},{"line_number":869,"context_line":"    not:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f6f57a37_6161a2d2","line":866,"range":{"start_line":861,"start_character":0,"end_line":866,"end_character":62},"in_reply_to":"7112fefe_3f615e38","updated":"2022-07-06 14:06:16.000000000","message":"Not sure what you mean. One of the conditions have to be true for libvirt_file_backed_memory_enabled to be false right?\n\n1. equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027] (always false as it\u0027s number)\n2. equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027] (true if no role parameter set)\n\nSo, \u0027libvirt_file_backed_memory_enabled\u0027 would be false (not true), when NovaLibvirtFileBackedMemory global parameter has a non-zero value and role specific parameter is not provided.","commit_id":"83deef7c409e6c5c6698c0def06678efeaf3812e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c650cb6a398de1562629ba7adca635f64e7b579b","unresolved":true,"context_lines":[{"line_number":681,"context_line":"      The number of virtio queues allocated will be the lesser of the CPUs"},{"line_number":682,"context_line":"      requested by the guest and the max value defined."},{"line_number":683,"context_line":"      Default 0 corresponds to not set"},{"line_number":684,"context_line":"    default: 0"},{"line_number":685,"context_line":"    tags:"},{"line_number":686,"context_line":"      - role_specific"},{"line_number":687,"context_line":"  GlanceRbdPoolName:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f84eede9_10b2550b","line":684,"updated":"2022-08-25 15:38:37.000000000","message":"this should be unest with no default.\nthe min value is 1 so the current value is invalid and  is propagating to the config\n\nhttps://zuul.opendev.org/t/openstack/build/28c061746356463eb007c20c407e33f6/log/logs/subnode-1/var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf#3619","commit_id":"08b3723915508cc60c4ee5baadad174978537663"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"12b08d6d0d936052c593b95dd0ab21703850d634","unresolved":false,"context_lines":[{"line_number":681,"context_line":"      The number of virtio queues allocated will be the lesser of the CPUs"},{"line_number":682,"context_line":"      requested by the guest and the max value defined."},{"line_number":683,"context_line":"      Default 0 corresponds to not set"},{"line_number":684,"context_line":"    default: 0"},{"line_number":685,"context_line":"    tags:"},{"line_number":686,"context_line":"      - role_specific"},{"line_number":687,"context_line":"  GlanceRbdPoolName:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fc55ab32_62d0962f","line":684,"in_reply_to":"f829169d_10254ed1","updated":"2022-08-25 15:59:20.000000000","message":"I don\u0027t think there is an issue with the default as the condition would not set the hiera if the value is 0. \n\nThe issue is in the condition where you don\u0027t check for empty string from RoleParameters. If a NovaLibvirtMaxQueues is not in RoleParameters {get_param: [RoleParameters, NovaLibvirtMaxQueues]} would be \u0027\u0027 and \u0027nova_libvirt_max_queues_set\u0027 would be \u0027true\u0027 and you it would endup setting 0 for the hiera.\n\nI somehow missed it in the review.","commit_id":"08b3723915508cc60c4ee5baadad174978537663"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"677acd02c02d747d5a6ecf15fc36bc5970a0cf33","unresolved":false,"context_lines":[{"line_number":681,"context_line":"      The number of virtio queues allocated will be the lesser of the CPUs"},{"line_number":682,"context_line":"      requested by the guest and the max value defined."},{"line_number":683,"context_line":"      Default 0 corresponds to not set"},{"line_number":684,"context_line":"    default: 0"},{"line_number":685,"context_line":"    tags:"},{"line_number":686,"context_line":"      - role_specific"},{"line_number":687,"context_line":"  GlanceRbdPoolName:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f829169d_10254ed1","line":684,"in_reply_to":"f84eede9_10b2550b","updated":"2022-08-25 15:48:34.000000000","message":"yes, thank you for more eyes on that.\n\nthe fix uncovered the wrong default we used to have since this parameter introduction. The fix just made it apllied and visible for puppet and nova, while earlier - it was not applied at all\n\n\npatched env:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_28c/847334/10/check/tripleo-ci-centos-9-containers-multinode/28c0617/logs/subnode-1/var/log/containers/nova/nova-compute.log\nsubnode-1/etc/puppet/hieradata/service_configs.json:    \"nova::compute::libvirt::max_queues\": 0,\nsubnode-1/etc/puppet/hieradata/service_configs.json:    \"nova_libvirt_max_queues\": 0,\nunpatched env:\nhttps://logserver.rdoproject.org/58/458/b46461db37c261c88260d5bb4bd638d9aee5e8f3/github-manual/tripleo-ci-centos-9-containers-multinode/0a693c7/logs/subnode-1/etc/puppet/hieradata/service_configs.json.txt.gz\nsubnode-1/etc/puppet/hieradata/service_configs.json:    \"nova_libvirt_max_queues\": 0,","commit_id":"08b3723915508cc60c4ee5baadad174978537663"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fc9c2db94a50a3b675b55fa91951a1a9aaa922f2","unresolved":true,"context_lines":[{"line_number":882,"context_line":"  nova_libvirt_max_queues_set:"},{"line_number":883,"context_line":"    not:"},{"line_number":884,"context_line":"      and:"},{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, \"\"]"},{"line_number":886,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":887,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":888,"context_line":"    or:"},{"line_number":889,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e2a7f407_0e96c1a0","line":886,"range":{"start_line":885,"start_character":0,"end_line":886,"end_character":74},"updated":"2022-08-25 16:09:17.000000000","message":"This won\u0027t work. If you set NovaLibvirtMaxQueues or the one for a role in *RoleParameter to 0, it would set \u00270\u0027 in hiera and it would fail like before.","commit_id":"6eb1c43408ea7ea6b17d3ada1c94708dfb9bedca"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"742ceceb5c36325147af28781751753ca3c6a828","unresolved":false,"context_lines":[{"line_number":882,"context_line":"  nova_libvirt_max_queues_set:"},{"line_number":883,"context_line":"    not:"},{"line_number":884,"context_line":"      and:"},{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, \"\"]"},{"line_number":886,"context_line":"      -  equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":887,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":888,"context_line":"    or:"},{"line_number":889,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"a175450a_1df4ce68","line":886,"range":{"start_line":885,"start_character":0,"end_line":886,"end_character":74},"in_reply_to":"e2a7f407_0e96c1a0","updated":"2022-08-26 12:03:16.000000000","message":"Done","commit_id":"6eb1c43408ea7ea6b17d3ada1c94708dfb9bedca"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1eac00c8e59ed6c13b59b073a754803da9f8ac15","unresolved":true,"context_lines":[{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, 0]"},{"line_number":886,"context_line":"      -  or:"},{"line_number":887,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":888,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, 0]"},{"line_number":889,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":890,"context_line":"    or:"},{"line_number":891,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"b0183a06_c0903f77","line":888,"updated":"2022-08-26 11:54:17.000000000","message":"this doesn\u0027t look correct as 0 is not accepted value, nova compute refuses to start","commit_id":"34c3837b16c489ba4ef79d5dd2ca4a5e168dcb9f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bf1646061515b3befb3e54cb9b1afc2605553b28","unresolved":false,"context_lines":[{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, 0]"},{"line_number":886,"context_line":"      -  or:"},{"line_number":887,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":888,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, 0]"},{"line_number":889,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":890,"context_line":"    or:"},{"line_number":891,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"f453478f_11b8b39b","line":888,"in_reply_to":"74f92e8f_e24f79bd","updated":"2022-08-26 13:55:05.000000000","message":"Actually, that revision #13 also won\u0027t work. A number check against an empty string does not make sense","commit_id":"34c3837b16c489ba4ef79d5dd2ca4a5e168dcb9f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"742ceceb5c36325147af28781751753ca3c6a828","unresolved":false,"context_lines":[{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, 0]"},{"line_number":886,"context_line":"      -  or:"},{"line_number":887,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":888,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, 0]"},{"line_number":889,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":890,"context_line":"    or:"},{"line_number":891,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df20b4bf_f96ab846","line":888,"in_reply_to":"b0183a06_c0903f77","updated":"2022-08-26 12:03:16.000000000","message":"Done","commit_id":"34c3837b16c489ba4ef79d5dd2ca4a5e168dcb9f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e5e51292327bbca42938aceed29bf29c77946d99","unresolved":false,"context_lines":[{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, 0]"},{"line_number":886,"context_line":"      -  or:"},{"line_number":887,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":888,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, 0]"},{"line_number":889,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":890,"context_line":"    or:"},{"line_number":891,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"74f92e8f_e24f79bd","line":888,"in_reply_to":"df20b4bf_f96ab846","updated":"2022-08-26 12:59:13.000000000","message":"As mentioned earlier 0 would never be set and it was correct as I proposed. We should not change a number parameter type to string. It goes in user documentation and would accept any string and fail in nova.","commit_id":"34c3837b16c489ba4ef79d5dd2ca4a5e168dcb9f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"176a69c3e187e5701e77fab7c94e61f60dc53c7a","unresolved":false,"context_lines":[{"line_number":885,"context_line":"      -  equals: [{get_param: NovaLibvirtMaxQueues}, 0]"},{"line_number":886,"context_line":"      -  or:"},{"line_number":887,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, \"\"]"},{"line_number":888,"context_line":"           - equals: [{get_param: [RoleParameters, NovaLibvirtMaxQueues]}, 0]"},{"line_number":889,"context_line":"  glance_enable_rbd_download_set:"},{"line_number":890,"context_line":"    or:"},{"line_number":891,"context_line":"      - and:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"10ad01cb_1d39f1ed","line":888,"in_reply_to":"f453478f_11b8b39b","updated":"2022-08-26 13:59:11.000000000","message":"or would it?.. I give up. Let\u0027s use rev 13 :)","commit_id":"34c3837b16c489ba4ef79d5dd2ca4a5e168dcb9f"}]}