)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"a629bcb1714cc89f8855cf91292c6a66f61797e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51831ca4_1dd05a42","updated":"2022-08-02 08:54:01.000000000","message":"In the case of TLS-e, the generated redis config uses an additional \"include /etc/redis-tls.conf\" statement. I guess we want it to become \"include /etc/redis/redis-tls.conf\" as well?\nSetting -1 temporarily just to figure out whether redis + TLS-e still works with that review, and if we need to plan another puppet-tripleo review to match the new location","commit_id":"3bc1e5d00b4082168e288be5c90b732312988b5f"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"e32095b1d8b11a0049bdebf7a1cd8da1dfbc8406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"780413a6_dcd794fe","updated":"2022-08-02 14:06:40.000000000","message":"quickly marking -1 for two things\n1. when i deploy a downstream wallaby with that patch, the generated file still lands in /etc/redis.conf. Is that expected?\n2. I think we should modify hiera key redis::extra_config_file to generate the extra tls file in /etc/redis/redis-tls.conf","commit_id":"3bc1e5d00b4082168e288be5c90b732312988b5f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0176166646a0faef4892101f0e44c0ee24417d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40ece87e_42639762","in_reply_to":"780413a6_dcd794fe","updated":"2022-08-02 15:39:08.000000000","message":"\u003e quickly marking -1 for two things\n\u003e 1. when i deploy a downstream wallaby with that patch, the generated file still lands in /etc/redis.conf. Is that expected?\n\nThe commit to adapt to the new path in CentOS9/RHEL9 is present in puppet-redis v8.3.0 and later.\n\nCurrent RDO wallaby provides puppet-redis 6.1.1 which does not include that commit, and I think usage of that old package is the reason the old path is used in your deployment.\n\nOn the other hand RDO master provides puppet-redis 8.4.0 so we can use the new config path by removing these overrides.\n\n\n\u003e 2. I think we should modify hiera key redis::extra_config_file to generate the extra tls file in /etc/redis/redis-tls.conf\n\nYeah that makes sense. I\u0027ll fix it.","commit_id":"3bc1e5d00b4082168e288be5c90b732312988b5f"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"0087981dff8cb35408b7fe80cb4f6525a1e112c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d110e649_442344c1","updated":"2022-08-03 08:52:16.000000000","message":"Tested locally on a downstream wallaby and the right puppet-redis version. both /etc/redis/redis.conf and /etc/redis/redis-tls.conf are there, and redis + TLS is clustered just fine with pacemaker.","commit_id":"e5ea92a5fb0a2a85cdb664108cb36ffabc78d8bb"}]}