)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"95804dd029ed32d434ce9b48fd91cd7983d6f1c0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The following two parameters have been implemented in the glance-api"},{"line_number":10,"context_line":"service resource but the hieradata key set by these two parameters"},{"line_number":11,"context_line":"have never been used actually."},{"line_number":12,"context_line":" - GlanceNotifierStrategy"},{"line_number":13,"context_line":" - GlanceLogFile"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Because the parameters have been \"broken\" for multiple cycles, this"},{"line_number":16,"context_line":"change removes these parameters directly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"899964b5_07c0c2cf","line":13,"range":{"start_line":12,"start_character":1,"end_line":13,"end_character":16},"updated":"2022-07-04 13:25:14.000000000","message":"forgot to mention the parameters ... :-(","commit_id":"7315e38a052b44879af6d60058758b83a256d127"}],"releasenotes/notes/remove-unused-glance-params-ae24869fef23fa06.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ddffedbd550950189a4effc2f9d5e591060874cd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``GlanceNotifierStrategy`` parameter and the ``GlanceLogFile``"},{"line_number":5,"context_line":"    parameter have been removed. These two parameters have had no effect"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f22595e5_a85eb121","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2022-07-05 16:14:10.000000000","message":"I think the \u0027upgrades\u0027 section is more relevant.\n\nHowever, since I can\u0027t even find when these parameters might have had any relevance (I searched old releases), maybe a release note isn\u0027t warranted. In fact, it might cause users to worry they should do their own research, which will just waste more of their time. Maybe we should just silently drop the parameters, but not advertise we\u0027re doing that in a release note?","commit_id":"7315e38a052b44879af6d60058758b83a256d127"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a36698d4615f23ab21960e52d9e69d92045edbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``GlanceNotifierStrategy`` parameter and the ``GlanceLogFile``"},{"line_number":5,"context_line":"    parameter have been removed. These two parameters have had no effect"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9bc0fd8f_2af79687","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"5d966c92_f9ae3d41","updated":"2022-07-05 23:02:58.000000000","message":"Done","commit_id":"7315e38a052b44879af6d60058758b83a256d127"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdf8399eef5266994840b3738db46c1174cb1254","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``GlanceNotifierStrategy`` parameter and the ``GlanceLogFile``"},{"line_number":5,"context_line":"    parameter have been removed. These two parameters have had no effect"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5d966c92_f9ae3d41","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"c895e212_941f3a0c","updated":"2022-07-05 16:19:56.000000000","message":"Thanks, I selected the wrong one and I think the upgrade section is best.\n\nRegarding your concern about the release note, I think it would not be too much worry them as long as we clearly states \"the parameters have had no effect\".\nOn the other hand, I expect this node helps users to check their templates and revisit their requirement in case these two parameters are written in their templates.","commit_id":"7315e38a052b44879af6d60058758b83a256d127"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"44e6efbaa3af99d3c15fb4141917a05fd5469910","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``GlanceNotifierStrategy`` parameter and the ``GlanceLogFile``"},{"line_number":5,"context_line":"    parameter have been removed. These two parameters have had no effect"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c895e212_941f3a0c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"f22595e5_a85eb121","updated":"2022-07-05 16:16:19.000000000","message":"If not the \u0027upgrades\u0027 section, then perhaps \u0027deprecations\u0027 or \u0027other\u0027.","commit_id":"7315e38a052b44879af6d60058758b83a256d127"}]}