)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"117bb2448ed8017135a7d624159d0e050551f534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e0bf8b3_e18b30c3","updated":"2022-09-06 17:31:26.000000000","message":"It\u0027s fine for the puppet-tripleo patch to provide a default shares config filename in the event that the user neglected to provide on in their multiconfig. However, I do not want to change the design to this extent.","commit_id":"1e92d01c8e5ea3b6cf352aa6b0b7046feafa9025"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"564e44df83e33fd5fcf6edfcf5ba7274197649fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b93c8e10_3c6ff068","updated":"2022-09-12 04:54:41.000000000","message":"The overall idea of the series of changes is that the Cinder*SharesConfig parameters is not something users should care. The parameters affect name of the config file and does not really affect the behavior of backends.\n\nI understand your point that users are responsible to set parameters properly for each backend so that they get expected behaviors. However ShareConfig does not really affect the functionality and setting unique values are just to avoid ugly internal error. So IMHO this is something we should consider separately.\n","commit_id":"1e92d01c8e5ea3b6cf352aa6b0b7046feafa9025"}],"environments/cinder-netapp-config.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"117bb2448ed8017135a7d624159d0e050551f534","unresolved":true,"context_lines":[{"line_number":41,"context_line":"#       CinderNetappPassword: \u0027secret_password_2\u0027"},{"line_number":42,"context_line":"#       CinderNetappNfsSharesConfig: \u0027/etc/cinder/shares_2.conf\u0027"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# NOTE - Each Netapp backend\u0027s CinderNetappNfsSharesConfig must be unique."},{"line_number":45,"context_line":"# In the above example, tripleo_netapp_1 will be configured with the"},{"line_number":46,"context_line":"# default CinderNetappNfsSharesConfig value (\u0027/etc/cinder/shares.conf\u0027),"},{"line_number":47,"context_line":"# and tripleo_netapp_2 will be configured with \u0027/etc/cinder/shares_2.conf\u0027."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c705224e_6d9b4e0c","side":"PARENT","line":44,"updated":"2022-09-06 17:31:26.000000000","message":"This note still applies. It\u0027s nice that puppet-tripleo attempts to provide a better experience when the user forgets to assign unique values, but the user is still supposed to be in charge of the values.","commit_id":"154de03fd4d6d0558c16953bf09ba7c409824fca"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"564e44df83e33fd5fcf6edfcf5ba7274197649fc","unresolved":true,"context_lines":[{"line_number":41,"context_line":"#       CinderNetappPassword: \u0027secret_password_2\u0027"},{"line_number":42,"context_line":"#       CinderNetappNfsSharesConfig: \u0027/etc/cinder/shares_2.conf\u0027"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# NOTE - Each Netapp backend\u0027s CinderNetappNfsSharesConfig must be unique."},{"line_number":45,"context_line":"# In the above example, tripleo_netapp_1 will be configured with the"},{"line_number":46,"context_line":"# default CinderNetappNfsSharesConfig value (\u0027/etc/cinder/shares.conf\u0027),"},{"line_number":47,"context_line":"# and tripleo_netapp_2 will be configured with \u0027/etc/cinder/shares_2.conf\u0027."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2b77d75f_42a53ba2","side":"PARENT","line":44,"in_reply_to":"c705224e_6d9b4e0c","updated":"2022-09-12 04:54:41.000000000","message":"It\u0027s true that users are responsible to provide values for each backend to get the expected behavior of individual backends, but IMO it\u0027s not quite reasonable to require them to avoid failure in Puppet. That is quite internal and is not something users should care IMHO.","commit_id":"154de03fd4d6d0558c16953bf09ba7c409824fca"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"117bb2448ed8017135a7d624159d0e050551f534","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  CinderNetappVserver: \u0027\u0027"},{"line_number":20,"context_line":"  CinderNetappPartnerBackendName: \u0027\u0027"},{"line_number":21,"context_line":"  CinderNetappNfsShares: \u0027\u0027"},{"line_number":22,"context_line":"  # Do not set this when CinderNetappMultiConfig is used."},{"line_number":23,"context_line":"  # CinderNetappNfsSharesConfig: \u0027/etc/cinder/shares.conf\u0027"},{"line_number":24,"context_line":"  CinderNetappNfsMountOptions: \u0027context\u003dsystem_u:object_r:container_file_t:s0\u0027"},{"line_number":25,"context_line":"  CinderNetappCopyOffloadToolPath: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a43b8bf6_3c1fda9b","line":22,"updated":"2022-09-06 17:31:26.000000000","message":"I feel this advice is wrong, and is inconsistent with how the multi-config options are designed to work.","commit_id":"1e92d01c8e5ea3b6cf352aa6b0b7046feafa9025"}]}