)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c5c1b20e1774a1d0e0022efec2f52ce2061fc5c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"115942a4_bb50d061","updated":"2022-06-28 11:09:26.000000000","message":"iirc this also requires a backport to wallaby?","commit_id":"da1e3e250313f80da47c3241f1c05cb15c123ed7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9736e7a8b8ac175d1ae6244e34a7330b0e7791df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc2f9ce7_5cb38410","updated":"2022-06-27 18:00:57.000000000","message":"recheck","commit_id":"da1e3e250313f80da47c3241f1c05cb15c123ed7"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9736e7a8b8ac175d1ae6244e34a7330b0e7791df","unresolved":true,"context_lines":[{"line_number":427,"context_line":"    # for backwards compatibility, all other roles default to internal_api"},{"line_number":428,"context_line":"  {%- for role in roles %}"},{"line_number":429,"context_line":"  {%- if \u0027ceph\u0027 in role.tags|default([]) %}"},{"line_number":430,"context_line":"  {%- if \u0027Storage\u0027 in role.networks %}"},{"line_number":431,"context_line":"    {{role.name}}HostnameResolveNetwork: {{ _service_nets.get(\u0027storage\u0027, \u0027ctlplane\u0027) }}"},{"line_number":432,"context_line":"    {{role.name}}MetricsQdrNetwork: {{ _service_nets.get(\u0027storage\u0027, \u0027ctlplane\u0027) }}"},{"line_number":433,"context_line":"  {%- else %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5b2537ee_6bca1da7","side":"PARENT","line":430,"range":{"start_line":430,"start_character":2,"end_line":430,"end_character":38},"updated":"2022-06-27 18:00:57.000000000","message":"_service_nets is not per-role. So there is a chance we set a hostname resolv network that won\u0027t be available on nodes in the role.\n\nOn the other hand, I don\u0027t see anywhere this would fail with roles shipped in code. I think it is a good idea to remove this complex stuff, advanced users with custom roles would most likely have to override these manually anyway.","commit_id":"93c6665a368f71a7e664ea2f8a49d4967c21d8fc"}]}