)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07aeae7c90c77b8f00fcae70c6362f8e663f5f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c351304e_96e92b3b","updated":"2022-06-30 00:19:28.000000000","message":"I\u0027ll regard +1 by Ronelle as +2 and will merge this now.","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"e843412b27be1e51947384ec7deba4bb57bfd591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50aa0917_3f3003a6","updated":"2022-06-29 17:43:18.000000000","message":"https://review.rdoproject.org/zuul/build/db672c58ebc04a5793e77a29195d0368 passes here","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8ce32f2d04973fb4d9575f7570a730555bda136d","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0f951ecf_efe1dc9b","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"updated":"2022-06-29 15:41:09.000000000","message":"why not disabling it by default by setting OS::Heat::None ?","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4c62c92f4f79ea9836d1f116e15135c02c7d4281","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"637a7b2f_89f011db","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"08750d9b_e0d01741","updated":"2022-06-29 16:13:11.000000000","message":"Ok got it now, in that case may be also add below to environment files and in resource registry default keep it disabled?, OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e7b52ef59a513f90ad755e393cd782a8506485ad","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"16fd1364_8e884a8c","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"08750d9b_e0d01741","updated":"2022-06-29 16:12:33.000000000","message":"The same approach is used by the other core plugins like VTS, Mellanox or NSX. If we fix this then we should fix all these services as well as relevant environment files. This expands scope of this change too much.\n\nI will leave it now as a follow up and we can discuss it later.","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7af46c2ae401526959611df3a35e7e1ccac91325","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"08750d9b_e0d01741","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"0c9d4589_5ac543bd","updated":"2022-06-29 16:06:38.000000000","message":"but still i think it\u0027s better to explicit disable in resource mappings.","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d62f74e7d2e0b97c6710f13323b3ed316fa46584","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0c9d4589_5ac543bd","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"0f951ecf_efe1dc9b","updated":"2022-06-29 16:02:58.000000000","message":"This resource is not assigned to any roles so this definition has no effect.\n\nWhat is tricky here is that we do not use NeutronCorePluginML2Ansible directly but use that resource to override OS::TripleO::Services::NeutronCorePlugin (which I missed previously). See how the resource is enabled in the environment files.","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c5943b83761f835a7d1360f93932459d3f417f42","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"14cb2ebd_8509797b","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"532fa7c8_8fd0ab5c","updated":"2022-06-30 00:06:52.000000000","message":"Done","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"31bc3f44b0955b0be163f0a34e8b8b3add50dcdb","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c948e7b6_d8890d04","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"637a7b2f_89f011db","updated":"2022-06-29 16:15:04.000000000","message":"Ok sounds good than.","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9a7023ce5506f8d8c329cf80efecbfa1dd590abd","unresolved":true,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  OS::TripleO::Services::NeutronCorePluginMLNXSDN: deployment/neutron/neutron-plugin-ml2-mlnx-sdn-assist-container-puppet.yaml"},{"line_number":160,"context_line":"  OS::TripleO::Services::NeutronCorePluginVTS: deployment/neutron/neutron-plugin-ml2-cisco-vts-container-puppet.yaml"},{"line_number":161,"context_line":"  OS::TripleO::Services::NeutronCorePluginML2Ansible: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml"},{"line_number":162,"context_line":"  OS::TripleO::Services::NeutronOvsAgent: OS::Heat::None"},{"line_number":163,"context_line":"  OS::TripleO::Services::NeutronLinuxbridgeAgent: OS::Heat::None"},{"line_number":164,"context_line":"  OS::TripleO::Services::ComputeNeutronOvsAgent: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"532fa7c8_8fd0ab5c","line":161,"range":{"start_line":161,"start_character":54,"end_line":161,"end_character":132},"in_reply_to":"c948e7b6_d8890d04","updated":"2022-06-29 16:18:02.000000000","message":"If we disable these services by default then there is no benefit of keeping these individual plugin services(as we need to define an individual plugin service first and the override the core plugin service by the individual plugin service).\n\nI think the better approach is to remove the all NeutronCorePlugin* services and directly override the NeutronCorePlugin service by individual resource template in environment files.\n\neg)\n```\nresource_registry:\n  OS::TripleO::Services:NeutronCorePlugin: deployment/deprecated/neutron/neutron-plugin-ml2-ansible-container-puppet.yaml\n```","commit_id":"b9148e452bc3676e0703d4ab4102ca4b503d3142"}]}