)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"bb3d42488388a0f5547f187b28b98aa6ca0277d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"395ffd0c_96445f4b","updated":"2022-07-22 07:38:15.000000000","message":"Looks good now, let\u0027s see how the tests goes","commit_id":"100beeebc21385f45026c87c2b8551a584eac6e1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f2268bef3a2b4dc93c2f197098cd51a8c64de37e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3e3ed1e3_4b709106","updated":"2022-07-28 04:58:46.000000000","message":"Now it works fine https://zuul.opendev.org/t/openstack/build/3b4b05fd3b7e4de3aa596ceca435ce57","commit_id":"ce3796aa60778df238e77cc971aa71654e4f2562"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f58b9ddb1f844301744c3862018e36c66ef84925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5ab2ed1a_dab4a003","updated":"2022-07-28 05:00:26.000000000","message":"check-rdo","commit_id":"ce3796aa60778df238e77cc971aa71654e4f2562"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ed44d627e31eccd27b546d1c133297ab904852df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"98a4a9a0_c839dc98","updated":"2022-08-02 13:32:32.000000000","message":"why can\u0027t we use puppet lookup here?","commit_id":"ce3796aa60778df238e77cc971aa71654e4f2562"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ace018747f0bef4f2fe64851dad8b0092a20e17e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"13b0745d_a50efe4b","in_reply_to":"98a4a9a0_c839dc98","updated":"2022-08-02 13:44:36.000000000","message":"I\u0027m implementing this as a quick solution and will work on it as a follow-up.\n\nWe\u0027d be able to replace the usage in ovdn db and nova az but the one in etcd is quite tricky because the command should be executed during service start up, and we need to come up with the way to make it work even when fact cache has expired.\n\nI\u0027ll consider whether these are any good solutions so will postpone actual replacement now.","commit_id":"ce3796aa60778df238e77cc971aa71654e4f2562"}],"deployment/etcd/etcd-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"528e7e0f30713dc8afe90c9445c2e5d47a9859a1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":218,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":219,"context_line":"                # etcd membership."},{"line_number":220,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_ETCD_NETWORK)"},{"line_number":221,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":222,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":223,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5edb711f_95f8e61c","line":220,"range":{"start_line":220,"start_character":60,"end_line":220,"end_character":77},"updated":"2022-07-22 07:53:24.000000000","message":"this one is too much tricky because this reference is required not only during deployment but also service start ups. we need to find out the way to persist this somehow otherwise we need to look up node facts always.","commit_id":"d965ae71cfd21a24cca03444dd5f12fff5451b54"}],"deployment/ovn/ovn-dbs-container-puppet.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6660b52f6210281059db3b995224ca10017597c4","unresolved":true,"context_lines":[{"line_number":224,"context_line":"                      - \u0027 \u0027"},{"line_number":225,"context_line":"                      -"},{"line_number":226,"context_line":"                        # TODO(tkajinam): Replace the hiera CLI"},{"line_number":227,"context_line":"                        - \u0027DBS_LISTEN_IP\u003d`hiera -c $OVN_DB_NETWORK`;\u0027"},{"line_number":228,"context_line":"                        - \u0027/usr/bin/bootstrap_host_exec ovn_dbs ovn-nbctl set-connection\u0027"},{"line_number":229,"context_line":"                        - if:"},{"line_number":230,"context_line":"                          - {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"159fccea_2ae49f2b","line":227,"range":{"start_line":227,"start_character":42,"end_line":227,"end_character":67},"updated":"2022-07-22 07:32:09.000000000","message":"hiera -c /etc/puppet/hiera.yaml $OVN_DB_NETWORK","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bbfe026619b94dfaf91a897ff7b7e2209769230","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                      - \u0027 \u0027"},{"line_number":225,"context_line":"                      -"},{"line_number":226,"context_line":"                        # TODO(tkajinam): Replace the hiera CLI"},{"line_number":227,"context_line":"                        - \u0027DBS_LISTEN_IP\u003d`hiera -c $OVN_DB_NETWORK`;\u0027"},{"line_number":228,"context_line":"                        - \u0027/usr/bin/bootstrap_host_exec ovn_dbs ovn-nbctl set-connection\u0027"},{"line_number":229,"context_line":"                        - if:"},{"line_number":230,"context_line":"                          - {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ae94dde8_27495d46","line":227,"range":{"start_line":227,"start_character":42,"end_line":227,"end_character":67},"in_reply_to":"159fccea_2ae49f2b","updated":"2022-07-22 07:35:27.000000000","message":"Done","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6660b52f6210281059db3b995224ca10017597c4","unresolved":true,"context_lines":[{"line_number":230,"context_line":"                          - {get_param: EnableInternalTLS}"},{"line_number":231,"context_line":"                          - \u0027pssl:$NB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":232,"context_line":"                          - \u0027ptcp:$NB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":233,"context_line":"              environment:"},{"line_number":234,"context_line":"                OVN_DB_NETWORK: {get_param: [ServiceNetMap, OvnDbsNetwork]}"},{"line_number":235,"context_line":"                NB_DB_PORT: {get_param: OVNNorthboundServerPort}"},{"line_number":236,"context_line":"          configure_ovn_south_db_server:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c0031ef1_edf6ad79","line":233,"updated":"2022-07-22 07:32:09.000000000","message":"ditto","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bbfe026619b94dfaf91a897ff7b7e2209769230","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                          - {get_param: EnableInternalTLS}"},{"line_number":231,"context_line":"                          - \u0027pssl:$NB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":232,"context_line":"                          - \u0027ptcp:$NB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":233,"context_line":"              environment:"},{"line_number":234,"context_line":"                OVN_DB_NETWORK: {get_param: [ServiceNetMap, OvnDbsNetwork]}"},{"line_number":235,"context_line":"                NB_DB_PORT: {get_param: OVNNorthboundServerPort}"},{"line_number":236,"context_line":"          configure_ovn_south_db_server:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4950a772_23278b61","line":233,"in_reply_to":"c0031ef1_edf6ad79","updated":"2022-07-22 07:35:27.000000000","message":"Done","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6660b52f6210281059db3b995224ca10017597c4","unresolved":true,"context_lines":[{"line_number":244,"context_line":"                      - \u0027 \u0027"},{"line_number":245,"context_line":"                      -"},{"line_number":246,"context_line":"                        # TODO(tkajinam): Replace the hiera CLI"},{"line_number":247,"context_line":"                        - \u0027DBS_LISTEN_IP\u003d`hiera -c $OVN_DB_NETWORK`;\u0027"},{"line_number":248,"context_line":"                        - \u0027/usr/bin/bootstrap_host_exec ovn_dbs ovn-sbctl set-connection\u0027"},{"line_number":249,"context_line":"                        - if:"},{"line_number":250,"context_line":"                          - {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5480d0f3_e4bac279","line":247,"range":{"start_line":247,"start_character":42,"end_line":247,"end_character":47},"updated":"2022-07-22 07:32:09.000000000","message":"hiera -c /etc/puppet/hiera.yaml $OVN_DB_NETWORK","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bbfe026619b94dfaf91a897ff7b7e2209769230","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                      - \u0027 \u0027"},{"line_number":245,"context_line":"                      -"},{"line_number":246,"context_line":"                        # TODO(tkajinam): Replace the hiera CLI"},{"line_number":247,"context_line":"                        - \u0027DBS_LISTEN_IP\u003d`hiera -c $OVN_DB_NETWORK`;\u0027"},{"line_number":248,"context_line":"                        - \u0027/usr/bin/bootstrap_host_exec ovn_dbs ovn-sbctl set-connection\u0027"},{"line_number":249,"context_line":"                        - if:"},{"line_number":250,"context_line":"                          - {get_param: EnableInternalTLS}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"53c0347b_ff698f23","line":247,"range":{"start_line":247,"start_character":42,"end_line":247,"end_character":47},"in_reply_to":"5480d0f3_e4bac279","updated":"2022-07-22 07:35:27.000000000","message":"Done","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6660b52f6210281059db3b995224ca10017597c4","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                          - {get_param: EnableInternalTLS}"},{"line_number":251,"context_line":"                          - \u0027pssl:$SB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":252,"context_line":"                          - \u0027ptcp:$SB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":253,"context_line":"              environment:"},{"line_number":254,"context_line":"                OVN_DB_NETWORK: {get_param: [ServiceNetMap, OvnDbsNetwork]}"},{"line_number":255,"context_line":"                SB_DB_PORT: {get_param: OVNSouthboundServerPort}"},{"line_number":256,"context_line":"          ovn_northd:"},{"line_number":257,"context_line":"            start_order: 2"},{"line_number":258,"context_line":"            image: {get_attr: [RoleParametersValue, value, ContainerOvnNorthdImage]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c812bbdd_1ff1afb9","line":255,"range":{"start_line":253,"start_character":14,"end_line":255,"end_character":22},"updated":"2022-07-22 07:32:09.000000000","message":"also i think you need to move one level back to inline with command:?","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0bbfe026619b94dfaf91a897ff7b7e2209769230","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                          - {get_param: EnableInternalTLS}"},{"line_number":251,"context_line":"                          - \u0027pssl:$SB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":252,"context_line":"                          - \u0027ptcp:$SB_DB_PORT:$DBS_LISTEN_IP\u0027"},{"line_number":253,"context_line":"              environment:"},{"line_number":254,"context_line":"                OVN_DB_NETWORK: {get_param: [ServiceNetMap, OvnDbsNetwork]}"},{"line_number":255,"context_line":"                SB_DB_PORT: {get_param: OVNSouthboundServerPort}"},{"line_number":256,"context_line":"          ovn_northd:"},{"line_number":257,"context_line":"            start_order: 2"},{"line_number":258,"context_line":"            image: {get_attr: [RoleParametersValue, value, ContainerOvnNorthdImage]}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"34479883_ad1652af","line":255,"range":{"start_line":253,"start_character":14,"end_line":255,"end_character":22},"in_reply_to":"c812bbdd_1ff1afb9","updated":"2022-07-22 07:35:27.000000000","message":"Done","commit_id":"5adcbcbe4eab8608e4da36e322f08c81c1a3af4d"}]}