)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"27295bc249f935bddded52f414ea27b5424605c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3c44136_1f01d5b1","updated":"2022-07-05 15:27:12.000000000","message":"nevermind, I got it, LGTM.\nAlthough there is no plans to support monolithic libvirt deployments in master.\nAnd this needs no to be backported into Wallaby","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e54e9313caf48b358a4dce84913ba312e3c90473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8a3dd62_9d309c86","updated":"2022-07-26 00:43:45.000000000","message":"recheck\n\nto clear -2 because of removed +A","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d970bb5218976ba7ff64b3c7583d56ff77982c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"642810ec_2e657ccf","updated":"2022-07-05 15:25:04.000000000","message":"thanks you for this!\nJust a few questions","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d2caca25456c5947ac4e0d2eebc045e211e2ccbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"62fcf578_30783c46","updated":"2022-08-10 07:41:31.000000000","message":"recheck","commit_id":"a1bdbe85718cfda40e6ea8bed1e8b041db25b01f"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"3bf448041e8c824deda331f0c5fa5a09803e5851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e09faf3_2d25ec4f","updated":"2022-08-12 02:45:36.000000000","message":"recheck\n\nAs per https://lists.centos.org/pipermail/centos-devel/2022-August/120525.html , issue got fixed, rerunning job to confirm if issue is fixed now.","commit_id":"a1bdbe85718cfda40e6ea8bed1e8b041db25b01f"}],"deployment/deprecated/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d970bb5218976ba7ff64b3c7583d56ff77982c90","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            - \u002761152-61215\u0027"},{"line_number":364,"context_line":"            - \u00275900-6923\u0027"},{"line_number":365,"context_line":"      ansible_group_vars:"},{"line_number":366,"context_line":"        tripleo_nova_libvirt_virsh_container: nova_libvirt"},{"line_number":367,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionNovaLibvirt}"},{"line_number":368,"context_line":"      config_settings:"},{"line_number":369,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c4246724_24348769","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":44},"updated":"2022-07-05 15:25:04.000000000","message":"what is this? Hound finds nothing but that reference...","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"142e41623193ca8306d93f00840127430540834a","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            - \u002761152-61215\u0027"},{"line_number":364,"context_line":"            - \u00275900-6923\u0027"},{"line_number":365,"context_line":"      ansible_group_vars:"},{"line_number":366,"context_line":"        tripleo_nova_libvirt_virsh_container: nova_libvirt"},{"line_number":367,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionNovaLibvirt}"},{"line_number":368,"context_line":"      config_settings:"},{"line_number":369,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dcbb034f_30c0dee5","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":44},"in_reply_to":"33f74989_8b660977","updated":"2022-08-08 15:59:29.000000000","message":"Done","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5956074df82991fe34a641dc07cda955f000277e","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            - \u002761152-61215\u0027"},{"line_number":364,"context_line":"            - \u00275900-6923\u0027"},{"line_number":365,"context_line":"      ansible_group_vars:"},{"line_number":366,"context_line":"        tripleo_nova_libvirt_virsh_container: nova_libvirt"},{"line_number":367,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionNovaLibvirt}"},{"line_number":368,"context_line":"      config_settings:"},{"line_number":369,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"33f74989_8b660977","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":44},"in_reply_to":"4e236f61_12a960b7","updated":"2022-07-25 15:39:40.000000000","message":"This is the trick to make this variable visible to a different service(nova-compute). This variable is now used by the tasks implemented in nova-compute-container-puppet.yaml. See https://review.opendev.org/c/openstack/tripleo-heat-templates/+/848640/1/deployment/nova/nova-compute-container-puppet.yaml#1499","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bed9791db9f68731f4e4c402d2ff536b6c1dfef0","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            - \u002761152-61215\u0027"},{"line_number":364,"context_line":"            - \u00275900-6923\u0027"},{"line_number":365,"context_line":"      ansible_group_vars:"},{"line_number":366,"context_line":"        tripleo_nova_libvirt_virsh_container: nova_libvirt"},{"line_number":367,"context_line":"      monitoring_subscription: {get_param: MonitoringSubscriptionNovaLibvirt}"},{"line_number":368,"context_line":"      config_settings:"},{"line_number":369,"context_line":"        map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4e236f61_12a960b7","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":44},"in_reply_to":"c4246724_24348769","updated":"2022-07-25 15:12:55.000000000","message":"could you please clarify that?","commit_id":"2c63adb9656b05286721524321449b159fa9147c"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8b5553040dd6e3578889b4f3042595bdc11345a6","unresolved":true,"context_lines":[{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"                    [Service]"},{"line_number":1515,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1516,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1517,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1518,"context_line":"                    Type\u003doneshot"},{"line_number":1519,"context_line":"                    RemainAfterExit\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"335bb892_21315a9e","line":1516,"range":{"start_line":1516,"start_character":47,"end_line":1516,"end_character":62},"updated":"2022-08-03 13:13:43.000000000","message":"can we not duplicate it, but only put {{ tripleo_nova_libvirt_virsh_container }} here?","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"148b89259251fcad0def2d4eda6139e407006b00","unresolved":true,"context_lines":[{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"                    [Service]"},{"line_number":1515,"context_line":"                    EnvironmentFile\u003d-/etc/sysconfig/libvirt-guests"},{"line_number":1516,"context_line":"                    ExecStart\u003d/bin/podman exec nova_virtproxyd /bin/rm -f /var/lib/libvirt/libvirt-guests"},{"line_number":1517,"context_line":"                    ExecStop\u003d/bin/podman exec nova_virtproxyd /bin/sh -x /usr/libexec/libvirt-guests.sh shutdown"},{"line_number":1518,"context_line":"                    Type\u003doneshot"},{"line_number":1519,"context_line":"                    RemainAfterExit\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"45cb64bc_f08ba354","line":1516,"range":{"start_line":1516,"start_character":47,"end_line":1516,"end_character":62},"in_reply_to":"335bb892_21315a9e","updated":"2022-08-04 08:41:43.000000000","message":"AFAIK, we need a separate j2 file for templating and I\u0027m not sure how we can make that here. We can simplify this when we move this to a standalone role.","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8b5553040dd6e3578889b4f3042595bdc11345a6","unresolved":true,"context_lines":[{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"                    [Install]"},{"line_number":1524,"context_line":"                    WantedBy\u003dmulti-user.target"},{"line_number":1525,"context_line":"                when: tripleo_nova_libvirt_container | default(\u0027nova_libvirt\u0027) !\u003d \u0027nova_libvirt\u0027"},{"line_number":1526,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1527,"context_line":"                copy:"},{"line_number":1528,"context_line":"                  dest: /etc/systemd/system/virt-guest-shutdown.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"07aea0e6_f7f22991","line":1525,"updated":"2022-08-03 13:13:43.000000000","message":"tripleo_nova_libvirt_virsh_container ?","commit_id":"2c63adb9656b05286721524321449b159fa9147c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"148b89259251fcad0def2d4eda6139e407006b00","unresolved":false,"context_lines":[{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"                    [Install]"},{"line_number":1524,"context_line":"                    WantedBy\u003dmulti-user.target"},{"line_number":1525,"context_line":"                when: tripleo_nova_libvirt_container | default(\u0027nova_libvirt\u0027) !\u003d \u0027nova_libvirt\u0027"},{"line_number":1526,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1527,"context_line":"                copy:"},{"line_number":1528,"context_line":"                  dest: /etc/systemd/system/virt-guest-shutdown.target"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"80d5d3b4_73221657","line":1525,"in_reply_to":"07aea0e6_f7f22991","updated":"2022-08-04 08:41:43.000000000","message":"Definitely! Done","commit_id":"2c63adb9656b05286721524321449b159fa9147c"}]}