)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a073bc812a3bd4534ecfd9beef96b426412f68ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2728d053_7d105ea9","updated":"2022-07-07 10:42:10.000000000","message":"Looks good. Couple of nit\u0027s, but I see no reason to block this.\n\nI see undercloud \u0027enable_nova\u0027 option is already deprecated, and un-wired.","commit_id":"30083de9f4048cc1ca31326b0ed081dd7ec29268"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"178ea47cf59872add3d7bc5379459e5981910ba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"23bed7dd_b3b7378d","updated":"2022-08-02 21:14:17.000000000","message":"nice!","commit_id":"34a2e1ebc9f5b71937277184e4b4b3d5004082a0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"73c76e62367cec6f2f0810c778d096ae5e4154f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e9423fca_1880ed76","updated":"2022-07-07 17:14:44.000000000","message":"recheck","commit_id":"34a2e1ebc9f5b71937277184e4b4b3d5004082a0"}],"ci/custom_ci_roles_data.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a073bc812a3bd4534ecfd9beef96b426412f68ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  # Set uses_deprecated_params to True if any deprecated params are used."},{"line_number":37,"context_line":"  uses_deprecated_params: True"},{"line_number":38,"context_line":"  deprecated_param_extraconfig: \u0027controllerExtraConfig\u0027"},{"line_number":39,"context_line":"  deprecated_nic_config_name: \u0027controller.yaml\u0027"},{"line_number":40,"context_line":"  update_serial: 1"},{"line_number":41,"context_line":"  ServicesDefault:"},{"line_number":42,"context_line":"    - OS::TripleO::Services::Aide"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"25a86086_e5797f85","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":47},"updated":"2022-07-07 10:42:10.000000000","message":"I think we can remove these \u0027deprecated_nic_config_name\u0027 both here and in all roles. nic-configs are jinja2 since Victoria, so this is invialid. Follow up is ok.","commit_id":"30083de9f4048cc1ca31326b0ed081dd7ec29268"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"588066684f566c04b6862c87c015c28488aeb9e0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  # Set uses_deprecated_params to True if any deprecated params are used."},{"line_number":37,"context_line":"  uses_deprecated_params: True"},{"line_number":38,"context_line":"  deprecated_param_extraconfig: \u0027controllerExtraConfig\u0027"},{"line_number":39,"context_line":"  deprecated_nic_config_name: \u0027controller.yaml\u0027"},{"line_number":40,"context_line":"  update_serial: 1"},{"line_number":41,"context_line":"  ServicesDefault:"},{"line_number":42,"context_line":"    - OS::TripleO::Services::Aide"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fdac0677_98d86d48","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":47},"in_reply_to":"25a86086_e5797f85","updated":"2022-07-07 11:35:18.000000000","message":"Ack. I\u0027ll cover it in a separate patch as this is not directly related to nova removal.","commit_id":"30083de9f4048cc1ca31326b0ed081dd7ec29268"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a073bc812a3bd4534ecfd9beef96b426412f68ea","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  OS::TripleO::Server: deployed-server/deployed-server.yaml"},{"line_number":38,"context_line":"{% for role in roles %}"},{"line_number":39,"context_line":"  OS::TripleO::{{role.name}}Server: deployed-server/deployed-server.yaml"},{"line_number":40,"context_line":"{% endfor %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Hooks for operator extra config"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e1716671_b7723a0b","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":72},"updated":"2022-07-07 10:42:10.000000000","message":"nit, no need to change this?","commit_id":"30083de9f4048cc1ca31326b0ed081dd7ec29268"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"588066684f566c04b6862c87c015c28488aeb9e0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  OS::TripleO::Server: deployed-server/deployed-server.yaml"},{"line_number":38,"context_line":"{% for role in roles %}"},{"line_number":39,"context_line":"  OS::TripleO::{{role.name}}Server: deployed-server/deployed-server.yaml"},{"line_number":40,"context_line":"{% endfor %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Hooks for operator extra config"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4b5b4edb_e6a5efcf","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":72},"in_reply_to":"e1716671_b7723a0b","updated":"2022-07-07 11:35:18.000000000","message":"Yes. I think it\u0027s better to fix this.","commit_id":"30083de9f4048cc1ca31326b0ed081dd7ec29268"}],"puppet/role.role.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d76dc2d36afc31e6e31fdac6cb0046e27c73c9cf","unresolved":true,"context_lines":[{"line_number":278,"context_line":"{%- endif %}"},{"line_number":279,"context_line":"          - network: ctlplane"},{"line_number":280,"context_line":"            subnet: {get_param: {{role.name}}ControlPlaneSubnet}"},{"line_number":281,"context_line":"      user_data_format: SOFTWARE_CONFIG"},{"line_number":282,"context_line":"      user_data: {get_param: UserData}"},{"line_number":283,"context_line":"      name:"},{"line_number":284,"context_line":"        yaql:"},{"line_number":285,"context_line":"          expression: $.data.hostname_map.get($.data.hostname, $.data.hostname).toLower()"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6e563f33_bc3d8b3e","side":"PARENT","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":38},"updated":"2022-07-06 03:25:31.000000000","message":"I noticed you\u0027re removing these in a followup patch. Why not in the same patch?","commit_id":"ab35091c41be587013f1526c50ac4ee7e7f2682a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7d47f2ef929fd98bb1efa42b7e420e34e03f1a9","unresolved":false,"context_lines":[{"line_number":278,"context_line":"{%- endif %}"},{"line_number":279,"context_line":"          - network: ctlplane"},{"line_number":280,"context_line":"            subnet: {get_param: {{role.name}}ControlPlaneSubnet}"},{"line_number":281,"context_line":"      user_data_format: SOFTWARE_CONFIG"},{"line_number":282,"context_line":"      user_data: {get_param: UserData}"},{"line_number":283,"context_line":"      name:"},{"line_number":284,"context_line":"        yaql:"},{"line_number":285,"context_line":"          expression: $.data.hostname_map.get($.data.hostname, $.data.hostname).toLower()"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e7c03dc7_1a319d13","side":"PARENT","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":38},"in_reply_to":"6e563f33_bc3d8b3e","updated":"2022-07-07 04:25:14.000000000","message":"Done","commit_id":"ab35091c41be587013f1526c50ac4ee7e7f2682a"}],"roles/ControllerSriov.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f316f510cde5d76af6bf86cdb8274269ce290292","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  # Set uses_deprecated_params to True if any deprecated params are used."},{"line_number":31,"context_line":"  uses_deprecated_params: True"},{"line_number":32,"context_line":"  deprecated_param_extraconfig: \u0027controllerExtraConfig\u0027"},{"line_number":33,"context_line":"  deprecated_param_flavor: \u0027OvercloudControlFlavor\u0027"},{"line_number":34,"context_line":"  deprecated_param_image: \u0027controllerImage\u0027"},{"line_number":35,"context_line":"  deprecated_nic_config_name: \u0027controller.yaml\u0027"},{"line_number":36,"context_line":"  update_serial: 1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"16d7dba5_3c9ec7d7","side":"PARENT","line":33,"updated":"2022-07-05 15:22:40.000000000","message":"actually, I\u0027m not sure how removing those impacts FFU?\nI know those deprecated params must be retained for upgrades, or things might fail in strange ways, whenever omitted any","commit_id":"ab35091c41be587013f1526c50ac4ee7e7f2682a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"588066684f566c04b6862c87c015c28488aeb9e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  # Set uses_deprecated_params to True if any deprecated params are used."},{"line_number":31,"context_line":"  uses_deprecated_params: True"},{"line_number":32,"context_line":"  deprecated_param_extraconfig: \u0027controllerExtraConfig\u0027"},{"line_number":33,"context_line":"  deprecated_param_flavor: \u0027OvercloudControlFlavor\u0027"},{"line_number":34,"context_line":"  deprecated_param_image: \u0027controllerImage\u0027"},{"line_number":35,"context_line":"  deprecated_nic_config_name: \u0027controller.yaml\u0027"},{"line_number":36,"context_line":"  update_serial: 1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"82447413_af0e27b3","side":"PARENT","line":33,"in_reply_to":"149d1643_a78fee36","updated":"2022-07-07 11:35:18.000000000","message":"Done","commit_id":"ab35091c41be587013f1526c50ac4ee7e7f2682a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e0b8ad392052a889ff0ce30e17b434b3c32de63","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  # Set uses_deprecated_params to True if any deprecated params are used."},{"line_number":31,"context_line":"  uses_deprecated_params: True"},{"line_number":32,"context_line":"  deprecated_param_extraconfig: \u0027controllerExtraConfig\u0027"},{"line_number":33,"context_line":"  deprecated_param_flavor: \u0027OvercloudControlFlavor\u0027"},{"line_number":34,"context_line":"  deprecated_param_image: \u0027controllerImage\u0027"},{"line_number":35,"context_line":"  deprecated_nic_config_name: \u0027controller.yaml\u0027"},{"line_number":36,"context_line":"  update_serial: 1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"149d1643_a78fee36","side":"PARENT","line":33,"in_reply_to":"16d7dba5_3c9ec7d7","updated":"2022-07-05 15:34:55.000000000","message":"No. These flavor parameters have had no effect since we get rid of Nova from undercloud. Currently we mock OS::Nova::Server by https://github.com/openstack/tripleo-heat-templates/blob/master/deployed-server/deployed-server.yaml#L9 and the flavor property is not used.\n\nI\u0027m not 100% clear about upgrade but as we completely removed nova I don\u0027t think removing this unused parameter can cause any back effect.","commit_id":"ab35091c41be587013f1526c50ac4ee7e7f2682a"}]}