)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f79260787566cae195e29102ff0c07902bcc3f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b1e43ae9_70f15dd3","updated":"2022-07-08 13:00:47.000000000","message":"thanks Rabi!","commit_id":"d49262a74b0ee090a9510d0955db05fe7dc3ef12"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ace2adb91e991eca47109d11edef45a32a72d8cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2fff463_a16fae7d","updated":"2022-07-14 16:19:38.000000000","message":"PTAL","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e7aa41208eb6ba31f061ae0ba6056f40cc4184b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08df36a7_c45f9d50","updated":"2022-07-14 16:24:54.000000000","message":"actually, no, the original condition looks still broken. But I give up fixing it :)","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3b69cb417cb4fa8f397b22b7e8cef96a6c851ec3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c1f341b_248b6110","updated":"2022-07-15 14:30:07.000000000","message":"let\u0027s give it a one more try","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"735594a6e0be4df470fa1bf90cb85e73c61032cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"779f3e4f_bc389660","updated":"2022-07-15 15:23:01.000000000","message":"I *think* this looks right to me now.. either it is or I\u0027ve looked at it too long and convinced myself it is 😊","commit_id":"5cec85c4cb8a3dd78295b4c3e69a894171f66259"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"591b7449b695a3a787a9dcdc95b1792df77557f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fbc72725_284728a1","updated":"2022-07-15 15:01:27.000000000","message":"nailed it!","commit_id":"5cec85c4cb8a3dd78295b4c3e69a894171f66259"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"459eefb7b8b4ac8e2e7997062e2ab3eae18ecb5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9dd29162_059d9f27","updated":"2022-07-26 07:20:13.000000000","message":"recheck\n\npep8 job has been fixed","commit_id":"032652dd5bfdd3ff72ed2f5b54628c3bac49cf82"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8c320e4ef21a58df843bda9358d0b63ab594fa16","unresolved":true,"context_lines":[{"line_number":862,"context_line":"    or:"},{"line_number":863,"context_line":"      - not:"},{"line_number":864,"context_line":"          and:"},{"line_number":865,"context_line":"          -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":866,"context_line":"          -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":867,"context_line":"      - not:"},{"line_number":868,"context_line":"          and:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d801d2bd_ff436b9b","line":865,"range":{"start_line":865,"start_character":13,"end_line":865,"end_character":67},"updated":"2022-07-07 04:04:09.000000000","message":"As mentioned in the earlier patchset, L865 is never going to be true. we should drop that.\n\n  or:\n    - not: {equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]}\n    - not: {equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]}\n    - not: {equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]}","commit_id":"d49262a74b0ee090a9510d0955db05fe7dc3ef12"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f79260787566cae195e29102ff0c07902bcc3f11","unresolved":false,"context_lines":[{"line_number":862,"context_line":"    or:"},{"line_number":863,"context_line":"      - not:"},{"line_number":864,"context_line":"          and:"},{"line_number":865,"context_line":"          -  equals: [{get_param: NovaLibvirtFileBackedMemory}, \u0027\u0027]"},{"line_number":866,"context_line":"          -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, \u0027\u0027]"},{"line_number":867,"context_line":"      - not:"},{"line_number":868,"context_line":"          and:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"335d5de0_df1425e7","line":865,"range":{"start_line":865,"start_character":13,"end_line":865,"end_character":67},"in_reply_to":"d801d2bd_ff436b9b","updated":"2022-07-08 13:00:47.000000000","message":"Ack","commit_id":"d49262a74b0ee090a9510d0955db05fe7dc3ef12"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"d0004866ce959bad821845615dabb08cc4ecbaea","unresolved":true,"context_lines":[{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    and:"},{"line_number":863,"context_line":"      - not: {equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]}"},{"line_number":864,"context_line":"      - not:"},{"line_number":865,"context_line":"        - or:"},{"line_number":866,"context_line":"          -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"31ebdb8d_fa2a23dc","line":863,"updated":"2022-07-13 13:37:41.000000000","message":"If I\u0027m reading this right, for the condition to be true, both the role specific parameter and global NovaLibvirtFileBackedMemory need to have non-zero values. Is that intended?","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"12c0b2fc3ef92ef2f53a09f3a089b3f9c3403ed8","unresolved":true,"context_lines":[{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    and:"},{"line_number":863,"context_line":"      - not: {equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]}"},{"line_number":864,"context_line":"      - not:"},{"line_number":865,"context_line":"        - or:"},{"line_number":866,"context_line":"          -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e46bc166_af0d0dbd","line":863,"in_reply_to":"31ebdb8d_fa2a23dc","updated":"2022-07-14 16:22:52.000000000","message":"hmmm it looks like the original version is correct and this change is not needed. If either of (the original) conditions met, we consider the featuregate ON","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"591b7449b695a3a787a9dcdc95b1792df77557f1","unresolved":false,"context_lines":[{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    and:"},{"line_number":863,"context_line":"      - not: {equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]}"},{"line_number":864,"context_line":"      - not:"},{"line_number":865,"context_line":"        - or:"},{"line_number":866,"context_line":"          -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1b05a14f_54512931","line":863,"in_reply_to":"b7ba797c_76e808d9","updated":"2022-07-15 15:01:27.000000000","message":"Done","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7e372c36fba6029117eca2e05056a7f6087a25a3","unresolved":true,"context_lines":[{"line_number":860,"context_line":"      - not: {get_param: EnableInstanceHA}"},{"line_number":861,"context_line":"  libvirt_file_backed_memory_enabled:"},{"line_number":862,"context_line":"    and:"},{"line_number":863,"context_line":"      - not: {equals: [{get_param: NovaLibvirtFileBackedMemory}, 0]}"},{"line_number":864,"context_line":"      - not:"},{"line_number":865,"context_line":"        - or:"},{"line_number":866,"context_line":"          -  equals: [{get_param: [RoleParameters, NovaLibvirtFileBackedMemory]}, 0]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b7ba797c_76e808d9","line":863,"in_reply_to":"e46bc166_af0d0dbd","updated":"2022-07-14 16:23:49.000000000","message":"if NOT met* ...","commit_id":"a64b4650c9f93a87bbb4dfbb80dc55a6884cc3fe"}]}