)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10d95e8b8dbe4389295e02992e12dc3131c9f575","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b00c709_2a9c2ab3","updated":"2022-07-11 15:43:02.000000000","message":"I assume this is required for https://review.opendev.org/c/x/tripleo-ipa/+/848255 . Do you care to add any reference to that bug ?","commit_id":"d6209288200d4842cd474ddba8d37339482cac6f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"dbcebf11b2927e3ba2afa0f801167281763e7869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc18d5a0_7a71c3b7","updated":"2022-07-20 20:47:10.000000000","message":"recheck","commit_id":"7761fed0cb1cd0740a2c0dee128144acf053249e"}],"deployment/ipa/ipaservices-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2cf11254a18331b9b52bb58fe8bea33767aed6b","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                tripleo_ipa_ptr_zone_split_ipv4: {get_param: IdMZoneSplitIPv4}"},{"line_number":113,"context_line":"                tripleo_ipa_ptr_zone_split_ipv6: {get_param: IdMZoneSplitIPv6}"},{"line_number":114,"context_line":"              when: {get_param: IdMModifyDNS}"},{"line_number":115,"context_line":"          environment:"},{"line_number":116,"context_line":"            if:"},{"line_number":117,"context_line":"              - idm_server_provided"},{"line_number":118,"context_line":"              - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":119,"context_line":"                IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":120,"context_line":"                KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":121,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":122,"context_line":"              - IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":123,"context_line":"                KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":124,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":125,"context_line":"        - name: enroll the node as an ipa client"},{"line_number":126,"context_line":"          #NOTE(xek): this is moved to external_deploy_tasks to make sure this happens before certificates are requested from certmonger"},{"line_number":127,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6bd5184d_abdc7afa","line":124,"range":{"start_line":115,"start_character":0,"end_line":124,"end_character":63},"updated":"2022-07-11 15:46:10.000000000","message":"You can try\n\n```\n          environment:\n            map_merge:\n              - IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\"\n                KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}\n                KRB5CCNAME: {get_param: IdMNovaCredentialCache}\n              - if:\n                - idm_server_provided\n                - IPA_HOST: {get_param: [IdMServer, 0]}\n```\n\nto avoid defining the same lines twice.","commit_id":"d6209288200d4842cd474ddba8d37339482cac6f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"706102ba3d39912a4e5fd0156359ab08aa2d6ae9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                tripleo_ipa_ptr_zone_split_ipv4: {get_param: IdMZoneSplitIPv4}"},{"line_number":113,"context_line":"                tripleo_ipa_ptr_zone_split_ipv6: {get_param: IdMZoneSplitIPv6}"},{"line_number":114,"context_line":"              when: {get_param: IdMModifyDNS}"},{"line_number":115,"context_line":"          environment:"},{"line_number":116,"context_line":"            if:"},{"line_number":117,"context_line":"              - idm_server_provided"},{"line_number":118,"context_line":"              - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":119,"context_line":"                IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":120,"context_line":"                KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":121,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":122,"context_line":"              - IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":123,"context_line":"                KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":124,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":125,"context_line":"        - name: enroll the node as an ipa client"},{"line_number":126,"context_line":"          #NOTE(xek): this is moved to external_deploy_tasks to make sure this happens before certificates are requested from certmonger"},{"line_number":127,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"74983737_b99dc10c","line":124,"range":{"start_line":115,"start_character":0,"end_line":124,"end_character":63},"in_reply_to":"6bd5184d_abdc7afa","updated":"2022-07-21 16:16:22.000000000","message":"Done","commit_id":"d6209288200d4842cd474ddba8d37339482cac6f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0dfa3d2e3be3957556dd1feaad2c18846bce5ffc","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                tripleo_ipa_ptr_zone_split_ipv6: {get_param: IdMZoneSplitIPv6}"},{"line_number":114,"context_line":"              when: {get_param: IdMModifyDNS}"},{"line_number":115,"context_line":"          environment:"},{"line_number":116,"context_line":"            map_merge:"},{"line_number":117,"context_line":"              - IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":118,"context_line":"                KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":119,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":120,"context_line":"              - if:"},{"line_number":121,"context_line":"                - idm_server_provided"},{"line_number":122,"context_line":"                - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":123,"context_line":"        - name: enroll the node as an ipa client"},{"line_number":124,"context_line":"          #NOTE(xek): this is moved to external_deploy_tasks to make sure this happens before certificates are requested from certmonger"},{"line_number":125,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":126,"context_line":"          vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9d25425d_b419f33b","line":123,"range":{"start_line":116,"start_character":0,"end_line":123,"end_character":48},"updated":"2022-07-21 15:51:25.000000000","message":"This is fine, but can be done optimally without the need for two lists and map_merge.\n\n\nenvironment:\n  IPA_USER: \"nova/{{ ansible_facts[\u0027fqdn\u0027] }}\"\n  KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}\n  KRB5CCNAME: {get_param: IdMNovaCredentialCache}\n  IPA_HOST:\n    if:\n      - idm_server_provided\n      - get_param: [IdMServer, 0]","commit_id":"7761fed0cb1cd0740a2c0dee128144acf053249e"}]}