)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3e2c28b8dc30d6afd013714cd2e8c6d7449018d6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"service/systemd check_mode fails[1] when service not found on host,"},{"line_number":10,"context_line":"we should skip the task instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/ansible/ansible/pull/68136"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I88f82e0eac5fa35b7a6de9ef20e936ef35a47891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"04eeb3d8_1a36e4cc","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":49},"updated":"2022-07-13 07:49:04.000000000","message":"thanks for context \nthat merged into core in 2020 - perhaps our pinned ansible version doesn\u0027t have this yet (probably?)","commit_id":"3178759035031015ec1d5b76d9e8f3b1009619ad"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"4d6c043b6c8979e409f15fb86ab1f1f8e03ad256","unresolved":true,"context_lines":[{"line_number":9,"context_line":"service/systemd check_mode fails[1] when service not found on host,"},{"line_number":10,"context_line":"we should skip the task instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/ansible/ansible/pull/68136"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I88f82e0eac5fa35b7a6de9ef20e936ef35a47891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f777b3a1_6a6e71fc","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":49},"in_reply_to":"04eeb3d8_1a36e4cc","updated":"2022-07-13 07:56:56.000000000","message":"This has been reported downstream and the ansible patch is there in ansible 2.10+. I guess we don\u0027t have jobs that run check mode.","commit_id":"3178759035031015ec1d5b76d9e8f3b1009619ad"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0977a64fc46c5863bb70eea8b5e82a4b4ff06064","unresolved":false,"context_lines":[{"line_number":9,"context_line":"service/systemd check_mode fails[1] when service not found on host,"},{"line_number":10,"context_line":"we should skip the task instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/ansible/ansible/pull/68136"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I88f82e0eac5fa35b7a6de9ef20e936ef35a47891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e8050514_95d6c0f3","line":12,"range":{"start_line":12,"start_character":39,"end_line":12,"end_character":49},"in_reply_to":"f777b3a1_6a6e71fc","updated":"2022-07-13 08:03:17.000000000","message":"oh right thanks (we don\u0027t run check_mode)","commit_id":"3178759035031015ec1d5b76d9e8f3b1009619ad"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3e2c28b8dc30d6afd013714cd2e8c6d7449018d6","unresolved":true,"context_lines":[{"line_number":450,"context_line":"        - name: Enabling the cleanup service"},{"line_number":451,"context_line":"          service:"},{"line_number":452,"context_line":"            name: neutron-cleanup"},{"line_number":453,"context_line":"            enabled: true"},{"line_number":454,"context_line":"          when: not (ansible_check_mode|bool)"},{"line_number":455,"context_line":"      external_deploy_tasks:"},{"line_number":456,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"57a7dc4c_23d18349","line":453,"updated":"2022-07-13 07:49:04.000000000","message":"hound gave up one more in tripleo-ansible do you need to fix that too https://opendev.org/openstack/tripleo-ansible/src/commit/0cff3f9556fd6aa7b808c5d71941162fdfbfe0d3/tripleo_ansible/roles/tripleo_ovn/tasks/hostprep.yml#L52","commit_id":"3178759035031015ec1d5b76d9e8f3b1009619ad"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3d0539a2d13e1b7c3f122d1e869b6b314d705f6f","unresolved":true,"context_lines":[{"line_number":450,"context_line":"        - name: Enabling the cleanup service"},{"line_number":451,"context_line":"          service:"},{"line_number":452,"context_line":"            name: neutron-cleanup"},{"line_number":453,"context_line":"            enabled: true"},{"line_number":454,"context_line":"          when: not (ansible_check_mode|bool)"},{"line_number":455,"context_line":"      external_deploy_tasks:"},{"line_number":456,"context_line":"        - when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e296498f_12531f0a","line":453,"in_reply_to":"57a7dc4c_23d18349","updated":"2022-07-13 08:19:08.000000000","message":"That\u0027s added recently for some standalone role change[1], which is not yet used, but duplicated in tripleo-ansible repo.\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/842041","commit_id":"3178759035031015ec1d5b76d9e8f3b1009619ad"}]}