)]}'
{"deployment/etcd/etcd-container-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1663d5f6a720395dd7848046f5170449fb7be15c","unresolved":true,"context_lines":[{"line_number":148,"context_line":"              tripleo_etcd_peer_trusted_ca_file: {get_param: InternalTLSCAFile}"},{"line_number":149,"context_line":"              tripleo_etcd_enable_internal_tls: true"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"      config_settings:"},{"line_number":152,"context_line":"        map_merge:"},{"line_number":153,"context_line":"        - if:"},{"line_number":154,"context_line":"          - not: internal_tls_enabled"},{"line_number":155,"context_line":"          - tripleo::profile::base::cinder::volume::enable_internal_tls: false"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":158,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dc9ad65c_bc29c34a","line":155,"range":{"start_line":151,"start_character":0,"end_line":155,"end_character":78},"updated":"2022-07-21 12:43:00.000000000","message":"you need to use service_config_settings if you want to inject this hieradata to cinder-volume. Also, false is the default value. Do we really need this ?","commit_id":"98827db9afb56412b457b99f7d49c02a5c21210b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5d4e63ed4b68aa4a8c2f679a04bf9c87cc4a08a","unresolved":true,"context_lines":[{"line_number":148,"context_line":"              tripleo_etcd_peer_trusted_ca_file: {get_param: InternalTLSCAFile}"},{"line_number":149,"context_line":"              tripleo_etcd_enable_internal_tls: true"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"      config_settings:"},{"line_number":152,"context_line":"        map_merge:"},{"line_number":153,"context_line":"        - if:"},{"line_number":154,"context_line":"          - not: internal_tls_enabled"},{"line_number":155,"context_line":"          - tripleo::profile::base::cinder::volume::enable_internal_tls: false"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":158,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f483ff81_041b50d4","line":155,"range":{"start_line":151,"start_character":0,"end_line":155,"end_character":78},"in_reply_to":"b481cec0_de1f9892","updated":"2022-08-19 13:50:05.000000000","message":"It\u0027s there for historical reasons that no longer apply. There was a time when we did NOT support tls-e with etcd, and so there was a need to specifically override the setting based on a THT parameter that was deprecated long ago.\n\nI other words, I agree we can eliminate L155 (L158 in the latest patchset).","commit_id":"98827db9afb56412b457b99f7d49c02a5c21210b"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"21da789720419fa56f12d75c6246e35a305e588c","unresolved":true,"context_lines":[{"line_number":148,"context_line":"              tripleo_etcd_peer_trusted_ca_file: {get_param: InternalTLSCAFile}"},{"line_number":149,"context_line":"              tripleo_etcd_enable_internal_tls: true"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"      config_settings:"},{"line_number":152,"context_line":"        map_merge:"},{"line_number":153,"context_line":"        - if:"},{"line_number":154,"context_line":"          - not: internal_tls_enabled"},{"line_number":155,"context_line":"          - tripleo::profile::base::cinder::volume::enable_internal_tls: false"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":158,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b481cec0_de1f9892","line":155,"range":{"start_line":151,"start_character":0,"end_line":155,"end_character":78},"in_reply_to":"dc9ad65c_bc29c34a","updated":"2022-08-17 01:17:10.000000000","message":"We still need service_config_settings for tls-e case, as the backend_url is created using certificate_specs hieradata injected to cinder-volume.\n\nAs we are not removing the section completely, i think it is ok to have it.","commit_id":"98827db9afb56412b457b99f7d49c02a5c21210b"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9e14603a1bf67e88118ad4cfffecaeae0259c21b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"              tripleo_etcd_peer_trusted_ca_file: {get_param: InternalTLSCAFile}"},{"line_number":149,"context_line":"              tripleo_etcd_enable_internal_tls: true"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"      config_settings:"},{"line_number":152,"context_line":"        map_merge:"},{"line_number":153,"context_line":"        - if:"},{"line_number":154,"context_line":"          - not: internal_tls_enabled"},{"line_number":155,"context_line":"          - tripleo::profile::base::cinder::volume::enable_internal_tls: false"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":158,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"596739a0_6bf42ffc","line":155,"range":{"start_line":151,"start_character":0,"end_line":155,"end_character":78},"in_reply_to":"f483ff81_041b50d4","updated":"2022-08-22 08:19:07.000000000","message":"Thanks for the information, L158 removed","commit_id":"98827db9afb56412b457b99f7d49c02a5c21210b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5d4e63ed4b68aa4a8c2f679a04bf9c87cc4a08a","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  EnableInternalTLS:"},{"line_number":56,"context_line":"    type: boolean"},{"line_number":57,"context_line":"    default: false"},{"line_number":58,"context_line":"  EnableEtcdInternalTLS:"},{"line_number":59,"context_line":"    description: Controls whether etcd and the cinder-volume service use TLS"},{"line_number":60,"context_line":"                 for cinder\u0027s lock manager, even when the rest of the internal"},{"line_number":61,"context_line":"                 API network is using TLS."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f0efb20b_0908220d","line":58,"updated":"2022-08-19 13:50:05.000000000","message":"As I note in another comment, this parameter is an artifact from the time when it was necessary to disable using tls-e with etcd, even when the result of the deployment was using tls-e. We no longer need to worry about that scenario, and so this parameter isn\u0027t needed in this new THT. Just use the global EnableInternalTLS parameter.","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9e14603a1bf67e88118ad4cfffecaeae0259c21b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  EnableInternalTLS:"},{"line_number":56,"context_line":"    type: boolean"},{"line_number":57,"context_line":"    default: false"},{"line_number":58,"context_line":"  EnableEtcdInternalTLS:"},{"line_number":59,"context_line":"    description: Controls whether etcd and the cinder-volume service use TLS"},{"line_number":60,"context_line":"                 for cinder\u0027s lock manager, even when the rest of the internal"},{"line_number":61,"context_line":"                 API network is using TLS."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0785085e_f0fdff54","line":58,"in_reply_to":"f0efb20b_0908220d","updated":"2022-08-22 08:19:07.000000000","message":"Done","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5d4e63ed4b68aa4a8c2f679a04bf9c87cc4a08a","unresolved":true,"context_lines":[{"line_number":82,"context_line":"                 certificate for this service"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"parameter_groups:"},{"line_number":85,"context_line":"- label: deprecated"},{"line_number":86,"context_line":"  description: |"},{"line_number":87,"context_line":"   The following parameters are deprecated and will be removed. They should not"},{"line_number":88,"context_line":"   be relied on for new deployments. If you have concerns regarding deprecated"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff9c1529_140db7b8","line":85,"updated":"2022-08-19 13:50:05.000000000","message":"No need to deprecate this because the entire THT is new.","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9e14603a1bf67e88118ad4cfffecaeae0259c21b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                 certificate for this service"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"parameter_groups:"},{"line_number":85,"context_line":"- label: deprecated"},{"line_number":86,"context_line":"  description: |"},{"line_number":87,"context_line":"   The following parameters are deprecated and will be removed. They should not"},{"line_number":88,"context_line":"   be relied on for new deployments. If you have concerns regarding deprecated"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"83764ad3_12a0f6ac","line":85,"in_reply_to":"ff9c1529_140db7b8","updated":"2022-08-22 08:19:07.000000000","message":"Done","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5d4e63ed4b68aa4a8c2f679a04bf9c87cc4a08a","unresolved":true,"context_lines":[{"line_number":155,"context_line":"          - tripleo::profile::base::etcd::certificate_specs:"},{"line_number":156,"context_line":"              service_certificate: \u0027/etc/pki/tls/certs/etcd.crt\u0027"},{"line_number":157,"context_line":"              service_key: \u0027/etc/pki/tls/private/etcd.key\u0027"},{"line_number":158,"context_line":"          - tripleo::profile::base::cinder::volume::enable_internal_tls: false"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":161,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"cf519e29_204db6ae","line":158,"updated":"2022-08-19 13:50:05.000000000","message":"Just repeating my comment that this line can be eliminated.","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9e14603a1bf67e88118ad4cfffecaeae0259c21b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"          - tripleo::profile::base::etcd::certificate_specs:"},{"line_number":156,"context_line":"              service_certificate: \u0027/etc/pki/tls/certs/etcd.crt\u0027"},{"line_number":157,"context_line":"              service_key: \u0027/etc/pki/tls/private/etcd.key\u0027"},{"line_number":158,"context_line":"          - tripleo::profile::base::cinder::volume::enable_internal_tls: false"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":161,"context_line":"      kolla_config:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6dc277b7_1670e7dc","line":158,"in_reply_to":"cf519e29_204db6ae","updated":"2022-08-22 08:19:07.000000000","message":"Ack","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d5d4e63ed4b68aa4a8c2f679a04bf9c87cc4a08a","unresolved":true,"context_lines":[{"line_number":201,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":202,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":203,"context_line":"                # etcd membership."},{"line_number":204,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":205,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":206,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":207,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f5a1997_b963f446","line":204,"updated":"2022-08-19 13:50:05.000000000","message":"As noted in [1], this should not be necessary since the ETCD_NAME should be present in the etcd.conf file that is sourced on L194.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/853565","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9e14603a1bf67e88118ad4cfffecaeae0259c21b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":202,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":203,"context_line":"                # etcd membership."},{"line_number":204,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":205,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":206,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":207,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"067ec14d_1bfc4f2a","line":204,"in_reply_to":"3f5a1997_b963f446","updated":"2022-08-22 08:19:07.000000000","message":"Done","commit_id":"9a0da2022846425439151adaee6421bc0581748e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9bda970a6cde9f913e3b749c67759ed03059826","unresolved":true,"context_lines":[{"line_number":130,"context_line":"              tripleo_etcd_enable_internal_tls: true"},{"line_number":131,"context_line":"      # This data generated below is needed during backend_url creation in puppet-tripleo"},{"line_number":132,"context_line":"      config_settings:"},{"line_number":133,"context_line":"        map_merge:"},{"line_number":134,"context_line":"        - if:"},{"line_number":135,"context_line":"          - internal_tls_enabled"},{"line_number":136,"context_line":"          - tripleo::profile::base::etcd::certificate_specs:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"d97b7967_8e0298ae","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":17},"updated":"2022-10-24 08:43:09.000000000","message":"I know this comes from -puppet.yaml but you can omit this map_merge because there is only a single dict here.","commit_id":"3b110bb1dbb1f5147b5d9a7369c1813a18334928"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9bda970a6cde9f913e3b749c67759ed03059826","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            - path: /etc/pki/tls/private/etcd.key"},{"line_number":164,"context_line":"              owner: etcd:etcd"},{"line_number":165,"context_line":"      container_config_scripts:"},{"line_number":166,"context_line":"        etcd_update_members.sh:"},{"line_number":167,"context_line":"          mode: \"0700\""},{"line_number":168,"context_line":"          content:"},{"line_number":169,"context_line":"            str_replace:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0962d93b_fb0a869b","line":166,"range":{"start_line":166,"start_character":9,"end_line":166,"end_character":30},"updated":"2022-10-24 08:43:09.000000000","message":"We might want to discuss whether we want to generate this script by ansible (this should be a separate topic so leave it now)","commit_id":"3b110bb1dbb1f5147b5d9a7369c1813a18334928"}]}