)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8123c9f5ce7ecf497e369ed07dab7ef6cb6d788e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1f7e89a_a5911a93","updated":"2022-08-03 13:36:36.000000000","message":"recheck","commit_id":"6c0410c74cee6e8809239f7a7877279723efec56"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b178b94e73c9409e8aa37e6bf4ad3ad270332a52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e37ceb6a_49d4ba1d","updated":"2022-07-29 05:31:43.000000000","message":"recheck ipa failure","commit_id":"6c0410c74cee6e8809239f7a7877279723efec56"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edd9ba03d19ded5fc6cab42a7880123701c5446b","unresolved":true,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee1069fa_b3096ed8","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"updated":"2022-07-28 13:16:41.000000000","message":"you can make it like\n```\nnova::compute::force_config_drive:\n  if:\n    - not: {get_param: OVNMetadataEnabled}\n    - true\n```\n\nThis allows you to reduce number of dicts being merged by map_merge.\n\nAlso this is not used by ovn-controller itself but is used by nova-comoute so IMO this should be implemented by service_config_settings (I\u0027ll address this in a follow-up)","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8c02eb869322f005a9b153d9a4b41fb2222d15ec","unresolved":false,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f94df827_bb644406","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"in_reply_to":"328a2a95_fd3836db","updated":"2022-07-28 13:58:30.000000000","message":"Done","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3592fc36f352c5ca6899a8a017aa190b62d12b0c","unresolved":true,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4f521c19_fb387b17","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"in_reply_to":"328a2a95_fd3836db","updated":"2022-07-28 14:00:29.000000000","message":"The definition you have in config_settings is only propagated to the services running in the same node. In case you have a compute node, without ovn-controller, but only with sriov-agent, the node does not get this into hieradata thus force_config_drive is not set. If we need to force config drive in all nova-compute service in the deployment then it\u0027s better we use service_config_settings so that the hieradata is present in all nodes which has nova-compute service running.","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9aad7c4c3b088eab5f773865724d3190052b61d0","unresolved":false,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"83350247_a275763a","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"in_reply_to":"4f521c19_fb387b17","updated":"2022-07-29 09:18:10.000000000","message":"Done","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e698ba2472a061d4e59c75ea37b97532ee89a2d","unresolved":true,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eb9b2ee9_417ccbb6","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"in_reply_to":"a2bc55fe_ced688a3","updated":"2022-07-28 13:44:13.000000000","message":"\u003e @Takashi with ^, if OVNMetadataEnabled\u003dTrue what nova::compute::force_config_drive will be set to? \n\nThen the hieradata is not set and the default value in puppet-nova is used, which is false.\n\nhttps://github.com/openstack/puppet-nova/blob/master/manifests/compute.pp#L291\n\n\u003e My intention in this patch to not touch it so if some other service like nova-ironic set that get\u0027s used.\n\nEven current implementation affects nova-ironic if ovn-controller and nova-ironic are collocated, so usage of config_settings does not solve the concern fully. Anyway we can discuss it later.","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4772b01eb090883cc7d4f31150438c435e9215db","unresolved":true,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"328a2a95_fd3836db","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"in_reply_to":"eb9b2ee9_417ccbb6","updated":"2022-07-28 13:54:37.000000000","message":"\u003c\u003c Then the hieradata is not set and the default value in puppet-nova is used, which is false.\nOk if this the case i will update.\n\n\u003c\u003c Even current implementation affects nova-ironic if ovn-controller and nova-ironic are collocated, so usage of config_settings does not solve the concern fully. Anyway we can discuss it later.\nwhat i understand is with PS1 OVNMetadataEnabled\u003dTrue ovn-controller service will not set nova::compute::force_config_drive at all, may be you meant something else","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"992eb3ec6436c5bebcb0795ddc29f70f1faca5a1","unresolved":true,"context_lines":[{"line_number":285,"context_line":"              if:"},{"line_number":286,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":287,"context_line":"                - 0"},{"line_number":288,"context_line":"          - if:"},{"line_number":289,"context_line":"              - not: {get_param: OVNMetadataEnabled}"},{"line_number":290,"context_line":"              - nova::compute::force_config_drive: true"},{"line_number":291,"context_line":"              - {}"},{"line_number":292,"context_line":"      service_config_settings: {}"},{"line_number":293,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":294,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a2bc55fe_ced688a3","line":291,"range":{"start_line":288,"start_character":0,"end_line":291,"end_character":18},"in_reply_to":"ee1069fa_b3096ed8","updated":"2022-07-28 13:36:19.000000000","message":"@Takashi with ^, if OVNMetadataEnabled\u003dTrue what nova::compute::force_config_drive will be set to? \n\nMy intention in this patch to not touch it so if some other service like nova-ironic set that get\u0027s used.","commit_id":"afff9d877f9ee10cb2cee8af46c167c8b83d80dd"}]}