)]}'
{"common/deploy-steps.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2ea57b2465b88cfff3c26508f9d9b0e0aa619bec","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                      delegate_to: localhost"},{"line_number":702,"context_line":"                      run_once: true"},{"line_number":703,"context_line":"                      debug:"},{"line_number":704,"context_line":"                        msg: Use --start-at-task \u0027Host prep steps\u0027 to resume from this task"},{"line_number":705,"context_line":"{% endraw %}"},{"line_number":706,"context_line":"{%- for role in roles %}"},{"line_number":707,"context_line":"                    - name: {{role.name}} Host prep tasks"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1257c02a_fbe0b995","line":704,"range":{"start_line":704,"start_character":24,"end_line":704,"end_character":91},"updated":"2022-08-03 05:28:25.000000000","message":"So, tripleo_free stops at the end of play in case of failures in any of the nodes[1]. Ansible \u0027free\u0027 does not stop at all on nodes that does not have any failures. \n\nSo, for us start-at-task should always be the first task in a play (in this case before DeployArtifacts as some nodes may fail with DeployArtifacts and others running host_prep_tasks.\n\nAlso, there are more issues with other plays like Deploy steps for step1, where the start-at-tasks won\u0027t work. Some nodes may fail in common_deploy_steps_tasks_step_1 and others in deploy_steps_tasks_step1.yaml. We need to change all those scenarios too.\n\n    - name: Overcloud common bootstrap tasks for step 1\n      block:\n        - name: Overcloud common bootstrap tasks for step 1\n          delegate_to: localhost\n          run_once: true\n          debug:\n            msg: Use --start-at-task \u0027Overcloud common bootstrap tasks for step 1\u0027 to resume from this task\n        - name: \"Check if /var/lib/tripleo-config/container-startup-config/step_1 already exists\"\n          stat:\n            path: \"/var/lib/tripleo-config/container-startup-config/step_1\"\n          register: container_startup_configs_json_stat\n        - name: Write config data at the start of step 1\n          include_tasks: common_deploy_steps_tasks_step_1.yaml\n          when:\n            - ((deploy_identifier is defined and deploy_identifier !\u003d \"\" and deploy_identifier is not none) or\n              not container_startup_configs_json_stat.stat.exists)\n\n    - name: Deploy step tasks for 1\n      delegate_to: localhost\n      run_once: true\n      debug:\n        msg: Use --start-at-task \u0027Deploy step tasks for 1\u0027 to resume from this task\n    - include_tasks: \"ControllerOpenstack/deploy_steps_tasks_step1.yaml\"\n      when:\n        - tripleo_role_name \u003d\u003d \u0027ControllerOpenstack\u0027\n        - playbook_dir ~ \u0027/ControllerOpenstack/deploy_steps_tasks_step1.yaml\u0027 is exists\n    - include_tasks: \"Database/deploy_steps_tasks_step1.yaml\"\n\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/ansible_plugins/strategy/tripleo_free.py#L268","commit_id":"e47fc087426ab37e65a6dcab68613f927e4ca470"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5f96f294384bbeea39de65308c16cbffc7182bc","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                      delegate_to: localhost"},{"line_number":702,"context_line":"                      run_once: true"},{"line_number":703,"context_line":"                      debug:"},{"line_number":704,"context_line":"                        msg: Use --start-at-task \u0027Host prep steps\u0027 to resume from this task"},{"line_number":705,"context_line":"{% endraw %}"},{"line_number":706,"context_line":"{%- for role in roles %}"},{"line_number":707,"context_line":"                    - name: {{role.name}} Host prep tasks"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"145e97c3_dacc2f8d","line":704,"range":{"start_line":704,"start_character":24,"end_line":704,"end_character":91},"in_reply_to":"1257c02a_fbe0b995","updated":"2022-08-03 07:53:43.000000000","message":"I agree these should be fixed as well and thanks for updating the patch to sourt out these !","commit_id":"e47fc087426ab37e65a6dcab68613f927e4ca470"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2ea57b2465b88cfff3c26508f9d9b0e0aa619bec","unresolved":true,"context_lines":[{"line_number":702,"context_line":"                      run_once: true"},{"line_number":703,"context_line":"                      debug:"},{"line_number":704,"context_line":"                        msg: Use --start-at-task \u0027Host prep steps\u0027 to resume from this task"},{"line_number":705,"context_line":"{% endraw %}"},{"line_number":706,"context_line":"{%- for role in roles %}"},{"line_number":707,"context_line":"                    - name: {{role.name}} Host prep tasks"},{"line_number":708,"context_line":"                      include_tasks: {{role.name}}/host_prep_tasks.yaml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"b8ac4e66_622b4b93","line":705,"range":{"start_line":705,"start_character":0,"end_line":705,"end_character":12},"updated":"2022-08-03 05:28:25.000000000","message":"Why move this?","commit_id":"e47fc087426ab37e65a6dcab68613f927e4ca470"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5f96f294384bbeea39de65308c16cbffc7182bc","unresolved":false,"context_lines":[{"line_number":702,"context_line":"                      run_once: true"},{"line_number":703,"context_line":"                      debug:"},{"line_number":704,"context_line":"                        msg: Use --start-at-task \u0027Host prep steps\u0027 to resume from this task"},{"line_number":705,"context_line":"{% endraw %}"},{"line_number":706,"context_line":"{%- for role in roles %}"},{"line_number":707,"context_line":"                    - name: {{role.name}} Host prep tasks"},{"line_number":708,"context_line":"                      include_tasks: {{role.name}}/host_prep_tasks.yaml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fbe481c7_b55bb9a7","line":705,"range":{"start_line":705,"start_character":0,"end_line":705,"end_character":12},"in_reply_to":"b8ac4e66_622b4b93","updated":"2022-08-03 07:53:43.000000000","message":"Done","commit_id":"e47fc087426ab37e65a6dcab68613f927e4ca470"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"256a266efc69a2b1d19ba2e22440b0054236f390","unresolved":true,"context_lines":[{"line_number":564,"context_line":"              vars:"},{"line_number":565,"context_line":"                deploy_source_host: \"DEPLOY_SOURCE_HOST\""},{"line_number":566,"context_line":"              tasks:"},{"line_number":567,"context_line":"{% raw %}"},{"line_number":568,"context_line":"                - import_tasks: hiera_steps_tasks.yaml"},{"line_number":569,"context_line":"                - name: Server pre-network deployments"},{"line_number":570,"context_line":"                  delegate_to: localhost"},{"line_number":571,"context_line":"                  run_once: true"},{"line_number":572,"context_line":"                  debug:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"601c87a0_ec7ea739","line":569,"range":{"start_line":567,"start_character":9,"end_line":569,"end_character":54},"updated":"2022-08-03 07:51:24.000000000","message":"we better swap these two, as is done for Server pre deployments","commit_id":"90fc2a880e898d6f99dfceed2efc5803241e5e27"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f5f96f294384bbeea39de65308c16cbffc7182bc","unresolved":false,"context_lines":[{"line_number":564,"context_line":"              vars:"},{"line_number":565,"context_line":"                deploy_source_host: \"DEPLOY_SOURCE_HOST\""},{"line_number":566,"context_line":"              tasks:"},{"line_number":567,"context_line":"{% raw %}"},{"line_number":568,"context_line":"                - import_tasks: hiera_steps_tasks.yaml"},{"line_number":569,"context_line":"                - name: Server pre-network deployments"},{"line_number":570,"context_line":"                  delegate_to: localhost"},{"line_number":571,"context_line":"                  run_once: true"},{"line_number":572,"context_line":"                  debug:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"c7e04f1e_6a0a0128","line":569,"range":{"start_line":567,"start_character":9,"end_line":569,"end_character":54},"in_reply_to":"601c87a0_ec7ea739","updated":"2022-08-03 07:53:43.000000000","message":"Done","commit_id":"90fc2a880e898d6f99dfceed2efc5803241e5e27"}]}