)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1535e322054b3c568fc6e1c6fce83a207bb7a4e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ab0e2b7_df7dac8c","updated":"2022-08-03 09:53:02.000000000","message":"recheck","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d13a039db62ba12c8fe847d2f99ca926845def73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17dd7644_c4430294","updated":"2022-08-03 13:24:42.000000000","message":"recheck","commit_id":"0bdd5dd6c596d0ff7b76f0c30e48a9f36a8e4ed5"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9c4b5ce49e461cc62d0afb1537e710656bf8379a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a9a8a2e_15dc9ed5","updated":"2022-08-04 07:05:00.000000000","message":"recheck\n\nissue with galaxy...","commit_id":"05f15aa646038af81fbee99810de600afb4ab601"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"de2ed14d9ebf13e2c032968931521568435aa1ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ae9b7b8_b17fad20","updated":"2022-08-09 08:41:21.000000000","message":"Rule file is correctly generated:\nhttps://63edb61fd0e056b1bbb1-b256b951e18c7d63775be8a7f99fd99d.ssl.cf2.rackcdn.com/851969/9/check/tripleo-ci-centos-9-standalone/9c07bd3/logs/undercloud/etc/audit/rules.d/tripleo.rules","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"85c037a99d55f0c94ad4810df69140fd4f1787f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f08e38cb_a1f11ce5","updated":"2022-08-09 06:07:16.000000000","message":"ok - it\u0027s expected to get empty rules actually in the test job: we don\u0027t include the env file. And the default for AuditDRules is {} - so it\u0027s overriding the default rules provided by the role, so it\u0027s working. YAY","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"8d6cc9c4a451cd18c1120772d106702be199e8ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c29768a_8cc3db79","updated":"2022-08-09 17:43:25.000000000","message":"recheck","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"45ede983831f0032ca66ca7279e342ba7303fabf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6057c221_71a4c1a6","updated":"2022-08-09 05:53:57.000000000","message":"weird, the rules aren\u0027t properly generated this time. Have to dig a bit.","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"25d74b343a54706fc7ac41f433c620648d16e7f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c012d138_78a1197d","updated":"2022-08-10 05:49:39.000000000","message":"re-adding the +W following the rebase","commit_id":"7098a066261241cbbbe011eff8162440a12cfb2e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a54c407fdda01be9b92eb989a8b19b4a964382ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c19b8dc_90e08afd","updated":"2022-08-10 11:35:45.000000000","message":"recheck","commit_id":"7098a066261241cbbbe011eff8162440a12cfb2e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ed238a002630e1e1047f0cffbdaeb75c76309a24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"33f110a6_5e70b536","updated":"2022-08-11 07:52:54.000000000","message":"recheck\n\nunrelated failure in the upgrade job.","commit_id":"7098a066261241cbbbe011eff8162440a12cfb2e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1d9f85fe4d60e8d87931ec317a43a6863e360afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"096b2f61_1f09f324","updated":"2022-08-16 07:36:18.000000000","message":"re-adding +W","commit_id":"8a5e9e68dd92f4cace5bb3839dc9afb95466c353"}],"deployment/auditd/auditd-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dee33175b13c68bc8eb62ac04690039f767fca86","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  role_data:"},{"line_number":41,"context_line":"    description: Role data for the auditd service"},{"line_number":42,"context_line":"    value:"},{"line_number":43,"context_line":"      service_name: tripleo_auditd"},{"line_number":44,"context_line":"      config_settings: {}"},{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b27754ae_b8707633","line":43,"range":{"start_line":43,"start_character":20,"end_line":43,"end_character":34},"updated":"2022-08-03 07:14:01.000000000","message":"we might want to keep the same name, seeing that we didn\u0027t rename the kernel service when migrating it to ansible.","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2283f3bb2360fe2a55a5ec78e4790d1a7981ad7e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  role_data:"},{"line_number":41,"context_line":"    description: Role data for the auditd service"},{"line_number":42,"context_line":"    value:"},{"line_number":43,"context_line":"      service_name: tripleo_auditd"},{"line_number":44,"context_line":"      config_settings: {}"},{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"19dc2755_02a44efd","line":43,"range":{"start_line":43,"start_character":20,"end_line":43,"end_character":34},"in_reply_to":"7628184d_adf9da18","updated":"2022-08-03 13:27:56.000000000","message":"Done","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fe4900ed84a6e273fab0ee6c7f88ff01f23493fe","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  role_data:"},{"line_number":41,"context_line":"    description: Role data for the auditd service"},{"line_number":42,"context_line":"    value:"},{"line_number":43,"context_line":"      service_name: tripleo_auditd"},{"line_number":44,"context_line":"      config_settings: {}"},{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7628184d_adf9da18","line":43,"range":{"start_line":43,"start_character":20,"end_line":43,"end_character":34},"in_reply_to":"b27754ae_b8707633","updated":"2022-08-03 13:26:47.000000000","message":"oh, right. OK. sounds fair. I\u0027ll update.","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dee33175b13c68bc8eb62ac04690039f767fca86","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"},{"line_number":47,"context_line":"          set_fact:"},{"line_number":48,"context_line":"            tripleo_auditd_rules: {get_param: AuditdRules}"},{"line_number":49,"context_line":"            tripleo_auditd_config: {get_param: AuditdConfig}"},{"line_number":50,"context_line":"        - name: Install and configure auditd using ansible"},{"line_number":51,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"402f09dd_63d4ad25","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":32},"updated":"2022-08-03 07:14:01.000000000","message":"I\u0027d prefer adding these to ansible_group_vars so that users can override these by {{role.name}}ExraGroupVars, in case they need role specific values.","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f4e69e1b44166d92aa9e67f461dfd97870f8234f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"},{"line_number":47,"context_line":"          set_fact:"},{"line_number":48,"context_line":"            tripleo_auditd_rules: {get_param: AuditdRules}"},{"line_number":49,"context_line":"            tripleo_auditd_config: {get_param: AuditdConfig}"},{"line_number":50,"context_line":"        - name: Install and configure auditd using ansible"},{"line_number":51,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6ed41511_aff1d032","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":32},"in_reply_to":"17724812_e8573026","updated":"2022-08-08 12:59:27.000000000","message":"hmm right, yes. We can drop that step then. Lemme push an update with that!","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fe4900ed84a6e273fab0ee6c7f88ff01f23493fe","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"},{"line_number":47,"context_line":"          set_fact:"},{"line_number":48,"context_line":"            tripleo_auditd_rules: {get_param: AuditdRules}"},{"line_number":49,"context_line":"            tripleo_auditd_config: {get_param: AuditdConfig}"},{"line_number":50,"context_line":"        - name: Install and configure auditd using ansible"},{"line_number":51,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"632145cd_9a0e8785","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":32},"in_reply_to":"402f09dd_63d4ad25","updated":"2022-08-03 13:26:47.000000000","message":"This isn\u0027t the case right now. Do we really want to break that part? Keep in mind this will need to be backported down to train, since the module is apparently broken since that release.... I\u0027d rather make a follow-up with a dedicated release-note, if you really want this new support.","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"18abbb17c944bd40181251aaa4ef128c484a4682","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"},{"line_number":47,"context_line":"          set_fact:"},{"line_number":48,"context_line":"            tripleo_auditd_rules: {get_param: AuditdRules}"},{"line_number":49,"context_line":"            tripleo_auditd_config: {get_param: AuditdConfig}"},{"line_number":50,"context_line":"        - name: Install and configure auditd using ansible"},{"line_number":51,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f09fce87_bd829a6a","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":32},"in_reply_to":"632145cd_9a0e8785","updated":"2022-08-04 11:47:16.000000000","message":"I\u0027m ok with discussing this separately, because this is more like a new feature.","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d3dbc5c562739d3be48a1c137aecf0d28759a578","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      host_prep_tasks:"},{"line_number":46,"context_line":"        - name: Set config and rules"},{"line_number":47,"context_line":"          set_fact:"},{"line_number":48,"context_line":"            tripleo_auditd_rules: {get_param: AuditdRules}"},{"line_number":49,"context_line":"            tripleo_auditd_config: {get_param: AuditdConfig}"},{"line_number":50,"context_line":"        - name: Install and configure auditd using ansible"},{"line_number":51,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"17724812_e8573026","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":32},"in_reply_to":"f09fce87_bd829a6a","updated":"2022-08-04 12:00:20.000000000","message":"Why set as facts? We can use \u0027vars\u0027 with include_role right?","commit_id":"fe86c18a96a0c60b4778b5b52e0f80f7379ced3b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"641fa881e40a4453932d51f96519067a2e145eb5","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  AuditdRules:"},{"line_number":31,"context_line":"    description: Mapping of auditd rules"},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"    default: {}"},{"line_number":34,"context_line":"  AuditdConfig:"},{"line_number":35,"context_line":"    description: Mapping of auditd configurations"},{"line_number":36,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"70d1e497_f10bcf05","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":15},"updated":"2022-08-09 06:13:54.000000000","message":"Why have default rules in the role when we\u0027re setting it to empty here? We can either have the same default here, or have a condition not to have the host_prep_task if AuditdRules is empty.","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"29bfb292af873be347298e863795bec219ff2d10","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  AuditdRules:"},{"line_number":31,"context_line":"    description: Mapping of auditd rules"},{"line_number":32,"context_line":"    type: json"},{"line_number":33,"context_line":"    default: {}"},{"line_number":34,"context_line":"  AuditdConfig:"},{"line_number":35,"context_line":"    description: Mapping of auditd configurations"},{"line_number":36,"context_line":"    type: json"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fb3c2b64_288a1a2b","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":15},"in_reply_to":"70d1e497_f10bcf05","updated":"2022-08-09 09:24:44.000000000","message":"We should update the default in tripleo-ansible because the current default is not used (and we should not use that default since we use a separate file to define additional rules). This will be covered by https://review.opendev.org/c/openstack/tripleo-ansible/+/852513","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"}],"releasenotes/notes/auditd-to-ansible-f39bd119bf25320e.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"910a6ece0dd1a8c21da20ae4ceae7899ca105684","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    configuration, and use a new \"AuditdConfig\" dict in the parameter_defaults"},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    All of the hiera value for the service configuration are deprecated, and"},{"line_number":9,"context_line":"    replaced by a new \"AuditdConfig\" dict to be passed in the"},{"line_number":10,"context_line":"    parameter_defaults"},{"line_number":11,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5ddb5995_4f524f57","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":71},"updated":"2022-08-09 13:17:46.000000000","message":"Why do we only say deprecated? After we changed the service templates they would have no effect in configuration of auditd right?","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f27bfcac4c8c934503a50046604d04d67913210a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    configuration, and use a new \"AuditdConfig\" dict in the parameter_defaults"},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    All of the hiera value for the service configuration are deprecated, and"},{"line_number":9,"context_line":"    replaced by a new \"AuditdConfig\" dict to be passed in the"},{"line_number":10,"context_line":"    parameter_defaults"},{"line_number":11,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e264d1b8_1b2bedaf","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":71},"in_reply_to":"5ddb5995_4f524f57","updated":"2022-08-09 13:24:56.000000000","message":"what would be the right word? Sorry, here I\u0027m hitting a language issue :/. \"useless\"?","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"48233551a8097b7d9a220272378e13ad0a5c7867","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    configuration, and use a new \"AuditdConfig\" dict in the parameter_defaults"},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    All of the hiera value for the service configuration are deprecated, and"},{"line_number":9,"context_line":"    replaced by a new \"AuditdConfig\" dict to be passed in the"},{"line_number":10,"context_line":"    parameter_defaults"},{"line_number":11,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3826d77e_873d66d0","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":71},"in_reply_to":"e264d1b8_1b2bedaf","updated":"2022-08-09 13:31:55.000000000","message":"AFAIK \u0027deprecated\u0027 always means \"still used\" till folks move to the replacement. We probably should just say \"Configuration of auditd with hiera is not supported anymore\" I guess.\n\nBut, as we say who reads release notes.. If you don\u0027t want to update still fine:)","commit_id":"80aefb8e88f2f300c841e592cd7233192b01b588"}]}