)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"03b11d07dad4aedee7c99a8a603948ca45064383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31d5151d_01e4d1e5","updated":"2022-08-05 11:16:26.000000000","message":"check-rdo ERROR 2002 (HY000): Can\u0027t connect to local MySQL server through socket \u0027/var/lib/mysql/mysql.sock\u0027","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2cd4f7000b863bd676f2ff3397622bd5d17bddc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5ca970c_5ce54bf7","updated":"2022-08-08 14:19:26.000000000","message":"lgtm. I guess we\u0027ll see some refinement patches to this from takashi soon based on the feedback here.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"}],"common/container-puppet.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e661d333a05205306a207d10e982b3d8d5f31696","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ca91ca3e_9cf15548","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"updated":"2022-08-08 04:53:09.000000000","message":"How about using this single regexp ?\n\n```\u0027s/\\#\\s*HEADER:.*//g\u0027```","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ac98eabe7b160e28ea953fb65bb3f4409ef47028","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"81447300_433a5869","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"in_reply_to":"438c4913_01cad3d2","updated":"2022-08-08 05:58:22.000000000","message":"Hmm.. I used the exact pattern match for an appended comment without worrying about what\u0027s already there:) We can change existing one, but not worth updating the patch I guess.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f105bae65dc55ec98f022e93a71aa23659034fb1","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"438c4913_01cad3d2","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"in_reply_to":"5996fca8_30a5e1a0","updated":"2022-08-08 05:49:42.000000000","message":"I was hoping to fix the vague pattern we currently have, by using that single pattern but it might not worth fixing at this stage.\n\nJust one question before I vote +2. Is there any reason why you want #.HEADER.*  instead of #.*HEADER.* ? The current usage (.*) looks non-best but I tend to use the same pattern as much as possible.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5194e7316e3c0f363734ef4c09ce4d6c6966ac77","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5996fca8_30a5e1a0","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"in_reply_to":"7acadc21_319849de","updated":"2022-08-08 05:37:47.000000000","message":"\u003e Once deployment is updated and gets this change then that replacement no longer happens.\n\nYes, but, we should not leave it to that assumption probably (i.e container tags changing when this script is updated) and also creating confusion when hash changing during minor update when config has not changed. I don\u0027t see multiple seds as a big performace bottleneck here and also it keeps the md5sum as before when configs do not change.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7c896b2ec58bbc92b8720531587502038cc5f529","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"b0e7afe6_b0ed22c2","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"in_reply_to":"81447300_433a5869","updated":"2022-08-08 06:04:43.000000000","message":"OK. I think we can keep the current status as we want to backport this to older releases but I\u0027ll refactor this in master.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"f567b1a7aefc805f351fe76d138043cfad81855b","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"cffce456_d9d1812e","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"in_reply_to":"ca91ca3e_9cf15548","updated":"2022-08-08 05:18:12.000000000","message":"That would leave blank lines for lines starting with \"# HEADER\" and would be different from the earlier md5sum (created without this change) and hence replace containers for all minor updates.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9bab101346135817a70d2cbc6aef0ef6908fc4bd","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    # needed because puppet puts timestamps as comments in cron and"},{"line_number":177,"context_line":"    # parsedfile resources, hence triggering a change at every redeploy"},{"line_number":178,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${conf_data_path} $additional_checksum_files | tar xO | \\"},{"line_number":179,"context_line":"            sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${conf_data_path}.md5sum"},{"line_number":180,"context_line":"    tar -c --mtime\u003d\u00271970-01-01\u0027 $EXCLUDE -f - ${puppet_generated_path} $additional_checksum_files --mtime\u003d\u00271970-01-01\u0027 | tar xO \\"},{"line_number":181,"context_line":"            | sed \u0027/^#.*HEADER.*/d; s/\\#.HEADER.*//g\u0027 | md5sum | awk \u0027{print $1}\u0027 \u003e ${puppet_generated_path}.md5sum"},{"line_number":182,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7acadc21_319849de","line":179,"range":{"start_line":179,"start_character":17,"end_line":179,"end_character":50},"in_reply_to":"cffce456_d9d1812e","updated":"2022-08-08 05:27:52.000000000","message":"During minor update, usually all container image tags are updated and all containers are replaced. I don\u0027t see actual concern with triggering replacement of all containers forcefully because of this change.\n\nOnce deployment is updated and gets this change then that replacement no longer happens.","commit_id":"7d64dd990a99ea47730a3c676de95376bb388942"}]}