)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"7927d4cd636f10dd81d13e6b37df1288be4109bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2cd8d287_ab32b7ca","updated":"2022-08-09 03:53:45.000000000","message":"Bit of a learning question for myself.\n\nWhat is the purposes of the deployment/snmp/snmpd-disabled-puppet.yaml file and how is it intended to be used? I was looking and didn\u0027t see any other files named with `-disabled-` in the name.\n\nJust trying to understand the proper way to disable services that are no longer wanted to be deployed that were previously deployed.\n\nWould you reference this deployment file in a custom environment file with a resource created using this to disable the snmp service the one time it is used?","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"30f2d7a6636a7dd36de35f8c3ebe956455e85854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea6c2f77_6a880a62","updated":"2022-08-08 14:31:02.000000000","message":"check-rdo","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"cba96a1c6c634f1da7305c50350552eecf6bf060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"350610a7_95adcc23","updated":"2022-08-09 07:07:04.000000000","message":"thank you!","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"234c0dff1dbdd20c9b53d567dde7f26e202a1084","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73d38c97_8db36424","in_reply_to":"246d67c8_363fc2c5","updated":"2022-08-09 21:47:35.000000000","message":"Ah ha! OK now it all makes sense :) Thanks! Glad I asked lol","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b186ca72dd23d17679b72a8dc873e7947831a3c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"246d67c8_363fc2c5","in_reply_to":"2cd8d287_ab32b7ca","updated":"2022-08-09 07:28:25.000000000","message":"Oops. It seems I forgot to update the core resource registry file after I noticed the needs to clean up the snmpd service already deployed during upgrade. I\u0027ve updated the patch to enable the new disable resource by default. This allows us to automatically stop snmpd service during upgrade to Zed.","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"09893eb541f5f3feb05cdf26b1ac6cffa5e64061","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"113c18ef_1706ffac","updated":"2022-08-09 15:15:11.000000000","message":"recheck  update failed at rabbitmq task, which is irrelevant to this.","commit_id":"8843088ff20f5173a9a8ffdd969c4436f410a09f"},{"author":{"_account_id":7294,"name":"Leif Madsen","email":"lmadsen@redhat.com","username":"leifmadsen"},"change_message_id":"f24194a87eb178a10359a5d74ea92db4abfd71bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8bacb3b2_20c52ad2","updated":"2022-08-18 03:13:08.000000000","message":"recheck","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc31ca8d84671533ad2cdb398d3abb57927f103a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5ae3eefb_2d2162e1","updated":"2022-09-22 02:28:40.000000000","message":"Hmmm... it seems extras is not working as expected . I\u0027ll look into it.","commit_id":"5ff75333776ad56962ca04be74111e1fff6c54e4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"92099e79e0591fe901c16d1998f01bd6b53cc3cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"087e92e3_dab8ab93","updated":"2022-10-12 09:31:18.000000000","message":"If this requirement is no longer valid in stable/wallaby, then I advocate for porting this back to stable/wallaby and actually removing this entirely from master.","commit_id":"31e96b9ce338f15101515d9e6440cfe3a46f3190"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f896ffc3c7e231090f7e67db3d84fcb41fb5a5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2d3963af_35aa9385","in_reply_to":"087e92e3_dab8ab93","updated":"2022-10-13 02:03:59.000000000","message":"I tend to agree with the direction but this is not really suitable for backport because this can break the existing deployment templates which explicitly define the snmpd service, because this moves the template path.","commit_id":"31e96b9ce338f15101515d9e6440cfe3a46f3190"}],"deployment/snmp/snmpd-disabled-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2dcaeaa3aec48ccaae17e1a8b8d8333bfcc1609d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          service:"},{"line_number":51,"context_line":"            name: snmpd"},{"line_number":52,"context_line":"            state: stopped"},{"line_number":53,"context_line":"        # TODO(tkajinam): Also remove net-snmp when we remove the service."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"feeedd8b_9eb012e0","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":74},"updated":"2022-08-08 04:34:50.000000000","message":"alternatively we can remove net-snmp during upgrade task and remove it from overcloud image, but that requires adding the package installation task to the snmpd service.","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a05e14d0454fde6dc648421e8b300c9bc40d7c9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          service:"},{"line_number":51,"context_line":"            name: snmpd"},{"line_number":52,"context_line":"            state: stopped"},{"line_number":53,"context_line":"        # TODO(tkajinam): Also remove net-snmp when we remove the service."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a4381407_1670754b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":74},"in_reply_to":"651bf8a6_7ac48b22","updated":"2022-08-17 15:04:31.000000000","message":"Considering the fact we intend to remove the service completely, we\u0027d be able to accept that limitation. I\u0027ve updated the patch to remove net-snmp.","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ba131665fa9b334d38b9696c0f4b4678b77d0768","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          service:"},{"line_number":51,"context_line":"            name: snmpd"},{"line_number":52,"context_line":"            state: stopped"},{"line_number":53,"context_line":"        # TODO(tkajinam): Also remove net-snmp when we remove the service."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"651bf8a6_7ac48b22","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":74},"in_reply_to":"f1eb96df_d9b7e0c3","updated":"2022-08-10 07:58:38.000000000","message":"If we remove the net-snmp package, then we should remove it from overcloud images. Otherwise the package is included in the host newly deployed, which looks quite inconsistent.\n\nIf we remove the package then usage of deprecated snmpd service is broken. This is because snmpd package is absent from overcloud image and package installation is disabled by default.\nWe might wamt to accept this as a limitation (and let users to install snmpd package by any way) instead of delaying the clean up.","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fea86e5123043b543eb68362260134eeac0475b0","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          service:"},{"line_number":51,"context_line":"            name: snmpd"},{"line_number":52,"context_line":"            state: stopped"},{"line_number":53,"context_line":"        # TODO(tkajinam): Also remove net-snmp when we remove the service."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f1eb96df_d9b7e0c3","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":74},"in_reply_to":"feeedd8b_9eb012e0","updated":"2022-08-10 07:44:37.000000000","message":"can\u0027t we just remove the package here right now? I don\u0027t get why you didn\u0027t add the task directly here, after the service is stopped and disabled.","commit_id":"57a6a13fc4b3492976472d7281321face10a8c66"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"0d4960cd5006192a05d26687c3e585dcd5c04140","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    description: Role data for the SNMP services"},{"line_number":34,"context_line":"    value:"},{"line_number":35,"context_line":"      service_name: snmp_disabled"},{"line_number":36,"context_line":"      upgrade_tasks:"},{"line_number":37,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":38,"context_line":"          block:"},{"line_number":39,"context_line":"            - name: Check if snmpd is enabled"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a74c094c_43a887e0","line":36,"updated":"2022-09-07 08:22:51.000000000","message":"Wondering if we shouldn\u0027t ensure the firewall openings are, also, removed. Of course, if no service is listening, there\u0027s no real issue, but it would be cleaner.","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b4819a2bbb882774bfcbbeeb8d65a00b5da4922","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    description: Role data for the SNMP services"},{"line_number":34,"context_line":"    value:"},{"line_number":35,"context_line":"      service_name: snmp_disabled"},{"line_number":36,"context_line":"      upgrade_tasks:"},{"line_number":37,"context_line":"        - when: step|int \u003d\u003d 0"},{"line_number":38,"context_line":"          block:"},{"line_number":39,"context_line":"            - name: Check if snmpd is enabled"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2cf9242f_bc2e0207","line":36,"in_reply_to":"a74c094c_43a887e0","updated":"2022-09-22 02:27:19.000000000","message":"Done. Added a few rules so that the existing rules are purged.","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e12856df1628d99fece0d42136e75af84aa56b9c","unresolved":true,"context_lines":[{"line_number":204,"context_line":"  OS::TripleO::Services::ExternalSwiftProxy: OS::Heat::None"},{"line_number":205,"context_line":"  OS::TripleO::Services::SwiftStorage: deployment/swift/swift-storage-container-puppet.yaml"},{"line_number":206,"context_line":"  OS::TripleO::Services::SwiftRingBuilder: deployment/swift/swift-ringbuilder-container-puppet.yaml"},{"line_number":207,"context_line":"  OS::TripleO::Services::Snmp: deployment/snmp/snmpd-disabled-puppet.yaml"},{"line_number":208,"context_line":"  OS::TripleO::Services::Timezone: deployment/time/timezone-baremetal-ansible.yaml"},{"line_number":209,"context_line":"  OS::TripleO::Services::UndercloudRemoveNovajoin: OS::Heat::None"},{"line_number":210,"context_line":"  OS::TripleO::Services::UndercloudTLS: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"05725f3f_918ef19a","line":207,"updated":"2022-09-01 14:43:07.000000000","message":"nit: we have a deprecated directory for such things","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d1a609918ed0db4bc847c0354a31a65239f7c65f","unresolved":true,"context_lines":[{"line_number":204,"context_line":"  OS::TripleO::Services::ExternalSwiftProxy: OS::Heat::None"},{"line_number":205,"context_line":"  OS::TripleO::Services::SwiftStorage: deployment/swift/swift-storage-container-puppet.yaml"},{"line_number":206,"context_line":"  OS::TripleO::Services::SwiftRingBuilder: deployment/swift/swift-ringbuilder-container-puppet.yaml"},{"line_number":207,"context_line":"  OS::TripleO::Services::Snmp: deployment/snmp/snmpd-disabled-puppet.yaml"},{"line_number":208,"context_line":"  OS::TripleO::Services::Timezone: deployment/time/timezone-baremetal-ansible.yaml"},{"line_number":209,"context_line":"  OS::TripleO::Services::UndercloudRemoveNovajoin: OS::Heat::None"},{"line_number":210,"context_line":"  OS::TripleO::Services::UndercloudTLS: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3b612061_f0b88a8f","line":207,"in_reply_to":"0344aca2_f6c7b124","updated":"2022-10-13 02:02:28.000000000","message":"We added the \"disabled\" service in the past and this follows that pattern.\n\nexample: https://github.com/openstack/tripleo-heat-templates/tree/queens-eol/puppet/services/disabled\n\nWe can implement the clean-up in the existing resource, but the concern with that approach is that disabling the cleanup might become tricky.\n\nIn the past, I\u0027ve seen several users using snmpd for monitoring. They have been leveraging the \"unintentional\" feature in TripleO but are likely to continue using snmpd. In such case they need to disable cleanup process otherwise TripleO forcefully remove snmpd during upgrade and they need to reinstall it again after upgrade. Having a separate service allows them to disable cleanup easily.","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"0d4960cd5006192a05d26687c3e585dcd5c04140","unresolved":true,"context_lines":[{"line_number":204,"context_line":"  OS::TripleO::Services::ExternalSwiftProxy: OS::Heat::None"},{"line_number":205,"context_line":"  OS::TripleO::Services::SwiftStorage: deployment/swift/swift-storage-container-puppet.yaml"},{"line_number":206,"context_line":"  OS::TripleO::Services::SwiftRingBuilder: deployment/swift/swift-ringbuilder-container-puppet.yaml"},{"line_number":207,"context_line":"  OS::TripleO::Services::Snmp: deployment/snmp/snmpd-disabled-puppet.yaml"},{"line_number":208,"context_line":"  OS::TripleO::Services::Timezone: deployment/time/timezone-baremetal-ansible.yaml"},{"line_number":209,"context_line":"  OS::TripleO::Services::UndercloudRemoveNovajoin: OS::Heat::None"},{"line_number":210,"context_line":"  OS::TripleO::Services::UndercloudTLS: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6f8a9a0d_6fa23123","line":207,"in_reply_to":"05725f3f_918ef19a","updated":"2022-09-07 08:22:51.000000000","message":"that one is more in order to clean the snmp service, the \"old\" service declaration/creation is, indeed, in the deprecated directory. IMHO it\u0027s really good like that, since it takes the opportunity to remove any dangling snmp service. Especially nice since it may be a security concern.","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"13061133e181701175f042e8913ec280f61bb04d","unresolved":true,"context_lines":[{"line_number":204,"context_line":"  OS::TripleO::Services::ExternalSwiftProxy: OS::Heat::None"},{"line_number":205,"context_line":"  OS::TripleO::Services::SwiftStorage: deployment/swift/swift-storage-container-puppet.yaml"},{"line_number":206,"context_line":"  OS::TripleO::Services::SwiftRingBuilder: deployment/swift/swift-ringbuilder-container-puppet.yaml"},{"line_number":207,"context_line":"  OS::TripleO::Services::Snmp: deployment/snmp/snmpd-disabled-puppet.yaml"},{"line_number":208,"context_line":"  OS::TripleO::Services::Timezone: deployment/time/timezone-baremetal-ansible.yaml"},{"line_number":209,"context_line":"  OS::TripleO::Services::UndercloudRemoveNovajoin: OS::Heat::None"},{"line_number":210,"context_line":"  OS::TripleO::Services::UndercloudTLS: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b2514bcb_fee78076","line":207,"in_reply_to":"3b612061_f0b88a8f","updated":"2022-10-13 03:14:18.000000000","message":"I mean having deployment/snmp/snmpd-disabled-puppet.yaml is fine (though we can create disabled folder like earlier to keep them). The point I\u0027m trying to make is someone adding OS::TripleO::Services::Snmp to a role and then realize that it\u0027s cleaned up during upgrade (if the service is running) by default (rather than adding it) can be misleading/confusing.\n\nAs you mentioned, it seems we \"were\" doing that before https://github.com/openstack/tripleo-heat-templates/blob/queens-eol/overcloud-resource-registry-puppet.j2.yaml#L236.","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7a55a11c3d429daf599b687667ee8954b7f62166","unresolved":true,"context_lines":[{"line_number":204,"context_line":"  OS::TripleO::Services::ExternalSwiftProxy: OS::Heat::None"},{"line_number":205,"context_line":"  OS::TripleO::Services::SwiftStorage: deployment/swift/swift-storage-container-puppet.yaml"},{"line_number":206,"context_line":"  OS::TripleO::Services::SwiftRingBuilder: deployment/swift/swift-ringbuilder-container-puppet.yaml"},{"line_number":207,"context_line":"  OS::TripleO::Services::Snmp: deployment/snmp/snmpd-disabled-puppet.yaml"},{"line_number":208,"context_line":"  OS::TripleO::Services::Timezone: deployment/time/timezone-baremetal-ansible.yaml"},{"line_number":209,"context_line":"  OS::TripleO::Services::UndercloudRemoveNovajoin: OS::Heat::None"},{"line_number":210,"context_line":"  OS::TripleO::Services::UndercloudTLS: OS::Heat::None"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0344aca2_f6c7b124","line":207,"in_reply_to":"6f8a9a0d_6fa23123","updated":"2022-10-12 13:04:58.000000000","message":"IMO, this could be misleading. Mapping a service to something that cleans the service is unintuitive and I don\u0027t see it being done for any other service. \n\nWe should add the upgrade_tasks in tripleo-packages-baremetal-puppet.yaml and undercloud-upgrade.yaml and map this one to OS::Heat::None ?","commit_id":"4d0d613cdd900f98ca447ce5fe316f55c4215cf4"}]}