)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"85b08d1e9329fe2ad9e299f30f7ce4da33512dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2dd57e40_201b6fcf","updated":"2022-08-18 01:09:59.000000000","message":"recheck\n\n\"kex_exchange_identification: Connection closed by remote host\" during collecting logs","commit_id":"819bfbe64339f46768985e31301820acba8be74c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2abf7274cf895df1d48d66ad50df81d6a660fc0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"06ca2e17_85766ba5","updated":"2022-08-24 14:37:13.000000000","message":"recheck\n\ntempest failure in ipa job","commit_id":"819bfbe64339f46768985e31301820acba8be74c"}],"deployment/etcd/etcd-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"34296abdf1eafc6a6e3de70f4276209f04046e44","unresolved":true,"context_lines":[{"line_number":217,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":218,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":219,"context_line":"                # etcd membership."},{"line_number":220,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":221,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":222,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":223,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ac4be59_40d5e357","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":81},"updated":"2022-08-19 01:49:07.000000000","message":"@Alan @Manoj\n\nI could not find any reason why we can\u0027t use ETCD_NAME in etcd.conf. Are you aware of any reason we are not using it and picking up the same value from hieradata here ?","commit_id":"01f4583111255d64c179f74df7d584c87ba5044d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e068dd74db6c444ece2a135a223b5b457dc89a9","unresolved":true,"context_lines":[{"line_number":217,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":218,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":219,"context_line":"                # etcd membership."},{"line_number":220,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":221,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":222,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":223,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"967ad563_d59a1641","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":81},"in_reply_to":"5feca6f2_d79ef7d9","updated":"2022-08-19 15:37:11.000000000","message":"I\u0027m planning to bump hieradata version to 5 for Zed release and that work depends on removal of the hiera CLI. (The hiera CLI does not work with hieradata v5)\n\nIf we will leave this puppet implementation in the deprecated directory at Zed release then I\u0027d prefer fixing this now.","commit_id":"01f4583111255d64c179f74df7d584c87ba5044d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7c36ae9c53a4f9edb633263273177195123f3cce","unresolved":true,"context_lines":[{"line_number":217,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":218,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":219,"context_line":"                # etcd membership."},{"line_number":220,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":221,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":222,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":223,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5feca6f2_d79ef7d9","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":81},"in_reply_to":"7ac4be59_40d5e357","updated":"2022-08-19 13:36:00.000000000","message":"You\u0027re correct, and I think I simply missed the fact that this variable is available in the conf file. However, because this THT is being deprecated (in favor of a new one that will use a new tripleo-ansible role), and the current code is doing no harm, I would leave this alone.\n\nManoj, please be sure the new THT doesn\u0027t make the same mistake that I made in this one!","commit_id":"01f4583111255d64c179f74df7d584c87ba5044d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"93f222e6c4802fd909b4898c66b01ba08d484f85","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":218,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":219,"context_line":"                # etcd membership."},{"line_number":220,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":221,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":222,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":223,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bbb1c339_6332f41a","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":81},"in_reply_to":"967ad563_d59a1641","updated":"2022-08-19 15:48:16.000000000","message":"OK, that makes sense!","commit_id":"01f4583111255d64c179f74df7d584c87ba5044d"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3753e325b3a3dac9a7b6be141587d07c7315e288","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                # etcdctl doesn\u0027t generate reliable error status, so use presence of the"},{"line_number":218,"context_line":"                # node\u0027s own name to determine whether this node is capable of managing"},{"line_number":219,"context_line":"                # etcd membership."},{"line_number":220,"context_line":"                ETCD_NAME\u003d$(hiera -c /etc/puppet/hiera.yaml fqdn_${ETCD_NETWORK})"},{"line_number":221,"context_line":"                if ! grep -q $ETCD_NAME /tmp/etcd-members; then"},{"line_number":222,"context_line":"                  echo \"This is a new node that is unable to manage etcd membership\""},{"line_number":223,"context_line":"                  exit 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"58f6b0e8_7a9916c9","side":"PARENT","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":81},"in_reply_to":"bbb1c339_6332f41a","updated":"2022-08-20 13:43:52.000000000","message":"Thanks @Takashi for bringing up this patch, I agree that etcd.conf can be used instead of hieradata.\n@Alan: I will make sure to handle this in new THT.","commit_id":"01f4583111255d64c179f74df7d584c87ba5044d"}]}