)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fb908f21edc8b24621ea2be1b52b87038f40d7c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0053ae8_b39e417b","updated":"2022-08-18 04:43:56.000000000","message":"recheck\n\nssh error","commit_id":"fed9ddd05df643bfc8f2799a22e9500a708b31d3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7642a773d0d9ef26bb3cd336ee3765e200cb6b04","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7e55c890_a5823f53","updated":"2022-08-23 16:31:04.000000000","message":"It seems this feature is not tested by any scenario... I\u0027ve submitted a DNM patch to test it with this change to ensure this does not break the functionality...","commit_id":"850b69024aaba32442c190cb886c96bd89120a0f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3888d487d4d262ff5b472ce09735f77080bfb235","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f495d3c1_58e04124","in_reply_to":"7e55c890_a5823f53","updated":"2022-08-25 04:38:36.000000000","message":"tested by https://review.opendev.org/c/openstack/tripleo-heat-templates/+/854243","commit_id":"850b69024aaba32442c190cb886c96bd89120a0f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c25203d2ef720a024db424c92676dce7fb032513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cfaff672_299d0686","updated":"2022-09-03 15:22:33.000000000","message":"recheck","commit_id":"a8ce51561eee5472839dff647cd936cd971248e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59c39b47672383e5d04f67add3815c23c9493a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e4b8e3d5_aae0c53e","updated":"2022-09-04 06:35:07.000000000","message":"recheck","commit_id":"a8ce51561eee5472839dff647cd936cd971248e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3888d487d4d262ff5b472ce09735f77080bfb235","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3b114e45_0ff30b29","updated":"2022-08-25 04:38:36.000000000","message":"tested ","commit_id":"a8ce51561eee5472839dff647cd936cd971248e1"}],"deployment/nova/nova-az-config.yaml":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"999a4cabf75d2924a84ea3ceeb2a6abc2a57ab88","unresolved":true,"context_lines":[{"line_number":65,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":66,"context_line":"          block:"},{"line_number":67,"context_line":"            - name: Read the parameter from nova.conf"},{"line_number":68,"context_line":"              shell:"},{"line_number":69,"context_line":"                crudini --get /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf DEFAULT host"},{"line_number":70,"context_line":"              register: nova_host_output"},{"line_number":71,"context_line":"            - name: Set nova_host fact"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a24e71a0_7fef0b80","line":68,"updated":"2022-08-19 04:15:02.000000000","message":"Any reason we want to use shell rather than the ini lookup module here?\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/ini_lookup.html\n\nCould we just use that to set the fact and have one less task here?","commit_id":"c7622b6944903950db75ed448ea52e5db5f70942"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5b4d38c6e3de77f750a8cab73bf8cabf81eb4434","unresolved":true,"context_lines":[{"line_number":65,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":66,"context_line":"          block:"},{"line_number":67,"context_line":"            - name: Read the parameter from nova.conf"},{"line_number":68,"context_line":"              shell:"},{"line_number":69,"context_line":"                crudini --get /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf DEFAULT host"},{"line_number":70,"context_line":"              register: nova_host_output"},{"line_number":71,"context_line":"            - name: Set nova_host fact"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ceb0c2de_891842af","line":68,"in_reply_to":"a24e71a0_7fef0b80","updated":"2022-08-19 04:45:08.000000000","message":"A problem with ini lookup module is it looks up the file in controlling node while we need to read the file in target nodes.\n\nWe might be able to transfer files but it\u0027s as redundant as executing crudini at remote.","commit_id":"c7622b6944903950db75ed448ea52e5db5f70942"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"bf63b1bbfd72b1f402096c2296b64f7387004ef7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":66,"context_line":"          block:"},{"line_number":67,"context_line":"            - name: Read the parameter from nova.conf"},{"line_number":68,"context_line":"              shell:"},{"line_number":69,"context_line":"                crudini --get /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf DEFAULT host"},{"line_number":70,"context_line":"              register: nova_host_output"},{"line_number":71,"context_line":"            - name: Set nova_host fact"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"193c14e5_871692be","line":68,"in_reply_to":"ceb0c2de_891842af","updated":"2022-08-24 04:17:17.000000000","message":"Done","commit_id":"c7622b6944903950db75ed448ea52e5db5f70942"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"728c62c9f9f8ae351f6de0faaab725663a11861a","unresolved":true,"context_lines":[{"line_number":70,"context_line":"              register: nova_host_output"},{"line_number":71,"context_line":"            - name: Set nova_host fact"},{"line_number":72,"context_line":"              set_fact:"},{"line_number":73,"context_line":"                nova_host: nova_host_output.output"},{"line_number":74,"context_line":"      external_post_deploy_tasks:"},{"line_number":75,"context_line":"        - name: \"Nova: Manage aggregate and availability zone and add hosts to the zone\""},{"line_number":76,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0e36c5e2_b73d57d0","line":73,"updated":"2022-08-23 15:51:22.000000000","message":"shouldn\u0027t this be nova_host_output.stdout?\n\nand are {{ }} needed, or does ansible automatically interpret this as a var? I would have guessed that without {{ }}, it\u0027s going to set it to the string nova_host_output.output.","commit_id":"c7622b6944903950db75ed448ea52e5db5f70942"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7642a773d0d9ef26bb3cd336ee3765e200cb6b04","unresolved":false,"context_lines":[{"line_number":70,"context_line":"              register: nova_host_output"},{"line_number":71,"context_line":"            - name: Set nova_host fact"},{"line_number":72,"context_line":"              set_fact:"},{"line_number":73,"context_line":"                nova_host: nova_host_output.output"},{"line_number":74,"context_line":"      external_post_deploy_tasks:"},{"line_number":75,"context_line":"        - name: \"Nova: Manage aggregate and availability zone and add hosts to the zone\""},{"line_number":76,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"acda21ff_463f8944","line":73,"in_reply_to":"0e36c5e2_b73d57d0","updated":"2022-08-23 16:31:04.000000000","message":"Done","commit_id":"c7622b6944903950db75ed448ea52e5db5f70942"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cc8a119490be08e12a36f4b67564d73897c9c844","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        #        an ansible fact so that we can use it later in the tasks in"},{"line_number":63,"context_line":"        #        external_post_deploy_tasks"},{"line_number":64,"context_line":"        - name: Get the host parameter from nova.conf"},{"line_number":65,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":66,"context_line":"          block:"},{"line_number":67,"context_line":"            - name: Read the parameter from nova.conf"},{"line_number":68,"context_line":"              shell:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bf6ea70e_154e398e","line":65,"range":{"start_line":65,"start_character":28,"end_line":65,"end_character":29},"updated":"2022-09-01 14:58:10.000000000","message":"why changing the step 1 to 2?","commit_id":"a8ce51561eee5472839dff647cd936cd971248e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"df7e8b8bf7ae7d5f5381e8b34b8c8d606748e4ef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        #        an ansible fact so that we can use it later in the tasks in"},{"line_number":63,"context_line":"        #        external_post_deploy_tasks"},{"line_number":64,"context_line":"        - name: Get the host parameter from nova.conf"},{"line_number":65,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":66,"context_line":"          block:"},{"line_number":67,"context_line":"            - name: Read the parameter from nova.conf"},{"line_number":68,"context_line":"              shell:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6f5c684f_e20c37ca","line":65,"range":{"start_line":65,"start_character":28,"end_line":65,"end_character":29},"in_reply_to":"a033ba92_b86b3315","updated":"2022-09-01 16:15:04.000000000","message":"Done","commit_id":"a8ce51561eee5472839dff647cd936cd971248e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a17e70367d0c7eef352c6c481ddc93461fd227d6","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        #        an ansible fact so that we can use it later in the tasks in"},{"line_number":63,"context_line":"        #        external_post_deploy_tasks"},{"line_number":64,"context_line":"        - name: Get the host parameter from nova.conf"},{"line_number":65,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":66,"context_line":"          block:"},{"line_number":67,"context_line":"            - name: Read the parameter from nova.conf"},{"line_number":68,"context_line":"              shell:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a033ba92_b86b3315","line":65,"range":{"start_line":65,"start_character":28,"end_line":65,"end_character":29},"in_reply_to":"bf6ea70e_154e398e","updated":"2022-09-01 15:31:58.000000000","message":"container puppet to generate configuration files are executed at step 1, so I had to move this to step 2 because this needs the nova.conf generated in advance.","commit_id":"a8ce51561eee5472839dff647cd936cd971248e1"}]}