)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-12 15:22:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"new t-h-t template for Cinder NFS backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, Cinder NFS storage backend is configured as part of"},{"line_number":10,"context_line":"cinder-volume-container-puppet.yaml."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9650dfcc_04f35df2","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":18},"updated":"2022-09-13 17:47:25.000000000","message":"nit: I suggest either \"tht\" or \"template\" (but not both).","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-12 15:22:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"new t-h-t template for Cinder NFS backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, Cinder NFS storage backend is configured as part of"},{"line_number":10,"context_line":"cinder-volume-container-puppet.yaml."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fabed5b4_a96fb93e","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":18},"in_reply_to":"9650dfcc_04f35df2","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"}],"deployment/cinder/cinder-backend-nfs-puppet.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"85bbf8cd83a2f3758eb1ba543525db870b051ff3","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  CinderEnableNfsBackend:"},{"line_number":8,"context_line":"    default: false"},{"line_number":9,"context_line":"    description: Whether to enable or not the NFS backend for Cinder"},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  CinderNfsBackendName:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1b78f644_181a2a98","line":8,"updated":"2022-09-06 18:44:18.000000000","message":"if we are going to refactor this out into it\u0027s own template, then I wonder if this should work like all the other storage templates, and this should default to true. The way to enable the backend ought to be by just the right mapping in the resource_registry, not the resource_registry *and* a parameter.","commit_id":"947f6c88ba6ef42ef9d9d53f4acc5370243c229c"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"10f1697e133e6aedc81bb94fd56b90768acbddc4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  CinderEnableNfsBackend:"},{"line_number":8,"context_line":"    default: false"},{"line_number":9,"context_line":"    description: Whether to enable or not the NFS backend for Cinder"},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  CinderNfsBackendName:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"852f45dd_c7735f93","line":8,"in_reply_to":"1b78f644_181a2a98","updated":"2022-09-12 09:55:14.000000000","message":"Agreed , thanks for bringing this up.\nDone!.","commit_id":"947f6c88ba6ef42ef9d9d53f4acc5370243c229c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  CinderEnableNfsBackend:"},{"line_number":8,"context_line":"    default: false"},{"line_number":9,"context_line":"    description: Whether to enable or not the NFS backend for Cinder"},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  CinderNfsBackendName:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1482f932_bc612cad","line":8,"in_reply_to":"852f45dd_c7735f93","updated":"2022-09-13 17:47:25.000000000","message":"Reopening to continue the discussion. I was the one who suggested Manoj work on this, and the motivation (as I state in another comment) is limited to cleaning up the cinder-volume-contain-puppet.yaml file by moving the NFS (and also RBD) backend parameters into their own THT. Having them all in one file is a very old legacy thing, and over time the file became messy and unwieldy.\n\nThat said, I want to retain the legacy behavior and not inadvertently disrupt things when someone does an update. To do that, I proposed the CinderBackendNfs tripleo service default to the new THT (not make it OS::Heat::None), and leave CinderEnableNfsBackend defaulting to false.\n\nThe goal is to ensure doing an update doesn\u0027t inadvertently flip the NFS backend on/off, or vice versa.","commit_id":"947f6c88ba6ef42ef9d9d53f4acc5370243c229c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  CinderEnableNfsBackend:"},{"line_number":8,"context_line":"    default: true"},{"line_number":9,"context_line":"    description: Whether to enable or not the NFS backend for Cinder"},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  CinderNfsBackendName:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5ad0b1d5_7c6156a0","line":8,"updated":"2022-09-13 17:47:25.000000000","message":"Although the general model for cinder backend templates would suggest this default value, it should be False in this template in order to avoid problems on upgrades. The legacy behavior, where NFS didn\u0027t have its own dedicated template, defaulted CinderEnableNfsBackend to false, and users had to manually override the setting to enable the backend. We should keep the same default value (false) in order to retain the legacy behavior so there are no surprises.","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameters:"},{"line_number":7,"context_line":"  CinderEnableNfsBackend:"},{"line_number":8,"context_line":"    default: true"},{"line_number":9,"context_line":"    description: Whether to enable or not the NFS backend for Cinder"},{"line_number":10,"context_line":"    type: boolean"},{"line_number":11,"context_line":"  CinderNfsBackendName:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a3e7ee44_7d17bade","line":8,"in_reply_to":"5ad0b1d5_7c6156a0","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        map_merge:"},{"line_number":98,"context_line":"          - tripleo::profile::base::cinder::volume::cinder_enable_nfs_backend: {get_param: CinderEnableNfsBackend}"},{"line_number":99,"context_line":"            tripleo::profile::base::cinder::volume::nfs::cinder_nfs_servers: {get_param: CinderNfsServers}"},{"line_number":100,"context_line":"            cinder::backend::nfs::volume_backend_name: {get_param: CinderNfsBackendName}"},{"line_number":101,"context_line":"            cinder::backend::nfs::volume_multi_config: {get_param: CinderNfsMultiConfig}"},{"line_number":102,"context_line":"            cinder::backend::nfs::nfs_mount_options: {get_param: CinderNfsMountOptions}"},{"line_number":103,"context_line":"            cinder::backend::nfs::nfs_shares_config: {get_param: CinderNfsSharesConfig}"},{"line_number":104,"context_line":"            cinder::backend::nfs::nfs_snapshot_support: {get_param: CinderNfsSnapshotSupport}"},{"line_number":105,"context_line":"            cinder::backend::nfs::nas_secure_file_operations: {get_param: CinderNasSecureFileOperations}"},{"line_number":106,"context_line":"            cinder::backend::nfs::nas_secure_file_permissions: {get_param: CinderNasSecureFilePermissions}"},{"line_number":107,"context_line":"          - if:"},{"line_number":108,"context_line":"            - not: {equals : [{get_param: CinderNfsAvailabilityZone}, \u0027\u0027]}"},{"line_number":109,"context_line":"            - cinder::backend::nfs::backend_availability_zone: {get_param: CinderNfsAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6aed0d2c_e9b0a177","line":109,"range":{"start_line":100,"start_character":0,"end_line":109,"end_character":100},"updated":"2022-09-13 17:47:25.000000000","message":"As we discussed on irc, this patch should retain the same tripleo::XXX hiera variables and not switch to cinder:XXX variable names. This will ensure the new THT will continue to work with the existing puppet-tripleo manifests.\n\nIt may be worth changing both THT and puppet-tripleo to use cinder::XXX variables (unfortunately, the cinder backends aren\u0027t consistent), but that should be handled by separate patches.","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        map_merge:"},{"line_number":98,"context_line":"          - tripleo::profile::base::cinder::volume::cinder_enable_nfs_backend: {get_param: CinderEnableNfsBackend}"},{"line_number":99,"context_line":"            tripleo::profile::base::cinder::volume::nfs::cinder_nfs_servers: {get_param: CinderNfsServers}"},{"line_number":100,"context_line":"            cinder::backend::nfs::volume_backend_name: {get_param: CinderNfsBackendName}"},{"line_number":101,"context_line":"            cinder::backend::nfs::volume_multi_config: {get_param: CinderNfsMultiConfig}"},{"line_number":102,"context_line":"            cinder::backend::nfs::nfs_mount_options: {get_param: CinderNfsMountOptions}"},{"line_number":103,"context_line":"            cinder::backend::nfs::nfs_shares_config: {get_param: CinderNfsSharesConfig}"},{"line_number":104,"context_line":"            cinder::backend::nfs::nfs_snapshot_support: {get_param: CinderNfsSnapshotSupport}"},{"line_number":105,"context_line":"            cinder::backend::nfs::nas_secure_file_operations: {get_param: CinderNasSecureFileOperations}"},{"line_number":106,"context_line":"            cinder::backend::nfs::nas_secure_file_permissions: {get_param: CinderNasSecureFilePermissions}"},{"line_number":107,"context_line":"          - if:"},{"line_number":108,"context_line":"            - not: {equals : [{get_param: CinderNfsAvailabilityZone}, \u0027\u0027]}"},{"line_number":109,"context_line":"            - cinder::backend::nfs::backend_availability_zone: {get_param: CinderNfsAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"21f41fa5_32477077","line":109,"range":{"start_line":100,"start_character":0,"end_line":109,"end_character":100},"in_reply_to":"6aed0d2c_e9b0a177","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"}],"environments/cinder-nfs-config.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to enable a"},{"line_number":2,"context_line":"# a Cinder NFS backend, configured via puppet"},{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  OS::TripleO::Services::CinderBackendNfs: ../deployment/cinder/cinder-backend-nfs-puppet.yaml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameter_defaults:"},{"line_number":7,"context_line":"  CinderNfsBackendName: [\u0027tripleo_nfs\u0027]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"099691dd_c87e240b","line":4,"range":{"start_line":3,"start_character":1,"end_line":4,"end_character":94},"updated":"2022-09-13 17:47:25.000000000","message":"This can be eliminated. In order to retain the legacy behavior, the CinderBackendNfs tripleo service already defaults to using this template.","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# A Heat environment file which can be used to enable a"},{"line_number":2,"context_line":"# a Cinder NFS backend, configured via puppet"},{"line_number":3,"context_line":"resource_registry:"},{"line_number":4,"context_line":"  OS::TripleO::Services::CinderBackendNfs: ../deployment/cinder/cinder-backend-nfs-puppet.yaml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"parameter_defaults:"},{"line_number":7,"context_line":"  CinderNfsBackendName: [\u0027tripleo_nfs\u0027]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3d45f482_493bed9b","line":4,"range":{"start_line":3,"start_character":1,"end_line":4,"end_character":94},"in_reply_to":"099691dd_c87e240b","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"}],"environments/storage/cinder-nfs.yaml":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"4f5bc00c495aa0a9786a8a43d0537cd94b77c6ee","unresolved":true,"context_lines":[{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  # Whether to enable or not the Iscsi backend for Cinder"},{"line_number":13,"context_line":"  # Type: boolean"},{"line_number":14,"context_line":"  CinderEnableIscsiBackend: False"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Whether to enable or not the NFS backend for Cinder"},{"line_number":17,"context_line":"  # Type: boolean"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b97cbfac_c9449c3f","side":"PARENT","line":14,"updated":"2022-09-19 17:42:01.000000000","message":"why is this dropped? when the Nfs backend is enabled, do we want Iscsi backend enabled or disabled? wouldn\u0027t this be a change for anyone using this environment file?","commit_id":"f9a4495c96dec4f44f3aef2f5ed79136f1071faa"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"5ccf616a6e74a94d798e0ec9fae58be23ddb0655","unresolved":false,"context_lines":[{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  # Whether to enable or not the Iscsi backend for Cinder"},{"line_number":13,"context_line":"  # Type: boolean"},{"line_number":14,"context_line":"  CinderEnableIscsiBackend: False"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Whether to enable or not the NFS backend for Cinder"},{"line_number":17,"context_line":"  # Type: boolean"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f11f3b8_7b1fde87","side":"PARENT","line":14,"in_reply_to":"71dadb85_446cd608","updated":"2022-09-21 16:23:25.000000000","message":"Considering the fact that there is a chance for someone using this file, reverted this change in the latest patch.","commit_id":"f9a4495c96dec4f44f3aef2f5ed79136f1071faa"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a8279ea0905e1f51bcacc245f17fa425bb9978fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"parameter_defaults:"},{"line_number":12,"context_line":"  # Whether to enable or not the Iscsi backend for Cinder"},{"line_number":13,"context_line":"  # Type: boolean"},{"line_number":14,"context_line":"  CinderEnableIscsiBackend: False"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Whether to enable or not the NFS backend for Cinder"},{"line_number":17,"context_line":"  # Type: boolean"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"71dadb85_446cd608","side":"PARENT","line":14,"in_reply_to":"b97cbfac_c9449c3f","updated":"2022-09-20 09:09:32.000000000","message":"I modified this env file along with sample-env-generator/storage.yaml to resolve sample-env-generator errors in CI.\n\n\u0027CinderEnableIscsiBackend\u0027 is not part of the new NFS template, it can be removed from this env file as NFS backend configuration is no longer done in cinder-volume-container-puppet.yaml\n\nI think it is ok to have default iscsi(lvm) backend enabled along with NFS unless user wants to disable it explicitly. (same is the case with all other cinder backends)\n\nMoreover this env file is outdated, latest one in use is https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/environments/cinder-nfs-config.yaml.","commit_id":"f9a4495c96dec4f44f3aef2f5ed79136f1071faa"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":108,"context_line":"  OS::TripleO::Services::CephIngress: OS::Heat::None"},{"line_number":109,"context_line":"  OS::TripleO::Services::CinderApi: deployment/cinder/cinder-api-container-puppet.yaml"},{"line_number":110,"context_line":"  OS::TripleO::Services::CinderBackup: OS::Heat::None"},{"line_number":111,"context_line":"  # NFS Backend is still optional unless it is explicitly enabled, this is just a separate template."},{"line_number":112,"context_line":"  OS::TripleO::Services::CinderBackendNfs: deployment/cinder/cinder-backend-nfs-puppet.yaml"},{"line_number":113,"context_line":"  OS::TripleO::Services::CinderScheduler: deployment/cinder/cinder-scheduler-container-puppet.yaml"},{"line_number":114,"context_line":"  OS::TripleO::Services::CinderVolume: deployment/cinder/cinder-volume-pacemaker-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a00bccb3_7f1cfffa","line":111,"updated":"2022-09-13 17:47:25.000000000","message":"Good! We acknowledge NFS is unlike other cinder backend services that default to OS::Heat::None. It might be worth adding one more sentence that explains is done in order to retain the legacy behavior, and avoid accidental problems when doing an update.","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  OS::TripleO::Services::CephIngress: OS::Heat::None"},{"line_number":109,"context_line":"  OS::TripleO::Services::CinderApi: deployment/cinder/cinder-api-container-puppet.yaml"},{"line_number":110,"context_line":"  OS::TripleO::Services::CinderBackup: OS::Heat::None"},{"line_number":111,"context_line":"  # NFS Backend is still optional unless it is explicitly enabled, this is just a separate template."},{"line_number":112,"context_line":"  OS::TripleO::Services::CinderBackendNfs: deployment/cinder/cinder-backend-nfs-puppet.yaml"},{"line_number":113,"context_line":"  OS::TripleO::Services::CinderScheduler: deployment/cinder/cinder-scheduler-container-puppet.yaml"},{"line_number":114,"context_line":"  OS::TripleO::Services::CinderVolume: deployment/cinder/cinder-volume-pacemaker-puppet.yaml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cfecf368_5ec820ba","line":111,"in_reply_to":"a00bccb3_7f1cfffa","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"}],"releasenotes/notes/nfs_backend_new_template-21243ef33346ed9a.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduce a separate template for Cinder NFS backend configuration."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The NFS Backend service enables the new template so the upgrades are"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f5df0433_a54ad3bb","line":4,"updated":"2022-09-13 17:47:25.000000000","message":"I would extend this to say the purpose is limited to relocating the existing cinder NFS parameters in their own file. There are no new parameters, and the existing parameters retain the same default values.","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduce a separate template for Cinder NFS backend configuration."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The NFS Backend service enables the new template so the upgrades are"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a8b36b18_6eb88f48","line":4,"in_reply_to":"f5df0433_a54ad3bb","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8cfc33c208a6a929085642ea2e615580064fb658","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Introduce a separate template for Cinder NFS backend configuration."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The NFS Backend service enables the new template so the upgrades are"},{"line_number":8,"context_line":"    not impacted."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7532d878_826c64e1","line":8,"range":{"start_line":7,"start_character":4,"end_line":8,"end_character":17},"updated":"2022-09-13 17:47:25.000000000","message":"This statement is technically accurate, but it may not make sense to the reader. I would say (possibly repeating a portion of the \"features\" note) that, although the cinder NFS parameters have been moved to their own file, there is no impact on upgrades because the parameters themselves are unchanged.","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"314e9e98add5b3dd60b483fb79b5298f92a2bbba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Introduce a separate template for Cinder NFS backend configuration."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The NFS Backend service enables the new template so the upgrades are"},{"line_number":8,"context_line":"    not impacted."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4309f4a6_ba3f0a1c","line":8,"range":{"start_line":7,"start_character":4,"end_line":8,"end_character":17},"in_reply_to":"7532d878_826c64e1","updated":"2022-09-14 10:47:16.000000000","message":"Done","commit_id":"5c5dab66d97420a275cb54ab7a49352956f3effe"}]}