)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f486ae5296a69d9f91d8fdb43db0ca46b73fee36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51cb9693_3bd563bf","updated":"2022-09-09 05:41:36.000000000","message":"recheck ipa job","commit_id":"1bb1f5448c4469e89d2e5906a95510de12deec49"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1a0df5a65db0fc9d6d466f234fd037fa3bb013ee","unresolved":true,"context_lines":[{"line_number":203,"context_line":"      Cron to purge expired or soft-deleted trusts - Ensure"},{"line_number":204,"context_line":"    default: \u0027present\u0027"},{"line_number":205,"context_line":"  KeystoneCronTrustFlushMinute:"},{"line_number":206,"context_line":"    type: comma_delimited_list"},{"line_number":207,"context_line":"    description: \u003e"},{"line_number":208,"context_line":"      Cron to purge expired or soft-deleted trusts - Minute"},{"line_number":209,"context_line":"    default: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"915bce9e_2f3a17a1","side":"PARENT","line":206,"range":{"start_line":206,"start_character":10,"end_line":206,"end_character":30},"updated":"2022-09-08 07:59:55.000000000","message":"How was this working? If these interfaces are never used by anyone, why have these? It just makes the THT unreadable.","commit_id":"d73dae1a83ede4b491f7ec19567767ff78560c43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"faa411f1bff2ccb76ca669fea71ea8a41c6c0790","unresolved":true,"context_lines":[{"line_number":203,"context_line":"      Cron to purge expired or soft-deleted trusts - Ensure"},{"line_number":204,"context_line":"    default: \u0027present\u0027"},{"line_number":205,"context_line":"  KeystoneCronTrustFlushMinute:"},{"line_number":206,"context_line":"    type: comma_delimited_list"},{"line_number":207,"context_line":"    description: \u003e"},{"line_number":208,"context_line":"      Cron to purge expired or soft-deleted trusts - Minute"},{"line_number":209,"context_line":"    default: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cf82ea04_be27dbc5","side":"PARENT","line":206,"range":{"start_line":206,"start_character":10,"end_line":206,"end_character":30},"in_reply_to":"915bce9e_2f3a17a1","updated":"2022-09-08 08:07:11.000000000","message":"These are used to tune cron jobs (we have the same set of interfaces for all cron jobs)\n\n\nIt seems puppet is converting the list and is currently putting \u0027valid\u0027 configuration but we better fix the incorrect type as we don\u0027t really able to accept list with multiple elements.\n\nhttps://0887da1acd77fe362fe6-dafd5ea511e702465bad7043bbe0ffd9.ssl.cf2.rackcdn.com/855156/1/check/tripleo-ci-centos-9-scenario001-standalone/14a316d/logs/undercloud/var/lib/config-data/puppet-generated/keystone/var/spool/cron/keystone","commit_id":"d73dae1a83ede4b491f7ec19567767ff78560c43"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"86a725a43bcf75c19fc22b0a59e8d59a4af7bba7","unresolved":true,"context_lines":[{"line_number":203,"context_line":"      Cron to purge expired or soft-deleted trusts - Ensure"},{"line_number":204,"context_line":"    default: \u0027present\u0027"},{"line_number":205,"context_line":"  KeystoneCronTrustFlushMinute:"},{"line_number":206,"context_line":"    type: comma_delimited_list"},{"line_number":207,"context_line":"    description: \u003e"},{"line_number":208,"context_line":"      Cron to purge expired or soft-deleted trusts - Minute"},{"line_number":209,"context_line":"    default: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e6479328_d3860d76","side":"PARENT","line":206,"range":{"start_line":206,"start_character":10,"end_line":206,"end_character":30},"in_reply_to":"cf82ea04_be27dbc5","updated":"2022-09-08 08:23:13.000000000","message":"Well, I know that we\u0027ve added that interface everywhere. My question is how is puppet converting those lists to string.\n\nAlso, what I\u0027m saying we don\u0027t so many parameters with that granularity (I doubt anyone would configure that way). Size of templates have impact on performance.","commit_id":"d73dae1a83ede4b491f7ec19567767ff78560c43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d142a7ab0e01de1fc37373956bb4d5cfb59a2efd","unresolved":true,"context_lines":[{"line_number":203,"context_line":"      Cron to purge expired or soft-deleted trusts - Ensure"},{"line_number":204,"context_line":"    default: \u0027present\u0027"},{"line_number":205,"context_line":"  KeystoneCronTrustFlushMinute:"},{"line_number":206,"context_line":"    type: comma_delimited_list"},{"line_number":207,"context_line":"    description: \u003e"},{"line_number":208,"context_line":"      Cron to purge expired or soft-deleted trusts - Minute"},{"line_number":209,"context_line":"    default: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5e3f6eff_9e4db591","side":"PARENT","line":206,"range":{"start_line":206,"start_character":10,"end_line":206,"end_character":30},"in_reply_to":"e6479328_d3860d76","updated":"2022-09-08 08:35:09.000000000","message":"\u003e Well, I know that we\u0027ve added that interface everywhere. My question is how is puppet converting those lists to string.\n\n\nThese is a logic within cron provider which converts a list to a string.\n\nhttps://github.com/puppetlabs/puppetlabs-cron_core/blob/main/lib/puppet/provider/cron/crontab.rb#L68-L70\n\nThis was added to allow usage of array(eg, [1, 31]) which is rendered as a comma-separated strings (eg 1,31).\nUsage of array/list might be valid according to the current implementation of the cron provider but this is inconsistent with the parameters for the other cron jobs so we\u0027d better fix the inconsistency.\n\n\u003e Also, what I\u0027m saying we don\u0027t so many parameters with that granularity (I doubt anyone would configure that way). Size of templates have impact on performance.\n\nMaybe we should consider deprecate these or even remove these in master ? Even if we do not provide the parameters users can still change these by ExtraConfig. I agree providing native tht interface is not much beneficial.","commit_id":"d73dae1a83ede4b491f7ec19567767ff78560c43"}]}