)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"488acd9171bdf2280fdf2873320dde240d3a9cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f0b21c8_35494e2a","updated":"2022-08-31 14:56:28.000000000","message":"recheck","commit_id":"2724db2dbf2a2e079659c8283a7b9000b660e474"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"89a50639e0f56750d187911f7c0b5072c4de7893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"793aa73f_ca63c072","updated":"2022-09-01 14:53:55.000000000","message":"recheck\n\nforgot to push a change...","commit_id":"4f4fa66a45acb904e317d2490acd2021031024dd"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3d787df09a5cdd9ef4d7b0a9fcd3a15527ad7f4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c377fa24_4022ef4d","updated":"2022-09-05 13:16:18.000000000","message":"recheck","commit_id":"5eb44692265809c5806c9ddb29f5741f05b28696"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d9843a131d9931267d7d97dba01464287368c6de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"71da0911_ff51a92e","updated":"2022-09-07 08:01:16.000000000","message":"check-rdo","commit_id":"51060dbaad170cb3e9f731c526e56c9d3b86f756"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a522b734a6fc07aba5c0e89de4882222d8d478a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"41f4bbfd_997ad6c5","updated":"2022-09-06 12:33:30.000000000","message":"recheck","commit_id":"51060dbaad170cb3e9f731c526e56c9d3b86f756"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"55d70cecc4e9396e40740a14e574b4c77639bc70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ef704ddb_a93c785a","updated":"2022-09-06 08:07:35.000000000","message":"recheck","commit_id":"51060dbaad170cb3e9f731c526e56c9d3b86f756"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c9e513f25276a4391b2189dcb8e424d6805d6b7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"466bf061_3642d8e8","updated":"2022-09-06 13:33:38.000000000","message":"recheck\n\nthe dependent patch was updated","commit_id":"51060dbaad170cb3e9f731c526e56c9d3b86f756"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"46cd7f5578f992126124866febeddbc75ebb813d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e9862d74_0a309b6e","updated":"2022-09-15 10:39:06.000000000","message":"-1 Looks good, but I think this needs a bit more work.\n\nI have concerns with the bind_host for ipxe vhost.\n\nRelated also the bind_port - See comment on: \nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/855873","commit_id":"bfd9957796bbbc30892a948705bced5b7d97a471"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"6544fbf52bb7a819d43fda2e1248b85d94fb1144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"29eb9b38_d3c209ff","updated":"2022-09-15 08:26:23.000000000","message":"Hello Harald, Steve,\n\nCare to have a look at this patch?\n\nThanks!","commit_id":"bfd9957796bbbc30892a948705bced5b7d97a471"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"802231f9bff20868ea94e7ab26feeaaea15643f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"30910a8d_c8728a50","updated":"2022-09-12 14:27:33.000000000","message":"recheck","commit_id":"bfd9957796bbbc30892a948705bced5b7d97a471"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b26edbae397ab2966bb8ee544d0e89a824bb05d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3d5ca386_823a2db1","updated":"2022-09-15 21:21:54.000000000","message":"I\u0027m catching up on this work, it looks really good. Thanks for taking it on.\n\nJust a couple of things which belong in the image build instead","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"15241bdbc3646435811b92801c9ac259c90ddb95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d296a6e6_31cc6060","updated":"2022-09-16 08:48:39.000000000","message":"recheck\n\ndidn\u0027t see the comment on the iPXE port customization","commit_id":"598789d4cf3082d3fb078aff971d76a7b72c82b3"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"fb88320f156da1686225e6a2811baa5d8b3fb4ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"89141b6d_8fb5507d","updated":"2022-09-20 06:42:37.000000000","message":"We can change the `with_items` thing I mentioned later. I think we should probably also consider moving all of the Heat templating logic for generating those Ansible variables into normal Ansible variables and have that complex logic moved to the Ansible role side. Just to reduce the dependency on THT.\n\nFunctionally this change seems good to me. We can follow up on everything else later.\n","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4c252eb0b29c1c5c9bff1a7843064e150941a991","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"62210f2c_f197cd37","updated":"2022-09-22 15:25:56.000000000","message":"belated comment","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"}],"deployment/apache/apache-baremetal-ansible.j2.yaml":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b26edbae397ab2966bb8ee544d0e89a824bb05d1","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":179,"context_line":"            - enable_internal_tls"},{"line_number":180,"context_line":"          block:"},{"line_number":181,"context_line":"            - name: Create dirs for certificates and keys"},{"line_number":182,"context_line":"              file:"},{"line_number":183,"context_line":"                path: \"{% raw %}{{ item }}{% endraw %}\""},{"line_number":184,"context_line":"                state: directory"},{"line_number":185,"context_line":"                serole: object_r"},{"line_number":186,"context_line":"                setype: cert_t"},{"line_number":187,"context_line":"                seuser: system_u"},{"line_number":188,"context_line":"              with_items:"},{"line_number":189,"context_line":"                - \u0027/etc/pki/tls/certs/httpd\u0027"},{"line_number":190,"context_line":"                - \u0027/etc/pki/tls/private/httpd\u0027"},{"line_number":191,"context_line":"            - include_role:"},{"line_number":192,"context_line":"                name: linux-system-roles.certificate"},{"line_number":193,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"789bf52b_de8fcd50","line":190,"range":{"start_line":181,"start_character":0,"end_line":190,"end_character":46},"updated":"2022-09-15 21:21:54.000000000","message":"This could be done in the image build, and later removed from here","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4c252eb0b29c1c5c9bff1a7843064e150941a991","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":179,"context_line":"            - enable_internal_tls"},{"line_number":180,"context_line":"          block:"},{"line_number":181,"context_line":"            - name: Create dirs for certificates and keys"},{"line_number":182,"context_line":"              file:"},{"line_number":183,"context_line":"                path: \"{% raw %}{{ item }}{% endraw %}\""},{"line_number":184,"context_line":"                state: directory"},{"line_number":185,"context_line":"                serole: object_r"},{"line_number":186,"context_line":"                setype: cert_t"},{"line_number":187,"context_line":"                seuser: system_u"},{"line_number":188,"context_line":"              with_items:"},{"line_number":189,"context_line":"                - \u0027/etc/pki/tls/certs/httpd\u0027"},{"line_number":190,"context_line":"                - \u0027/etc/pki/tls/private/httpd\u0027"},{"line_number":191,"context_line":"            - include_role:"},{"line_number":192,"context_line":"                name: linux-system-roles.certificate"},{"line_number":193,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"88d68cd0_8bd29a63","line":190,"range":{"start_line":181,"start_character":0,"end_line":190,"end_character":46},"in_reply_to":"5014a38f_0b692c88","updated":"2022-09-22 15:25:56.000000000","message":"if we ensure these only with overcloud disk image build, what would create it for deployed servers and standalone deployemnts?","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3bb2af29b5ef187024382d64c48bc28a8d9d742d","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":179,"context_line":"            - enable_internal_tls"},{"line_number":180,"context_line":"          block:"},{"line_number":181,"context_line":"            - name: Create dirs for certificates and keys"},{"line_number":182,"context_line":"              file:"},{"line_number":183,"context_line":"                path: \"{% raw %}{{ item }}{% endraw %}\""},{"line_number":184,"context_line":"                state: directory"},{"line_number":185,"context_line":"                serole: object_r"},{"line_number":186,"context_line":"                setype: cert_t"},{"line_number":187,"context_line":"                seuser: system_u"},{"line_number":188,"context_line":"              with_items:"},{"line_number":189,"context_line":"                - \u0027/etc/pki/tls/certs/httpd\u0027"},{"line_number":190,"context_line":"                - \u0027/etc/pki/tls/private/httpd\u0027"},{"line_number":191,"context_line":"            - include_role:"},{"line_number":192,"context_line":"                name: linux-system-roles.certificate"},{"line_number":193,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"5014a38f_0b692c88","line":190,"range":{"start_line":181,"start_character":0,"end_line":190,"end_character":46},"in_reply_to":"6fcb743f_23ba98cd","updated":"2022-09-20 08:18:03.000000000","message":"I also intend to move some of the tasks there in dedicated role in tripleo-ansible - that will remove part of the intelligence from heat, as expected for the next steps: make it as dumb as possible :). Here I\u0027m mostly thinking about the certificate generation part.","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2879b7e78199832762da983f99797e0e3c276f32","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":179,"context_line":"            - enable_internal_tls"},{"line_number":180,"context_line":"          block:"},{"line_number":181,"context_line":"            - name: Create dirs for certificates and keys"},{"line_number":182,"context_line":"              file:"},{"line_number":183,"context_line":"                path: \"{% raw %}{{ item }}{% endraw %}\""},{"line_number":184,"context_line":"                state: directory"},{"line_number":185,"context_line":"                serole: object_r"},{"line_number":186,"context_line":"                setype: cert_t"},{"line_number":187,"context_line":"                seuser: system_u"},{"line_number":188,"context_line":"              with_items:"},{"line_number":189,"context_line":"                - \u0027/etc/pki/tls/certs/httpd\u0027"},{"line_number":190,"context_line":"                - \u0027/etc/pki/tls/private/httpd\u0027"},{"line_number":191,"context_line":"            - include_role:"},{"line_number":192,"context_line":"                name: linux-system-roles.certificate"},{"line_number":193,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"c1575b2a_b0c645cd","line":190,"range":{"start_line":181,"start_character":0,"end_line":190,"end_character":46},"in_reply_to":"789bf52b_de8fcd50","updated":"2022-09-16 08:48:17.000000000","message":"hmmm that may be cool indeed - less tasks in ansible/heat, and won\u0027t break anything. I\u0027m all for that!","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f7d33c2192c0892fbc4a61482299f83a344149b0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":179,"context_line":"            - enable_internal_tls"},{"line_number":180,"context_line":"          block:"},{"line_number":181,"context_line":"            - name: Create dirs for certificates and keys"},{"line_number":182,"context_line":"              file:"},{"line_number":183,"context_line":"                path: \"{% raw %}{{ item }}{% endraw %}\""},{"line_number":184,"context_line":"                state: directory"},{"line_number":185,"context_line":"                serole: object_r"},{"line_number":186,"context_line":"                setype: cert_t"},{"line_number":187,"context_line":"                seuser: system_u"},{"line_number":188,"context_line":"              with_items:"},{"line_number":189,"context_line":"                - \u0027/etc/pki/tls/certs/httpd\u0027"},{"line_number":190,"context_line":"                - \u0027/etc/pki/tls/private/httpd\u0027"},{"line_number":191,"context_line":"            - include_role:"},{"line_number":192,"context_line":"                name: linux-system-roles.certificate"},{"line_number":193,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"c490bbf7_ef0715a7","line":190,"range":{"start_line":181,"start_character":0,"end_line":190,"end_character":46},"in_reply_to":"88d68cd0_8bd29a63","updated":"2022-09-23 07:57:36.000000000","message":"we\u0027re still discussing this issue - but we\u0027ll have to keep them here imho.","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"9a01c868f1cca054bda7847864d2a5d4dd6d761c","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":179,"context_line":"            - enable_internal_tls"},{"line_number":180,"context_line":"          block:"},{"line_number":181,"context_line":"            - name: Create dirs for certificates and keys"},{"line_number":182,"context_line":"              file:"},{"line_number":183,"context_line":"                path: \"{% raw %}{{ item }}{% endraw %}\""},{"line_number":184,"context_line":"                state: directory"},{"line_number":185,"context_line":"                serole: object_r"},{"line_number":186,"context_line":"                setype: cert_t"},{"line_number":187,"context_line":"                seuser: system_u"},{"line_number":188,"context_line":"              with_items:"},{"line_number":189,"context_line":"                - \u0027/etc/pki/tls/certs/httpd\u0027"},{"line_number":190,"context_line":"                - \u0027/etc/pki/tls/private/httpd\u0027"},{"line_number":191,"context_line":"            - include_role:"},{"line_number":192,"context_line":"                name: linux-system-roles.certificate"},{"line_number":193,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"6fcb743f_23ba98cd","line":190,"range":{"start_line":181,"start_character":0,"end_line":190,"end_character":46},"in_reply_to":"c1575b2a_b0c645cd","updated":"2022-09-20 05:56:18.000000000","message":"Yeah, be good to remove this from here and rely on our Ansible roles. It reduces the complexity of the standalone-roles work.\n\nBut if we plan to leave it here for whatever reason, can we use loop instead of with_items? If it were an existing file we were updating, I would say leave it. But since it\u0027s a new file, we should probably make sure it\u0027s using the latest Ansible standards.","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"}],"deployment/ironic/ironic-api-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fec4bf26f132350e24e428c24bd98fca8c0cd0fc","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            ironic_api_network: {get_param: [ServiceNetMap, IronicApiNetwork]}"},{"line_number":390,"context_line":"            tripleo_httpd_vhost_service_name: \u0027ironic_api\u0027"},{"line_number":391,"context_line":"            #tripleo_httpd_vhost_bind_host: \"{{ lookup(\u0027vars\u0027, service_net_map[\u0027IronicApiNetwork\u0027 | snake_case]) }}\""},{"line_number":392,"context_line":"            tripleo_httpd_vhost_bind_host: \"{{ deployed_server_port_map[tripleo_role_name|lower + \u0027-\u0027 + ironic_api_network][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] }}\""},{"line_number":393,"context_line":"            tripleo_httpd_vhost_bind_port: {get_param: [EndpointMap, IronicInternal, port]}"},{"line_number":394,"context_line":"            tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 + service_net_map[\u0027IronicApiNetwork\u0027 | snake_case] ) }}\""},{"line_number":395,"context_line":"            tripleo_httpd_vhost_custom_fragment:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"21dbb7f5_c191a003","line":392,"range":{"start_line":392,"start_character":47,"end_line":392,"end_character":153},"updated":"2022-09-01 08:14:12.000000000","message":"try\n\n{{ lookup(\u0027vars\u0027, service_net_map[\u0027ironic_api_network\u0027] ~ \u0027_ip\u0027 + ) }}","commit_id":"2724db2dbf2a2e079659c8283a7b9000b660e474"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5e7638430beb9debe879a577f597b48dea552afc","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            ironic_api_network: {get_param: [ServiceNetMap, IronicApiNetwork]}"},{"line_number":390,"context_line":"            tripleo_httpd_vhost_service_name: \u0027ironic_api\u0027"},{"line_number":391,"context_line":"            #tripleo_httpd_vhost_bind_host: \"{{ lookup(\u0027vars\u0027, service_net_map[\u0027IronicApiNetwork\u0027 | snake_case]) }}\""},{"line_number":392,"context_line":"            tripleo_httpd_vhost_bind_host: \"{{ deployed_server_port_map[tripleo_role_name|lower + \u0027-\u0027 + ironic_api_network][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] }}\""},{"line_number":393,"context_line":"            tripleo_httpd_vhost_bind_port: {get_param: [EndpointMap, IronicInternal, port]}"},{"line_number":394,"context_line":"            tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 + service_net_map[\u0027IronicApiNetwork\u0027 | snake_case] ) }}\""},{"line_number":395,"context_line":"            tripleo_httpd_vhost_custom_fragment:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5ac35ead_ca31af68","line":392,"range":{"start_line":392,"start_character":47,"end_line":392,"end_character":153},"in_reply_to":"21dbb7f5_c191a003","updated":"2022-09-02 08:34:58.000000000","message":"Done","commit_id":"2724db2dbf2a2e079659c8283a7b9000b660e474"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fec4bf26f132350e24e428c24bd98fca8c0cd0fc","unresolved":true,"context_lines":[{"line_number":391,"context_line":"            #tripleo_httpd_vhost_bind_host: \"{{ lookup(\u0027vars\u0027, service_net_map[\u0027IronicApiNetwork\u0027 | snake_case]) }}\""},{"line_number":392,"context_line":"            tripleo_httpd_vhost_bind_host: \"{{ deployed_server_port_map[tripleo_role_name|lower + \u0027-\u0027 + ironic_api_network][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] }}\""},{"line_number":393,"context_line":"            tripleo_httpd_vhost_bind_port: {get_param: [EndpointMap, IronicInternal, port]}"},{"line_number":394,"context_line":"            tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 + service_net_map[\u0027IronicApiNetwork\u0027 | snake_case] ) }}\""},{"line_number":395,"context_line":"            tripleo_httpd_vhost_custom_fragment:"},{"line_number":396,"context_line":"              if:"},{"line_number":397,"context_line":"                - auth_strategy_http_basic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"208e55a7_1c0b68a3","line":394,"range":{"start_line":394,"start_character":90,"end_line":394,"end_character":106},"updated":"2022-09-01 08:14:12.000000000","message":"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 + service_net_map[\u0027ironic_api_network\u0027] ) }} ?\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_2a9/854568/3/check/tripleo-ci-centos-9-standalone/2a95504/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-szyvoy_r/global_vars.yaml","commit_id":"2724db2dbf2a2e079659c8283a7b9000b660e474"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5e7638430beb9debe879a577f597b48dea552afc","unresolved":false,"context_lines":[{"line_number":391,"context_line":"            #tripleo_httpd_vhost_bind_host: \"{{ lookup(\u0027vars\u0027, service_net_map[\u0027IronicApiNetwork\u0027 | snake_case]) }}\""},{"line_number":392,"context_line":"            tripleo_httpd_vhost_bind_host: \"{{ deployed_server_port_map[tripleo_role_name|lower + \u0027-\u0027 + ironic_api_network][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] }}\""},{"line_number":393,"context_line":"            tripleo_httpd_vhost_bind_port: {get_param: [EndpointMap, IronicInternal, port]}"},{"line_number":394,"context_line":"            tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 + service_net_map[\u0027IronicApiNetwork\u0027 | snake_case] ) }}\""},{"line_number":395,"context_line":"            tripleo_httpd_vhost_custom_fragment:"},{"line_number":396,"context_line":"              if:"},{"line_number":397,"context_line":"                - auth_strategy_http_basic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"725a90e4_fc738ddf","line":394,"range":{"start_line":394,"start_character":90,"end_line":394,"end_character":106},"in_reply_to":"208e55a7_1c0b68a3","updated":"2022-09-02 08:34:58.000000000","message":"Done","commit_id":"2724db2dbf2a2e079659c8283a7b9000b660e474"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b26edbae397ab2966bb8ee544d0e89a824bb05d1","unresolved":true,"context_lines":[{"line_number":277,"context_line":"            - source: \"/usr/bin/ironic-api-wsgi\""},{"line_number":278,"context_line":"              dest: \"/var/www/cgi-bin/ironic/app\""},{"line_number":279,"context_line":"              merge: false"},{"line_number":280,"context_line":"              preserve_properties: true"},{"line_number":281,"context_line":"          permissions: \u0026ironic_api_permissions"},{"line_number":282,"context_line":"            - path: /var/log/ironic"},{"line_number":283,"context_line":"              owner: ironic:ironic"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ca9e71a6_b199c894","line":280,"updated":"2022-09-15 21:21:54.000000000","message":"https://review.opendev.org/c/openstack/tripleo-common/+/854459 has merged so this can be removed now?","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2879b7e78199832762da983f99797e0e3c276f32","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            - source: \"/usr/bin/ironic-api-wsgi\""},{"line_number":278,"context_line":"              dest: \"/var/www/cgi-bin/ironic/app\""},{"line_number":279,"context_line":"              merge: false"},{"line_number":280,"context_line":"              preserve_properties: true"},{"line_number":281,"context_line":"          permissions: \u0026ironic_api_permissions"},{"line_number":282,"context_line":"            - path: /var/log/ironic"},{"line_number":283,"context_line":"              owner: ironic:ironic"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"d8bd82e3_06e35096","line":280,"in_reply_to":"ca9e71a6_b199c894","updated":"2022-09-16 08:48:17.000000000","message":"oh, perfect! Didn\u0027t check if it was in or not...","commit_id":"cf38bdaa1dd57df4ddf55a242042db91e22af641"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5f22c5e39641602223ceea4b9e04bd713f6a4f21","unresolved":true,"context_lines":[{"line_number":307,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":308,"context_line":"                -"},{"line_number":309,"context_line":"                - - /var/lib/kolla/config_files/ironic_api_db_sync.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":310,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic_api:/var/lib/kolla/config_files/src:ro"},{"line_number":311,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic_api:/var/lib/kolla/config_files/ansible:ro"},{"line_number":312,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"},{"line_number":313,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2428d15a_69fb66b4","line":310,"updated":"2022-09-22 15:28:49.000000000","message":"please drop this bind mount","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f7d33c2192c0892fbc4a61482299f83a344149b0","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":308,"context_line":"                -"},{"line_number":309,"context_line":"                - - /var/lib/kolla/config_files/ironic_api_db_sync.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":310,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic_api:/var/lib/kolla/config_files/src:ro"},{"line_number":311,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic_api:/var/lib/kolla/config_files/ansible:ro"},{"line_number":312,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"},{"line_number":313,"context_line":"            environment:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7aedcabd_56532cbc","line":310,"in_reply_to":"2428d15a_69fb66b4","updated":"2022-09-23 07:57:36.000000000","message":"no. ironic config itself is still done in puppet.","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5f22c5e39641602223ceea4b9e04bd713f6a4f21","unresolved":true,"context_lines":[{"line_number":326,"context_line":"              list_concat:"},{"line_number":327,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":328,"context_line":"                - - /var/lib/kolla/config_files/ironic_api.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":329,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic_api:/var/lib/kolla/config_files/src:ro"},{"line_number":330,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic_api:/var/lib/kolla/config_files/ansible:ro"},{"line_number":331,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"},{"line_number":332,"context_line":"                  - /var/log/containers/httpd/ironic-api:/var/log/httpd:z"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"e8ff55c2_8539f0e1","line":329,"updated":"2022-09-22 15:28:49.000000000","message":"please drop this bind mount","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f7d33c2192c0892fbc4a61482299f83a344149b0","unresolved":false,"context_lines":[{"line_number":326,"context_line":"              list_concat:"},{"line_number":327,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":328,"context_line":"                - - /var/lib/kolla/config_files/ironic_api.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":329,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic_api:/var/lib/kolla/config_files/src:ro"},{"line_number":330,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic_api:/var/lib/kolla/config_files/ansible:ro"},{"line_number":331,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"},{"line_number":332,"context_line":"                  - /var/log/containers/httpd/ironic-api:/var/log/httpd:z"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"54604e35_6181ca94","line":329,"in_reply_to":"e8ff55c2_8539f0e1","updated":"2022-09-23 07:57:36.000000000","message":"ditto","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"}],"deployment/ironic/ironic-pxe-container-puppet.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"46cd7f5578f992126124866febeddbc75ebb813d","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            - { \u0027path\u0027: /var/lib/ironic, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u0027g+s\u0027 }"},{"line_number":198,"context_line":"            - { \u0027path\u0027: /var/log/containers/ironic, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":199,"context_line":"            - { \u0027path\u0027: /var/log/containers/httpd/ironic-pxe, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":200,"context_line":"        - name: Create vhost for ipxe"},{"line_number":201,"context_line":"          import_role:"},{"line_number":202,"context_line":"            name: tripleo_ironic"},{"line_number":203,"context_line":"            tasks_from: ipxe_httpd.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4792828b_31588dbf","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":37},"updated":"2022-09-15 10:39:06.000000000","message":"How are we ensuring the bind_host here? Afict this will bind to \u0027*\u0027? It should bind only on [ServiceNetMap, IronicNetwork]?","commit_id":"bfd9957796bbbc30892a948705bced5b7d97a471"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"577df5612849754796148a96bc3c716dd6c90814","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            - { \u0027path\u0027: /var/lib/ironic, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u0027g+s\u0027 }"},{"line_number":198,"context_line":"            - { \u0027path\u0027: /var/log/containers/ironic, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":199,"context_line":"            - { \u0027path\u0027: /var/log/containers/httpd/ironic-pxe, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":200,"context_line":"        - name: Create vhost for ipxe"},{"line_number":201,"context_line":"          import_role:"},{"line_number":202,"context_line":"            name: tripleo_ironic"},{"line_number":203,"context_line":"            tasks_from: ipxe_httpd.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"64a4f8f6_482a1b58","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":37},"in_reply_to":"4792828b_31588dbf","updated":"2022-09-15 13:42:13.000000000","message":"hmm I think it was listening on * when I checked my env - but it\u0027s not that complicated to change.\n\nAs for the \"port\": I didn\u0027t see mention of it being different in anything - not to mention the potential issues with the firewall if ppl aren\u0027t using that one: there will be a rule opening 8088, and they will have to manually add the rule opening their custom one. Is it really supported?\n\nIn any cases: we can easily do the right thing in here. Lemme amend this commit, at least for the bind_host.","commit_id":"bfd9957796bbbc30892a948705bced5b7d97a471"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a1c297ea3ff3066db4f47c83c0399197ab47c356","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            - { \u0027path\u0027: /var/lib/ironic, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u0027g+s\u0027 }"},{"line_number":198,"context_line":"            - { \u0027path\u0027: /var/log/containers/ironic, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":199,"context_line":"            - { \u0027path\u0027: /var/log/containers/httpd/ironic-pxe, \u0027setype\u0027: container_file_t, \u0027mode\u0027: \u00270750\u0027 }"},{"line_number":200,"context_line":"        - name: Create vhost for ipxe"},{"line_number":201,"context_line":"          import_role:"},{"line_number":202,"context_line":"            name: tripleo_ironic"},{"line_number":203,"context_line":"            tasks_from: ipxe_httpd.yaml"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"845b4fca_c97f5acc","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":37},"in_reply_to":"64a4f8f6_482a1b58","updated":"2022-09-15 14:53:45.000000000","message":"Done","commit_id":"bfd9957796bbbc30892a948705bced5b7d97a471"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5f22c5e39641602223ceea4b9e04bd713f6a4f21","unresolved":true,"context_lines":[{"line_number":164,"context_line":"              list_concat:"},{"line_number":165,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":166,"context_line":"                - - /var/lib/kolla/config_files/ironic_pxe_tftp.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":167,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic:/var/lib/kolla/config_files/src:ro"},{"line_number":168,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic:/var/lib/kolla/config_files/ansible:ro"},{"line_number":169,"context_line":"                  - /var/lib/ironic:/var/lib/ironic:shared,z"},{"line_number":170,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"78ac018a_4724c2df","line":167,"updated":"2022-09-22 15:28:49.000000000","message":"please drop this bind mount","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f7d33c2192c0892fbc4a61482299f83a344149b0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"              list_concat:"},{"line_number":165,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":166,"context_line":"                - - /var/lib/kolla/config_files/ironic_pxe_tftp.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":167,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic:/var/lib/kolla/config_files/src:ro"},{"line_number":168,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic:/var/lib/kolla/config_files/ansible:ro"},{"line_number":169,"context_line":"                  - /var/lib/ironic:/var/lib/ironic:shared,z"},{"line_number":170,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2a482843_1b4c1e05","line":167,"in_reply_to":"78ac018a_4724c2df","updated":"2022-09-23 07:57:36.000000000","message":"ditto","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5f22c5e39641602223ceea4b9e04bd713f6a4f21","unresolved":true,"context_lines":[{"line_number":183,"context_line":"              list_concat:"},{"line_number":184,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":185,"context_line":"                - - /var/lib/kolla/config_files/ironic_pxe_http.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":186,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic:/var/lib/kolla/config_files/src:ro"},{"line_number":187,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic:/var/lib/kolla/config_files/ansible:ro"},{"line_number":188,"context_line":"                  - /var/lib/ironic:/var/lib/ironic:shared,z"},{"line_number":189,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"ff253ab7_81581f88","line":186,"updated":"2022-09-22 15:28:49.000000000","message":"please drop this bind mount","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f7d33c2192c0892fbc4a61482299f83a344149b0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"              list_concat:"},{"line_number":184,"context_line":"                - {get_attr: [ContainersCommon, volumes]}"},{"line_number":185,"context_line":"                - - /var/lib/kolla/config_files/ironic_pxe_http.json:/var/lib/kolla/config_files/config.json:ro"},{"line_number":186,"context_line":"                  - /var/lib/config-data/puppet-generated/ironic:/var/lib/kolla/config_files/src:ro"},{"line_number":187,"context_line":"                  - /var/lib/config-data/ansible-generated/ironic:/var/lib/kolla/config_files/ansible:ro"},{"line_number":188,"context_line":"                  - /var/lib/ironic:/var/lib/ironic:shared,z"},{"line_number":189,"context_line":"                  - /var/log/containers/ironic:/var/log/ironic:z"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"56e87630_84cd7e5c","line":186,"in_reply_to":"ff253ab7_81581f88","updated":"2022-09-23 07:57:36.000000000","message":"ditto","commit_id":"8e9ade5f11e3191a2ec982afadcbabdded9bcdf7"}]}