)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88a47a4dce6c9f8d42e0093d8e91cd7bf2f9c8b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bc3aa32_59246086","updated":"2022-08-29 03:11:43.000000000","message":"-1 because of missing role_specific tag.\n\nAlso, I think the change is worth documenting in a release note.","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f82de6e4625bcdc183f71585078e18b92cfb5fa8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec901f34_d12db69a","in_reply_to":"0bc3aa32_59246086","updated":"2022-08-29 08:10:53.000000000","message":"Why a release note is needed? The problem  was that those values were not configurable before while they should (bug). The problem was hidden by tripleo-ansible setting the defaults we were actually testing so this was not notice before.","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"006c726cfe03d9417aa56b6de1a7697bd3ad40cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f72f7e10_21b81de6","in_reply_to":"c218e2c2_c9521bad","updated":"2022-08-29 09:02:43.000000000","message":"You are right! the problem is that I don\u0027t know enough TripleO... And I was trying to set it up using role specific setting instead of parameter_defaults. Going to try if it works as intended with parameter_defaults and then close this one. Thanks for the quite valuable description in here!","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"648f3754bc6f5dafefb43c14f85bfc310cd526cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c218e2c2_c9521bad","in_reply_to":"ec901f34_d12db69a","updated":"2022-08-29 08:42:38.000000000","message":"\u003e The problem  was that those values were not configurable before while they should (bug). \n\nI don\u0027t get this point. Those values were configurable as long as you use parameter_defaults section and set the consistent value. This change just allows you to set these parameters via role specific parameter interface and use different values per role. If your problem is that role specific setting does not work then that is not something previously supported, rather than a bug.\n\nThe current description is the commit message is quite vague and doesn\u0027t allow me to understand what is wrong, but if you are facing a different problem then I\u0027m afraid this change does not solve it.\n\nAlso, this introduces the new FrrOvnBgpAgentReconcileInterval parameter.","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c6972c0a1e667183abd7481c4a01728170eb204","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c59cb8bb_0626d438","in_reply_to":"f72f7e10_21b81de6","updated":"2022-09-02 01:37:04.000000000","message":"I\u0027d be ok with not having a release note. The main blocker was the missing role specific tag.","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"}],"deployment/frr/frr-container-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88a47a4dce6c9f8d42e0093d8e91cd7bf2f9c8b3","unresolved":true,"context_lines":[{"line_number":185,"context_line":"      - allowed_values: [ \u0027ovn_bgp_driver\u0027, \u0027ovn_evpn_driver\u0027 ]"},{"line_number":186,"context_line":"    tags:"},{"line_number":187,"context_line":"      - role_specific"},{"line_number":188,"context_line":"  FrrOvnBgpAgentExposeTenantNetworks:"},{"line_number":189,"context_line":"    description: \u003e"},{"line_number":190,"context_line":"      Exposes VM IPs on tenant networks via MP-BGP IPv4 and IPv6 unicast."},{"line_number":191,"context_line":"      Requires the BGP driver (see THT parameter FrrOvnBgpAgentDriver)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"62479226_b976a84c","line":188,"range":{"start_line":188,"start_character":2,"end_line":188,"end_character":36},"updated":"2022-08-29 03:11:43.000000000","message":"please add the role_specific tag.","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f82de6e4625bcdc183f71585078e18b92cfb5fa8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"      - allowed_values: [ \u0027ovn_bgp_driver\u0027, \u0027ovn_evpn_driver\u0027 ]"},{"line_number":186,"context_line":"    tags:"},{"line_number":187,"context_line":"      - role_specific"},{"line_number":188,"context_line":"  FrrOvnBgpAgentExposeTenantNetworks:"},{"line_number":189,"context_line":"    description: \u003e"},{"line_number":190,"context_line":"      Exposes VM IPs on tenant networks via MP-BGP IPv4 and IPv6 unicast."},{"line_number":191,"context_line":"      Requires the BGP driver (see THT parameter FrrOvnBgpAgentDriver)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5925ae31_56348a79","line":188,"range":{"start_line":188,"start_character":2,"end_line":188,"end_character":36},"in_reply_to":"62479226_b976a84c","updated":"2022-08-29 08:10:53.000000000","message":"Done","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88a47a4dce6c9f8d42e0093d8e91cd7bf2f9c8b3","unresolved":true,"context_lines":[{"line_number":191,"context_line":"      Requires the BGP driver (see THT parameter FrrOvnBgpAgentDriver)."},{"line_number":192,"context_line":"    type: boolean"},{"line_number":193,"context_line":"    default: false"},{"line_number":194,"context_line":"  FrrOvnBgpAgentAsn:"},{"line_number":195,"context_line":"    default: 64999"},{"line_number":196,"context_line":"    description: \u003e"},{"line_number":197,"context_line":"      Autonomous System Number to be used by the agent when running in BGP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1813cbf7_14dcbf2a","line":194,"range":{"start_line":194,"start_character":2,"end_line":194,"end_character":19},"updated":"2022-08-29 03:11:43.000000000","message":"ditto","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f82de6e4625bcdc183f71585078e18b92cfb5fa8","unresolved":false,"context_lines":[{"line_number":191,"context_line":"      Requires the BGP driver (see THT parameter FrrOvnBgpAgentDriver)."},{"line_number":192,"context_line":"    type: boolean"},{"line_number":193,"context_line":"    default: false"},{"line_number":194,"context_line":"  FrrOvnBgpAgentAsn:"},{"line_number":195,"context_line":"    default: 64999"},{"line_number":196,"context_line":"    description: \u003e"},{"line_number":197,"context_line":"      Autonomous System Number to be used by the agent when running in BGP"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"61ade7f8_42225827","line":194,"range":{"start_line":194,"start_character":2,"end_line":194,"end_character":19},"in_reply_to":"1813cbf7_14dcbf2a","updated":"2022-08-29 08:10:53.000000000","message":"Done","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88a47a4dce6c9f8d42e0093d8e91cd7bf2f9c8b3","unresolved":true,"context_lines":[{"line_number":197,"context_line":"      Autonomous System Number to be used by the agent when running in BGP"},{"line_number":198,"context_line":"      mode."},{"line_number":199,"context_line":"    type: number"},{"line_number":200,"context_line":"  FrrOvnBgpAgentOvsdbConnection:"},{"line_number":201,"context_line":"    default: \u0027tcp:127.0.0.1:6640\u0027"},{"line_number":202,"context_line":"    description: \u003e"},{"line_number":203,"context_line":"      The connection string for the native OVSDB backend. Use tcp:IP:PORT"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"03ec77d5_2d8c8af6","line":200,"range":{"start_line":200,"start_character":2,"end_line":200,"end_character":31},"updated":"2022-08-29 03:11:43.000000000","message":"ditto","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f82de6e4625bcdc183f71585078e18b92cfb5fa8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      Autonomous System Number to be used by the agent when running in BGP"},{"line_number":198,"context_line":"      mode."},{"line_number":199,"context_line":"    type: number"},{"line_number":200,"context_line":"  FrrOvnBgpAgentOvsdbConnection:"},{"line_number":201,"context_line":"    default: \u0027tcp:127.0.0.1:6640\u0027"},{"line_number":202,"context_line":"    description: \u003e"},{"line_number":203,"context_line":"      The connection string for the native OVSDB backend. Use tcp:IP:PORT"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eb1a2983_5688ea3a","line":200,"range":{"start_line":200,"start_character":2,"end_line":200,"end_character":31},"in_reply_to":"03ec77d5_2d8c8af6","updated":"2022-08-29 08:10:53.000000000","message":"Done","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88a47a4dce6c9f8d42e0093d8e91cd7bf2f9c8b3","unresolved":true,"context_lines":[{"line_number":203,"context_line":"      The connection string for the native OVSDB backend. Use tcp:IP:PORT"},{"line_number":204,"context_line":"      for TCP connection."},{"line_number":205,"context_line":"    type: string"},{"line_number":206,"context_line":"  FrrOvnBgpAgentReconcileInterval:"},{"line_number":207,"context_line":"    default: 120"},{"line_number":208,"context_line":"    description: \u003e"},{"line_number":209,"context_line":"      Defines how frequently to reconcile the status, to ensure only the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"53bb0359_6d19812f","line":206,"range":{"start_line":206,"start_character":2,"end_line":206,"end_character":33},"updated":"2022-08-29 03:11:43.000000000","message":"ditto","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f82de6e4625bcdc183f71585078e18b92cfb5fa8","unresolved":false,"context_lines":[{"line_number":203,"context_line":"      The connection string for the native OVSDB backend. Use tcp:IP:PORT"},{"line_number":204,"context_line":"      for TCP connection."},{"line_number":205,"context_line":"    type: string"},{"line_number":206,"context_line":"  FrrOvnBgpAgentReconcileInterval:"},{"line_number":207,"context_line":"    default: 120"},{"line_number":208,"context_line":"    description: \u003e"},{"line_number":209,"context_line":"      Defines how frequently to reconcile the status, to ensure only the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3b2ffb2f_b8b48264","line":206,"range":{"start_line":206,"start_character":2,"end_line":206,"end_character":33},"in_reply_to":"53bb0359_6d19812f","updated":"2022-08-29 08:10:53.000000000","message":"Done","commit_id":"9ebab71899debc1b318bc03d873e541eff5e73bc"}]}
