)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ff4b323a4ee982fd4f085bc05f1904baa03b31e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"119a6b37_7233bf31","updated":"2022-09-08 13:55:43.000000000","message":"recheck","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"13b29d9e8c0eddbfdfd51e2153499c6f85defd4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa661421_a5aa0d97","updated":"2022-09-08 16:01:08.000000000","message":"recheck","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"708c1102f78943531bdbc9f1a97ec728eb7f4f1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8333738_7beca036","updated":"2022-09-08 15:06:13.000000000","message":"recheck","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"95d33bdbe6135d7a7b92e289ca354dab3b126634","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf52fa09_33f3ab77","updated":"2022-09-08 12:34:09.000000000","message":"recheck","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"95ff7c66433eb751fce37ff63a7e13c0897841a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"962068d9_efc7f81f","updated":"2022-09-20 02:45:18.000000000","message":"Seems there are still a few left ?\n\n```\n$ grep -r delegate_to  | grep groups | grep -v excluded | grep -v Undercloud\ndeployment/nova/nova-scheduler-container-puppet.yaml:                tripleo_delegate_to: \"{{ groups[\u0027nova_scheduler\u0027] | default([]) }}\"\ndeployment/nova/nova-api-container-puppet.yaml:                tripleo_delegate_to: \"{{ groups[\u0027nova_api\u0027] | default([]) }}\"\ndeployment/nova/nova-metadata-container-puppet.yaml:                tripleo_delegate_to: \"{{ groups[\u0027nova_metadata\u0027] | default([]) }}\"\ndeployment/nova/nova-ironic-container-puppet.yaml:                tripleo_delegate_to: \"{{ groups[\u0027nova_ironic\u0027] | default([]) }}\"\n```","commit_id":"c66cd0868f2cd54e1937d33bd187359eb08c3e82"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ae926308297a3338bd7ded390af9eb262a85c0a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e08bb34f_1fe4c7a1","in_reply_to":"962068d9_efc7f81f","updated":"2022-09-20 03:49:40.000000000","message":"Yeah, not sure how those were missed. We did not catch them in testing as we were testing with only compute services.","commit_id":"c66cd0868f2cd54e1937d33bd187359eb08c3e82"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"458871bc3f6e06729c57cda90bc3297396626c1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c6f29c9b_c5ea3386","updated":"2022-09-21 06:31:25.000000000","message":"Didn\u0027t see any missing delegate_to nor tripleo_delegate_to. guess we\u0027re good to go.","commit_id":"cc38db4c99caf8a1e9f4f8a6d7155700cfbe0471"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"04ee477570906182e6a5459f40ef4632e514528c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e36f91c5_fbd1506a","updated":"2022-09-20 03:55:33.000000000","message":"fixed a few missing brackets.","commit_id":"cc38db4c99caf8a1e9f4f8a6d7155700cfbe0471"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"104dac5b7f2d9fbd496a933d9432430eff1efca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e6d59a31_40fc4222","updated":"2022-09-20 14:59:59.000000000","message":"recheck","commit_id":"cc38db4c99caf8a1e9f4f8a6d7155700cfbe0471"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"dc7a37099b7d68539eb3b9aab324b011b25bc8ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5458730a_b70200fc","updated":"2022-09-20 07:56:23.000000000","message":"recheck NODE_FAILURE","commit_id":"cc38db4c99caf8a1e9f4f8a6d7155700cfbe0471"}],"deployment/aodh/aodh-api-container-puppet.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"95d33bdbe6135d7a7b92e289ca354dab3b126634","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                tripleo_containers_to_stop:"},{"line_number":388,"context_line":"                  - aodh_api"},{"line_number":389,"context_line":"                  - aodh_api_cron"},{"line_number":390,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027aodh_api\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6f9382a5_7579cfd7","line":390,"updated":"2022-09-08 12:34:09.000000000","message":"what happens if the \"groups[\u0027aodh_api\u0027]\" doesn\u0027t exist (i.e. no \u0027aodh_api\u0027 key in the dict)? Shouldn\u0027t we keep the |default([])?","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0d4d59db7615c03837dc877cbca7f90c5b7de5c5","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                tripleo_containers_to_stop:"},{"line_number":388,"context_line":"                  - aodh_api"},{"line_number":389,"context_line":"                  - aodh_api_cron"},{"line_number":390,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027aodh_api\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"de78e7b2_f9b08fc7","line":390,"in_reply_to":"4af09140_cdfed0bc","updated":"2022-09-12 04:12:03.000000000","message":"We don\u0027t use the default atm in many places[1], as it does not matter.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ovn/ovn-controller-container-puppet.yaml#L468","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2bc3bd6330dfdc17951b180fff719cbeb56446d9","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                tripleo_containers_to_stop:"},{"line_number":388,"context_line":"                  - aodh_api"},{"line_number":389,"context_line":"                  - aodh_api_cron"},{"line_number":390,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027aodh_api\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4af09140_cdfed0bc","line":390,"in_reply_to":"6f9382a5_7579cfd7","updated":"2022-09-08 12:43:36.000000000","message":"It\u0027s not needed. If the service is there in a role and role count \u003e 0 then these tasks would be added to playbook. Then there would be these groups in the inventory.","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9b82786b6d0d627a20be5653c8955abbfdf9e52c","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                tripleo_containers_to_stop:"},{"line_number":388,"context_line":"                  - aodh_api"},{"line_number":389,"context_line":"                  - aodh_api_cron"},{"line_number":390,"context_line":"                tripleo_delegate_to: \"{{ groups[\u0027aodh_api\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"82a4c085_5854c14c","line":390,"in_reply_to":"de78e7b2_f9b08fc7","updated":"2022-09-12 12:56:17.000000000","message":"Ack","commit_id":"b225813f2547dd632e1adee98fa0760b6dda65de"}]}