)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1bdeb2d1a6b5937d4b4b93fb98adec9d95884a05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fe403f40_cbe3954d","updated":"2022-09-14 15:12:21.000000000","message":"I have push the new implementation, but we will still use a different parameter.","commit_id":"295a5654d680bdd44bfc953e4aeb03343614b33d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6445e61ca40776d387c50aa14d262073dd9b35a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eff31047_c31f5b73","updated":"2022-09-16 08:37:18.000000000","message":"Looks good - it\u0027d be good to see feedback that this has been tested and works.","commit_id":"3a929ba224275b34b0bc174eed5ae37653e8de19"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1533bf04e0e8d7203248cb4321ea00946164c688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e0afd121_1c6e5aba","updated":"2022-09-15 12:56:08.000000000","message":"recheck","commit_id":"3a929ba224275b34b0bc174eed5ae37653e8de19"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eb025f6c14f26076e0f87d3c6b1af12d1b291a27","unresolved":true,"context_lines":[{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages }}\""},{"line_number":313,"context_line":"                state: present"},{"line_number":314,"context_line":"              when:"},{"line_number":315,"context_line":"                - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e56c9b0b_1786b4de","line":312,"range":{"start_line":311,"start_character":0,"end_line":312,"end_character":47},"updated":"2022-09-14 09:29:20.000000000","message":"Will this be a list, or should this receive a string that is comma delimited and split that into a list?\n\neg:\n\n  name: \"{{ base_tripleo_packages | split(\u0027,\u0027) }}\"","commit_id":"06a4eb8e8595df0155f53e09156472b2daa43ffd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"78e0929e4e4bb551ade55a95cfad51d2ba320d96","unresolved":false,"context_lines":[{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages }}\""},{"line_number":313,"context_line":"                state: present"},{"line_number":314,"context_line":"              when:"},{"line_number":315,"context_line":"                - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6b7207a8_f6c171d7","line":312,"range":{"start_line":311,"start_character":0,"end_line":312,"end_character":47},"in_reply_to":"666ec33f_c0adcf4b","updated":"2022-09-14 11:15:32.000000000","message":"Done","commit_id":"06a4eb8e8595df0155f53e09156472b2daa43ffd"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"16c58995fb116b8df6db4ee914564092e5d165a4","unresolved":true,"context_lines":[{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages }}\""},{"line_number":313,"context_line":"                state: present"},{"line_number":314,"context_line":"              when:"},{"line_number":315,"context_line":"                - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"666ec33f_c0adcf4b","line":312,"range":{"start_line":311,"start_character":0,"end_line":312,"end_character":47},"in_reply_to":"e56c9b0b_1786b4de","updated":"2022-09-14 10:04:28.000000000","message":"Hi Jesse,\n\nYou\u0027re right, thanks a lot, I will do the modification now.","commit_id":"06a4eb8e8595df0155f53e09156472b2daa43ffd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8c8b68bf0dd0570e1a9886f398238c5fd5d85d93","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    type: json"},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"},{"line_number":116,"context_line":"  BaseTripleoPackages:"},{"line_number":117,"context_line":"    default: []"},{"line_number":118,"context_line":"    description: List of packages to install."},{"line_number":119,"context_line":"    type: comma_delimited_list"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf440c36_7b6158fc","line":116,"updated":"2022-09-14 11:17:39.000000000","message":"Does it make sense to use a new parameter, when we already have UpgradeLeappToInstall as a role parameter which can be used to install new packages?","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1bdeb2d1a6b5937d4b4b93fb98adec9d95884a05","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    type: json"},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"},{"line_number":116,"context_line":"  BaseTripleoPackages:"},{"line_number":117,"context_line":"    default: []"},{"line_number":118,"context_line":"    description: List of packages to install."},{"line_number":119,"context_line":"    type: comma_delimited_list"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a0d5e367_4ac6e7b1","line":116,"in_reply_to":"678c2372_5871d842","updated":"2022-09-14 15:12:21.000000000","message":"Done","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"95454e9e2e71e5911a08dc41ae8425d65ead6658","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    type: json"},{"line_number":114,"context_line":"    tags:"},{"line_number":115,"context_line":"      - role_specific"},{"line_number":116,"context_line":"  BaseTripleoPackages:"},{"line_number":117,"context_line":"    default: []"},{"line_number":118,"context_line":"    description: List of packages to install."},{"line_number":119,"context_line":"    type: comma_delimited_list"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"678c2372_5871d842","line":116,"in_reply_to":"bf440c36_7b6158fc","updated":"2022-09-14 11:44:29.000000000","message":"I will check it, you probably right we can reuse the same parameter.","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6e3019e970381714f0a72fba37e07feca4bdd78a","unresolved":true,"context_lines":[{"line_number":141,"context_line":"              UpgradeLeappCommandOptions: {get_param: UpgradeLeappCommandOptions}"},{"line_number":142,"context_line":"              UpgradeLeappToRemove: {get_param: UpgradeLeappToRemove}"},{"line_number":143,"context_line":"              UpgradeLeappToInstall: {get_param: UpgradeLeappToInstall}"},{"line_number":144,"context_line":"              UpgradeInitCommand: {get_param: UpgradeInitCommand}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"outputs:"},{"line_number":147,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"638c119b_ab4b99e9","line":144,"updated":"2022-09-14 11:15:22.000000000","message":"BaseTripleoPackages is a Role Parameter - should it be part of this map, similar to UpgradeLeappToInstall ?","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"95454e9e2e71e5911a08dc41ae8425d65ead6658","unresolved":true,"context_lines":[{"line_number":141,"context_line":"              UpgradeLeappCommandOptions: {get_param: UpgradeLeappCommandOptions}"},{"line_number":142,"context_line":"              UpgradeLeappToRemove: {get_param: UpgradeLeappToRemove}"},{"line_number":143,"context_line":"              UpgradeLeappToInstall: {get_param: UpgradeLeappToInstall}"},{"line_number":144,"context_line":"              UpgradeInitCommand: {get_param: UpgradeInitCommand}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"outputs:"},{"line_number":147,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfe59716_a5deb2a4","line":144,"in_reply_to":"638c119b_ab4b99e9","updated":"2022-09-14 11:44:29.000000000","message":"Yes.","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1bdeb2d1a6b5937d4b4b93fb98adec9d95884a05","unresolved":false,"context_lines":[{"line_number":141,"context_line":"              UpgradeLeappCommandOptions: {get_param: UpgradeLeappCommandOptions}"},{"line_number":142,"context_line":"              UpgradeLeappToRemove: {get_param: UpgradeLeappToRemove}"},{"line_number":143,"context_line":"              UpgradeLeappToInstall: {get_param: UpgradeLeappToInstall}"},{"line_number":144,"context_line":"              UpgradeInitCommand: {get_param: UpgradeInitCommand}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"outputs:"},{"line_number":147,"context_line":"  role_data:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfba99df_79f9fafa","line":144,"in_reply_to":"dfe59716_a5deb2a4","updated":"2022-09-14 15:12:21.000000000","message":"Done","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6e3019e970381714f0a72fba37e07feca4bdd78a","unresolved":true,"context_lines":[{"line_number":306,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":307,"context_line":"            - name: Ensure TripleO prerequisite packages are installed and use role based heat variable to provide specific list of packages"},{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages | split(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f931fb9b_ab0cbe9c","line":309,"range":{"start_line":309,"start_character":0,"end_line":309,"end_character":71},"updated":"2022-09-14 11:15:22.000000000","message":"See UpgradeLeappToInstall\u0027s lines 135,143,217. It looks different and that implements a role parameter.","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1bdeb2d1a6b5937d4b4b93fb98adec9d95884a05","unresolved":false,"context_lines":[{"line_number":306,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":307,"context_line":"            - name: Ensure TripleO prerequisite packages are installed and use role based heat variable to provide specific list of packages"},{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages | split(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4defacf9_4550e65a","line":309,"range":{"start_line":309,"start_character":0,"end_line":309,"end_character":71},"in_reply_to":"801ad775_22529db6","updated":"2022-09-14 15:12:21.000000000","message":"Done","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"95454e9e2e71e5911a08dc41ae8425d65ead6658","unresolved":true,"context_lines":[{"line_number":306,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":307,"context_line":"            - name: Ensure TripleO prerequisite packages are installed and use role based heat variable to provide specific list of packages"},{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages | split(\u0027,\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"801ad775_22529db6","line":309,"range":{"start_line":309,"start_character":0,"end_line":309,"end_character":71},"in_reply_to":"f931fb9b_ab0cbe9c","updated":"2022-09-14 11:44:29.000000000","message":"Yes, I work locally right now on that, you are totally right.","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6e3019e970381714f0a72fba37e07feca4bdd78a","unresolved":true,"context_lines":[{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages | split(\u0027,\u0027) }}\""},{"line_number":313,"context_line":"                state: present"},{"line_number":314,"context_line":"              when:"},{"line_number":315,"context_line":"                - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6ae45cda_770a3c29","line":312,"range":{"start_line":311,"start_character":0,"end_line":312,"end_character":60},"updated":"2022-09-14 11:15:22.000000000","message":"My apologies. My previous thought was wrong - this is actually a list.\n\nI do not think it makes sense to multiline this though... it could just be:\n\n name: \"{{ base_tripleo_packages }}\"\n\nbase_tripleo_packages is a list, much like pkg_to_install is a list.","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"1bdeb2d1a6b5937d4b4b93fb98adec9d95884a05","unresolved":false,"context_lines":[{"line_number":308,"context_line":"              vars:"},{"line_number":309,"context_line":"                base_tripleo_packages: {get_param: BaseTripleoPackages}"},{"line_number":310,"context_line":"              package:"},{"line_number":311,"context_line":"                name:"},{"line_number":312,"context_line":"                  \"{{ base_tripleo_packages | split(\u0027,\u0027) }}\""},{"line_number":313,"context_line":"                state: present"},{"line_number":314,"context_line":"              when:"},{"line_number":315,"context_line":"                - ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5088343a_c76dbbeb","line":312,"range":{"start_line":311,"start_character":0,"end_line":312,"end_character":60},"in_reply_to":"6ae45cda_770a3c29","updated":"2022-09-14 15:12:21.000000000","message":"Done","commit_id":"51562fb1c47a801efcbb12a68656671f8430d899"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9ac6b740e1f6755a91a7238208a33c337ebe1d96","unresolved":true,"context_lines":[{"line_number":307,"context_line":"                state: present"},{"line_number":308,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":309,"context_line":"            - name: Ensure TripleO prerequisite packages are installed and use role based heat variable to provide specific list of packages"},{"line_number":310,"context_line":"              vars: {get_attr: [RoleParametersValue, value, \u0027base_tripleo_packages\u0027]}"},{"line_number":311,"context_line":"              package:"},{"line_number":312,"context_line":"                name:"},{"line_number":313,"context_line":"                  \"{{ base_tripleo_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3c33ce71_2eb4d33c","line":310,"range":{"start_line":310,"start_character":14,"end_line":310,"end_character":85},"updated":"2022-09-15 07:50:55.000000000","message":"Are you sure this is right? Should it be of the format:\n\n  vars:\n    \u003cvar name\u003e: {get_attr: ...}","commit_id":"295a5654d680bdd44bfc953e4aeb03343614b33d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"e2a3850000550c852094992279b0e4057c93ce28","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                state: present"},{"line_number":308,"context_line":"              when: ansible_facts[\u0027distribution_major_version\u0027] is version(\u00278\u0027, \u0027\u003d\u003d\u0027)"},{"line_number":309,"context_line":"            - name: Ensure TripleO prerequisite packages are installed and use role based heat variable to provide specific list of packages"},{"line_number":310,"context_line":"              vars: {get_attr: [RoleParametersValue, value, \u0027base_tripleo_packages\u0027]}"},{"line_number":311,"context_line":"              package:"},{"line_number":312,"context_line":"                name:"},{"line_number":313,"context_line":"                  \"{{ base_tripleo_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4276a117_690b5612","line":310,"range":{"start_line":310,"start_character":14,"end_line":310,"end_character":85},"in_reply_to":"3c33ce71_2eb4d33c","updated":"2022-09-15 12:55:33.000000000","message":"Done","commit_id":"295a5654d680bdd44bfc953e4aeb03343614b33d"}]}