)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1dc4295edf29cc8dd07d33ff647d4c429d876695","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Sensubility is also set to connect to QDR in scenario001-standalone job"},{"line_number":18,"context_line":"so that it is visible in the logs that HC script succeeds."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://github.com/containers/podman/issues/12493"},{"line_number":21,"context_line":"Depends-On: I7538def60e4fd3a7187ede0e1f5ada1b0c460f65"},{"line_number":22,"context_line":"Change-Id: I9149dd5087ae6af0265f37b36de9213c9d625a3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ed7189a7_3ff13964","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":53},"updated":"2022-11-11 15:04:18.000000000","message":"What is this reference about?","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Sensubility is also set to connect to QDR in scenario001-standalone job"},{"line_number":18,"context_line":"so that it is visible in the logs that HC script succeeds."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://github.com/containers/podman/issues/12493"},{"line_number":21,"context_line":"Depends-On: I7538def60e4fd3a7187ede0e1f5ada1b0c460f65"},{"line_number":22,"context_line":"Change-Id: I9149dd5087ae6af0265f37b36de9213c9d625a3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"65a6a6c9_c78c33f6","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":53},"in_reply_to":"ed7189a7_3ff13964","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39ec990f539869f87a80529e7ab26bf597db529b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da05cdcf_c67154cf","updated":"2022-09-15 11:19:55.000000000","message":"-1 to raise awareness about the useless loop - we\u0027ll gain some time by not looping :)\n\nAFAIK this will require a change in openstack-selinux to allow init_t to manage a socket in container_file_t context.\n\nThis was already discussed offline, and we (Julie and I) don\u0027t see issue with this new rule.","commit_id":"75690efc06a0098e89579f92e1b03155528a6088"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3f940a74a1133bcbfd66799f1973abfb62708e58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39602c3c_5cceb0fb","updated":"2022-09-21 15:51:11.000000000","message":"check-rdo","commit_id":"813c256fee51721ca90dc178b05274b1c4816c9c"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f5bbcdb724f2c325d8fd2ac19d6f8bf23df8ba9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62e45748_cc6d90e9","updated":"2022-09-22 14:04:13.000000000","message":"check-rdo","commit_id":"1cb3956c83159218e014ea6260e34a6d4b8acaf6"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"59f55ec449b5832ac9c3c5390048b5a92256c20c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e284a0a_5499868c","updated":"2022-09-26 13:33:29.000000000","message":"check-rdo","commit_id":"1cb3956c83159218e014ea6260e34a6d4b8acaf6"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3c746981ddc3ec420ecc3685f578d7e46d7ba3c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5925b9ea_929411d7","updated":"2022-09-23 10:43:56.000000000","message":"recheck","commit_id":"1cb3956c83159218e014ea6260e34a6d4b8acaf6"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"7ce0d549394fdc45857e61fda366c9478ebd5bbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"680db471_1eb6488e","updated":"2022-10-03 12:48:17.000000000","message":"(\"just\" +1 for feedback about the \"it\u0027s working\")","commit_id":"1adb31b72a687a10f298b01ec777561e9005419a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9e7c762c1a2737e1da14bfa14805ab61d63574f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"03fad8c8_61e94830","updated":"2022-10-03 12:42:33.000000000","message":"Is it working without any selinux denials? Is there a job deploying collectd in the CI?\n\nOtherwise, looks good, really.","commit_id":"1adb31b72a687a10f298b01ec777561e9005419a"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"9d45b2f1094332e9101a105474568ace55086647","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8150d447_e0300aa9","updated":"2022-09-30 10:12:58.000000000","message":"check-rdo","commit_id":"1adb31b72a687a10f298b01ec777561e9005419a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c0c8f957a5bde6fcd565e40b210f93137c01f548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"732d7b1e_9cd16516","updated":"2022-10-17 11:47:59.000000000","message":"I get the idea, but I see some potential issues:\n- exposing the socket to *any* container, since all of them is using the host network\n- as Takashi pointed out, no resource cleanup, this may be useful if customer wants to disable sensuability.\n\n\nMay main concern is, really, exposing the podman TCP socket to the world via the host network :(. We can probably act against this via the firewall though, but it will be complicated (marking packets, filtering on that mark, for instance... Or some similar mechanism)....\n\nAnother solution may be:\n- dedicated container for sensu\n- NOT using network\u003dhost, but the podman one (or maybe a brand new, dedicated one)\n- expose podman TCP socket on that specific network\n\nAFAIK, that would still allow sensu to push data to collectd, while ensuring we\u0027re not exposing the socket to the world (or close to it, since, again, any container may access it).","commit_id":"e241235c7527b55dfe53f6a264aa4554099c8aa1"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f2c6ce103b97e3c3a5775514fb5291525ee83bb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3bd02435_119ff074","updated":"2022-10-20 11:31:46.000000000","message":"getting closer, some cleaning and consolidation imho.","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"816e342278c9b73b08bd7744785791790aef6fb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a4816e65_de886cde","updated":"2022-11-11 15:06:12.000000000","message":"I would suggest to add other cores are reviewers from next time to get reviews quickly. Most cores review patches quickly if added to their queue.","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"82a72b7bf526a38be73677221fe5972ee771f22d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"73c79791_3392fd18","updated":"2022-11-21 14:58:20.000000000","message":"check-rdo","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f22b5c5167d983d9d7793ad0fccd8f94de4aeca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"04e3ae90_4ab8a198","updated":"2022-11-15 11:36:21.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"4820c789802b27a5d7337c8dba9dc9f1852d021f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0c13762a_c2373d16","updated":"2022-11-15 16:01:41.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"39ab22a7748db95f7ad368603eab3f64ab77a358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"28b9b2f8_b9c0f40e","updated":"2022-11-14 22:14:12.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"a1c4687e8f1461290d30198439f9d0f764a60e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"505f7735_abfecaad","updated":"2022-11-11 19:41:07.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"8c40004fee48d677db1c7d8758e1ec0aba415be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"69ce300f_3712bc08","updated":"2022-11-21 16:46:27.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"a9b158fb15938bd6ebdd0b13dee9b8756be99f2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d35c6205_0ae93845","updated":"2022-11-14 15:54:40.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7ad2e921f78ef663015f686eb2e9cb3edcf0ad4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d61ca781_c7b44254","updated":"2022-11-21 09:35:16.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"6ba441ed4241eb1716f8b877c80abfb757190f88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f6f87a64_58868442","updated":"2022-11-14 09:38:29.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"59fec6f5f721e71f88eff9949ad841130d711e41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fe21fcb8_b2eedc3d","updated":"2022-11-12 10:49:09.000000000","message":"recheck","commit_id":"fff89083bb9e1e08f3ec5ce07abb99a8e61aacf4"}],"deployment/metrics/collectd-container-puppet.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39ec990f539869f87a80529e7ab26bf597db529b","unresolved":true,"context_lines":[{"line_number":606,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":607,"context_line":"                  - /var/lib/container-config-scripts:/scripts:ro"},{"line_number":608,"context_line":"                  - /run:/run:rw"},{"line_number":609,"context_line":"                  - /var/lib/config-data/collectd/run/podman:/run/podman:rw,z"},{"line_number":610,"context_line":"                  - /sys/fs/cgroup:/sys/fs/cgroup:ro"},{"line_number":611,"context_line":"            environment:"},{"line_number":612,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1329a37c_f37027cb","line":609,"range":{"start_line":609,"start_character":73,"end_line":609,"end_character":75},"updated":"2022-09-15 11:19:55.000000000","message":"\"rw\" is default btw.","commit_id":"75690efc06a0098e89579f92e1b03155528a6088"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c0c8f957a5bde6fcd565e40b210f93137c01f548","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":607,"context_line":"                  - /var/lib/container-config-scripts:/scripts:ro"},{"line_number":608,"context_line":"                  - /run:/run:rw"},{"line_number":609,"context_line":"                  - /var/lib/config-data/collectd/run/podman:/run/podman:rw,z"},{"line_number":610,"context_line":"                  - /sys/fs/cgroup:/sys/fs/cgroup:ro"},{"line_number":611,"context_line":"            environment:"},{"line_number":612,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fe55523d_0fb63e88","line":609,"range":{"start_line":609,"start_character":73,"end_line":609,"end_character":75},"in_reply_to":"1329a37c_f37027cb","updated":"2022-10-17 11:47:59.000000000","message":"not relevant anymore","commit_id":"75690efc06a0098e89579f92e1b03155528a6088"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39ec990f539869f87a80529e7ab26bf597db529b","unresolved":true,"context_lines":[{"line_number":664,"context_line":"        - name: create podman socket for sensubility purposes"},{"line_number":665,"context_line":"          block:"},{"line_number":666,"context_line":"            - ansible.builtin.file:"},{"line_number":667,"context_line":"                path: \"{{ item }}\""},{"line_number":668,"context_line":"                state: directory"},{"line_number":669,"context_line":"              with_items:"},{"line_number":670,"context_line":"                - /var/lib/config-data"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7e2d009e_2ae781e3","line":667,"updated":"2022-09-15 11:19:55.000000000","message":"\"If directory, all intermediate subdirectories will be created if they do not exist\"\n\nYou can therefore remove the loop and just create the /var/lib/config-data/collectd/run","commit_id":"75690efc06a0098e89579f92e1b03155528a6088"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"06f9e69952064205f469e50995a5b0ae25b7b891","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        - name: create podman socket for sensubility purposes"},{"line_number":665,"context_line":"          block:"},{"line_number":666,"context_line":"            - ansible.builtin.file:"},{"line_number":667,"context_line":"                path: \"{{ item }}\""},{"line_number":668,"context_line":"                state: directory"},{"line_number":669,"context_line":"              with_items:"},{"line_number":670,"context_line":"                - /var/lib/config-data"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4edeefc2_2374ca6d","line":667,"in_reply_to":"5156cf00_2cb3f273","updated":"2022-09-15 11:45:35.000000000","message":"Yeah, it\u0027s \"\"\"new\"\"\". And only valid for a directory - if you want to get a file, you must create its dirname first.","commit_id":"75690efc06a0098e89579f92e1b03155528a6088"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"fa94c9f9da013fd46317811483b4093f696ec1e6","unresolved":true,"context_lines":[{"line_number":664,"context_line":"        - name: create podman socket for sensubility purposes"},{"line_number":665,"context_line":"          block:"},{"line_number":666,"context_line":"            - ansible.builtin.file:"},{"line_number":667,"context_line":"                path: \"{{ item }}\""},{"line_number":668,"context_line":"                state: directory"},{"line_number":669,"context_line":"              with_items:"},{"line_number":670,"context_line":"                - /var/lib/config-data"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5156cf00_2cb3f273","line":667,"in_reply_to":"7e2d009e_2ae781e3","updated":"2022-09-15 11:23:07.000000000","message":"Oh really? Good to know. Last time I was doing similar exercise in Ansible I had to create directory one by one. Will fix.","commit_id":"75690efc06a0098e89579f92e1b03155528a6088"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"7ce0d549394fdc45857e61fda366c9478ebd5bbc","unresolved":true,"context_lines":[{"line_number":580,"context_line":"                net: none"},{"line_number":581,"context_line":"                user: root"},{"line_number":582,"context_line":"                volumes:"},{"line_number":583,"context_line":"                  - /var/lib/config-data/collectd/run:/tmp/run:rw,z"},{"line_number":584,"context_line":"                command: [\u0027setfacl\u0027, \u0027-R\u0027, \u0027-m\u0027, \u0027u:collectd:rwx\u0027, \u0027/tmp/run/podman\u0027]"},{"line_number":585,"context_line":"        step_3:"},{"line_number":586,"context_line":"          collectd:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"03f7a8d6_5e0cb20d","line":583,"updated":"2022-10-03 12:48:17.000000000","message":"Same remark as the depends-on patch regarding the location - though, here, it\u0027s more \"logical\" with the \"collectd\" prefix. I won\u0027t block on that.","commit_id":"1adb31b72a687a10f298b01ec777561e9005419a"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c0c8f957a5bde6fcd565e40b210f93137c01f548","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                net: none"},{"line_number":581,"context_line":"                user: root"},{"line_number":582,"context_line":"                volumes:"},{"line_number":583,"context_line":"                  - /var/lib/config-data/collectd/run:/tmp/run:rw,z"},{"line_number":584,"context_line":"                command: [\u0027setfacl\u0027, \u0027-R\u0027, \u0027-m\u0027, \u0027u:collectd:rwx\u0027, \u0027/tmp/run/podman\u0027]"},{"line_number":585,"context_line":"        step_3:"},{"line_number":586,"context_line":"          collectd:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2ed9f01e_957942d3","line":583,"in_reply_to":"03f7a8d6_5e0cb20d","updated":"2022-10-17 11:47:59.000000000","message":"not relevant anymore","commit_id":"1adb31b72a687a10f298b01ec777561e9005419a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b4aedf0a122ebd3346bff3c3d69a2c212a5f7cd","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        - name: set enable_sensubility fact"},{"line_number":614,"context_line":"          set_fact:"},{"line_number":615,"context_line":"            enable_sensubility: {get_param: CollectdEnableSensubility}"},{"line_number":616,"context_line":"        - name: Configure rsyslog for container healthchecks"},{"line_number":617,"context_line":"          when:"},{"line_number":618,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":619,"context_line":"          block:"},{"line_number":620,"context_line":"            - name: Check if rsyslog exists"},{"line_number":621,"context_line":"              command: systemctl list-unit-files --type\u003dservice rsyslog.service"},{"line_number":622,"context_line":"              register: rsyslog_config"},{"line_number":623,"context_line":"              failed_when: rsyslog_config.rc not in [0, 1]"},{"line_number":624,"context_line":"            - name: Configure if we can"},{"line_number":625,"context_line":"              when:"},{"line_number":626,"context_line":"                - rsyslog_config is changed"},{"line_number":627,"context_line":"                - rsyslog_config.rc \u003d\u003d 0"},{"line_number":628,"context_line":"              block:"},{"line_number":629,"context_line":"                - name: Log healthchecks in dedicated file"},{"line_number":630,"context_line":"                  when:"},{"line_number":631,"context_line":"                    - enable_sensubility|bool"},{"line_number":632,"context_line":"                  register: logconfig_add"},{"line_number":633,"context_line":"                  copy:"},{"line_number":634,"context_line":"                    dest: /etc/rsyslog.d/openstack-healthcheck.conf"},{"line_number":635,"context_line":"                    content: |"},{"line_number":636,"context_line":"                      if ($programname startswith \u0027podman\u0027 and ($msg contains \u0027container exec\u0027 or $msg contains \u0027healthy\u0027)) or ($programname startswith \u0027systemd\u0027 and $msg contains \u0027podman healthcheck run\u0027) then -/var/log/containers/collectd/healthchecks.stdout"},{"line_number":637,"context_line":"                      \u0026 stop"},{"line_number":638,"context_line":"                - name: Remove healthcheck log"},{"line_number":639,"context_line":"                  when:"},{"line_number":640,"context_line":"                    - not enable_sensubility|bool"},{"line_number":641,"context_line":"                  register: logconfig_rm"},{"line_number":642,"context_line":"                  file:"},{"line_number":643,"context_line":"                    path: /etc/rsyslog.d/openstack-healthcheck.conf"},{"line_number":644,"context_line":"                    state: absent"},{"line_number":645,"context_line":"                - name: Reload rsyslogd if needed"},{"line_number":646,"context_line":"                  when: logconfig_add is changed or logconfig_rm is changed"},{"line_number":647,"context_line":"                  service:"},{"line_number":648,"context_line":"                    name: rsyslog"},{"line_number":649,"context_line":"                    state: restarted"},{"line_number":650,"context_line":"      host_prep_tasks:"},{"line_number":651,"context_line":"        - name: create persistent directories"},{"line_number":652,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2b910c6f_2c6fff52","side":"PARENT","line":649,"range":{"start_line":616,"start_character":0,"end_line":649,"end_character":36},"updated":"2022-10-13 02:27:14.000000000","message":"we need to implement the cleanup process in update/upgrade tasks, otherwise these configurations are left in the system updated/upgrade from an older version.","commit_id":"2acf398d75398659798f5cbaa9ae515b47381ac0"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c0c8f957a5bde6fcd565e40b210f93137c01f548","unresolved":true,"context_lines":[{"line_number":613,"context_line":"        - name: set enable_sensubility fact"},{"line_number":614,"context_line":"          set_fact:"},{"line_number":615,"context_line":"            enable_sensubility: {get_param: CollectdEnableSensubility}"},{"line_number":616,"context_line":"        - name: Configure rsyslog for container healthchecks"},{"line_number":617,"context_line":"          when:"},{"line_number":618,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":619,"context_line":"          block:"},{"line_number":620,"context_line":"            - name: Check if rsyslog exists"},{"line_number":621,"context_line":"              command: systemctl list-unit-files --type\u003dservice rsyslog.service"},{"line_number":622,"context_line":"              register: rsyslog_config"},{"line_number":623,"context_line":"              failed_when: rsyslog_config.rc not in [0, 1]"},{"line_number":624,"context_line":"            - name: Configure if we can"},{"line_number":625,"context_line":"              when:"},{"line_number":626,"context_line":"                - rsyslog_config is changed"},{"line_number":627,"context_line":"                - rsyslog_config.rc \u003d\u003d 0"},{"line_number":628,"context_line":"              block:"},{"line_number":629,"context_line":"                - name: Log healthchecks in dedicated file"},{"line_number":630,"context_line":"                  when:"},{"line_number":631,"context_line":"                    - enable_sensubility|bool"},{"line_number":632,"context_line":"                  register: logconfig_add"},{"line_number":633,"context_line":"                  copy:"},{"line_number":634,"context_line":"                    dest: /etc/rsyslog.d/openstack-healthcheck.conf"},{"line_number":635,"context_line":"                    content: |"},{"line_number":636,"context_line":"                      if ($programname startswith \u0027podman\u0027 and ($msg contains \u0027container exec\u0027 or $msg contains \u0027healthy\u0027)) or ($programname startswith \u0027systemd\u0027 and $msg contains \u0027podman healthcheck run\u0027) then -/var/log/containers/collectd/healthchecks.stdout"},{"line_number":637,"context_line":"                      \u0026 stop"},{"line_number":638,"context_line":"                - name: Remove healthcheck log"},{"line_number":639,"context_line":"                  when:"},{"line_number":640,"context_line":"                    - not enable_sensubility|bool"},{"line_number":641,"context_line":"                  register: logconfig_rm"},{"line_number":642,"context_line":"                  file:"},{"line_number":643,"context_line":"                    path: /etc/rsyslog.d/openstack-healthcheck.conf"},{"line_number":644,"context_line":"                    state: absent"},{"line_number":645,"context_line":"                - name: Reload rsyslogd if needed"},{"line_number":646,"context_line":"                  when: logconfig_add is changed or logconfig_rm is changed"},{"line_number":647,"context_line":"                  service:"},{"line_number":648,"context_line":"                    name: rsyslog"},{"line_number":649,"context_line":"                    state: restarted"},{"line_number":650,"context_line":"      host_prep_tasks:"},{"line_number":651,"context_line":"        - name: create persistent directories"},{"line_number":652,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e733e542_8621f601","side":"PARENT","line":649,"range":{"start_line":616,"start_character":0,"end_line":649,"end_character":36},"in_reply_to":"2b910c6f_2c6fff52","updated":"2022-10-17 11:47:59.000000000","message":"+1 - a \"socket_cleanup.yaml\" may be helpful in tripleo_podman.","commit_id":"2acf398d75398659798f5cbaa9ae515b47381ac0"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        - name: set enable_sensubility fact"},{"line_number":614,"context_line":"          set_fact:"},{"line_number":615,"context_line":"            enable_sensubility: {get_param: CollectdEnableSensubility}"},{"line_number":616,"context_line":"        - name: Configure rsyslog for container healthchecks"},{"line_number":617,"context_line":"          when:"},{"line_number":618,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":619,"context_line":"          block:"},{"line_number":620,"context_line":"            - name: Check if rsyslog exists"},{"line_number":621,"context_line":"              command: systemctl list-unit-files --type\u003dservice rsyslog.service"},{"line_number":622,"context_line":"              register: rsyslog_config"},{"line_number":623,"context_line":"              failed_when: rsyslog_config.rc not in [0, 1]"},{"line_number":624,"context_line":"            - name: Configure if we can"},{"line_number":625,"context_line":"              when:"},{"line_number":626,"context_line":"                - rsyslog_config is changed"},{"line_number":627,"context_line":"                - rsyslog_config.rc \u003d\u003d 0"},{"line_number":628,"context_line":"              block:"},{"line_number":629,"context_line":"                - name: Log healthchecks in dedicated file"},{"line_number":630,"context_line":"                  when:"},{"line_number":631,"context_line":"                    - enable_sensubility|bool"},{"line_number":632,"context_line":"                  register: logconfig_add"},{"line_number":633,"context_line":"                  copy:"},{"line_number":634,"context_line":"                    dest: /etc/rsyslog.d/openstack-healthcheck.conf"},{"line_number":635,"context_line":"                    content: |"},{"line_number":636,"context_line":"                      if ($programname startswith \u0027podman\u0027 and ($msg contains \u0027container exec\u0027 or $msg contains \u0027healthy\u0027)) or ($programname startswith \u0027systemd\u0027 and $msg contains \u0027podman healthcheck run\u0027) then -/var/log/containers/collectd/healthchecks.stdout"},{"line_number":637,"context_line":"                      \u0026 stop"},{"line_number":638,"context_line":"                - name: Remove healthcheck log"},{"line_number":639,"context_line":"                  when:"},{"line_number":640,"context_line":"                    - not enable_sensubility|bool"},{"line_number":641,"context_line":"                  register: logconfig_rm"},{"line_number":642,"context_line":"                  file:"},{"line_number":643,"context_line":"                    path: /etc/rsyslog.d/openstack-healthcheck.conf"},{"line_number":644,"context_line":"                    state: absent"},{"line_number":645,"context_line":"                - name: Reload rsyslogd if needed"},{"line_number":646,"context_line":"                  when: logconfig_add is changed or logconfig_rm is changed"},{"line_number":647,"context_line":"                  service:"},{"line_number":648,"context_line":"                    name: rsyslog"},{"line_number":649,"context_line":"                    state: restarted"},{"line_number":650,"context_line":"      host_prep_tasks:"},{"line_number":651,"context_line":"        - name: create persistent directories"},{"line_number":652,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d048b9a9_3abdf83a","side":"PARENT","line":649,"range":{"start_line":616,"start_character":0,"end_line":649,"end_character":36},"in_reply_to":"e733e542_8621f601","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"2acf398d75398659798f5cbaa9ae515b47381ac0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b4aedf0a122ebd3346bff3c3d69a2c212a5f7cd","unresolved":true,"context_lines":[{"line_number":620,"context_line":"            - include_role:"},{"line_number":621,"context_line":"                name: tripleo_podman"},{"line_number":622,"context_line":"                tasks_from: tripleo_podman_socket.yml"},{"line_number":623,"context_line":"              vars:"},{"line_number":624,"context_line":"                tripleo_podman_service_unit_name: \"tripleo.collectd.podman.service\""},{"line_number":625,"context_line":"                tripleo_podman_service_unit_description: \"Podman API service for collectd-sensubility purposes\""},{"line_number":626,"context_line":"                tripleo_podman_socket_unit_name: \"tripleo.collectd.podman.socket\""},{"line_number":627,"context_line":"                tripleo_podman_socket_unit_description: \"Podman API socket for collectd-sensubility purposes\""},{"line_number":628,"context_line":"                tripleo_podman_socket_port: 8666"},{"line_number":629,"context_line":"          when:"},{"line_number":630,"context_line":"            - enable_sensubility|bool"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d38dcd46_25c25d5c","line":627,"range":{"start_line":623,"start_character":19,"end_line":627,"end_character":109},"updated":"2022-10-13 02:27:14.000000000","message":"you don\u0027t need to set these variables because the reasonable defaults are already defined in tripleo-ansible.","commit_id":"52fe30abd30870aeb6ac30c2de9febd848685da8"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":620,"context_line":"            - include_role:"},{"line_number":621,"context_line":"                name: tripleo_podman"},{"line_number":622,"context_line":"                tasks_from: tripleo_podman_socket.yml"},{"line_number":623,"context_line":"              vars:"},{"line_number":624,"context_line":"                tripleo_podman_service_unit_name: \"tripleo.collectd.podman.service\""},{"line_number":625,"context_line":"                tripleo_podman_service_unit_description: \"Podman API service for collectd-sensubility purposes\""},{"line_number":626,"context_line":"                tripleo_podman_socket_unit_name: \"tripleo.collectd.podman.socket\""},{"line_number":627,"context_line":"                tripleo_podman_socket_unit_description: \"Podman API socket for collectd-sensubility purposes\""},{"line_number":628,"context_line":"                tripleo_podman_socket_port: 8666"},{"line_number":629,"context_line":"          when:"},{"line_number":630,"context_line":"            - enable_sensubility|bool"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4e6ec643_ef98c2dc","line":627,"range":{"start_line":623,"start_character":19,"end_line":627,"end_character":109},"in_reply_to":"d38dcd46_25c25d5c","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"52fe30abd30870aeb6ac30c2de9febd848685da8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f2c6ce103b97e3c3a5775514fb5291525ee83bb9","unresolved":true,"context_lines":[{"line_number":580,"context_line":"                net: none"},{"line_number":581,"context_line":"                user: root"},{"line_number":582,"context_line":"                volumes:"},{"line_number":583,"context_line":"                  - /var/lib/config-data/collectd/run:/tmp/run:rw,z"},{"line_number":584,"context_line":"                command: [\u0027setfacl\u0027, \u0027-R\u0027, \u0027-m\u0027, \u0027u:collectd:rwx\u0027, \u0027/tmp/run\u0027]"},{"line_number":585,"context_line":"        step_3:"},{"line_number":586,"context_line":"          collectd:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"095745e1_688a0ff4","line":583,"updated":"2022-10-20 11:31:46.000000000","message":"see comment #L638","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":580,"context_line":"                net: none"},{"line_number":581,"context_line":"                user: root"},{"line_number":582,"context_line":"                volumes:"},{"line_number":583,"context_line":"                  - /var/lib/config-data/collectd/run:/tmp/run:rw,z"},{"line_number":584,"context_line":"                command: [\u0027setfacl\u0027, \u0027-R\u0027, \u0027-m\u0027, \u0027u:collectd:rwx\u0027, \u0027/tmp/run\u0027]"},{"line_number":585,"context_line":"        step_3:"},{"line_number":586,"context_line":"          collectd:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ffbb6f82_7c79a4ca","line":583,"in_reply_to":"095745e1_688a0ff4","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f2c6ce103b97e3c3a5775514fb5291525ee83bb9","unresolved":true,"context_lines":[{"line_number":606,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":607,"context_line":"                  - /var/lib/container-config-scripts:/scripts:ro"},{"line_number":608,"context_line":"                  - /run:/run:rw"},{"line_number":609,"context_line":"                  - /var/lib/config-data/collectd/run/podman:/run/podman:rw,z"},{"line_number":610,"context_line":"                  - /sys/fs/cgroup:/sys/fs/cgroup:ro"},{"line_number":611,"context_line":"            environment:"},{"line_number":612,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"cc6c052c_89747d91","line":609,"updated":"2022-10-20 11:31:46.000000000","message":"see comment #L638","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":606,"context_line":"                  - /var/log/containers/collectd:/var/log/collectd:rw,z"},{"line_number":607,"context_line":"                  - /var/lib/container-config-scripts:/scripts:ro"},{"line_number":608,"context_line":"                  - /run:/run:rw"},{"line_number":609,"context_line":"                  - /var/lib/config-data/collectd/run/podman:/run/podman:rw,z"},{"line_number":610,"context_line":"                  - /sys/fs/cgroup:/sys/fs/cgroup:ro"},{"line_number":611,"context_line":"            environment:"},{"line_number":612,"context_line":"              KOLLA_CONFIG_STRATEGY: COPY_ALWAYS"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ec3f3432_8d8f45a3","line":609,"in_reply_to":"cc6c052c_89747d91","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f2c6ce103b97e3c3a5775514fb5291525ee83bb9","unresolved":true,"context_lines":[{"line_number":628,"context_line":"          when: {get_param: CollectdEnableMcelog}"},{"line_number":629,"context_line":"        - name: create podman socket for sensubility purposes"},{"line_number":630,"context_line":"          block:"},{"line_number":631,"context_line":"            - ansible.builtin.file:"},{"line_number":632,"context_line":"                path: /var/lib/config-data/collectd/run/podman"},{"line_number":633,"context_line":"                state: directory"},{"line_number":634,"context_line":"            - include_role:"},{"line_number":635,"context_line":"                name: tripleo_podman"},{"line_number":636,"context_line":"                tasks_from: tripleo_podman_service"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4964a8a2_e2a12157","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":32},"updated":"2022-10-20 11:31:46.000000000","message":"useless, it\u0027s already done in the associated role/task file in tripleo_podman","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":628,"context_line":"          when: {get_param: CollectdEnableMcelog}"},{"line_number":629,"context_line":"        - name: create podman socket for sensubility purposes"},{"line_number":630,"context_line":"          block:"},{"line_number":631,"context_line":"            - ansible.builtin.file:"},{"line_number":632,"context_line":"                path: /var/lib/config-data/collectd/run/podman"},{"line_number":633,"context_line":"                state: directory"},{"line_number":634,"context_line":"            - include_role:"},{"line_number":635,"context_line":"                name: tripleo_podman"},{"line_number":636,"context_line":"                tasks_from: tripleo_podman_service"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ca355252_6ed1768f","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":32},"in_reply_to":"4964a8a2_e2a12157","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"f2c6ce103b97e3c3a5775514fb5291525ee83bb9","unresolved":true,"context_lines":[{"line_number":635,"context_line":"                name: tripleo_podman"},{"line_number":636,"context_line":"                tasks_from: tripleo_podman_service"},{"line_number":637,"context_line":"              vars:"},{"line_number":638,"context_line":"                tripleo_podman_socket_path: /var/lib/config-data/collectd/run/podman/podman.sock"},{"line_number":639,"context_line":"          when:"},{"line_number":640,"context_line":"            - enable_sensubility|bool"},{"line_number":641,"context_line":"      update_tasks:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c629c356_516792ee","line":638,"range":{"start_line":638,"start_character":16,"end_line":638,"end_character":96},"updated":"2022-10-20 11:31:46.000000000","message":"maybe keeping the default path (/var/lib/tripleo-podman) is something we should consider - maybe a sub-directory therein (/var/lib/tripleo-podman/collectd).\nThe config-data is usually only for configuration files, not socket.","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"220af30f86809d5d19f6234bddbe67af96021de9","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                name: tripleo_podman"},{"line_number":636,"context_line":"                tasks_from: tripleo_podman_service"},{"line_number":637,"context_line":"              vars:"},{"line_number":638,"context_line":"                tripleo_podman_socket_path: /var/lib/config-data/collectd/run/podman/podman.sock"},{"line_number":639,"context_line":"          when:"},{"line_number":640,"context_line":"            - enable_sensubility|bool"},{"line_number":641,"context_line":"      update_tasks:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"16b234a3_d4819e41","line":638,"range":{"start_line":638,"start_character":16,"end_line":638,"end_character":96},"in_reply_to":"c629c356_516792ee","updated":"2022-11-12 10:48:50.000000000","message":"Done","commit_id":"c0f6e16f768e8a52f3992245cbee33c06cb7a09f"}]}