)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8c58a6ec593e41c78a4d355a64ae27c5c1656223","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-08 11:22:40 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for IBM Svf driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for IBM Spectrum Vritualize family (Svf) driver."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"8bf7107b_f57d8717","line":7,"updated":"2022-11-08 16:26:07.000000000","message":"Why did you remove \"Cinder\" from the subject? It provides useful context for people who wouldn\u0027t otherwise associate this with cinder storage.","commit_id":"cb3c6c2a9dffcf06d7f0fde75599cc305425dadf"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"857f0c0ad766b7f8f2b566fad3ee9a5725853efa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-08 11:22:40 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for IBM Svf driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for IBM Spectrum Vritualize family (Svf) driver."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bb7aed87_c3cba335","line":7,"in_reply_to":"8bf7107b_f57d8717","updated":"2022-11-08 17:59:22.000000000","message":"my bad, i removed it by mistake (my local branch didn\u0027t have it), update it now.","commit_id":"cb3c6c2a9dffcf06d7f0fde75599cc305425dadf"}],"deployment/cinder/cinder-backend-ibm-svf-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c76ae9dc94ce3076da696b65c63ab20c8544574c","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  CinderSvfIscsiChapEnabled:"},{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":"    default: true"},{"line_number":38,"context_line":"  CinderSvfRetainAuxvolume:"},{"line_number":39,"context_line":"    type: boolean"},{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"  CinderSvfSanIp:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5b861267_e20c7fbb","line":38,"updated":"2022-11-01 17:35:15.000000000","message":"In the puppet-tripleo patch, we discussed changing this to CinderSvfRetainAuxVolume.","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3b84f93604c24a398c59932bac0ec30fa8a13306","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  CinderSvfIscsiChapEnabled:"},{"line_number":36,"context_line":"    type: boolean"},{"line_number":37,"context_line":"    default: true"},{"line_number":38,"context_line":"  CinderSvfRetainAuxvolume:"},{"line_number":39,"context_line":"    type: boolean"},{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"  CinderSvfSanIp:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"222cd5ac_9bc5e271","line":38,"in_reply_to":"5b861267_e20c7fbb","updated":"2022-11-01 18:07:50.000000000","message":"Done","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c76ae9dc94ce3076da696b65c63ab20c8544574c","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  CinderSvfSanPassword:"},{"line_number":47,"context_line":"    type: string"},{"line_number":48,"context_line":"    hidden: true"},{"line_number":49,"context_line":"  CinderSvfVolumePoolName:"},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \u0027\u0027"},{"line_number":52,"context_line":"  ServiceData:"},{"line_number":53,"context_line":"    default: {}"},{"line_number":54,"context_line":"    description: Dictionary packing service data"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2bb378e6_e96d9978","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":15},"updated":"2022-11-01 17:35:15.000000000","message":"According to puppet-cinder [1], this parameter should be a comma_delimited_list, and have no default value (it seems to be a required parameter).\n\n\n[1] https://github.com/openstack/puppet-cinder/blob/master/manifests/backend/ibm_svf.pp#L18","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3b84f93604c24a398c59932bac0ec30fa8a13306","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  CinderSvfSanPassword:"},{"line_number":47,"context_line":"    type: string"},{"line_number":48,"context_line":"    hidden: true"},{"line_number":49,"context_line":"  CinderSvfVolumePoolName:"},{"line_number":50,"context_line":"    type: string"},{"line_number":51,"context_line":"    default: \u0027\u0027"},{"line_number":52,"context_line":"  ServiceData:"},{"line_number":53,"context_line":"    default: {}"},{"line_number":54,"context_line":"    description: Dictionary packing service data"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"83e8e565_dd979b5d","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":15},"in_reply_to":"2bb378e6_e96d9978","updated":"2022-11-01 18:07:50.000000000","message":"Done","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c76ae9dc94ce3076da696b65c63ab20c8544574c","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            cinder::backend::ibm_svf::san_ip: {get_param: CinderSvfSanIp}"},{"line_number":87,"context_line":"            cinder::backend::ibm_svf::san_login: {get_param: CinderSvfSanLogin}"},{"line_number":88,"context_line":"            cinder::backend::ibm_svf::san_password: {get_param: CinderSvfSanPassword}"},{"line_number":89,"context_line":"            # NOTE:Svf was earlier called as storwize/svc driver, so the cinder "},{"line_number":90,"context_line":"            # configuration parameters were named accordingly.   "},{"line_number":91,"context_line":"            cinder::backend::ibm_svf::storwize_svc_volpool_name: {get_param: CinderSvfVolumePoolName}"},{"line_number":92,"context_line":"            cinder::backend::ibm_svf::storwize_svc_allow_tenant_qos: {get_param: CinderSvfAllowTenantQos}"},{"line_number":93,"context_line":"            cinder::backend::ibm_svf::storwize_svc_retain_aux_volume: {get_param: CinderSvfRetainAuxvolume}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2a7c7c48_bd146e63","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":65},"updated":"2022-11-01 17:35:15.000000000","message":"Trailing whitespace should be deleted.","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3b84f93604c24a398c59932bac0ec30fa8a13306","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            cinder::backend::ibm_svf::san_ip: {get_param: CinderSvfSanIp}"},{"line_number":87,"context_line":"            cinder::backend::ibm_svf::san_login: {get_param: CinderSvfSanLogin}"},{"line_number":88,"context_line":"            cinder::backend::ibm_svf::san_password: {get_param: CinderSvfSanPassword}"},{"line_number":89,"context_line":"            # NOTE:Svf was earlier called as storwize/svc driver, so the cinder "},{"line_number":90,"context_line":"            # configuration parameters were named accordingly.   "},{"line_number":91,"context_line":"            cinder::backend::ibm_svf::storwize_svc_volpool_name: {get_param: CinderSvfVolumePoolName}"},{"line_number":92,"context_line":"            cinder::backend::ibm_svf::storwize_svc_allow_tenant_qos: {get_param: CinderSvfAllowTenantQos}"},{"line_number":93,"context_line":"            cinder::backend::ibm_svf::storwize_svc_retain_aux_volume: {get_param: CinderSvfRetainAuxvolume}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0a6d0eb5_606b9ccc","line":90,"range":{"start_line":89,"start_character":0,"end_line":90,"end_character":65},"in_reply_to":"2a7c7c48_bd146e63","updated":"2022-11-01 18:07:50.000000000","message":"Done","commit_id":"93576945204bb055c58092d1943f16c9d101f788"}],"releasenotes/notes/Add-support-for-ibm_svf-driver-342ca73422326f62.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c76ae9dc94ce3076da696b65c63ab20c8544574c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":5,"context_line":"    Introduced a new tht for Svf, which replaces the use of tripleo\u0027s "},{"line_number":6,"context_line":"    ExtraConfig technique to configure the backend."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"09883a1a_0bf5a2f9","line":5,"updated":"2022-11-01 17:35:15.000000000","message":"trailing whitespace","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3b84f93604c24a398c59932bac0ec30fa8a13306","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":5,"context_line":"    Introduced a new tht for Svf, which replaces the use of tripleo\u0027s "},{"line_number":6,"context_line":"    ExtraConfig technique to configure the backend."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3d88a71e_e021e0da","line":5,"in_reply_to":"09883a1a_0bf5a2f9","updated":"2022-11-01 18:07:50.000000000","message":"Done","commit_id":"93576945204bb055c58092d1943f16c9d101f788"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9aa56dcc3aa78530d16f10405ea6028a7f2710af","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":5,"context_line":"    Introduced a new tht for Svf, which replaces the use of tripleo\u0027s"},{"line_number":6,"context_line":"    ExtraConfig technique to configure the backend."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8293578a_159a8df7","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":51},"updated":"2022-11-07 11:36:36.000000000","message":"Sorry, I should have read the note more carefully when I first reviewed this patch. I think the second sentence (L5,6) should be removed, and L4 is adequate. First, it\u0027s OK for developers to abbreviate tht, but it shouldn\u0027t be done in a user facing release note.\n\nSecond, there\u0027s nothing in the existing code related to ExtraConfig and the Svf driver, so stating that something has been replaced might be misleading to some readers. One possibility would be to add an \"upgrade:\" note. It could inform users who have an Svf backend deployed using ExtraConfig that they should switch to using the new template by referring them to the new env file.","commit_id":"2b3b529a30aa8a5d54ea276edd2ff993e0f2dfe0"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"bd4267d49c5e7cad314c03b88b774ffd831e3629","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":5,"context_line":"    Introduced a new tht for Svf, which replaces the use of tripleo\u0027s"},{"line_number":6,"context_line":"    ExtraConfig technique to configure the backend."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"638e2e6f_f31c379a","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":51},"in_reply_to":"8293578a_159a8df7","updated":"2022-11-08 06:00:10.000000000","message":"Done","commit_id":"2b3b529a30aa8a5d54ea276edd2ff993e0f2dfe0"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8c58a6ec593e41c78a4d355a64ae27c5c1656223","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add support for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Svf backend deployed using ExtraConfig can switch to new template"},{"line_number":8,"context_line":"    by using \u0027environments/cinder-ibm-svf-config.yaml\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3da037d7_5d727753","line":7,"updated":"2022-11-08 16:26:07.000000000","message":"This needs more context. Bear in mind the release notes bundle all sections together, so this \"upgrade\" note will appear alongside other upgrade notes, and *not* adjacent to the \"features\" note on L4. In other words, the upgrade note use the full reference (the \"Cinder IBM Spectrum virtualize family (Svf) driver\").","commit_id":"cb3c6c2a9dffcf06d7f0fde75599cc305425dadf"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"857f0c0ad766b7f8f2b566fad3ee9a5725853efa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add support for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Svf backend deployed using ExtraConfig can switch to new template"},{"line_number":8,"context_line":"    by using \u0027environments/cinder-ibm-svf-config.yaml\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6bfd967b_d77087e6","line":7,"in_reply_to":"3da037d7_5d727753","updated":"2022-11-08 17:59:22.000000000","message":"Thanks for reminding me about upgrade section, update it.","commit_id":"cb3c6c2a9dffcf06d7f0fde75599cc305425dadf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8c58a6ec593e41c78a4d355a64ae27c5c1656223","unresolved":true,"context_lines":[{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Svf backend deployed using ExtraConfig can switch to new template"},{"line_number":8,"context_line":"    by using \u0027environments/cinder-ibm-svf-config.yaml\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6f25ccbb_cd390a97","line":8,"updated":"2022-11-08 16:26:07.000000000","message":"This is good, but use double back-ticks to quote: ``environments/cinder-ibm-svf-config.yaml``","commit_id":"cb3c6c2a9dffcf06d7f0fde75599cc305425dadf"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"857f0c0ad766b7f8f2b566fad3ee9a5725853efa","unresolved":false,"context_lines":[{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Svf backend deployed using ExtraConfig can switch to new template"},{"line_number":8,"context_line":"    by using \u0027environments/cinder-ibm-svf-config.yaml\u0027."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"14ccb1c8_94636946","line":8,"in_reply_to":"6f25ccbb_cd390a97","updated":"2022-11-08 17:59:22.000000000","message":"Done","commit_id":"cb3c6c2a9dffcf06d7f0fde75599cc305425dadf"}]}