)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e20042280fd214d7ab3a4aae6d77a3ca830432ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5eb668f2_e91e9b9f","updated":"2022-09-27 07:08:55.000000000","message":"looks good but first pass and its a new patch (came here from https://review.opendev.org/q/project:openstack/tripleo-heat-templates)","commit_id":"190420f1bb4221e9655c2f95a095508ecb5bcd64"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"076021e21dcb13418236a6082f7685e977424064","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69e27575_bd16e129","updated":"2022-09-29 06:34:48.000000000","message":"updating my vote - couldn\u0027t find any more string \u0027.*Workers\u0027 with grep","commit_id":"190420f1bb4221e9655c2f95a095508ecb5bcd64"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"62fdb6425c458d84339523074d202f61c5947b73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cee37427_2161b991","updated":"2022-10-06 14:45:31.000000000","message":"well done, thank you","commit_id":"190420f1bb4221e9655c2f95a095508ecb5bcd64"}],"deployment/barbican/barbican-api-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e20042280fd214d7ab3a4aae6d77a3ca830432ca","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                 params:"},{"line_number":294,"context_line":"                   $NETWORK: {get_param: [ServiceNetMap, BarbicanApiNetwork]}"},{"line_number":295,"context_line":"            barbican::wsgi::apache::ssl:  {get_param: EnableInternalTLS}"},{"line_number":296,"context_line":"            barbican::wsgi::apache::workers:"},{"line_number":297,"context_line":"              if:"},{"line_number":298,"context_line":"                - barbican_workers_set"},{"line_number":299,"context_line":"                - {get_param: BarbicanWorkers}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cc29d18d_365d30e9","line":296,"updated":"2022-09-27 07:08:55.000000000","message":"so per commit message i guess $::os_workers  is the puppet module default which we\u0027ll get by not setting it here","commit_id":"190420f1bb4221e9655c2f95a095508ecb5bcd64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e09b7fc239286b29759969ca499b25e1a5a0fa3d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                 params:"},{"line_number":294,"context_line":"                   $NETWORK: {get_param: [ServiceNetMap, BarbicanApiNetwork]}"},{"line_number":295,"context_line":"            barbican::wsgi::apache::ssl:  {get_param: EnableInternalTLS}"},{"line_number":296,"context_line":"            barbican::wsgi::apache::workers:"},{"line_number":297,"context_line":"              if:"},{"line_number":298,"context_line":"                - barbican_workers_set"},{"line_number":299,"context_line":"                - {get_param: BarbicanWorkers}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"44422516_88032eba","line":296,"in_reply_to":"cc29d18d_365d30e9","updated":"2022-09-27 07:17:00.000000000","message":"You are correct. See https://github.com/openstack/puppet-barbican/blob/334a0686c251ceee83bbf9610d4b973ed7949563/manifests/wsgi/apache.pp#L133","commit_id":"190420f1bb4221e9655c2f95a095508ecb5bcd64"}],"deployment/keystone/keystone-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e20042280fd214d7ab3a4aae6d77a3ca830432ca","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    description: Set a token expiration time in seconds."},{"line_number":140,"context_line":"    type: number"},{"line_number":141,"context_line":"  KeystoneWorkers:"},{"line_number":142,"context_line":"    type: string"},{"line_number":143,"context_line":"    description: Set the number of workers for keystone::wsgi::apache"},{"line_number":144,"context_line":"    default: \u0027%{::os_workers_keystone}\u0027"},{"line_number":145,"context_line":"  MonitoringSubscriptionKeystone:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"04120356_4332608e","side":"PARENT","line":142,"range":{"start_line":142,"start_character":10,"end_line":142,"end_character":16},"updated":"2022-09-27 07:08:55.000000000","message":"should not be a breaking change unless someone is explicitly passing \"\" in an environment file? probably heat will just convert that to number?\n\ni cant find any explicit \"\" in our envs e.g. https://opendev.org/openstack/tripleo-heat-templates/src/commit/24829bc6ccbc9e92bfc1adf682f488edefcd57aa/environments/low-memory-usage.yaml#L10","commit_id":"09e8ccac779171914f5f94bc78c78de275105d7c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e09b7fc239286b29759969ca499b25e1a5a0fa3d","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    description: Set a token expiration time in seconds."},{"line_number":140,"context_line":"    type: number"},{"line_number":141,"context_line":"  KeystoneWorkers:"},{"line_number":142,"context_line":"    type: string"},{"line_number":143,"context_line":"    description: Set the number of workers for keystone::wsgi::apache"},{"line_number":144,"context_line":"    default: \u0027%{::os_workers_keystone}\u0027"},{"line_number":145,"context_line":"  MonitoringSubscriptionKeystone:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eb3ee656_8972b4b7","side":"PARENT","line":142,"range":{"start_line":142,"start_character":10,"end_line":142,"end_character":16},"in_reply_to":"04120356_4332608e","updated":"2022-09-27 07:17:00.000000000","message":"Heat no longer accepts \u0027\u0027 and deployment fails at the early stage when creating a heat stack. For this specific parameter we have never supported usage of \u0027\u0027 and in case you put \u0027\u0027 then the value is directly put to the config file and keystone can\u0027t start (that\u0027s what is validated by this change)\n\nFor some parameters such as NeutronWorkers, \u0027\u0027 is not treated as a \u0027special\u0027 value so in case users define the value in their template then the stack creation fails because of validation failure. However IMO \u0027\u0027 is not meant for actual usage and in case the default is needed then the users should remove the wrong parameter definition from their template.","commit_id":"09e8ccac779171914f5f94bc78c78de275105d7c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"076021e21dcb13418236a6082f7685e977424064","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    description: Set a token expiration time in seconds."},{"line_number":140,"context_line":"    type: number"},{"line_number":141,"context_line":"  KeystoneWorkers:"},{"line_number":142,"context_line":"    type: string"},{"line_number":143,"context_line":"    description: Set the number of workers for keystone::wsgi::apache"},{"line_number":144,"context_line":"    default: \u0027%{::os_workers_keystone}\u0027"},{"line_number":145,"context_line":"  MonitoringSubscriptionKeystone:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"db6fe8a5_458c0dc4","side":"PARENT","line":142,"range":{"start_line":142,"start_character":10,"end_line":142,"end_character":16},"in_reply_to":"eb3ee656_8972b4b7","updated":"2022-09-29 06:34:48.000000000","message":"thanks for checking","commit_id":"09e8ccac779171914f5f94bc78c78de275105d7c"}]}