)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"bd9d75448c344838b319b20b6584198c251fa78f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e5b2cee_1856d213","updated":"2022-11-23 14:24:03.000000000","message":"recheck (been awhile since last result)","commit_id":"a8e936a9c45f3a4b2c12288e929f5c2d20098697"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"03a774ea80c769ddedbceb2517382a4171ccc870","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a039ad8d_cf212737","updated":"2023-02-28 13:46:31.000000000","message":"recheck (it\u0027s been awhile)","commit_id":"a8e936a9c45f3a4b2c12288e929f5c2d20098697"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"129337ef844f26ddb4bbfb5a9646644134825fd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d1b26dc0_d5aa89f2","updated":"2022-11-28 08:26:37.000000000","message":"recheck c-p job has been fixed I believe.","commit_id":"a8e936a9c45f3a4b2c12288e929f5c2d20098697"}],"deployment/designate/designate-mdns-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7bf64cd47394df6ca0d16f1ba4ddac524fdb2eb8","unresolved":true,"context_lines":[{"line_number":113,"context_line":"          repeat:"},{"line_number":114,"context_line":"            for_each:"},{"line_number":115,"context_line":"              \u003c% net_cidr %\u003e: {get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, DesignateMdnsNetwork]}]}"},{"line_number":116,"context_line":"          template:"},{"line_number":117,"context_line":"            \u0027142 designate_mdns udp \u003c% net_cidr %\u003e\u0027:"},{"line_number":118,"context_line":"              proto: \u0027udp\u0027"},{"line_number":119,"context_line":"              source: \u003c% net_cidr %\u003e"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"10a5a2bc_b255869f","line":116,"range":{"start_line":116,"start_character":10,"end_line":116,"end_character":18},"updated":"2022-10-18 02:45:01.000000000","message":"this key should be under the repeat key in L113","commit_id":"e22bdf9d143e4a85e67ea90789c99e644a4b3bfb"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"53920a1d4b4383481390d470cbed1b6f8706a0bc","unresolved":false,"context_lines":[{"line_number":113,"context_line":"          repeat:"},{"line_number":114,"context_line":"            for_each:"},{"line_number":115,"context_line":"              \u003c% net_cidr %\u003e: {get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, DesignateMdnsNetwork]}]}"},{"line_number":116,"context_line":"          template:"},{"line_number":117,"context_line":"            \u0027142 designate_mdns udp \u003c% net_cidr %\u003e\u0027:"},{"line_number":118,"context_line":"              proto: \u0027udp\u0027"},{"line_number":119,"context_line":"              source: \u003c% net_cidr %\u003e"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2bd44120_ec1d35b2","line":116,"range":{"start_line":116,"start_character":10,"end_line":116,"end_character":18},"in_reply_to":"10a5a2bc_b255869f","updated":"2022-10-26 11:48:36.000000000","message":"Done","commit_id":"e22bdf9d143e4a85e67ea90789c99e644a4b3bfb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7bf64cd47394df6ca0d16f1ba4ddac524fdb2eb8","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            for_each:"},{"line_number":115,"context_line":"              \u003c% net_cidr %\u003e: {get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, DesignateMdnsNetwork]}]}"},{"line_number":116,"context_line":"          template:"},{"line_number":117,"context_line":"            \u0027142 designate_mdns udp \u003c% net_cidr %\u003e\u0027:"},{"line_number":118,"context_line":"              proto: \u0027udp\u0027"},{"line_number":119,"context_line":"              source: \u003c% net_cidr %\u003e"},{"line_number":120,"context_line":"              dport:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cdf7166c_cce3b8c8","line":117,"range":{"start_line":117,"start_character":13,"end_line":117,"end_character":50},"updated":"2022-10-18 02:45:01.000000000","message":"AFAIK the current implementation by ansible does not purge the existing rules, so this is likely to leave the existing rules without source ips, and we likely need to add rules to ensure these are purged. eg: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/snmp/snmpd-disabled-puppet.yaml#L61-L62\n\n@Tengu do you mind double-checking my understanding ?","commit_id":"e22bdf9d143e4a85e67ea90789c99e644a4b3bfb"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c17c7610715cc681dd24586cafd9acac8eed4e88","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            for_each:"},{"line_number":115,"context_line":"              \u003c% net_cidr %\u003e: {get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, DesignateMdnsNetwork]}]}"},{"line_number":116,"context_line":"          template:"},{"line_number":117,"context_line":"            \u0027142 designate_mdns udp \u003c% net_cidr %\u003e\u0027:"},{"line_number":118,"context_line":"              proto: \u0027udp\u0027"},{"line_number":119,"context_line":"              source: \u003c% net_cidr %\u003e"},{"line_number":120,"context_line":"              dport:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f020b08b_db9de1c5","line":117,"range":{"start_line":117,"start_character":13,"end_line":117,"end_character":50},"in_reply_to":"481f9d7a_38126945","updated":"2022-12-13 13:42:57.000000000","message":"woops, sorry, didn\u0027t see the notification. the rules are re-generated and re-loaded upon each run, so it *should* remove old things that aren\u0027t explicitly written.","commit_id":"e22bdf9d143e4a85e67ea90789c99e644a4b3bfb"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"53920a1d4b4383481390d470cbed1b6f8706a0bc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            for_each:"},{"line_number":115,"context_line":"              \u003c% net_cidr %\u003e: {get_param: [ServiceData, net_cidr_map, {get_param: [ServiceNetMap, DesignateMdnsNetwork]}]}"},{"line_number":116,"context_line":"          template:"},{"line_number":117,"context_line":"            \u0027142 designate_mdns udp \u003c% net_cidr %\u003e\u0027:"},{"line_number":118,"context_line":"              proto: \u0027udp\u0027"},{"line_number":119,"context_line":"              source: \u003c% net_cidr %\u003e"},{"line_number":120,"context_line":"              dport:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"481f9d7a_38126945","line":117,"range":{"start_line":117,"start_character":13,"end_line":117,"end_character":50},"in_reply_to":"cdf7166c_cce3b8c8","updated":"2022-10-26 11:48:36.000000000","message":"Done","commit_id":"e22bdf9d143e4a85e67ea90789c99e644a4b3bfb"}]}