)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b16ab54834fb723abd82db8f040b28bf03fe5e2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8ddece8_2af2ef5b","updated":"2022-10-17 14:11:57.000000000","message":"Yeah, I could use this in the patch I\u0027m working on. Makes sense.","commit_id":"3e0e7f20042fe884e25c5bcd4365366140e091b6"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"f8d915d7d8b56dc2b5444bca0345b74573cf5afe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f67aff7_55e88013","updated":"2022-10-17 09:56:39.000000000","message":"recheck","commit_id":"3e0e7f20042fe884e25c5bcd4365366140e091b6"}],"deployment/iscsid/iscsid-container-puppet.yaml":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"03edb843d7f9308e289c0661d56433bec1cde35a","unresolved":true,"context_lines":[{"line_number":114,"context_line":"          name: tripleo_iscsid"},{"line_number":115,"context_line":"          tasks_from: iscsid.yaml"},{"line_number":116,"context_line":"        vars:"},{"line_number":117,"context_line":"          tripleo_iscsid_config_dir: /var/lib/config-data/puppet-generated/iscsid"},{"line_number":118,"context_line":"        when:"},{"line_number":119,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":120,"context_line":"      ansible_group_vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0284d158_72779f82","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":81},"updated":"2022-10-03 07:03:59.000000000","message":"to fix the bug, you are using puppet config dir, but it overrides the ansible confg dir in [1]\n\niiuc tripleo_iscsid role is supposed to use the ansible configuration right ?\n\ndo let me know if i have missed something.\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/842437/18/tripleo_ansible/roles/tripleo_iscsid/defaults/main.yml#26","commit_id":"3e0e7f20042fe884e25c5bcd4365366140e091b6"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"03b06c3fb28b8f4567f2b946ed3107c9d479bc8f","unresolved":true,"context_lines":[{"line_number":114,"context_line":"          name: tripleo_iscsid"},{"line_number":115,"context_line":"          tasks_from: iscsid.yaml"},{"line_number":116,"context_line":"        vars:"},{"line_number":117,"context_line":"          tripleo_iscsid_config_dir: /var/lib/config-data/puppet-generated/iscsid"},{"line_number":118,"context_line":"        when:"},{"line_number":119,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":120,"context_line":"      ansible_group_vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0af7a4bb_2d2fd45f","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":81},"in_reply_to":"0284d158_72779f82","updated":"2022-10-14 11:27:32.000000000","message":"t-h-t is still using the iscsi config generated by puppet. we override the config dir here to tell the role to use the puppet-generated dir instead of the ansible one.","commit_id":"3e0e7f20042fe884e25c5bcd4365366140e091b6"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"44d8e217169f70548163f3d0e036533bebc618cf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"          name: tripleo_iscsid"},{"line_number":115,"context_line":"          tasks_from: iscsid.yaml"},{"line_number":116,"context_line":"        vars:"},{"line_number":117,"context_line":"          tripleo_iscsid_config_dir: /var/lib/config-data/puppet-generated/iscsid"},{"line_number":118,"context_line":"        when:"},{"line_number":119,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":120,"context_line":"      ansible_group_vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a1d026ac_08bedcdf","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":81},"in_reply_to":"0af7a4bb_2d2fd45f","updated":"2022-10-17 09:28:40.000000000","message":"Ack","commit_id":"3e0e7f20042fe884e25c5bcd4365366140e091b6"}]}