)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c41807812de709eb118b2d1bc41ac4d098b980e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"720be8dc_701faf85","updated":"2022-10-05 09:29:05.000000000","message":"Very nice. ","commit_id":"0074098f0e5e1c20b0c47c9bdf8cbebb4192725c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2ebd9927dd6bb79c9206bb610f1ed61f4dddb285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4a3c2e8_127571de","updated":"2022-10-03 08:49:06.000000000","message":"recheck","commit_id":"0074098f0e5e1c20b0c47c9bdf8cbebb4192725c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b810b8df2197f1c63c4cc772ab2783ed75e05be7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ccd59cb_ec413895","updated":"2022-10-03 08:01:27.000000000","message":"recheck\n\nhad to update depends-on patch","commit_id":"0074098f0e5e1c20b0c47c9bdf8cbebb4192725c"}],"deployment/tripleo-firewall/tripleo-firewall-baremetal-ansible.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3760d6290e9837a11cdb1f46c4e1f95152d7b66f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":"    tags:"},{"line_number":35,"context_line":"      - role_specific"},{"line_number":36,"context_line":"  FirewallEngine:"},{"line_number":37,"context_line":"    default: \u0027nftables\u0027"},{"line_number":38,"context_line":"    description: Set the actual firewall engine. Can be \"iptables\" or \"nftables\""},{"line_number":39,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d3023e71_2e5bfd27","side":"PARENT","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"updated":"2022-10-05 10:19:12.000000000","message":"No release was made since the parameter was added. If we remove the parameter then we better modify(or remove) the existing release note.","commit_id":"c16d9aca8a07106d793d7b765e5ea383a806dd27"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"70ee38000b6d720901557870b4c5613fa32986bd","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":"    tags:"},{"line_number":35,"context_line":"      - role_specific"},{"line_number":36,"context_line":"  FirewallEngine:"},{"line_number":37,"context_line":"    default: \u0027nftables\u0027"},{"line_number":38,"context_line":"    description: Set the actual firewall engine. Can be \"iptables\" or \"nftables\""},{"line_number":39,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ec7867f8_6a3f78bb","side":"PARENT","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"in_reply_to":"472c5c28_52c3beab","updated":"2022-10-06 06:38:39.000000000","message":"IMO we should squash these three nodes into a single note which just explains the firewall engine has been changed from iptables to nftables. That can be done in a separate commit as long as the commit is merged before Zed release so let\u0027s merge the change now and discuss the release note as a follow-up.","commit_id":"c16d9aca8a07106d793d7b765e5ea383a806dd27"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"fe50165cdfc6ce7da6a1200c44c4d5856e6e88e0","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":"    tags:"},{"line_number":35,"context_line":"      - role_specific"},{"line_number":36,"context_line":"  FirewallEngine:"},{"line_number":37,"context_line":"    default: \u0027nftables\u0027"},{"line_number":38,"context_line":"    description: Set the actual firewall engine. Can be \"iptables\" or \"nftables\""},{"line_number":39,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"472c5c28_52c3beab","side":"PARENT","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"in_reply_to":"a67e590c_badb797c","updated":"2022-10-05 11:42:00.000000000","message":"though..\n- a release-note was done for the addition\n- another for the default value change\n- and now a 3rd for the removal\n\nGuess we\u0027re kind of clean all the way... ? Not sure removing/editing past notes is something we should do. I was (probably?) too verbose, but since there wasn\u0027t defined timeline for the merge, I wanted things to be clean.","commit_id":"c16d9aca8a07106d793d7b765e5ea383a806dd27"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"9a04bf077f0896e6b2dd308bc4cf21a154d79b39","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    type: json"},{"line_number":34,"context_line":"    tags:"},{"line_number":35,"context_line":"      - role_specific"},{"line_number":36,"context_line":"  FirewallEngine:"},{"line_number":37,"context_line":"    default: \u0027nftables\u0027"},{"line_number":38,"context_line":"    description: Set the actual firewall engine. Can be \"iptables\" or \"nftables\""},{"line_number":39,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a67e590c_badb797c","side":"PARENT","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":16},"in_reply_to":"d3023e71_2e5bfd27","updated":"2022-10-05 11:39:30.000000000","message":"hmmm right.","commit_id":"c16d9aca8a07106d793d7b765e5ea383a806dd27"}]}
