)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8175e2896efe3a127e47b3c7f84350f2eb46dc6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f76da56_bf20e3f7","updated":"2022-10-10 14:14:28.000000000","message":"I think we should put that value in a parameter with some pointer about how to set it and a \"reasonable\" default. In the ovn patch there was a mention about how to calculate it for a environment, maybe that should be somewhere in the ovn documentation and that paramater could point to that ?\n","commit_id":"afa4d871fa46fd2caac778ca34127ab0cae435ed"}],"deployment/ovn/ovn-controller-container-puppet.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8175e2896efe3a127e47b3c7f84350f2eb46dc6d","unresolved":true,"context_lines":[{"line_number":511,"context_line":"            image: {get_param: ContainerOvnControllerConfigImage}"},{"line_number":512,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":513,"context_line":"          tags: ovn"},{"line_number":514,"context_line":"        - name: Set ovn-ofctrl-wait-before-clear 60"},{"line_number":515,"context_line":"          command: ovs-vsctl set open . external_ids:ovn-ofctrl-wait-before-clear\u003d60"},{"line_number":516,"context_line":"          register: ovs_set_wait_before_clear"},{"line_number":517,"context_line":"          loop: \"{{ groups[\u0027ovn_controller\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0e8e2222_042aae81","line":514,"range":{"start_line":514,"start_character":49,"end_line":514,"end_character":51},"updated":"2022-10-10 14:14:28.000000000","message":"Shouldn\u0027t the be a Heat parameter, I\u0027ve understood that this value could be tweaked by the user depending on his/her need ?","commit_id":"afa4d871fa46fd2caac778ca34127ab0cae435ed"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8175e2896efe3a127e47b3c7f84350f2eb46dc6d","unresolved":true,"context_lines":[{"line_number":516,"context_line":"          register: ovs_set_wait_before_clear"},{"line_number":517,"context_line":"          loop: \"{{ groups[\u0027ovn_controller\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""},{"line_number":518,"context_line":"          delegate_to: \"{{ item }}\""},{"line_number":519,"context_line":"          failed_when: \"\u0027rc\u0027 in ovs_set_wait_before_clear and ovs_set_wait_before_clear.rc !\u003d 0\""},{"line_number":520,"context_line":"        - name: Update ovn_controller."},{"line_number":521,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":522,"context_line":"          tags: ovn"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fab2109_7403d5a5","line":519,"range":{"start_line":519,"start_character":0,"end_line":519,"end_character":21},"updated":"2022-10-10 14:14:28.000000000","message":"Hum, does this work when using a loop of delegation ?","commit_id":"afa4d871fa46fd2caac778ca34127ab0cae435ed"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f3663b7749f45a10b531bde0fcbb7a0ee939be8e","unresolved":true,"context_lines":[{"line_number":111,"context_line":"       Sets the time ovn-controller will wait before clearing all openflows"},{"line_number":112,"context_line":"       rules and installing the new ones."},{"line_number":113,"context_line":"    type: string"},{"line_number":114,"context_line":"    default: \"60\""},{"line_number":115,"context_line":"  OvsHwOffload:"},{"line_number":116,"context_line":"    default: false"},{"line_number":117,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"96a086e3_d4bc0567","line":114,"updated":"2022-11-01 17:31:27.000000000","message":"This value is in ms, and according to the feature commit message and a discussion I had with mmichelson, the value should be on the order of 8000ms.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5031b237e15a527423b692fe6422dfdb43bb41c5","unresolved":true,"context_lines":[{"line_number":285,"context_line":"              action: \u0027append\u0027"},{"line_number":286,"context_line":"              state: []"},{"line_number":287,"context_line":"      config_settings:"},{"line_number":288,"context_line":"        map_merge:"},{"line_number":289,"context_line":"          - get_attr: [RoleParametersValue, value]"},{"line_number":290,"context_line":"          - ovn::southbound::port: {get_param: OVNSouthboundServerPort}"},{"line_number":291,"context_line":"            ovn::controller::ovn_encap_ip:"},{"line_number":292,"context_line":"              str_replace:"},{"line_number":293,"context_line":"                 template:"},{"line_number":294,"context_line":"                   \"%{lookup(\u0027$NETWORK\u0027)}\""},{"line_number":295,"context_line":"                 params:"},{"line_number":296,"context_line":"                   $NETWORK: {get_param: [ServiceNetMap, NeutronTenantNetwork]}"},{"line_number":297,"context_line":"            ovn::controller::ovn_encap_type: {get_param: OVNEncapType}"},{"line_number":298,"context_line":"            ovn::controller::ovn_bridge: {get_param: OVNIntegrationBridge}"},{"line_number":299,"context_line":"            ovn::controller::hostname: \"%{lookup(\u0027fqdn_canonical\u0027)}\""},{"line_number":300,"context_line":"            ovn::controller::ovn_remote_probe_interval: {get_param: OVNRemoteProbeInterval}"},{"line_number":301,"context_line":"            ovn::controller::ovn_openflow_probe_interval: {get_param: OVNOpenflowProbeInterval}"},{"line_number":302,"context_line":"            nova::compute::force_config_drive:"},{"line_number":303,"context_line":"              if:"},{"line_number":304,"context_line":"                - not: {get_param: OVNMetadataEnabled}"},{"line_number":305,"context_line":"                - true"},{"line_number":306,"context_line":"            ovn::controller::ovn_monitor_all: true"},{"line_number":307,"context_line":"            tripleo::profile::base::neutron::agents::ovn::protocol:"},{"line_number":308,"context_line":"              if:"},{"line_number":309,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":310,"context_line":"                - \u0027ssl\u0027"},{"line_number":311,"context_line":"            vswitch::ovs::vlan_limit:"},{"line_number":312,"context_line":"              if:"},{"line_number":313,"context_line":"                - {get_param: EnableVLANTransparency}"},{"line_number":314,"context_line":"                - 0"},{"line_number":315,"context_line":"      service_config_settings: {}"},{"line_number":316,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":317,"context_line":"      puppet_config:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8600456a_e28804b6","line":314,"range":{"start_line":288,"start_character":0,"end_line":314,"end_character":19},"updated":"2022-11-01 14:23:40.000000000","message":"If I\u0027m not mistaken, these values get set here and end up written to the same place in the DB as the proposed ovn-ofctrl-wait-before-clear setting. I think the setting ends up actually being set in puppet-ovn. Is this correct? If so, it seems like we should do the same thing with the new setting?","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":517,"context_line":"            image: {get_param: ContainerOvnControllerConfigImage}"},{"line_number":518,"context_line":"          when: step|int \u003d\u003d 1"},{"line_number":519,"context_line":"          tags: ovn"},{"line_number":520,"context_line":"        - name: Set ovn-ofctrl-wait-before-clear "},{"line_number":521,"context_line":"          when:"},{"line_number":522,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":523,"context_line":"            - \"\u0027results\u0027 in ovs_set_wait_before_clear\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ca8faca9_2c4b9157","line":520,"range":{"start_line":520,"start_character":48,"end_line":520,"end_character":49},"updated":"2022-11-09 13:55:39.000000000","message":"extra white.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":520,"context_line":"        - name: Set ovn-ofctrl-wait-before-clear "},{"line_number":521,"context_line":"          when:"},{"line_number":522,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":523,"context_line":"            - \"\u0027results\u0027 in ovs_set_wait_before_clear\""},{"line_number":524,"context_line":"          tags:"},{"line_number":525,"context_line":"            - ovn"},{"line_number":526,"context_line":"            - ovn_image"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"83e1960c_4fced7f9","line":523,"range":{"start_line":523,"start_character":13,"end_line":523,"end_character":54},"updated":"2022-11-09 13:55:39.000000000","message":"Hum, are you sure that condition belongs here, it looks like it\u0027s defined by the task and will be always false ?","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":523,"context_line":"            - \"\u0027results\u0027 in ovs_set_wait_before_clear\""},{"line_number":524,"context_line":"          tags:"},{"line_number":525,"context_line":"            - ovn"},{"line_number":526,"context_line":"            - ovn_image"},{"line_number":527,"context_line":"          become: true"},{"line_number":528,"context_line":"          vars:"},{"line_number":529,"context_line":"            timeout: {get_param: OvnOfctrlWaitBeforeClear}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7959a2c8_39c0da7a","line":526,"updated":"2022-11-09 13:55:39.000000000","message":"That tag should be removed. It is used to skip force pull of the image (image are forced pulled by default as tag may not change). This tasks shouldn\u0027t be skipped if the image are not forced pulled.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":532,"context_line":"          poll: 0"},{"line_number":533,"context_line":"          register: ovs_set_wait_before_clear"},{"line_number":534,"context_line":"          loop: \"{{ groups[\u0027ovn_controller\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""},{"line_number":535,"context_line":"          delegate_to: \"{{ item }}\""},{"line_number":536,"context_line":"        - name: Was ovn-ofctrl-wait-before-clear ovn setted properly"},{"line_number":537,"context_line":"          when:"},{"line_number":538,"context_line":"            - step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3402bfc2_cfa529b6","line":535,"updated":"2022-11-09 13:55:39.000000000","message":"the delay parameter should be set to 1 for consistency.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":539,"context_line":"            - \"\u0027results\u0027 in ovs_set_wait_before_clear\""},{"line_number":540,"context_line":"          tags:"},{"line_number":541,"context_line":"            - ovn"},{"line_number":542,"context_line":"            - ovn_image"},{"line_number":543,"context_line":"          delegate_to: \"{{ async_result_item.item }}\""},{"line_number":544,"context_line":"          async_status:"},{"line_number":545,"context_line":"            jid: \"{{ async_result_item.ansible_job_id }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f56454c0_2ff5fab5","line":542,"range":{"start_line":542,"start_character":14,"end_line":542,"end_character":23},"updated":"2022-11-09 13:55:39.000000000","message":"tag to be removed.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":540,"context_line":"          tags:"},{"line_number":541,"context_line":"            - ovn"},{"line_number":542,"context_line":"            - ovn_image"},{"line_number":543,"context_line":"          delegate_to: \"{{ async_result_item.item }}\""},{"line_number":544,"context_line":"          async_status:"},{"line_number":545,"context_line":"            jid: \"{{ async_result_item.ansible_job_id }}\""},{"line_number":546,"context_line":"          loop: \"{{ovs_set_wait_before_clear.results }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b1b721ab_cefa7e51","line":543,"range":{"start_line":543,"start_character":23,"end_line":543,"end_character":53},"updated":"2022-11-09 13:55:39.000000000","message":"that should be:\n\n   \"{{ groups[\u0027ovn_controller\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\"\n   \nas async_result_item.item doesn\u0027t look like a list of hosts. Haven\u0027t tested it some maybe there\u0027s a trick.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"91114510a7f663fc70dd625a04e3a0c8f9df41d7","unresolved":true,"context_lines":[{"line_number":556,"context_line":"          become: true"},{"line_number":557,"context_line":"          async: {get_param: OVNControllerUpdateTimeout}"},{"line_number":558,"context_line":"          poll: 0"},{"line_number":559,"context_line":"          loop: \"{{ groups[\u0027ovn_controller\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""},{"line_number":560,"context_line":"          delegate_to: \"{{ item }}\""},{"line_number":561,"context_line":"          register: ovn_controller_update"},{"line_number":562,"context_line":"          tripleo_container_manage:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"159100c9_b2dc9213","line":559,"updated":"2022-11-09 13:55:39.000000000","message":"Those lines should be removed before L557, \"async: ...\" to avoid the extra diff.","commit_id":"c952f26f9e9e802e56c55495a802e1a4d7ee176d"}]}