)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d3da3cd65f2e642d61e0ecf1b86266c615d50c39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"14a73c10_013d12b9","updated":"2022-10-14 06:13:24.000000000","message":"Hmm, seems to be missing a step here:\n```\nThe volume driver requires the iSCSI initiator name in the connector\n```","commit_id":"1f7b32d8348faf6507336b6f958a99dea4339c1c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"cfa74ac6b687ce35f2672a7038889fe10721eb6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0117833d_849df010","updated":"2022-10-11 13:54:14.000000000","message":"recheck","commit_id":"1f7b32d8348faf6507336b6f958a99dea4339c1c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"0c0c3c1faf560e7a5efc00a0f53b7370a84fb7a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"267fa35b_1d267748","updated":"2022-10-12 23:03:41.000000000","message":"recheck","commit_id":"1f7b32d8348faf6507336b6f958a99dea4339c1c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"ab8a8c721763bd6cc8a18a2b3143e57edf9f3a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bae706b0_d46159e7","updated":"2022-10-14 03:25:32.000000000","message":"recheck","commit_id":"1f7b32d8348faf6507336b6f958a99dea4339c1c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"25b04c030b9591b47e1e5a57d056fb36056f6213","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7742c397_d154f870","updated":"2022-10-19 02:02:47.000000000","message":"recheck","commit_id":"26aa1c63adf3f51605899e5a2a7b5fabd8cedec6"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"7260282c62ada8ec1ca4f5869878980c347a2311","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"28f8c6ab_acac870b","updated":"2022-11-02 10:47:42.000000000","message":"Brendan, thanks for this patch, as discussed over mail, I will take it over from here and post further updates.","commit_id":"199d35f8cc9d685dd0d5c8146f7db8fa26c9b637"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"b065ecdd6b11015d1221fbd9918b981d4723c747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2499ddeb_f1451d6a","updated":"2022-10-28 04:49:19.000000000","message":"recheck","commit_id":"199d35f8cc9d685dd0d5c8146f7db8fa26c9b637"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"25cabec1009f062ad7a8b984e5b2a4f12c1abefd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"51c474bc_e387a1bf","updated":"2022-11-10 19:01:41.000000000","message":"This is looking real good, and the CI results (mainly from tripleo-ci-centos-9-scenario001-standalone and tripleo-ci-centos-9-scenario007-multinode-oooq-container) are just what I hope to see.","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bff73c7522a91f054f0d3941b8329c0c30ac6f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3df507ac_a53c5373","updated":"2023-02-16 16:16:13.000000000","message":"I don\u0027t think we need to make this change given Wallaby is the last release, and we don\u0027t need this change there.","commit_id":"be636418e26db4f9f77da7640600601f30921c01"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"79f5e2d07244353c82d9559be2a1e43cff3786d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"17bfb948_7a2b6423","updated":"2023-02-16 17:30:55.000000000","message":"Yeah, that makes sense, this patch can be abandoned.\n\nManoj and I assume the tripleo-ansible patch doesn\u0027t need to be backported, and instead the corresponding role should be updated in the new epmd_ansible repo.","commit_id":"be636418e26db4f9f77da7640600601f30921c01"}],"deployment/iscsid/iscsid-container-ansible.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"25cabec1009f062ad7a8b984e5b2a4f12c1abefd","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"    tags:"},{"line_number":11,"context_line":"      - role_specific"},{"line_number":12,"context_line":"  ContainerIscsidConfigImage:"},{"line_number":13,"context_line":"    description: The container image to use for the iscsid config_volume"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5af9a79c_308586de","line":12,"updated":"2022-11-10 19:01:41.000000000","message":"I don\u0027t know if the tox validations will complain, but we should see if this (plus L89 and L96) can be eliminated.","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"341d1609de3cecf597063e064442156adc159a7e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    type: string"},{"line_number":10,"context_line":"    tags:"},{"line_number":11,"context_line":"      - role_specific"},{"line_number":12,"context_line":"  ContainerIscsidConfigImage:"},{"line_number":13,"context_line":"    description: The container image to use for the iscsid config_volume"},{"line_number":14,"context_line":"    type: string"},{"line_number":15,"context_line":"    tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa514597_b3b3fe62","line":12,"in_reply_to":"5af9a79c_308586de","updated":"2022-11-11 04:21:36.000000000","message":"removed it, tox validation passed.","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"25cabec1009f062ad7a8b984e5b2a4f12c1abefd","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        vars:"},{"line_number":114,"context_line":"          tripleo_iscsid_chap_algs: {get_param: IscsidCHAPAlgorithms}"},{"line_number":115,"context_line":"        when:"},{"line_number":116,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":117,"context_line":"      - name: Run iscsid"},{"line_number":118,"context_line":"        include_role:"},{"line_number":119,"context_line":"          name: tripleo_iscsid"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"51e9f705_a828842f","line":116,"updated":"2022-11-10 19:01:41.000000000","message":"The configure task should be moved up to Step 1, when rest of the services are configured (mainly the puppet stuff).\n\nThis will also help verify the IscsidCHAPAlgorithms are properly handled by the FIPS job, tripleo-ci-centos-9-standalone-fips. That job appears to be completely broken, but the failure occurs in Step 2. If iscsid were configured in Step 1 then we could verify the configuration because it would take place prior to when the jobs fails.\n\n-1 for this, primarily so we can verify the iscsid FIPS configuration even if the job fails.","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"341d1609de3cecf597063e064442156adc159a7e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        vars:"},{"line_number":114,"context_line":"          tripleo_iscsid_chap_algs: {get_param: IscsidCHAPAlgorithms}"},{"line_number":115,"context_line":"        when:"},{"line_number":116,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":117,"context_line":"      - name: Run iscsid"},{"line_number":118,"context_line":"        include_role:"},{"line_number":119,"context_line":"          name: tripleo_iscsid"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9723e221_c35ad078","line":116,"in_reply_to":"51e9f705_a828842f","updated":"2022-11-11 04:21:36.000000000","message":"Done","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"25cabec1009f062ad7a8b984e5b2a4f12c1abefd","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        map_merge:"},{"line_number":125,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":126,"context_line":"          - tripleo_iscsid_image: {get_attr: [RoleParametersValue, value, ContainerIscsidImage]}"},{"line_number":127,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":128,"context_line":"      host_prep_tasks:"},{"line_number":129,"context_line":"        - name: Iscsid install tasks"},{"line_number":130,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ca5330fc_1856056a","line":127,"updated":"2022-11-10 19:01:41.000000000","message":"This line should be removed, because there\u0027s no more puppet_config, kolla_config or docker_config now that everything is handled by the ansible role.","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"341d1609de3cecf597063e064442156adc159a7e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        map_merge:"},{"line_number":125,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":126,"context_line":"          - tripleo_iscsid_image: {get_attr: [RoleParametersValue, value, ContainerIscsidImage]}"},{"line_number":127,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":128,"context_line":"      host_prep_tasks:"},{"line_number":129,"context_line":"        - name: Iscsid install tasks"},{"line_number":130,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"55260a96_0cc80f41","line":127,"in_reply_to":"ca5330fc_1856056a","updated":"2022-11-11 04:21:36.000000000","message":"Done","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"25cabec1009f062ad7a8b984e5b2a4f12c1abefd","unresolved":true,"context_lines":[{"line_number":130,"context_line":"          include_role:"},{"line_number":131,"context_line":"            name: tripleo_iscsid"},{"line_number":132,"context_line":"            tasks_from: install.yml"},{"line_number":133,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4e6aadfc_b0ee0a27","line":133,"updated":"2022-11-10 19:01:41.000000000","message":"Is this required, or can it be removed?","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"341d1609de3cecf597063e064442156adc159a7e","unresolved":true,"context_lines":[{"line_number":130,"context_line":"          include_role:"},{"line_number":131,"context_line":"            name: tripleo_iscsid"},{"line_number":132,"context_line":"            tasks_from: install.yml"},{"line_number":133,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"61287039_1d4ba188","line":133,"in_reply_to":"4e6aadfc_b0ee0a27","updated":"2022-11-11 04:21:36.000000000","message":"I think we shouldn\u0027t remove this, as the documentation [1] says --\n\"upgrade_tasks: These are ansible tasks that run when TripleO is running an upgrade with your service enabled. If you don’t have any upgrade tasks to do, you still have to specify this output, but it’s enough to set it as an empty list.\"\n\n[1] https://docs.openstack.org/tripleo-docs/latest/developer/tht_walkthrough/service_template_sections.html#pre-deploy-step-tasks-or-pre-deploy-step-tasks","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9b2c0d272ad966953820a2a2c04670ee56f04221","unresolved":false,"context_lines":[{"line_number":130,"context_line":"          include_role:"},{"line_number":131,"context_line":"            name: tripleo_iscsid"},{"line_number":132,"context_line":"            tasks_from: install.yml"},{"line_number":133,"context_line":"      upgrade_tasks: []"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6bfd15c2_dcf7af0d","line":133,"in_reply_to":"61287039_1d4ba188","updated":"2022-11-29 20:46:30.000000000","message":"Ack","commit_id":"bce1070a4a179a53ecf3fa3c1d4394927e4f9ebc"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9b2c0d272ad966953820a2a2c04670ee56f04221","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    default: \u0027SHA3-256,SHA256,SHA1,MD5\u0027"},{"line_number":65,"context_line":"    description: A comma separated list of algorithms to be used for the CHAP"},{"line_number":66,"context_line":"                 algorithm."},{"line_number":67,"context_line":"    type: string"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"resources:"},{"line_number":70,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bd2c7e2c_30af4a3b","line":67,"updated":"2022-11-29 20:46:30.000000000","message":"I realize the original (now deprecated) file also lists this as a string, but it really should be a comma_delimited_list.\n\nMight as well fix this now, as the patch is in merge conflict and needs to be rebased.","commit_id":"9c048fca45f6237a836a6ca88af389dd26a4fd4a"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"e720639db8509e19c277fd4a3b35c2439d263381","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    default: \u0027SHA3-256,SHA256,SHA1,MD5\u0027"},{"line_number":65,"context_line":"    description: A comma separated list of algorithms to be used for the CHAP"},{"line_number":66,"context_line":"                 algorithm."},{"line_number":67,"context_line":"    type: string"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"resources:"},{"line_number":70,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4e935acd_2e9077a3","line":67,"in_reply_to":"b6f648a2_8c373338","updated":"2022-12-13 16:58:03.000000000","message":"Done, Learnt a new thing!","commit_id":"9c048fca45f6237a836a6ca88af389dd26a4fd4a"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"1bb60c32f95e37b733594e4191667945cde167bd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    default: \u0027SHA3-256,SHA256,SHA1,MD5\u0027"},{"line_number":65,"context_line":"    description: A comma separated list of algorithms to be used for the CHAP"},{"line_number":66,"context_line":"                 algorithm."},{"line_number":67,"context_line":"    type: string"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"resources:"},{"line_number":70,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"da72c8c4_e4adbd44","line":67,"in_reply_to":"bd2c7e2c_30af4a3b","updated":"2022-12-13 09:16:37.000000000","message":"Done","commit_id":"9c048fca45f6237a836a6ca88af389dd26a4fd4a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"700144556f48ae773873d370970ab91d3a974d7a","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    default: \u0027SHA3-256,SHA256,SHA1,MD5\u0027"},{"line_number":65,"context_line":"    description: A comma separated list of algorithms to be used for the CHAP"},{"line_number":66,"context_line":"                 algorithm."},{"line_number":67,"context_line":"    type: string"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"resources:"},{"line_number":70,"context_line":"  ContainersCommon:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b6f648a2_8c373338","line":67,"in_reply_to":"da72c8c4_e4adbd44","updated":"2022-12-13 16:26:30.000000000","message":"Argh, so it looks like it will not be possible to change the type due to the presence of the deprecated template. The types must match in every template that references a parameter. I think you\u0027ll need to revert this back to a string, so it matches the original deprecated parameter.","commit_id":"9c048fca45f6237a836a6ca88af389dd26a4fd4a"}],"deployment/iscsid/iscsid-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0cc49b92fe140b4af6b2597ebc781ef5afef834","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8c48f1f9_39e8b910","updated":"2022-11-09 11:26:42.000000000","message":"This file should be renamed to iscsid-container-ansible.yaml, and a copy of the original one added to the deployment/deprecated directory.","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6e8ea587c7253580a0dbe91196bf08c51ea98a5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd8b33ec_f80f9332","in_reply_to":"8c48f1f9_39e8b910","updated":"2022-11-09 18:13:34.000000000","message":"Done","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0cc49b92fe140b4af6b2597ebc781ef5afef834","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    description: Role data for the Iscsid role."},{"line_number":101,"context_line":"    value:"},{"line_number":102,"context_line":"      service_name: iscsid"},{"line_number":103,"context_line":"      config_settings: {}"},{"line_number":104,"context_line":"      service_config_settings: {}"},{"line_number":105,"context_line":"      deploy_steps_tasks:"},{"line_number":106,"context_line":"      - name: Run lvmfilter role"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c4041c40_c6dcd4fe","line":103,"updated":"2022-11-09 11:26:42.000000000","message":"See my comment at L124. However, I think the \"tox -e pep8\" validations require every service has a config_settings section, even if it\u0027s empty like this one. So you may not be able to delete this line. Not sure about service_config_settings at L104.","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6e8ea587c7253580a0dbe91196bf08c51ea98a5e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    description: Role data for the Iscsid role."},{"line_number":101,"context_line":"    value:"},{"line_number":102,"context_line":"      service_name: iscsid"},{"line_number":103,"context_line":"      config_settings: {}"},{"line_number":104,"context_line":"      service_config_settings: {}"},{"line_number":105,"context_line":"      deploy_steps_tasks:"},{"line_number":106,"context_line":"      - name: Run lvmfilter role"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b6bb7d4a_ae7d7cde","line":103,"in_reply_to":"c4041c40_c6dcd4fe","updated":"2022-11-09 18:13:34.000000000","message":"pep8 validation check passed, removed config_settings and service_config_settings.","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0cc49b92fe140b4af6b2597ebc781ef5afef834","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        when:"},{"line_number":110,"context_line":"        - step|int \u003d\u003d 1"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"      - name: Iscsid role"},{"line_number":113,"context_line":"        include_role:"},{"line_number":114,"context_line":"          name: tripleo_iscsid"},{"line_number":115,"context_line":"          tasks_from: run.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"03c7a51b_92c6d7b8","line":112,"updated":"2022-11-09 11:26:42.000000000","message":"If L130 (\"Configure iscsid\") precedes this task, then perhaps a better task name here would be \"Run iscsid\"","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6e8ea587c7253580a0dbe91196bf08c51ea98a5e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        when:"},{"line_number":110,"context_line":"        - step|int \u003d\u003d 1"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"      - name: Iscsid role"},{"line_number":113,"context_line":"        include_role:"},{"line_number":114,"context_line":"          name: tripleo_iscsid"},{"line_number":115,"context_line":"          tasks_from: run.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"94845bd0_612c6c33","line":112,"in_reply_to":"03c7a51b_92c6d7b8","updated":"2022-11-09 18:13:34.000000000","message":"Done","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0cc49b92fe140b4af6b2597ebc781ef5afef834","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        when:"},{"line_number":117,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":118,"context_line":"      ansible_group_vars:"},{"line_number":119,"context_line":"        tripleo_iscsid_chap_algs: {get_param: IscsidCHAPAlgorithms}"},{"line_number":120,"context_line":"        map_merge:"},{"line_number":121,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":122,"context_line":"          - tripleo_iscsid_image: {get_attr: [RoleParametersValue, value, ContainerIscsidImage]}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9acde7dd_3fd45a95","line":119,"updated":"2022-11-09 11:26:42.000000000","message":"This line is in the wrong spot. If it actually is needed as a group var then the line should be moved down after L122.\n\nBut, the variable is needed only to configure iscsid, and so it should be supplied to only the task that configures the service. The stuff at L130 (which needs to be moved to the deploy_steps_tasks) would look like this:\n\n        - name: Configure iscsid\n          include_role:\n            name: tripleo_iscsid\n            tasks_from: configure.yml\n          vars:\n            tripleo_iscsid_chap_algs: {get_param: IscsidCHAPAlgorithms}","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6e8ea587c7253580a0dbe91196bf08c51ea98a5e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        when:"},{"line_number":117,"context_line":"          - step|int \u003d\u003d 3"},{"line_number":118,"context_line":"      ansible_group_vars:"},{"line_number":119,"context_line":"        tripleo_iscsid_chap_algs: {get_param: IscsidCHAPAlgorithms}"},{"line_number":120,"context_line":"        map_merge:"},{"line_number":121,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":122,"context_line":"          - tripleo_iscsid_image: {get_attr: [RoleParametersValue, value, ContainerIscsidImage]}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"971379f1_c3ad49cf","line":119,"in_reply_to":"9acde7dd_3fd45a95","updated":"2022-11-09 18:13:34.000000000","message":"Done","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0cc49b92fe140b4af6b2597ebc781ef5afef834","unresolved":true,"context_lines":[{"line_number":121,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":122,"context_line":"          - tripleo_iscsid_image: {get_attr: [RoleParametersValue, value, ContainerIscsidImage]}"},{"line_number":123,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":124,"context_line":"      puppet_config: {}"},{"line_number":125,"context_line":"      host_prep_tasks:"},{"line_number":126,"context_line":"        - name: Iscsid install tasks"},{"line_number":127,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8a57a600_d587d9c9","line":124,"updated":"2022-11-09 11:26:42.000000000","message":"I think this line can be completely eliminated. You can test this by running \"tox -e pep\" to run the validation checks, and if it passes then you don\u0027t need this line.","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6e8ea587c7253580a0dbe91196bf08c51ea98a5e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"          - {get_attr: [RoleParametersValue, value]}"},{"line_number":122,"context_line":"          - tripleo_iscsid_image: {get_attr: [RoleParametersValue, value, ContainerIscsidImage]}"},{"line_number":123,"context_line":"      # BEGIN DOCKER SETTINGS"},{"line_number":124,"context_line":"      puppet_config: {}"},{"line_number":125,"context_line":"      host_prep_tasks:"},{"line_number":126,"context_line":"        - name: Iscsid install tasks"},{"line_number":127,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a6a7825_5edd9fe2","line":124,"in_reply_to":"8a57a600_d587d9c9","updated":"2022-11-09 18:13:34.000000000","message":"pep8 validation check passed, removed the line.","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f0cc49b92fe140b4af6b2597ebc781ef5afef834","unresolved":true,"context_lines":[{"line_number":127,"context_line":"          include_role:"},{"line_number":128,"context_line":"            name: tripleo_iscsid"},{"line_number":129,"context_line":"            tasks_from: install.yml"},{"line_number":130,"context_line":"        - name: Configure iscsid"},{"line_number":131,"context_line":"          include_role:"},{"line_number":132,"context_line":"            name: tripleo_iscsid"},{"line_number":133,"context_line":"            tasks_from: configure.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"36e1926c_eb753b13","line":130,"updated":"2022-11-09 11:26:42.000000000","message":"This should be in the deploy_steps tasks, just prior to the one at L112 (which runs it).","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6e8ea587c7253580a0dbe91196bf08c51ea98a5e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"          include_role:"},{"line_number":128,"context_line":"            name: tripleo_iscsid"},{"line_number":129,"context_line":"            tasks_from: install.yml"},{"line_number":130,"context_line":"        - name: Configure iscsid"},{"line_number":131,"context_line":"          include_role:"},{"line_number":132,"context_line":"            name: tripleo_iscsid"},{"line_number":133,"context_line":"            tasks_from: configure.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"48429775_0994cf6e","line":130,"in_reply_to":"36e1926c_eb753b13","updated":"2022-11-09 18:13:34.000000000","message":"Done","commit_id":"759e611e9e697e86021e2187a3fb7430cd31b9d9"}]}