)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b0be07333c79d2d5edf1249cdc71cefcd308e1c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92babc51_5b81250c","updated":"2022-10-26 04:37:01.000000000","message":"I agree that this does not change the current behavior wrt to the default for DeployedSever[1]. If required we should document that for air-gaped deployments EnablePackageInstall should be set to false.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/environments/deployed-server-environment.j2.yaml#L5","commit_id":"00a774f4f7161e48c50f2bd80016924f52d65732"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e8c98767e1bdbc3bfb7bb570f58d52185de554d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bfeb4777_67727d5f","updated":"2022-10-20 14:48:35.000000000","message":"would this work for air-gaped deployments?","commit_id":"00a774f4f7161e48c50f2bd80016924f52d65732"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"68cbb3ec8526cd6d2b7fa50dafd7fe102e318eb2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3795d20_6d2fa596","in_reply_to":"2dfc2058_06335ce7","updated":"2022-10-24 14:25:56.000000000","message":"This change does not change the behavior. We\u0027ve already enabled package installation in overcloud deployment process by [1].\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/861134\n\nAFAIK puppet and ansible should skip package installation if the package is already installed. AFAIK some CI jobs we have in downstream does not set up repos in overcloud but deployment succeeds as long as overcloud-images-full is used.","commit_id":"00a774f4f7161e48c50f2bd80016924f52d65732"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"6ca82e4167583753b1387d5cfb4bf78e9eb095d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6be81d3_f0da3d78","in_reply_to":"b3795d20_6d2fa596","updated":"2022-10-24 18:55:39.000000000","message":"that\u0027s a link to this same patch?\n\neverything should be installed, yes, but ensure\u003d\u003elatest will still check repos. I just want to be sure before we merege this one.","commit_id":"00a774f4f7161e48c50f2bd80016924f52d65732"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bf7200949890620e72ccd86a151acc25529b7732","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2dfc2058_06335ce7","in_reply_to":"bfeb4777_67727d5f","updated":"2022-10-21 18:59:46.000000000","message":"I have the same concern. puppet/ansible will both try to update packages during a deployment if they\u0027ve been asked to ensure the latest.\n\nthe difference with using pre-provisioned nodes that are not provisioned from overcloud-full is that we explicitly doc that you must enable repos on the nodes.\n\nwe need to make sure that this change doesn\u0027t add the same requirement when using overcloud-full.","commit_id":"00a774f4f7161e48c50f2bd80016924f52d65732"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"91ecce7400d4acafcad732d62b96a8aebd614413","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dcc4c1d5_fbe11317","in_reply_to":"e6be81d3_f0da3d78","updated":"2022-10-25 04:24:57.000000000","message":"Sorry I meant this one https://review.opendev.org/c/openstack/python-tripleoclient/+/758002 .\n\nAFAIK we generally use ensure \u003d\u003e present (in puppet modules and ansible tasks as far as I\u0027m aware of) to avoid updating the package.","commit_id":"00a774f4f7161e48c50f2bd80016924f52d65732"}]}