)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"acb92fe1420d73ae41213854f3c663500cd41cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a98264c_c1446afc","updated":"2022-10-18 08:41:10.000000000","message":"I think we need to remove the env for undercloud. https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/tripleo_deploy.py#L554","commit_id":"7f959b320b48dac6df96def6f91c42f1563d7afb"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"91765ec1aebf167351b05e3aa07d3b537655807c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43861998_d8f8cdf2","updated":"2022-10-30 01:36:28.000000000","message":"recheck POST_FAILURE collect logs","commit_id":"b6b38bce0f371434550a70ecb8a14120e8d0f14c"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"79ff382d69ef574a90f4424cf2230a81e839a4b1","unresolved":true,"context_lines":[{"line_number":33,"context_line":"{%- endfor %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  OS::TripleO::Server: deployed-server/deployed-server.yaml"},{"line_number":36,"context_line":"  OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port"},{"line_number":37,"context_line":"{% for role in roles %}"},{"line_number":38,"context_line":"  OS::TripleO::{{role.name}}Server: OS::TripleO::Server"},{"line_number":39,"context_line":"{% endfor %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e1751937_60b53437","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":66},"updated":"2022-10-18 06:21:58.000000000","message":"I don\u0027t think this is correct. We should map it to deployed-server/deployed-neutron-port.yaml by default. \n\nThis was wrongly mapped to OS::Neutron::Port by default.","commit_id":"f612748598363e0a7ac6ca457704cb9df7a40e5a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"526228d18564b0902f15c9a36ceff87a6238f4fd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{%- endfor %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  OS::TripleO::Server: deployed-server/deployed-server.yaml"},{"line_number":36,"context_line":"  OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port"},{"line_number":37,"context_line":"{% for role in roles %}"},{"line_number":38,"context_line":"  OS::TripleO::{{role.name}}Server: OS::TripleO::Server"},{"line_number":39,"context_line":"{% endfor %}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b9e4d25d_9ac25df6","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":66},"in_reply_to":"e1751937_60b53437","updated":"2022-10-18 06:55:32.000000000","message":"Ah, good catch. Because we use the pre-provisioned nodes, it makes more sense to use pre-privision ctlplane ports .","commit_id":"f612748598363e0a7ac6ca457704cb9df7a40e5a"}],"overcloud.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c9fc24b8422ba1e1de6d04fc5fcc69c3175adc1c","unresolved":true,"context_lines":[{"line_number":213,"context_line":"  {{role.name}}NetworkConfigTemplate:"},{"line_number":214,"context_line":"    description: {{role.name}} NetworkConfig Template"},{"line_number":215,"context_line":"    type: string"},{"line_number":216,"context_line":"    default: \u0027templates/net_config_static_bridge.j2\u0027"},{"line_number":217,"context_line":"  {{role.name}}ExtraConfig:"},{"line_number":218,"context_line":"    default: {}"},{"line_number":219,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9c5f90e1_af8f6ba2","line":216,"range":{"start_line":216,"start_character":14,"end_line":216,"end_character":51},"updated":"2022-10-20 07:29:42.000000000","message":"We changed this default and don\u0027t mention about it in the commit message.","commit_id":"b6b38bce0f371434550a70ecb8a14120e8d0f14c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c7e024d790b9a484a668b129c88164e5fa4eb3cf","unresolved":false,"context_lines":[{"line_number":213,"context_line":"  {{role.name}}NetworkConfigTemplate:"},{"line_number":214,"context_line":"    description: {{role.name}} NetworkConfig Template"},{"line_number":215,"context_line":"    type: string"},{"line_number":216,"context_line":"    default: \u0027templates/net_config_static_bridge.j2\u0027"},{"line_number":217,"context_line":"  {{role.name}}ExtraConfig:"},{"line_number":218,"context_line":"    default: {}"},{"line_number":219,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e0f465f0_815f58da","line":216,"range":{"start_line":216,"start_character":14,"end_line":216,"end_character":51},"in_reply_to":"5699be26_62be8844","updated":"2022-10-20 14:46:08.000000000","message":"Done","commit_id":"b6b38bce0f371434550a70ecb8a14120e8d0f14c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"05f7ba2c9e173a09b0a96868c3d7f1c65c548c00","unresolved":true,"context_lines":[{"line_number":213,"context_line":"  {{role.name}}NetworkConfigTemplate:"},{"line_number":214,"context_line":"    description: {{role.name}} NetworkConfig Template"},{"line_number":215,"context_line":"    type: string"},{"line_number":216,"context_line":"    default: \u0027templates/net_config_static_bridge.j2\u0027"},{"line_number":217,"context_line":"  {{role.name}}ExtraConfig:"},{"line_number":218,"context_line":"    default: {}"},{"line_number":219,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5699be26_62be8844","line":216,"range":{"start_line":216,"start_character":14,"end_line":216,"end_character":51},"in_reply_to":"9c5f90e1_af8f6ba2","updated":"2022-10-20 09:17:56.000000000","message":"In short, this does not cause any change from user\u0027s PoV.\n\n- for overcloud, we consistently used templates/net_config_static_bridge.j2 when pre-provisioned nodes are used (according to the override in deployed-server-envionment.j2.yaml)\n- for standalone and undercloud, we have explicit override in the environment files so change of the underlying default does not surface.\n\nI initially considered adding a release note but this internal default is not really used so I omitted it.","commit_id":"b6b38bce0f371434550a70ecb8a14120e8d0f14c"}]}