)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbf9a8a79a348c12cc1009d1c7c8d36036e9bb14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a153b773_3f319955","updated":"2022-10-30 07:15:26.000000000","message":"recheck\n\nthe dependent change is being merged","commit_id":"b82f8b415e4d785ce1a8d2c0fa45a25f31148509"}],"environments/deployed-server-deployed-neutron-ports.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e3e14b0bbb9e5736ed142a1c363cb1e94b2051d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# ******************************************************************************"},{"line_number":2,"context_line":"# DEPRECATED: The environment"},{"line_number":3,"context_line":"# environments/deployed-server-deployed-neutron-ports.yaml, the"},{"line_number":4,"context_line":"# deployed-neutron-port.yaml template, and DeployedServerPortMap parameter are"},{"line_number":5,"context_line":"# deprecated in favor of NodePortMap, ControlPlaneVipData, and VipPortMap,"},{"line_number":6,"context_line":"# which can be used with the generated environments/deployed-ports.yaml"},{"line_number":7,"context_line":"# ******************************************************************************"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"29e939e1_6c10ea95","side":"PARENT","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":64},"updated":"2022-10-28 08:03:58.000000000","message":"We really need to reconsider this. Current implementation in all tripleo repos still heavily depends on DeployedServerPortMap and deployed-neutron-port.yaml and cause deprecation warning always unless users generate their own environment file manually in a new format and override resources.\n\nIf we pursue this then we need to update the logic in tripleo-ansible and tripleo-client to use the new resource and the new parameters, but I\u0027m not sure whether we should make that change in Zed.","commit_id":"b6b38bce0f371434550a70ecb8a14120e8d0f14c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1182b300287d35d18ce8e8add688c15ddbf9a703","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# ******************************************************************************"},{"line_number":2,"context_line":"# DEPRECATED: The environment"},{"line_number":3,"context_line":"# environments/deployed-server-deployed-neutron-ports.yaml, the"},{"line_number":4,"context_line":"# deployed-neutron-port.yaml template, and DeployedServerPortMap parameter are"},{"line_number":5,"context_line":"# deprecated in favor of NodePortMap, ControlPlaneVipData, and VipPortMap,"},{"line_number":6,"context_line":"# which can be used with the generated environments/deployed-ports.yaml"},{"line_number":7,"context_line":"# ******************************************************************************"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4ee37b7a_5922db71","side":"PARENT","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":64},"in_reply_to":"29e939e1_6c10ea95","updated":"2022-10-28 08:42:34.000000000","message":"Nevermind. vip provision generates the parameter according to the new format it seems.\n\nWhat we still need to fix are \n - standalone/undercloud, to use the deployed_vip_ctlplane.yaml file\n - the baremetal_deploy module to use \u003cnetwork\u003eDeployedPort\n but these do not block this change.","commit_id":"b6b38bce0f371434550a70ecb8a14120e8d0f14c"}],"overcloud-resource-registry-puppet.j2.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3cb88fb0bb375a183a4b941144bf2166ed23b189","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: network/ports/noop.yaml"},{"line_number":76,"context_line":"  {%- endfor %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: network/ports/noop.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  # Service to network Mappings"},{"line_number":81,"context_line":"  OS::TripleO::ServiceNetMap: network/service_net_map.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"182e4885_410bb51b","line":78,"range":{"start_line":78,"start_character":1,"end_line":78,"end_character":75},"updated":"2022-10-28 04:52:53.000000000","message":"I think this should map to ../deployed-server/deployed-neutron-port.yaml as in https://github.com/openstack/tripleo-heat-templates/blob/master/environments/deployed-server-deployed-neutron-ports.yaml#L9.","commit_id":"4e30911b628c05cb806551647eadd0b40284eba0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e4e623e4766ec98507a963b75eb440fbd8d7fb48","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: network/ports/noop.yaml"},{"line_number":76,"context_line":"  {%- endfor %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: network/ports/noop.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  # Service to network Mappings"},{"line_number":81,"context_line":"  OS::TripleO::ServiceNetMap: network/service_net_map.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d69fd89_535d85f2","line":78,"range":{"start_line":78,"start_character":1,"end_line":78,"end_character":75},"in_reply_to":"182e4885_410bb51b","updated":"2022-10-28 08:01:59.000000000","message":"Done","commit_id":"4e30911b628c05cb806551647eadd0b40284eba0"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"54158fbb96850cd37ff928b00b441ac1d051928c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: network/ports/noop.yaml"},{"line_number":76,"context_line":"  {%- endfor %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: network/ports/noop.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  # Service to network Mappings"},{"line_number":81,"context_line":"  OS::TripleO::ServiceNetMap: network/service_net_map.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8d514f18_cbcbff59","line":78,"range":{"start_line":78,"start_character":1,"end_line":78,"end_character":75},"in_reply_to":"1d69fd89_535d85f2","updated":"2022-10-28 08:19:33.000000000","message":"Sorry, on second thought I think it would be better to use https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/network/ports/deployed_vip_ctlplane.yaml as in [1] as the default.\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/environments/deployed-network-environment.j2.yaml#L16","commit_id":"4e30911b628c05cb806551647eadd0b40284eba0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1182b300287d35d18ce8e8add688c15ddbf9a703","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  OS::TripleO::Network::Ports::{{network.name}}VipPort: network/ports/noop.yaml"},{"line_number":76,"context_line":"  {%- endfor %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  OS::TripleO::Network::Ports::ControlPlaneVipPort: network/ports/noop.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  # Service to network Mappings"},{"line_number":81,"context_line":"  OS::TripleO::ServiceNetMap: network/service_net_map.yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"534e8104_4972e76f","line":78,"range":{"start_line":78,"start_character":1,"end_line":78,"end_character":75},"in_reply_to":"8d514f18_cbcbff59","updated":"2022-10-28 08:42:34.000000000","message":"Yeah that one is better. Updated the change to use deployed_vip_ctlplane.yaml","commit_id":"4e30911b628c05cb806551647eadd0b40284eba0"}]}