)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"37ff01b4b00738f6568238bcd2a7693b13ecdea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7246a78b_f92b5a65","updated":"2022-11-01 20:45:08.000000000","message":"LGTM. Thanks Alan. I can re-review when WIP is ready to be removed.","commit_id":"9d22735ddc76080c9914a488b74403df61571db5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b077d6602ffc7340ea9c3d99a9c6e07a0681e3f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c0219b1_d76ff5f2","updated":"2022-11-02 18:09:02.000000000","message":"The zuul results look good, here are some observations from the tripleo-ci-centos-9-scenario001-standalone job.\n\n[1] shows glance\u0027s new api_internal.log file\n[2] shows both glance_api and glance_api_internal containers\n[3] shows nova\u0027s [glance]valid_interfaces option is set to \u0027internal\u0027\n[4] shows cinder\u0027s glance_api_servers is using the internal service on port 9293\n\n[1] https://19cf9bba29f554d23468-8178b0cd40c1a7a00b8d9de8255e73af.ssl.cf5.rackcdn.com/863142/2/check/tripleo-ci-centos-9-scenario001-standalone/70e89b7/logs/undercloud/var/log/containers/glance/index.html\n[2] https://19cf9bba29f554d23468-8178b0cd40c1a7a00b8d9de8255e73af.ssl.cf5.rackcdn.com/863142/2/check/tripleo-ci-centos-9-scenario001-standalone/70e89b7/logs/undercloud/var/log/extra/podman/containers/index.html\n[3] https://19cf9bba29f554d23468-8178b0cd40c1a7a00b8d9de8255e73af.ssl.cf5.rackcdn.com/863142/2/check/tripleo-ci-centos-9-scenario001-standalone/70e89b7/logs/undercloud/var/lib/config-data/puppet-generated/nova/etc/nova/nova.conf\n[4] https://19cf9bba29f554d23468-8178b0cd40c1a7a00b8d9de8255e73af.ssl.cf5.rackcdn.com/863142/2/check/tripleo-ci-centos-9-scenario001-standalone/70e89b7/logs/undercloud/var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf\n\nHere\u0027s the diff of the glance-api.conf file for glance_api [5] versus glance_api_internal [6] services:\n\n% diff glance-api.conf glance-api_internal.conf \n262c262\n\u003c show_image_direct_url\u003dFalse\n---\n\u003e show_image_direct_url\u003dTrue\n305c305\n\u003c show_multiple_locations\u003dFalse\n---\n\u003e show_multiple_locations\u003dTrue\n667c667\n\u003c bind_port\u003d9292\n---\n\u003e bind_port\u003d9293\n1111c1111\n\u003c log_file\u003d/var/log/glance/api.log\n---\n\u003e log_file\u003d/var/log/glance/api_internal.log\n\n[5] https://19cf9bba29f554d23468-8178b0cd40c1a7a00b8d9de8255e73af.ssl.cf5.rackcdn.com/863142/2/check/tripleo-ci-centos-9-scenario001-standalone/70e89b7/logs/undercloud/var/lib/config-data/puppet-generated/glance_api/etc/glance/glance-api.conf\n[6] https://19cf9bba29f554d23468-8178b0cd40c1a7a00b8d9de8255e73af.ssl.cf5.rackcdn.com/863142/2/check/tripleo-ci-centos-9-scenario001-standalone/70e89b7/logs/undercloud/var/lib/config-data/puppet-generated/glance_api_internal/etc/glance/glance-api.conf","commit_id":"9d22735ddc76080c9914a488b74403df61571db5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"91fe1009e25a44f9163df9fc5cd5bbe525b47036","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2447dc8_0b2aba66","updated":"2022-11-02 03:45:00.000000000","message":"recheck\n\nseveral RETRY_LIMIT","commit_id":"9d22735ddc76080c9914a488b74403df61571db5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"15d6bdb93526dce8c2db540ed7c268d7189e5fd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09950f67_1b6c00f4","updated":"2022-11-16 20:03:59.000000000","message":"Holding this until I resolve a question that just came up.","commit_id":"93d5ebab53c3869dd6887b79756ac0a3861f2bf3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b8414d5c5e5c44c02b95d33bccf49b9d035d8e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09863dcb_026ca12b","updated":"2022-11-11 12:43:47.000000000","message":"LGTM but the deprecation of a removed parameter concern","commit_id":"93d5ebab53c3869dd6887b79756ac0a3861f2bf3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c4f7a112cd963fc6502ba4a3d625d996ca5502bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6719e5e5_18430034","updated":"2022-11-24 16:47:57.000000000","message":"recheck\n\ntripleo-ci-centos-9-content-provider-zed failure","commit_id":"a5a423aeab5f7fd591948c17249304e10abaabe4"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a9ee45d1c47b910efe76e4f71d3433c7e82722b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f94d5fa3_97d1e8a7","updated":"2022-11-23 04:36:57.000000000","message":"recheck\n\ntripleo-ci-centos-9-content-provider-zed failure","commit_id":"a5a423aeab5f7fd591948c17249304e10abaabe4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"12e39f3b0581c49921d182b34aefbfe6658067c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1948d149_bb4e564f","updated":"2022-11-28 15:21:20.000000000","message":"(I see this is being merged. I won\u0027t block this bug am just dumping a note here just in case this sounds interesting)\n\nAlternatively we can create a separate config file (eg. glance-api-internal.conf) which contains only the option we want to override and use that file to launch the service for internal api.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0ee68929ed86b75b30579376eb41bfb72d318f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f6f74040_30d7964a","updated":"2022-11-25 04:54:15.000000000","message":"This is ready for review, and is tracked for inclusion in downstream RHOSP as soon as possible, thanks!","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"379f3d808f9993a87d205637c332de6bbefb1eab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a34a07a3_e73fa187","in_reply_to":"05c62841_82c72381","updated":"2022-11-28 15:44:06.000000000","message":"I believe the approach with the separate file is easier for backport. With the approach we can use the shared config directory and does not need the additional service in roles data.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"afe3fdee4b976f9ef53eaa908c5b059f44f42cbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"05c62841_82c72381","in_reply_to":"1948d149_bb4e564f","updated":"2022-11-28 15:35:21.000000000","message":"I considered that approach but judged it more complex to implement, especially in light of the anticipated need to backport it all.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9f6b969951d93815efea7bcbbfece25d71bb6f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5ade2f4_e897a367","in_reply_to":"283af9cd_4cc73b9b","updated":"2022-11-28 16:15:24.000000000","message":"\u003e We can continue with this, but would need to consider adding update tasks to ensure the glance_api_internal service is enabled if glance_api service is enabled, as a safe guard.\n\nI\u0027m not concerned with major upgrade because users always need to regenerate roles, otherwise they can face different issues. So I don\u0027t think we require this in the change for master.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"298813beeeba4011c644df5558949937ab8f1445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"abf669da_91b7bcb8","in_reply_to":"30985e83_314dd67e","updated":"2022-11-29 21:26:54.000000000","message":"See https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866075","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"46b1d41c8f58e4891ff1dcbc1f18627ec7f6216e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7d2848e4_300bbd8a","in_reply_to":"366118c7_a1d1dab6","updated":"2022-11-28 16:01:24.000000000","message":"Let\u0027s not reinvent a working solution unless there\u0027s a compelling reason. I\u0027ve successfully tested trial backports all the way back to train, including deployments with tls-e and DCN deployments.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cea051a18a1280e30a7457793463a13dc0318408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"283af9cd_4cc73b9b","in_reply_to":"7d2848e4_300bbd8a","updated":"2022-11-28 16:13:34.000000000","message":"Reducing upgrade impact can be a reason, IMO. In case users do not update roles data during minor update, which we don\u0027t usually require, then they end up with incomplete glance services after upgrade. That\u0027s the main concern I have if we backport this to stable branches.\n\nWe can continue with this, but would need to consider adding update tasks to ensure the glance_api_internal service is enabled if glance_api service is enabled, as a safe guard.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ad070d0c2a6fb3894e9aebf0f603eb7bb3ea0844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"366118c7_a1d1dab6","in_reply_to":"a34a07a3_e73fa187","updated":"2022-11-28 15:53:47.000000000","message":"Hmm. I noticed we can\u0027t use this approach because of tls proxy ... I\u0027ll consider how we can complete that approach separately but at this moment I don\u0027t have clear ETA. so I\u0027m good with merging this approach now (as I said I won\u0027t block this change now but we should be quite careful about backporting this)","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a72e1b260581fdb771910d320e34e76877b87e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"30985e83_314dd67e","in_reply_to":"a5ade2f4_e897a367","updated":"2022-11-28 16:21:28.000000000","message":"Adding something to tge update_tasks is a great idea, I\u0027ll pursue a follow-up patch.","commit_id":"d60969cb55344e9004721dee04ed1d685d95a39f"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"  # DEPRECATED: the following options are deprecated and are currently maintained"},{"line_number":366,"context_line":"  # for backwards compatibility. They will be removed in future release."},{"line_number":367,"context_line":"  GlanceShowMultipleLocations:"},{"line_number":368,"context_line":"    default: false"},{"line_number":369,"context_line":"    description: |"},{"line_number":370,"context_line":"      Whether to show multiple image locations e.g for copy-on-write support on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6b8a30ed_bc3c8318","line":367,"range":{"start_line":367,"start_character":2,"end_line":367,"end_character":29},"updated":"2022-11-01 19:39:49.000000000","message":"OK, so this file is updated to deprecate GlanceShowMultipleLocations.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"  # DEPRECATED: the following options are deprecated and are currently maintained"},{"line_number":366,"context_line":"  # for backwards compatibility. They will be removed in future release."},{"line_number":367,"context_line":"  GlanceShowMultipleLocations:"},{"line_number":368,"context_line":"    default: false"},{"line_number":369,"context_line":"    description: |"},{"line_number":370,"context_line":"      Whether to show multiple image locations e.g for copy-on-write support on"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e14b498f_a3459a71","line":367,"range":{"start_line":367,"start_character":2,"end_line":367,"end_character":29},"in_reply_to":"6b8a30ed_bc3c8318","updated":"2022-11-01 20:14:30.000000000","message":"Yes, it\u0027s no longer configurable. The setting should be off for the public facing glance-api service (this THT) per OSSN-0090.\n\nIf for some reason a cloud admin wants it enabled, they can always supply hieradata to override things, but I chose to not make it easy by providing them a THT parameter.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"}],"deployment/glance/glance-api-edge-container-puppet.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":37,"context_line":"      \u0027glance-direct\u0027, \u0027web-download\u0027, or \u0027copy-image\u0027"},{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":"  EnableGlanceApiProxy:"},{"line_number":40,"context_line":"    default: true"},{"line_number":41,"context_line":"    description: Configure haproxy to forward glance-api requests to glance-api"},{"line_number":42,"context_line":"                 services running at the edge site."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa71a830_867e0f0c","side":"PARENT","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":22},"updated":"2022-11-01 19:39:49.000000000","message":"I assume this is removed because we no longer need it here. It\u0027s used to set firewall_{,ssl}edge_frontend_rules but those are now excluded (as pointed out below) since we\u0027re now using GlanceApiInternal for GlanceApiEdge.\n\nI see EnableGlanceApiProxy is still used in haproxy-edge-container-puppet.yaml","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":37,"context_line":"      \u0027glance-direct\u0027, \u0027web-download\u0027, or \u0027copy-image\u0027"},{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":"  EnableGlanceApiProxy:"},{"line_number":40,"context_line":"    default: true"},{"line_number":41,"context_line":"    description: Configure haproxy to forward glance-api requests to glance-api"},{"line_number":42,"context_line":"                 services running at the edge site."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e7431695_795f24d0","side":"PARENT","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":22},"in_reply_to":"fa71a830_867e0f0c","updated":"2022-11-01 20:14:30.000000000","message":"Correct.","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":true,"context_lines":[{"line_number":75,"context_line":"      map_merge:"},{"line_number":76,"context_line":"        - get_attr: [GlanceApiBase, role_data]"},{"line_number":77,"context_line":"        - service_name: glance_api_edge"},{"line_number":78,"context_line":"          firewall_edge_frontend_rules:"},{"line_number":79,"context_line":"            if:"},{"line_number":80,"context_line":"              - {get_param: EnableGlanceApiProxy}"},{"line_number":81,"context_line":"              - {get_attr: [GlanceApiBase, role_data, firewall_frontend_rules]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b701a8c4_583cf720","side":"PARENT","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":38},"updated":"2022-11-01 19:39:49.000000000","message":"Are these firewall rules (including the SSL version too) no longer necessary in this file because we\u0027re now using GlanceApiInternal instead of GlanceApiBase and GlanceApiInternal defines them in deployment/glance/glance-api-internal-container-puppet.yaml?","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"      map_merge:"},{"line_number":76,"context_line":"        - get_attr: [GlanceApiBase, role_data]"},{"line_number":77,"context_line":"        - service_name: glance_api_edge"},{"line_number":78,"context_line":"          firewall_edge_frontend_rules:"},{"line_number":79,"context_line":"            if:"},{"line_number":80,"context_line":"              - {get_param: EnableGlanceApiProxy}"},{"line_number":81,"context_line":"              - {get_attr: [GlanceApiBase, role_data, firewall_frontend_rules]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d2ce6b6a_7e685596","side":"PARENT","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":38},"in_reply_to":"b701a8c4_583cf720","updated":"2022-11-01 20:14:30.000000000","message":"Correct. The GlanceApiInternal template defines the firewall rules, even when the template is referenced by this GlanceApiEdge template for use at edge sites.","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"37ff01b4b00738f6568238bcd2a7693b13ecdea0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      map_merge:"},{"line_number":76,"context_line":"        - get_attr: [GlanceApiBase, role_data]"},{"line_number":77,"context_line":"        - service_name: glance_api_edge"},{"line_number":78,"context_line":"          firewall_edge_frontend_rules:"},{"line_number":79,"context_line":"            if:"},{"line_number":80,"context_line":"              - {get_param: EnableGlanceApiProxy}"},{"line_number":81,"context_line":"              - {get_attr: [GlanceApiBase, role_data, firewall_frontend_rules]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0e5fa7c1_973dcbc0","side":"PARENT","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":38},"in_reply_to":"d2ce6b6a_7e685596","updated":"2022-11-01 20:45:08.000000000","message":"Ack","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"resources:"},{"line_number":41,"context_line":"  GlanceApiInternal:"},{"line_number":42,"context_line":"    type: ./glance-api-internal-container-puppet.yaml"},{"line_number":43,"context_line":"    properties:"},{"line_number":44,"context_line":"      ServiceData: {get_param: ServiceData}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e4cfc7b8_99299b36","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":19},"updated":"2022-11-01 19:39:49.000000000","message":"So the GlanceApiEdge service which is deployed on certain DCN nodes (e.g. DistributedCompute or DistributedComputeHci) will result in the GlanceApiInternal service being deployed on Edge nodes without the GlanceApi (external) service. That makes sense to me since we shouldn\u0027t need the user-facing external glance service on the DCN nodes. We just need to ensure that the image services are consumed at the local edge site rather than at the central site.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"resources:"},{"line_number":41,"context_line":"  GlanceApiInternal:"},{"line_number":42,"context_line":"    type: ./glance-api-internal-container-puppet.yaml"},{"line_number":43,"context_line":"    properties:"},{"line_number":44,"context_line":"      ServiceData: {get_param: ServiceData}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cf25df7a_d3d38c62","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":19},"in_reply_to":"e4cfc7b8_99299b36","updated":"2022-11-01 20:14:30.000000000","message":"Correct. Also, the service_config_settings at L76 still apply at edge sites.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      - {get_param: EnableInternalTLS}"},{"line_number":57,"context_line":"      - str_replace:"},{"line_number":58,"context_line":"          template:"},{"line_number":59,"context_line":"            \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:PORT\""},{"line_number":60,"context_line":"          params:"},{"line_number":61,"context_line":"            NETWORK: {get_param: [ServiceNetMap, GlanceApiEdgeNetwork]}"},{"line_number":62,"context_line":"            PORT: {get_param: [EndpointMap, GlanceInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b4e5ece2_bec22e83","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":51},"updated":"2022-11-01 19:39:49.000000000","message":"This makes sense since the port can now change.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      - {get_param: EnableInternalTLS}"},{"line_number":57,"context_line":"      - str_replace:"},{"line_number":58,"context_line":"          template:"},{"line_number":59,"context_line":"            \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:PORT\""},{"line_number":60,"context_line":"          params:"},{"line_number":61,"context_line":"            NETWORK: {get_param: [ServiceNetMap, GlanceApiEdgeNetwork]}"},{"line_number":62,"context_line":"            PORT: {get_param: [EndpointMap, GlanceInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d223c3d5_4afa4dd2","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":51},"in_reply_to":"b4e5ece2_bec22e83","updated":"2022-11-01 20:14:30.000000000","message":"It ~shouldn\u0027t~ change (unless someone modifies the endpoint map), but I want to reduce the number of places where hard coded port numbers appear.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b8414d5c5e5c44c02b95d33bccf49b9d035d8e76","unresolved":true,"context_lines":[{"line_number":36,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":37,"context_line":"      \u0027glance-direct\u0027, \u0027web-download\u0027, or \u0027copy-image\u0027"},{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":"  EnableGlanceApiProxy:"},{"line_number":40,"context_line":"    default: true"},{"line_number":41,"context_line":"    description: Configure haproxy to forward glance-api requests to glance-api"},{"line_number":42,"context_line":"                 services running at the edge site."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ebd92209_6ed27265","side":"PARENT","line":39,"updated":"2022-11-11 12:43:47.000000000","message":"this parameter cannot be removed without deprecating it frist","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"accfd7b309bb77ee58f7b4b9adfead6f7abc7654","unresolved":true,"context_lines":[{"line_number":36,"context_line":"      List of enabled Image Import Methods. Valid values in the list are"},{"line_number":37,"context_line":"      \u0027glance-direct\u0027, \u0027web-download\u0027, or \u0027copy-image\u0027"},{"line_number":38,"context_line":"    type: comma_delimited_list"},{"line_number":39,"context_line":"  EnableGlanceApiProxy:"},{"line_number":40,"context_line":"    default: true"},{"line_number":41,"context_line":"    description: Configure haproxy to forward glance-api requests to glance-api"},{"line_number":42,"context_line":"                 services running at the edge site."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c08b5fd5_b99cfd8c","side":"PARENT","line":39,"in_reply_to":"ebd92209_6ed27265","updated":"2022-11-11 14:10:25.000000000","message":"It\u0027s removed from this file as it\u0027s no longer referenced, but the parameter is still used by haproxy-edge-container-puppet.yaml","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"}],"deployment/haproxy/haproxy-edge-container-puppet.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"outputs:"},{"line_number":50,"context_line":"  glance_api_edge_uri:"},{"line_number":51,"context_line":"    description: URI of the glance-api service running at the edge site."},{"line_number":52,"context_line":"    value: \u0026glance_api_edge_uri"},{"line_number":53,"context_line":"      if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"36a31ea1_1147d6db","side":"PARENT","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":21},"updated":"2022-11-01 19:39:49.000000000","message":"glance_api_edge_uri is removed but on line 125 the glance_api_edge_uri is getattr\u0027d from GlanceApiEdge for nova_compute. So the URI is still getting passed where it is needed so it should be OK to remove it as an output here.","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1960e3c20201f82c29297defdab0cb057fd5207d","unresolved":true,"context_lines":[{"line_number":47,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"outputs:"},{"line_number":50,"context_line":"  glance_api_edge_uri:"},{"line_number":51,"context_line":"    description: URI of the glance-api service running at the edge site."},{"line_number":52,"context_line":"    value: \u0026glance_api_edge_uri"},{"line_number":53,"context_line":"      if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b7001e1e_d059d7b7","side":"PARENT","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":21},"in_reply_to":"175e799c_812d54c6","updated":"2022-11-08 15:09:21.000000000","message":"I had to revert this and go back to having each service (GlanceApiEdge and HAproxyEdge) declare their own glance_api_edge_uri Heat output. This seems to be necessary because the two services are, by design, never deployed on the same edge nodes (GlanceApiEdge is deployed on the first 3 nodes, then HAproxyEdge on scale out nodes). When testing this on an actual DCN deployment, Heat threw an obscure yaql merge error when processing the HAproxyEdge template for a scale out node, and I think that\u0027s because the scale out role doesn\u0027t include the GlanceApiEdge service.","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      RoleParameters: {get_param: RoleParameters}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"outputs:"},{"line_number":50,"context_line":"  glance_api_edge_uri:"},{"line_number":51,"context_line":"    description: URI of the glance-api service running at the edge site."},{"line_number":52,"context_line":"    value: \u0026glance_api_edge_uri"},{"line_number":53,"context_line":"      if:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"175e799c_812d54c6","side":"PARENT","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":21},"in_reply_to":"36a31ea1_1147d6db","updated":"2022-11-01 20:14:30.000000000","message":"Correct. I basically de-duped things so that the glance_api_edge_uri is derived in one place (the GlanceApiEdge template), and it\u0027s referenced again here at L123 and L125.","commit_id":"a4007902c6f9487f0d047ca333ef94c8e25138fd"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                tripleo::haproxy::designate: false"},{"line_number":81,"context_line":"                tripleo::haproxy::docker_registry: false"},{"line_number":82,"context_line":"                tripleo::haproxy::etcd: false"},{"line_number":83,"context_line":"                tripleo::haproxy::glance_api: false"},{"line_number":84,"context_line":"              - if:"},{"line_number":85,"context_line":"                  - {get_param: EnableGlanceApiProxy}"},{"line_number":86,"context_line":"                  - tripleo::haproxy::glance_api_internal: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c0c4fcf5_daad2161","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":51},"updated":"2022-11-01 19:39:49.000000000","message":"So we\u0027re excluding the non-internal version of glance_api here.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                tripleo::haproxy::designate: false"},{"line_number":81,"context_line":"                tripleo::haproxy::docker_registry: false"},{"line_number":82,"context_line":"                tripleo::haproxy::etcd: false"},{"line_number":83,"context_line":"                tripleo::haproxy::glance_api: false"},{"line_number":84,"context_line":"              - if:"},{"line_number":85,"context_line":"                  - {get_param: EnableGlanceApiProxy}"},{"line_number":86,"context_line":"                  - tripleo::haproxy::glance_api_internal: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ab0c71e4_dc360528","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":51},"in_reply_to":"c0c4fcf5_daad2161","updated":"2022-11-01 20:14:30.000000000","message":"Correct.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                tripleo::haproxy::glance_api: false"},{"line_number":84,"context_line":"              - if:"},{"line_number":85,"context_line":"                  - {get_param: EnableGlanceApiProxy}"},{"line_number":86,"context_line":"                  - tripleo::haproxy::glance_api_internal: true"},{"line_number":87,"context_line":"                    glance_api_vip:"},{"line_number":88,"context_line":"                      str_replace:"},{"line_number":89,"context_line":"                        template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"528ba96a_28ea442a","line":86,"range":{"start_line":86,"start_character":59,"end_line":86,"end_character":63},"updated":"2022-11-01 19:39:49.000000000","message":"So if EnableGlanceApiProxy is true, then glance_api_internal is true. Else False per line 95.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                tripleo::haproxy::glance_api: false"},{"line_number":84,"context_line":"              - if:"},{"line_number":85,"context_line":"                  - {get_param: EnableGlanceApiProxy}"},{"line_number":86,"context_line":"                  - tripleo::haproxy::glance_api_internal: true"},{"line_number":87,"context_line":"                    glance_api_vip:"},{"line_number":88,"context_line":"                      str_replace:"},{"line_number":89,"context_line":"                        template:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5477163f_fa45fa7f","line":86,"range":{"start_line":86,"start_character":59,"end_line":86,"end_character":63},"in_reply_to":"528ba96a_28ea442a","updated":"2022-11-01 20:14:30.000000000","message":"Correct.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                          \"%{lookup(\u0027NETWORK\u0027)}\""},{"line_number":91,"context_line":"                        params:"},{"line_number":92,"context_line":"                          NETWORK: {get_param: [ServiceNetMap, GlanceApiEdgeNetwork]}"},{"line_number":93,"context_line":"                    glance_api_internal_node_ips: \"%{alias(\u0027glance_api_edge_node_ips\u0027)}\""},{"line_number":94,"context_line":"                    glance_api_internal_node_names: \"%{alias(\u0027glance_api_edge_node_names\u0027)}\""},{"line_number":95,"context_line":"                  - tripleo::haproxy::glance_api_internal: false"},{"line_number":96,"context_line":"              - tripleo::haproxy::gnocchi: false"},{"line_number":97,"context_line":"                tripleo::haproxy::heat_api: false"},{"line_number":98,"context_line":"                tripleo::haproxy::heat_cfn: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d7a25f9c_499cd162","line":95,"range":{"start_line":93,"start_character":0,"end_line":95,"end_character":64},"updated":"2022-11-01 19:39:49.000000000","message":"So these changes are just to rename it from glance_api_* to glance_api_internal_*","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bedb8ae13176e164699d3d07be697518bc16e61a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                          \"%{lookup(\u0027NETWORK\u0027)}\""},{"line_number":91,"context_line":"                        params:"},{"line_number":92,"context_line":"                          NETWORK: {get_param: [ServiceNetMap, GlanceApiEdgeNetwork]}"},{"line_number":93,"context_line":"                    glance_api_internal_node_ips: \"%{alias(\u0027glance_api_edge_node_ips\u0027)}\""},{"line_number":94,"context_line":"                    glance_api_internal_node_names: \"%{alias(\u0027glance_api_edge_node_names\u0027)}\""},{"line_number":95,"context_line":"                  - tripleo::haproxy::glance_api_internal: false"},{"line_number":96,"context_line":"              - tripleo::haproxy::gnocchi: false"},{"line_number":97,"context_line":"                tripleo::haproxy::heat_api: false"},{"line_number":98,"context_line":"                tripleo::haproxy::heat_cfn: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a3c4c90_1a9edbda","line":95,"range":{"start_line":93,"start_character":0,"end_line":95,"end_character":64},"in_reply_to":"d7a25f9c_499cd162","updated":"2022-11-01 20:14:30.000000000","message":"Correct. This is a side effect of the GlanceApiEdge service now being derived from the GlanceApiInternal service, which has its own set of node names and IPs.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2c261dd2158619b255936ddddc0e8f670c7791b1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                  - cinder_volume:"},{"line_number":123,"context_line":"                      cinder::glance::glance_api_servers: {getattr: [GlanceApiEdge, glance_api_edge_uri]}"},{"line_number":124,"context_line":"                    nova_compute:"},{"line_number":125,"context_line":"                      nova::glance::endpoint_override: {getattr: [GlanceApiEdge, glance_api_edge_uri]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3dfb2436_8be041ce","line":125,"range":{"start_line":125,"start_character":66,"end_line":125,"end_character":79},"updated":"2022-11-01 19:39:49.000000000","message":"We\u0027re now using the GlanceApiEdge resource above.","commit_id":"3e052c0561902bc1252abb2678fc94aa07217917"}]}