)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"935f2b84715832c4705894738dc9aa8c0ce29d82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a9888f7e_a36019d1","updated":"2022-11-23 16:10:41.000000000","message":"+1 functionality wise we should be good. we tested this patch extensively and it works as intended.\npacemaker resources are deleted (both remote and stonith), and there are no leftovers to clean up.\nlet\u0027s see if we can improve it even more with additional feedback.","commit_id":"6e20eed6c830772fc854b8bca2256e18fe210234"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"ce5853e3f4a5ffa3d8a350287755c7cb9d221cb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6713f306_5366d3b4","updated":"2022-11-24 09:32:16.000000000","message":"Setting the -1 temporarily as I\u0027m unsure about the become: true comment.","commit_id":"6e20eed6c830772fc854b8bca2256e18fe210234"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"87245b2df63acd7322ed57f008d9119d23b01f53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2da095f4_a9d5d6a4","updated":"2022-11-24 14:40:36.000000000","message":"LGTM","commit_id":"1e4a28b2683c0ff3ef8a6720759cad3671451cb9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2dfdca441e73474b06147ef1473a19814e8bc71f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3774a824_2fb05153","updated":"2022-11-25 06:45:21.000000000","message":"Should we implement this in deployment/pacemaker/compute-instanceha-baremetal-puppet.yaml instead ?","commit_id":"1e4a28b2683c0ff3ef8a6720759cad3671451cb9"},{"author":{"_account_id":35080,"name":"Antonio Romito","email":"aromito@redhat.com","username":"antonioromito"},"change_message_id":"fb71174185ab0e24f0ff14246c2834c8387bee5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6972ffe1_2f7cfead","in_reply_to":"3774a824_2fb05153","updated":"2022-12-02 09:56:57.000000000","message":"It perfectly makes sense. Code has been moved in deployment/pacemaker/compute-instanceha-baremetal-puppet.yaml.","commit_id":"1e4a28b2683c0ff3ef8a6720759cad3671451cb9"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"ce5853e3f4a5ffa3d8a350287755c7cb9d221cb2","unresolved":true,"context_lines":[{"line_number":1738,"context_line":"                  -\u003e {{ nova_compute_service }}."},{"line_number":1739,"context_line":"              when:"},{"line_number":1740,"context_line":"                - (nova_compute_service | length) \u003e 1"},{"line_number":1741,"context_line":"            - name: Clean up Pacemaker resources for Compute node"},{"line_number":1742,"context_line":"              when:"},{"line_number":1743,"context_line":"                - (nova_compute_service | length) \u003d\u003d 1"},{"line_number":1744,"context_line":"                - nova_compute_service[0].Host.split(\u0027.\u0027)[0] in compute_instanceha_short_node_names"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"45d57717_2472e449","line":1741,"updated":"2022-11-24 09:32:16.000000000","message":"Nit: maybe say \"pacemaker remote and stonith resources\" to be more specific as to which resource we are talking about?","commit_id":"6e20eed6c830772fc854b8bca2256e18fe210234"},{"author":{"_account_id":35080,"name":"Antonio Romito","email":"aromito@redhat.com","username":"antonioromito"},"change_message_id":"fa6ed96139d35a3f7955d6b4b16bcacd0e36ec51","unresolved":false,"context_lines":[{"line_number":1738,"context_line":"                  -\u003e {{ nova_compute_service }}."},{"line_number":1739,"context_line":"              when:"},{"line_number":1740,"context_line":"                - (nova_compute_service | length) \u003e 1"},{"line_number":1741,"context_line":"            - name: Clean up Pacemaker resources for Compute node"},{"line_number":1742,"context_line":"              when:"},{"line_number":1743,"context_line":"                - (nova_compute_service | length) \u003d\u003d 1"},{"line_number":1744,"context_line":"                - nova_compute_service[0].Host.split(\u0027.\u0027)[0] in compute_instanceha_short_node_names"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"79060da9_5f0fd68f","line":1741,"in_reply_to":"45d57717_2472e449","updated":"2022-11-24 12:06:12.000000000","message":"I submitted a new review hoping it clarify the block scope","commit_id":"6e20eed6c830772fc854b8bca2256e18fe210234"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"ce5853e3f4a5ffa3d8a350287755c7cb9d221cb2","unresolved":true,"context_lines":[{"line_number":1748,"context_line":"                  register: stonith_service_results"},{"line_number":1749,"context_line":"                  delegate_to: \"{{ pacemaker_short_bootstrap_node_name }}\""},{"line_number":1750,"context_line":"                - name: Disable the STONITH resources for the Compute node"},{"line_number":1751,"context_line":"                  command: pcs resource disable \"{{ item }}\""},{"line_number":1752,"context_line":"                  loop: \"{{ stonith_service_results.stdout | regex_findall(\u0027^(stonith-fence(?!_compute-fence-nova).*)\u0027, multiline\u003dTrue)}}\""},{"line_number":1753,"context_line":"                  delegate_to: \"{{ pacemaker_short_bootstrap_node_name }}\""},{"line_number":1754,"context_line":"                - name: Delete the STONITH resources for the Compute node"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2769aac0_655ccbde","line":1751,"updated":"2022-11-24 09:32:16.000000000","message":"I think all pcs/crm/stonith command require become: true?","commit_id":"6e20eed6c830772fc854b8bca2256e18fe210234"},{"author":{"_account_id":35080,"name":"Antonio Romito","email":"aromito@redhat.com","username":"antonioromito"},"change_message_id":"fa6ed96139d35a3f7955d6b4b16bcacd0e36ec51","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"                  register: stonith_service_results"},{"line_number":1749,"context_line":"                  delegate_to: \"{{ pacemaker_short_bootstrap_node_name }}\""},{"line_number":1750,"context_line":"                - name: Disable the STONITH resources for the Compute node"},{"line_number":1751,"context_line":"                  command: pcs resource disable \"{{ item }}\""},{"line_number":1752,"context_line":"                  loop: \"{{ stonith_service_results.stdout | regex_findall(\u0027^(stonith-fence(?!_compute-fence-nova).*)\u0027, multiline\u003dTrue)}}\""},{"line_number":1753,"context_line":"                  delegate_to: \"{{ pacemaker_short_bootstrap_node_name }}\""},{"line_number":1754,"context_line":"                - name: Delete the STONITH resources for the Compute node"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ebb37cc5_cfaa804b","line":1751,"in_reply_to":"2769aac0_655ccbde","updated":"2022-11-24 12:06:12.000000000","message":"It inherits the \"become: true\" from https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865445/4/deployment/nova/nova-compute-container-puppet.yaml#1706","commit_id":"6e20eed6c830772fc854b8bca2256e18fe210234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2dfdca441e73474b06147ef1473a19814e8bc71f","unresolved":true,"context_lines":[{"line_number":1728,"context_line":"                - name: List STONITH resource for the Compute node"},{"line_number":1729,"context_line":"                  command: stonith_admin -l {{ nova_compute_service[0].Host.split(\u0027.\u0027)[0] }}"},{"line_number":1730,"context_line":"                  register: stonith_service_results"},{"line_number":1731,"context_line":"                  delegate_to: \"{{ pacemaker_short_bootstrap_node_name }}\""},{"line_number":1732,"context_line":"                - name: Disable the STONITH resources for the Compute node"},{"line_number":1733,"context_line":"                  command: pcs resource disable \"{{ item }}\""},{"line_number":1734,"context_line":"                  loop: \"{{ stonith_service_results.stdout | regex_findall(\u0027^(stonith-fence(?!_compute-fence-nova).*)\u0027, multiline\u003dTrue)}}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bd489be5_5a65f28b","line":1731,"range":{"start_line":1731,"start_character":35,"end_line":1731,"end_character":70},"updated":"2022-11-25 06:45:21.000000000","message":"It\u0027s likely we don\u0027t have this in case of split-stack deployment(for spine-leaf) + Instance HA. We probably better skip the task in case the bootstrap node is missing and then just warn the user.","commit_id":"1e4a28b2683c0ff3ef8a6720759cad3671451cb9"},{"author":{"_account_id":35080,"name":"Antonio Romito","email":"aromito@redhat.com","username":"antonioromito"},"change_message_id":"fb71174185ab0e24f0ff14246c2834c8387bee5e","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"                - name: List STONITH resource for the Compute node"},{"line_number":1729,"context_line":"                  command: stonith_admin -l {{ nova_compute_service[0].Host.split(\u0027.\u0027)[0] }}"},{"line_number":1730,"context_line":"                  register: stonith_service_results"},{"line_number":1731,"context_line":"                  delegate_to: \"{{ pacemaker_short_bootstrap_node_name }}\""},{"line_number":1732,"context_line":"                - name: Disable the STONITH resources for the Compute node"},{"line_number":1733,"context_line":"                  command: pcs resource disable \"{{ item }}\""},{"line_number":1734,"context_line":"                  loop: \"{{ stonith_service_results.stdout | regex_findall(\u0027^(stonith-fence(?!_compute-fence-nova).*)\u0027, multiline\u003dTrue)}}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d3a3f934_48b9d489","line":1731,"range":{"start_line":1731,"start_character":35,"end_line":1731,"end_character":70},"in_reply_to":"bd489be5_5a65f28b","updated":"2022-12-02 09:56:57.000000000","message":"I\u0027ve added the warning message as you suggested. Thanks for the hint!","commit_id":"1e4a28b2683c0ff3ef8a6720759cad3671451cb9"}]}