)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7665c1d2b70e7265ee472bf31014851246c76f28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b55744cc_1c004259","updated":"2022-11-30 14:01:18.000000000","message":"Commenting here too.\n\nLooking at [1] that does not look like the fix as it uses GlanceApiEdgeNetwork in ServiceNetMap and glance_api_edge_node_ips.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/haproxy/haproxy-edge-container-puppet.yaml#L100-L102","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"cbd6a8041759475e757ac3e88e922c6459c3302b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4fdd6885_ea6598be","updated":"2023-02-06 12:50:37.000000000","message":"Rabi, do we want to restore this?","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b13f3ee3329ae5bc1946f8a97d39a946262397ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ad665f8_a85c9e7d","updated":"2022-11-30 13:53:59.000000000","message":"See https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866165 for the proper fix.\n\nI encountered this issue (the LP bug) when I developed the feature, but somehow I introduced a typo in the THT file that defines the internal g-api network. I was juggling patches to test the code on multiple branches, and somehow messed things up prior to submitting the THT patch for master.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1dba0c350aaaf517f0fb05a4a532c70dd182a56e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bca148f3_79573fca","updated":"2023-01-27 18:07:31.000000000","message":"There\u0027s interest in reviving this patch even though the immediate urgency (fixing CI) was resolved. I will remove my -1 if this patch is restored.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a10eb1f5e3c9d30451e3bdca0d85c5e44d892ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc069eec_aaa77f46","updated":"2022-12-01 07:46:26.000000000","message":"downgrading vote based on comments here ","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"855342a539e4ec86440b5428a8866c16c737eb06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b17daf14_aa316d2e","updated":"2022-11-30 10:14:31.000000000","message":"lgtm do we have a test for it @Ananya?","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fc9a0430584b89922cefb81746f2a33e015820b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f825283_b3f8546e","in_reply_to":"08fb4cee_a4303b3f","updated":"2022-12-01 07:48:41.000000000","message":"so hold on, i just went and read the thread @ https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866165/1#message-0c935da246283a2d1a3269998cf010bb62c064c3\n\n\n@Alan so do you mean we want *this* patch but also include your typo fix here?","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a10eb1f5e3c9d30451e3bdca0d85c5e44d892ed9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08fb4cee_a4303b3f","in_reply_to":"2df4a3f2_7a69b4a8","updated":"2022-12-01 07:46:26.000000000","message":"if this is really caused by a typo then lets fix that instead of adding an override if this is not needed?","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"74ad39ef39d250a9e8d0b7c2194441d46b22a994","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90950c39_38224be5","in_reply_to":"3c5b5df9_89bea5d1","updated":"2022-12-02 05:24:36.000000000","message":"\u003e Alternatively we can replace glance_api_internal_ips consistently...\n\nThat is what this patch is doing and suggests not to add GlanceApiInternalNetwork which I think is the best way to avoid any issues with the current implementation (Till we change GlanceApiInternal service to use GlanceApiInternalNetwork for everything including bind_host). Sorry, I can\u0027t shout out more louder than this:(","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"91a64d86ce08418c74ffe47ae35f78758fe355a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baedebce_02d5905c","in_reply_to":"6ec26bcd_ce9eda55","updated":"2022-12-01 02:22:33.000000000","message":"\u003e That said, I still believe the root problem is a typo in my original patch [1].\n\nWhen proposing this patch I did think about adding the GlanceApiInternal to ServiceNetMap but decided not to do it. This is more of a design question (i.e if we have two instances of the same service expected to be using the same network, we probably don\u0027t need to define them separately in ServiceNetMap for \u0027only\u0027 two hiera values which you can override).","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6017ecb5536c46fc241297b56eb330de5654d425","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd3aa589_37d9b3de","in_reply_to":"7d97abd8_c2cbbc19","updated":"2022-12-01 05:12:11.000000000","message":"I think the above justification \u0027not override\u0027 glance_api_internal_node_ips is a contradiction based on what you do in another(HAProxyEdge) service[1]. \n\nI raised my concern of not having networks defined for multiple instances of the same service (which I\u0027m sure won\u0027t be different). Having said that, feel free to go with your patch if there is consensus that this won\u0027t suffice.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/haproxy/haproxy-edge-container-puppet.yaml#L101-L102","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89a75322d657b894459d13e7d30369171a1837ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d369df01_8fcade13","in_reply_to":"7f825283_b3f8546e","updated":"2022-12-01 13:42:52.000000000","message":"Not quite. The two solutions being offered are mine (fix the typo) and Rabi\u0027s (this patch), which uses overrides instead of a ServiceNetMap entry (which has the typo). If people prefer this patch then my line (with the typo) should be removed entirely. The broken ServiceNetMap entry needs to be fixed or removed.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89c78a47b1feb7f8c3c5e6a6026dade9d81ee211","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ec26bcd_ce9eda55","in_reply_to":"8ad665f8_a85c9e7d","updated":"2022-11-30 22:51:02.000000000","message":"My apologies to Rabi for the -2. As I noted in a comment on my alternative patch (the one listed above), I was confusing this patch with another in puppet-tripleo (which has since been abandoned). One reason for my original -2 was that I thought this patch wouldn\u0027t work for DCN/Edge deployments, but that is not the case.\n\nThat said, I still believe the root problem is a typo in my original patch [1]. As we know, tripleo uses the ServiceNetMap to render a set of \u003cservice\u003e_node_ips and \u003cservice\u003e_node_names hiera data for every tripleo service, and my patch [1] contains a typo in the service name (it\u0027s \"GlanceApiInternal\" not \"GlanceApiEdgeInternal\").\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865875/2/overcloud-resource-registry-puppet.j2.yaml#362\n\nThis patch works because it overrides the \"wrong\" network info with the correct node names and IPs. The override won\u0027t be necessary if this patch fixes the typo.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a76b205010eee5e1b0c8cf27611dea42d457573","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a6df1b1b_fb1cdeb7","in_reply_to":"90950c39_38224be5","updated":"2022-12-02 05:56:25.000000000","message":"Yes now I finally got your point completely (I hope) and that\u0027s why I added that comment. I\u0027m inclined to drop GlanceApiInternalNetwork considering the complexity of redirecting glance-api-internal service.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6d3bdf2d144e7b1d52b9e7c9140124291e9318b3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c5b5df9_89bea5d1","in_reply_to":"9a3ff7a3_388ff5b9","updated":"2022-12-02 02:32:01.000000000","message":"Alternatively we can replace glance_api_internal_ips consistently (as suggested by this) and get rid of GlanceApiInternalNetwork . That would not require additional modification for ServiceNetMap so have less impact on users using ServiceNetMap","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cc7ff142dd95fdb4523cc0804d2895ba8212211a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f5fd980_1faef3c8","in_reply_to":"a6df1b1b_fb1cdeb7","updated":"2022-12-02 08:02:07.000000000","message":"the other patch just merged.\n\nbased on Rabi comments in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866165/1#message-c15e8a1c0baa7063b086167a903d6f3325c3a823\n\ncan we go with this anyway? Or maybe since it isn\u0027t a blocker any more, is it worth considering non override solution (i.e. make GlanceApiInternal \u0026 ServiceNetMap working properly?) or is that too much rework for not a lot of benefit compared to the override?","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"aeec9a0abff6545c7edcea9c6b86588a0cf43f76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"134b0e65_8cb95f18","in_reply_to":"b17daf14_aa316d2e","updated":"2022-11-30 10:21:25.000000000","message":"tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001 runs as check job in this patch. But lemme tp the periodic one as well : https://review.rdoproject.org/r/c/testproject/+/46302","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5825fbb67161e475caee978021a51fed29e88dab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d97abd8_c2cbbc19","in_reply_to":"baedebce_02d5905c","updated":"2022-12-01 04:55:18.000000000","message":"I chose to not diverge from the existing design pattern, where every service is presumed to have a network. We know tripleo-ansible includes every service in its loop, regardless of whether there\u0027s an entry in the ServiceNetMap. The glance_api_internal_node_ips and _names will appear in /etc/puppet/hieradata/all_nodes.json, regardless of whether there\u0027s a ServiceNetMap entry. Overriding the values results in additional entries in service_configs.json. The variables appear twice in the hieradata, which doesn\u0027t feel right and is potentially confusing to anyone not familiar with the design.\n\nAlso, the two services don\u0027t even have to be on the same network, it\u0027s just that tripleo uses the internal_api for many of them.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6ec3123091a00f599f11c704555d0564a75bcf16","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a3ff7a3_388ff5b9","in_reply_to":"d369df01_8fcade13","updated":"2022-12-02 02:26:36.000000000","message":"Sorry it took me a while until I went through the whole implementation and I\u0027m joining this too late.\n\nRegarding the existing override, I think that is dependent on a bit different situation. In edge compute we deploy only glance_api_edge service without glance_api and glance_api_internal. However, to enable haproxy in the edge site, we forcefully enable the endpoint[1] for glance_api_internal (previously, glance_api). This is why we need to override these node_ips or node_names because these are not populated by t-a because glance_api(_internal) service is not enabled in the edge stack. So the main intention of the override is not overriding the network but hijacking the existing implementation for glance_api(_internal) for _edge.\n\n[1]\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/haproxy/haproxy-edge-container-puppet.yaml#L94\n\nNow I feel like the solution suggested by Alan would be correct, though we still have a problem. Currently glance-api-internal service is deployed in GlanceApiNetwork, instead of GlanceApiInternalNetwork. This means we technically should use glance_api_node_(ip/name)s instead of glance_api_internal_node_(ip/name)s. If we pursue GlanceApiInternalNetwork then we have to fix that point.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"47ce52e9e36b4bdf4f4dfbe12d054e98510592e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2df4a3f2_7a69b4a8","in_reply_to":"dd3aa589_37d9b3de","updated":"2022-12-01 05:27:01.000000000","message":"It\u0027s true the HAproxyEdge overrides the data, but it does so solely to satisfy unique requirements for DCN/Edge (it\u0027s done that way to select a subset of nodes).\n\nI guess we need to leave it up to other reviewers to decide which approach they prefer. If they do choose your override method, then I would ask you remove the bad \"GlanceApiEdgeInternalNetwork\" entry (the one with my typo) from the ServiceNetMap.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c628c8e1259ed339aa0d8b0609efdb37b7c82f3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac231125_7b6716dd","updated":"2023-02-07 10:54:42.000000000","message":"lgtm, I will update the commit message to point to the new bug","commit_id":"92c45f51b408d2ee40404345654e2ec72e03ea78"}],"deployment/haproxy/haproxy-container-puppet.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"855342a539e4ec86440b5428a8866c16c737eb06","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5ac728de_d202e562","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"updated":"2022-11-30 10:14:31.000000000","message":"just wondering what is that i don\u0027t see it elsewhere in tht\nis it a puppet or jinja/ansible thing?\n\nI will +2 even though I don\u0027t fully understand that :) as it is the same as was added in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/863142/5/deployment/haproxy/haproxy-edge-container-puppet.yaml","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89c78a47b1feb7f8c3c5e6a6026dade9d81ee211","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dcef46f2_1fc33c94","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"in_reply_to":"5ac728de_d202e562","updated":"2022-11-30 22:51:02.000000000","message":"It\u0027s a puppet/hiera thing. The tripleo_hieradata ansible role renders \u003cservice\u003e_node_ips and \u003cservice\u003e_node_names hiera data for every service, and this hiera data is picked up and used by the tripleo::haproxy puppet module.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"66fb5bd6bb82ab1f13cf2a6f473e41739fccd687","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e17701ee_8c0392cb","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"in_reply_to":"8516ab7e_2884dcfd","updated":"2022-12-01 15:28:36.000000000","message":"looks a bit like the hiera() calls we have in the manifests? for example https://github.com/openstack/puppet-tripleo/blob/stable/train/manifests/haproxy.pp#L649","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89a75322d657b894459d13e7d30369171a1837ec","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8516ab7e_2884dcfd","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"in_reply_to":"dbe98cf1_3650a00f","updated":"2022-12-01 13:42:52.000000000","message":"Ah, sorry for misunderstanding the question. It\u0027s a puppet/hiera thing, see https://puppet.com/docs/puppet/7/hiera_merging.html#alias-function","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a10eb1f5e3c9d30451e3bdca0d85c5e44d892ed9","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dbe98cf1_3650a00f","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"in_reply_to":"dcef46f2_1fc33c94","updated":"2022-12-01 07:46:26.000000000","message":"Thanks for checking Alan, I meant specifically the %{alias syntax is what i was wondering about.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"868f1205a2a4da928f2c7c7bf5c626c287307ea2","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f55febc8_c12fefea","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"in_reply_to":"e17701ee_8c0392cb","updated":"2022-12-01 15:44:50.000000000","message":"A bit like that. When puppet looks up the value for glance_api_internal_node_ips, the alias redirects it to return the glance_api_node_ips value.","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cc7ff142dd95fdb4523cc0804d2895ba8212211a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            tripleo::haproxy::crl_file: null"},{"line_number":202,"context_line":"            tripleo::haproxy::haproxy_stats: {get_param: HAProxyStatsEnabled}"},{"line_number":203,"context_line":"            enable_load_balancer: {get_param: EnableLoadBalancer}"},{"line_number":204,"context_line":"            glance_api_internal_node_ips: \"%{alias(\u0027glance_api_node_ips\u0027)}\""},{"line_number":205,"context_line":"            glance_api_internal_node_names: \"%{alias(\u0027glance_api_node_names\u0027)}\""},{"line_number":206,"context_line":"            tripleo::profile::base::haproxy::certificates_specs:"},{"line_number":207,"context_line":"              map_merge:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2cd34909_fa3cf070","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":50},"in_reply_to":"f55febc8_c12fefea","updated":"2022-12-02 08:02:07.000000000","message":"thanks for pointers Alan o/","commit_id":"bee8262cba6bf538d5ebe42f93d22a49c96a272d"}]}