)]}'
{"deployment/ironic/ironic-api-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b1e109cf5d90649f00370382c5b814f2934d46f1","unresolved":true,"context_lines":[{"line_number":380,"context_line":"                tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 ~ ironic_api_network ) }}\""},{"line_number":381,"context_line":"              - if:"},{"line_number":382,"context_line":"                - ironic_workers_set"},{"line_number":383,"context_line":"                - tripleo_ironic_api_httpd_vhost_workers: {get_param: IronicWorkers}"},{"line_number":384,"context_line":"              - if:"},{"line_number":385,"context_line":"                - auth_strategy_http_basic"},{"line_number":386,"context_line":"                - tripleo_httpd_vhost_custom_options:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b574e32_86cf7e32","line":383,"updated":"2022-12-01 15:02:23.000000000","message":"we have a chance to ditch all _workers_set conditions and make Heat live easier 😊\nwe couldn\u0027t shift a special 0 value handling to puppetlabs-apache, because it was unlikely to see it lands. But as we have a full control over tripleo-ansible, we can shift the special 0 value handling there instead, and drop all extra conditions for tht services. See https://review.opendev.org/c/openstack/tripleo-ansible/+/866163","commit_id":"e213affbcacc5642aa3230dd401351cd2aca1f86"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d849ddb8dbaaf562a721bc917d0317adfb072aa3","unresolved":true,"context_lines":[{"line_number":380,"context_line":"                tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 ~ ironic_api_network ) }}\""},{"line_number":381,"context_line":"              - if:"},{"line_number":382,"context_line":"                - ironic_workers_set"},{"line_number":383,"context_line":"                - tripleo_ironic_api_httpd_vhost_workers: {get_param: IronicWorkers}"},{"line_number":384,"context_line":"              - if:"},{"line_number":385,"context_line":"                - auth_strategy_http_basic"},{"line_number":386,"context_line":"                - tripleo_httpd_vhost_custom_options:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6427443d_f9ca8dec","line":383,"in_reply_to":"5b574e32_86cf7e32","updated":"2022-12-02 01:25:43.000000000","message":"This is mot ansible-native way IMO. Ideally we should be able to use omit but heat does not support such semantics. Having more complicated logic within underlying t-a, because of the limitation of tht is not ideal as we are trying to make it as general as possible.","commit_id":"e213affbcacc5642aa3230dd401351cd2aca1f86"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fdbed66ab5c7581cd6322d62ad807dbd13bce031","unresolved":true,"context_lines":[{"line_number":380,"context_line":"                tripleo_httpd_vhost_servername: \"{{ lookup(\u0027vars\u0027, \u0027fqdn_\u0027 ~ ironic_api_network ) }}\""},{"line_number":381,"context_line":"              - if:"},{"line_number":382,"context_line":"                - ironic_workers_set"},{"line_number":383,"context_line":"                - tripleo_ironic_api_httpd_vhost_workers: {get_param: IronicWorkers}"},{"line_number":384,"context_line":"              - if:"},{"line_number":385,"context_line":"                - auth_strategy_http_basic"},{"line_number":386,"context_line":"                - tripleo_httpd_vhost_custom_options:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"28bae557_c458bc0c","line":383,"in_reply_to":"6427443d_f9ca8dec","updated":"2022-12-02 04:09:17.000000000","message":"\u003e This is not ansible-native way IMO\n\nI mean, adding additional handling of \u00270\u0027 because of the behavior of heat templates, is not ansible-native or desired.","commit_id":"e213affbcacc5642aa3230dd401351cd2aca1f86"}]}