)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c5a444c0333eef8533e4ddd785fee174b0666c74","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM test bug/1998501"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/865050"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib4de49adc50ee4c806882754c5657c7dbd1f8993"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3672c6a2_f7449e68","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":17},"updated":"2022-12-09 14:52:26.000000000","message":"also please remove this .. once we\u0027re happy with the fix, lets merge this\nthen we can merge the job tripleo-ci/+/865050\n\ni.e. we\u0027ll switch the depends-on the other way around.","commit_id":"9881f91e9fec483ce3f8f9dd07c2db9262914beb"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"4e753e5391d1084825c826cb9685a2ebb6f7bf94","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DNM test bug/1998501"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/865050"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib4de49adc50ee4c806882754c5657c7dbd1f8993"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0c0ffe21_9510a9af","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":17},"in_reply_to":"3672c6a2_f7449e68","updated":"2022-12-14 09:42:21.000000000","message":"Done","commit_id":"9881f91e9fec483ce3f8f9dd07c2db9262914beb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"1e53b2c5ad061d70ea2daa6b3a4b9fa0cac69012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"06907356_2f2e4107","updated":"2022-12-15 18:50:56.000000000","message":"Fixed zed upgrades issue:\n\n\u003e periodic-tripleo-ci-centos-9-undercloud-upgrade-zed https://review.rdoproject.org/zuul/build/6deacf1424bb41d08441cd970e874675 : SUCCESS in 1h 14m 02s (non-voting)\n\ntest project: https://review.rdoproject.org/r/c/testproject/+/45781\n\nThanks","commit_id":"8fe5aae74f3a657f6d6a51d58a1187f5c724972e"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"082bd17cabd0d7a006512b5d3a42b175755a278a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4f51d10d_bd12e661","updated":"2022-12-15 19:25:11.000000000","message":"https://zuul.opendev.org/t/openstack/build/16f1e71723cc4fd9b18ab445dd035dda - passing","commit_id":"8fe5aae74f3a657f6d6a51d58a1187f5c724972e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"69c140d76dcb3a2512165d5aba9158517309cb70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c8e233db_f3d9dd29","in_reply_to":"4f51d10d_bd12e661","updated":"2022-12-16 07:40:40.000000000","message":"ack but lets get them in order we need to merge master one first https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866381","commit_id":"8fe5aae74f3a657f6d6a51d58a1187f5c724972e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a5dbf3fd8f4e2b2a2f9e1cb74080f92f564a0668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3f8a459c_c11af176","updated":"2023-01-02 07:55:24.000000000","message":"bump\n\nwhat is the status for this\n\nlooking at the bug there is some discussion from Rabi about an alternative https://bugs.launchpad.net/tripleo/+bug/1998501/comments/11\n\nWas the an alternative patch to this one proposed and tested?","commit_id":"c7c6ac2dd1e084b5144995a3948dad5d2559e10b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3f873d03646ffcdd8a367f97b4d237c7130c49e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7f6547f3_6d9e9f2c","in_reply_to":"3f8a459c_c11af176","updated":"2023-01-03 07:07:48.000000000","message":".","commit_id":"c7c6ac2dd1e084b5144995a3948dad5d2559e10b"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"036bad00f97fdf102942c25971f5f5777251f554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9e3f1d5b_5f445558","updated":"2023-01-03 08:01:43.000000000","message":"BTW, this last test is reverting https://github.com/openstack/tripleo-heat-templates/commit/c8fba9b2375d38dea0ca20a6a52e396d30b20472 as rabi suggested on the master patch. ","commit_id":"c1f34adf33f19fd3f498bbb1a488f3b02ca61ab8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4e32320fb3ed91851c1b500e6c637957073a5703","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"1d8d3ca8_96559e48","updated":"2023-01-04 07:39:50.000000000","message":"-1 for master first","commit_id":"28dbdb09b05e04f483c72d875fa54e0cedac9c7e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"65c2bb2667baf1c4208d7a9552fe9270be221827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"aaa740d6_e4ad4e96","updated":"2023-01-09 10:22:23.000000000","message":"recheck content provider failure","commit_id":"fb3574e444e23bb2c70e3beb715c1a3e01147757"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9f7bb0f25879176d296372047e8cce5283a41738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"aece71c0_b4846f7b","updated":"2023-01-12 08:20:03.000000000","message":"k master merged lets get these going for now... ","commit_id":"f7251ad83ea565adcd42f7026382e93b5f336c2a"}],"common/deploy-steps.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d70a8827f711fda8abfe14db067245ff5aa675c9","unresolved":true,"context_lines":[{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"                - debug:"},{"line_number":1132,"context_line":"                    var: playbook_dir"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"                - include_tasks: \"{{ _task_file_path }}\""},{"line_number":1135,"context_line":"                  vars:"},{"line_number":1136,"context_line":"                    _task_file_path: \"{{ tripleo_role_name }}/upgrade_tasks_step{{ step }}.yaml\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"8e5bcd93_9b93df0f","line":1133,"updated":"2022-12-09 14:50:06.000000000","message":"discussing this with dasm who is working on https://review.opendev.org/c/openstack/tripleo-ci/+/865050\n\nwhy did you post v4 and what are we debugging. looked like the fix was good no?","commit_id":"e4851bf6bed0a6be48dff8d0fb00a31ba89d4819"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"4e753e5391d1084825c826cb9685a2ebb6f7bf94","unresolved":false,"context_lines":[{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"                - debug:"},{"line_number":1132,"context_line":"                    var: playbook_dir"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"                - include_tasks: \"{{ _task_file_path }}\""},{"line_number":1135,"context_line":"                  vars:"},{"line_number":1136,"context_line":"                    _task_file_path: \"{{ tripleo_role_name }}/upgrade_tasks_step{{ step }}.yaml\""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"8f0c6cde_634b73f0","line":1133,"in_reply_to":"8e5bcd93_9b93df0f","updated":"2022-12-14 09:42:21.000000000","message":"There was a testing on going","commit_id":"e4851bf6bed0a6be48dff8d0fb00a31ba89d4819"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c971a435586c4c89b1a4bfa958ad4c2cea9a13ab","unresolved":true,"context_lines":[{"line_number":991,"context_line":"                  vars:"},{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1249bc38_7ea917e5","line":994,"updated":"2023-01-02 13:56:22.000000000","message":"it makes more sense to use include for conditional blocks, to have a single check instead of having each task checks the criteria","commit_id":"c7c6ac2dd1e084b5144995a3948dad5d2559e10b"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"c02fd27abbc8cca7af871e550353e3a55a631167","unresolved":true,"context_lines":[{"line_number":991,"context_line":"                  vars:"},{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1536d086_95b5326a","line":994,"in_reply_to":"1249bc38_7ea917e5","updated":"2023-01-02 14:16:54.000000000","message":"thanks for the improvement.","commit_id":"c7c6ac2dd1e084b5144995a3948dad5d2559e10b"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"c965c7d2557876887659c3253595fe12ccdaabfc","unresolved":false,"context_lines":[{"line_number":991,"context_line":"                  vars:"},{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - import_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"716e5ffe_c6f02f08","line":994,"in_reply_to":"1536d086_95b5326a","updated":"2023-01-02 14:18:24.000000000","message":"Done","commit_id":"c7c6ac2dd1e084b5144995a3948dad5d2559e10b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a42b91cc97f12b874c3e575ad22b24092b927f1d","unresolved":true,"context_lines":[{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - include_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"},{"line_number":998,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"d6919917_1b74bd14","line":995,"updated":"2023-01-03 07:17:59.000000000","message":"I know you changed this on the suggestion from Bogdan but just wondering about the mix of include and import here and noting this is not recommended in general\n\n(from https://docs.ansible.com/ansible/2.9/user_guide/playbooks_reuse_includes.html#including-and-importing-task-files )\n\n\"\nNote\n\n    Static and dynamic can be mixed, however this is not recommended as it may lead to difficult-to-diagnose bugs in your playbooks.\n    \n\"","commit_id":"1a2c05e7e7e8943d7f85cf6f948032f466f1f562"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"670c7ad87a370eb0c300973020a91cbb160f26fe","unresolved":true,"context_lines":[{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - include_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"},{"line_number":998,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"e7ffaa23_2c06dbe1","line":995,"in_reply_to":"0770f6bf_c19ec642","updated":"2023-01-03 07:54:51.000000000","message":"ok, let\u0027s use the import_tasks then and update the master one.","commit_id":"1a2c05e7e7e8943d7f85cf6f948032f466f1f562"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e5727dfcb8010b534af8eae9b9c2bc91bc1ce9bc","unresolved":true,"context_lines":[{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - include_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"},{"line_number":998,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"0770f6bf_c19ec642","line":995,"in_reply_to":"d6919917_1b74bd14","updated":"2023-01-03 07:27:14.000000000","message":"also just noticed this is stable/zed. please update the master one first and then update this depending on what we merge for master? https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866381","commit_id":"1a2c05e7e7e8943d7f85cf6f948032f466f1f562"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"04b6e0c971b8dd3198cf1157a74d1ac843043c95","unresolved":true,"context_lines":[{"line_number":992,"context_line":"                    step: \"{{ step }}\""},{"line_number":993,"context_line":"{%- endfor %}"},{"line_number":994,"context_line":"                - include_tasks: \"{{role.name}}/host_prep_tasks.yaml\""},{"line_number":995,"context_line":"                  when: tripleo_role_name \u003d\u003d \u0027{{role.name}}\u0027"},{"line_number":996,"context_line":"                - import_tasks: deploy_steps_tasks_step_0.yaml"},{"line_number":997,"context_line":"                  vars:"},{"line_number":998,"context_line":"                    step: 0"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"8fd8f3e0_fa41cd78","line":995,"in_reply_to":"e7ffaa23_2c06dbe1","updated":"2023-01-11 17:05:35.000000000","message":"imported tasks with conditionals end up with a load of skipped tasks in execution.\n\nincluded tasks with conditionals skip the actual include task and is therefore faster to execute.\n\ngenerally speaking that\u0027s the pattern being used.","commit_id":"1a2c05e7e7e8943d7f85cf6f948032f466f1f562"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4e32320fb3ed91851c1b500e6c637957073a5703","unresolved":true,"context_lines":[{"line_number":1322,"context_line":"            - include_tasks: \"{{ _task_file_path }}\""},{"line_number":1323,"context_line":"              vars:"},{"line_number":1324,"context_line":"                _task_file_path: \"{{ tripleo_role_name }}/post_update_tasks.yaml\""},{"line_number":1325,"context_line":"              when: \"\u0027{{ playbook_dir }}/{{ _task_file_path }}\u0027 is exists\""},{"line_number":1326,"context_line":"              tags:"},{"line_number":1327,"context_line":"                - always"},{"line_number":1328,"context_line":"{% endraw %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"07156057_6ecf2088","line":1325,"range":{"start_line":1325,"start_character":0,"end_line":1325,"end_character":32},"updated":"2023-01-04 07:39:50.000000000","message":"please check comment @ https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866381/3#message-050a2b056667f62d25ee96041d8873fe25f49ad8 do you need to udpate that\n\nin general lets hold on this until we agree and merge the master one","commit_id":"28dbdb09b05e04f483c72d875fa54e0cedac9c7e"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"56e0159997e8848072a1ca1c1eab60962fde3766","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"            - include_tasks: \"{{ _task_file_path }}\""},{"line_number":1323,"context_line":"              vars:"},{"line_number":1324,"context_line":"                _task_file_path: \"{{ tripleo_role_name }}/post_update_tasks.yaml\""},{"line_number":1325,"context_line":"              when: \"\u0027{{ playbook_dir }}/{{ _task_file_path }}\u0027 is exists\""},{"line_number":1326,"context_line":"              tags:"},{"line_number":1327,"context_line":"                - always"},{"line_number":1328,"context_line":"{% endraw %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"c792f60a_cad294ea","line":1325,"range":{"start_line":1325,"start_character":0,"end_line":1325,"end_character":32},"in_reply_to":"07156057_6ecf2088","updated":"2023-01-04 07:49:54.000000000","message":"Thanks for checking it.","commit_id":"28dbdb09b05e04f483c72d875fa54e0cedac9c7e"}],"zuul.d/layout.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d70a8827f711fda8abfe14db067245ff5aa675c9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"      - check-requirements"},{"line_number":5,"context_line":"      - release-notes-jobs-python3"},{"line_number":6,"context_line":"      - openstack-python3-zed-jobs"},{"line_number":7,"context_line":"      - tripleo-upgrades-zed-pipeline"},{"line_number":8,"context_line":"    check:"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8a5c7b39_67d6ceba","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":37},"updated":"2022-12-09 14:50:06.000000000","message":"fix is good, lets update this so we can merge please","commit_id":"e4851bf6bed0a6be48dff8d0fb00a31ba89d4819"}]}