)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"d5b691dc832b477517270b1d1d71490837220922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43623c33_1b48f233","updated":"2022-12-29 19:18:28.000000000","message":"recheck","commit_id":"41ac414d36ac9dc7e0445db3318028bbbd3c784c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"c63ab6eabb07b74ad0e1c428f3e59179f9b1afa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28a35ffa_f3159e06","updated":"2023-01-03 17:42:31.000000000","message":"recheck","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ebdcf9d15309b590e048c097383bd27d1cd812b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71c51e47_88756893","updated":"2023-01-05 19:12:13.000000000","message":"recheck","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"a6f065b10324488c8606c8a78a5a77ef315128d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4ae6be6_c93e425a","updated":"2023-01-06 17:36:48.000000000","message":"recheck","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"24b340b98b59f0c650c2d14a971dda4a61ce766d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a50fda36_6959f647","updated":"2023-01-06 13:58:02.000000000","message":"recheck","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"322c6d54d51f98d867e3d0d09c7a4b25de2d869d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4fddc37_d1cea55e","updated":"2023-01-05 15:45:08.000000000","message":"recheck","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8309d5c085542b7cd0e9a51adbc175f7e9aa07f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bcd330c0_94f74f8b","updated":"2023-01-05 15:13:34.000000000","message":"recheck","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"}],"deployment/cinder/cinder-backend-pure-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b18abdc84b8827056e1ece12c44eeae9e33aa0d","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":141,"context_line":"            cinder::backend::pure::pure_nvme_transport : {get_param: CinderPureNvmeTransport}"},{"line_number":142,"context_line":"            cinder::backend::pure::pure_nvme_cidr : {get_param: CinderPureNvmeCidr}"},{"line_number":143,"context_line":"            cinder::backend::pure::pure_nvme_cidr_list : {get_param: CinderPureNvmeCidrList}"},{"line_number":144,"context_line":"          - if:"},{"line_number":145,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":146,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"28690ddf_3413923e","line":143,"range":{"start_line":143,"start_character":35,"end_line":143,"end_character":54},"updated":"2023-01-05 15:03:12.000000000","message":"Usage of a list value requires a fix in underlying puppet module. Currently the value is not converted into a commpa-separated list string, and put into multiple lines when being rendered into cinder.conf.\n\nWe need a logic similar to [1].\n\n[1] https://review.opendev.org/c/openstack/puppet-cinder/+/869269","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"0f4dc43c82f41eef3ee48a6f405f7fd12e26c19c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":141,"context_line":"            cinder::backend::pure::pure_nvme_transport : {get_param: CinderPureNvmeTransport}"},{"line_number":142,"context_line":"            cinder::backend::pure::pure_nvme_cidr : {get_param: CinderPureNvmeCidr}"},{"line_number":143,"context_line":"            cinder::backend::pure::pure_nvme_cidr_list : {get_param: CinderPureNvmeCidrList}"},{"line_number":144,"context_line":"          - if:"},{"line_number":145,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":146,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8ac1a46a_9d625e6c","line":143,"range":{"start_line":143,"start_character":35,"end_line":143,"end_character":54},"in_reply_to":"28690ddf_3413923e","updated":"2023-01-05 15:13:26.000000000","message":"https://review.opendev.org/c/openstack/puppet-cinder/+/869269has been amended as requested","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"67bf58521966066fab8f6d7c9e26e5d90687df0b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":141,"context_line":"            cinder::backend::pure::pure_nvme_transport : {get_param: CinderPureNvmeTransport}"},{"line_number":142,"context_line":"            cinder::backend::pure::pure_nvme_cidr : {get_param: CinderPureNvmeCidr}"},{"line_number":143,"context_line":"            cinder::backend::pure::pure_nvme_cidr_list : {get_param: CinderPureNvmeCidrList}"},{"line_number":144,"context_line":"          - if:"},{"line_number":145,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":146,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d7067eed_bdb67120","line":143,"range":{"start_line":143,"start_character":35,"end_line":143,"end_character":54},"in_reply_to":"6aac0701_14d39911","updated":"2023-01-06 20:57:17.000000000","message":"Ack","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"65cb82fb81f86170794fb68f2d70f12b68e44524","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":141,"context_line":"            cinder::backend::pure::pure_nvme_transport : {get_param: CinderPureNvmeTransport}"},{"line_number":142,"context_line":"            cinder::backend::pure::pure_nvme_cidr : {get_param: CinderPureNvmeCidr}"},{"line_number":143,"context_line":"            cinder::backend::pure::pure_nvme_cidr_list : {get_param: CinderPureNvmeCidrList}"},{"line_number":144,"context_line":"          - if:"},{"line_number":145,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":146,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cd3320f8_196b7311","line":143,"range":{"start_line":143,"start_character":35,"end_line":143,"end_character":54},"in_reply_to":"8ac1a46a_9d625e6c","updated":"2023-01-05 15:54:29.000000000","message":"True, but the depends-on needs to be updated in the commit message.","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ebdcf9d15309b590e048c097383bd27d1cd812b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            cinder::backend::pure::pure_iscsi_cidr : {get_param: CinderPureIscsiCidr}"},{"line_number":141,"context_line":"            cinder::backend::pure::pure_nvme_transport : {get_param: CinderPureNvmeTransport}"},{"line_number":142,"context_line":"            cinder::backend::pure::pure_nvme_cidr : {get_param: CinderPureNvmeCidr}"},{"line_number":143,"context_line":"            cinder::backend::pure::pure_nvme_cidr_list : {get_param: CinderPureNvmeCidrList}"},{"line_number":144,"context_line":"          - if:"},{"line_number":145,"context_line":"            - not: {equals : [{get_param: CinderPureAvailabilityZone}, \u0027\u0027]}"},{"line_number":146,"context_line":"            - cinder::backend::pure::backend_availability_zone: {get_param: CinderPureAvailabilityZone}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6aac0701_14d39911","line":143,"range":{"start_line":143,"start_character":35,"end_line":143,"end_character":54},"in_reply_to":"cd3320f8_196b7311","updated":"2023-01-05 19:12:13.000000000","message":"I have amended all the depends-on for this sequence. The initial puppet-cinder has all the changes requested by Takashi","commit_id":"bb7ea440ee53064a4f8ec811fd3955089938002b"}]}