)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b29c60bc84ab0a839efb50cf633a2dd0ece51bb2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Use /run/nova/ for nova-comp delay script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova have no permissions to write into /run."},{"line_number":10,"context_line":"Use /run/nova instead, and ensure its creation by the init container"},{"line_number":11,"context_line":"step."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"307e9dbc_eecbbc97","line":10,"updated":"2023-02-28 13:42:39.000000000","message":"so /run is recreated on every host reboot and the init contaienr does not run every time we start nova_compute correct so i dont think this will work after a host reboot.","commit_id":"997dbb4f29881aa4bf246872a1e4121c897b5d6a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f157cad2330d73a7c9c8dcd86d1bda8349f3f667","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use /run/nova/ for nova-comp delay script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova have no permissions to write into /run."},{"line_number":10,"context_line":"Use /run/nova instead, and ensure its creation by the init container"},{"line_number":11,"context_line":"step."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"78ef0988_6b2da1c6","line":10,"in_reply_to":"307e9dbc_eecbbc97","updated":"2023-02-28 14:18:44.000000000","message":"Done","commit_id":"997dbb4f29881aa4bf246872a1e4121c897b5d6a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"128e12d5a334d1aa6af9dad334d42b00abccfe33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a4b0330_66636997","updated":"2023-03-08 12:58:27.000000000","message":"PTAL","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ddb1773a9dadba663174e7b4c90af014b6f02255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fc321f0_4368afd5","updated":"2023-03-10 12:40:08.000000000","message":"PTAL","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"004c46a40cd0e6884f2f91a88cea00c1427bab98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7cc2da82_cfcaec11","updated":"2023-03-06 13:16:03.000000000","message":"PTAL","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4f7ccf90f51c07dda60982688a94c9a14b4a8b6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ac97d40_b584f692","updated":"2023-03-02 15:11:41.000000000","message":"PTAL","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"302a1b2990e136038e1ebc311b2f9ab3b8558924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"11537f27_f2b9f074","updated":"2023-03-22 15:10:03.000000000","message":"recheck","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6dcad8e28f7c9c5e3b1de75cc822f7fbee66c54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e07f841_03cf3713","updated":"2023-03-22 03:28:40.000000000","message":"sorry for my late review but are we sure access to /run/nova is allowed by selinux ? bind mount of /run does not have :z flag so the directory is now relabeled when the nova-compute container starts.","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f157cad2330d73a7c9c8dcd86d1bda8349f3f667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c14ca702_69484371","updated":"2023-02-28 14:18:44.000000000","message":"thanks!","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7851261b2f22eef59ec2f8527d0548f1f7976275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"39a5f63c_3a2816bd","in_reply_to":"15515d7d_2a6a8f78","updated":"2023-03-22 15:21:08.000000000","message":"Done","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4b6ab1e9e877bb01006e4b5bb374b7307442836e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"edde92bb_f9b2e881","in_reply_to":"7e07f841_03cf3713","updated":"2023-03-22 03:29:01.000000000","message":"(dummy comment to open my previous comment)","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cc3bb75ce04ae860f52cafea3f8cb8d59088e3e0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"15515d7d_2a6a8f78","in_reply_to":"edde92bb_f9b2e881","updated":"2023-03-22 15:17:34.000000000","message":"good question, thanks.\nperhaps I can switch it to use /run/nova:z instead","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2aa4ea65ac081e3ec6063f8354d9578958282325","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"17ed7644_cc40af18","updated":"2023-03-29 11:03:10.000000000","message":"recheck","commit_id":"3ca91cc57ff06eab57bef21139715203bd3ef9fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ffb3401e3c606a8291095628cf33801a7a3c46e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"58e5e753_70e6e317","updated":"2023-03-29 12:22:45.000000000","message":"recheck","commit_id":"3ca91cc57ff06eab57bef21139715203bd3ef9fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"367bf2692904c0414f722db362212c6f00de4c91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6c6336d_e662d7e1","updated":"2023-03-24 13:02:18.000000000","message":"recheck fips","commit_id":"3ca91cc57ff06eab57bef21139715203bd3ef9fe"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7e4bd03947910a645b96fbfc001b13e9b8af1fa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9898582b_b499041c","updated":"2023-03-30 10:45:46.000000000","message":"recheck ipa","commit_id":"3ca91cc57ff06eab57bef21139715203bd3ef9fe"}],"deployment/logging/files/nova-common.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"89527e63335d67e25d255147fcb33dfc864a1f1e","unresolved":true,"context_lines":[{"line_number":70,"context_line":"            volumes:"},{"line_number":71,"context_line":"              - /run:/run"},{"line_number":72,"context_line":"              - /var/log/containers/nova:/var/log/nova:z"},{"line_number":73,"context_line":"            command: [\u0027/bin/bash\u0027, \u0027-c\u0027, \u0027mkdir -p /run/nova; chown nova:nova /run/nova; chown -R nova:nova /var/log/nova\u0027]"},{"line_number":74,"context_line":"            environment:"},{"line_number":75,"context_line":"              # NOTE: this should force this container to re-run on each"},{"line_number":76,"context_line":"              # update (scale-out, etc.)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6aec0388_5652a744","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":88},"updated":"2023-02-28 13:41:08.000000000","message":"i see\n\ni dont think this will work arcoss host reboots.\n\nyou shoudl proaly use tempfiles.d instead to creat this.","commit_id":"997dbb4f29881aa4bf246872a1e4121c897b5d6a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f157cad2330d73a7c9c8dcd86d1bda8349f3f667","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            volumes:"},{"line_number":71,"context_line":"              - /run:/run"},{"line_number":72,"context_line":"              - /var/log/containers/nova:/var/log/nova:z"},{"line_number":73,"context_line":"            command: [\u0027/bin/bash\u0027, \u0027-c\u0027, \u0027mkdir -p /run/nova; chown nova:nova /run/nova; chown -R nova:nova /var/log/nova\u0027]"},{"line_number":74,"context_line":"            environment:"},{"line_number":75,"context_line":"              # NOTE: this should force this container to re-run on each"},{"line_number":76,"context_line":"              # update (scale-out, etc.)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5dcfa21d_43c3853d","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":88},"in_reply_to":"6aec0388_5652a744","updated":"2023-02-28 14:18:44.000000000","message":"Done","commit_id":"997dbb4f29881aa4bf246872a1e4121c897b5d6a"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8109a1cdba0d1aa94e46ad5f65a48e2267c54df5","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"            copy:"},{"line_number":1474,"context_line":"              dest: /etc/tmpfiles.d/run-nova.conf"},{"line_number":1475,"context_line":"              content: |"},{"line_number":1476,"context_line":"                d /run/nova 0750 42436 42436 - -"},{"line_number":1477,"context_line":"          - name: create tempfiles"},{"line_number":1478,"context_line":"            command: systemd-tmpfiles --create"},{"line_number":1479,"context_line":"          - name: Mount Nova NFS Share"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"85191522_d60f3666","line":1476,"range":{"start_line":1476,"start_character":33,"end_line":1476,"end_character":38},"updated":"2023-03-08 13:13:46.000000000","message":"ack 42436 is the nova user and group although this will also get fixed by the kolla_set_configs script but it does not hurt to create it with the right permissions.","commit_id":"7db435ee02fbf79a9fbbe208db1d69821ed3d97f"}]}