)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"ec26856ed7bf3723f5bc74aa963a2a6cd553c0ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6c25ddf_7076677b","updated":"2023-03-08 10:41:59.000000000","message":"I like the idea of providing this as a bespoke tool rather than trying to add it to some existing interface.\n\nI think we need to do some more testing with this before we merge it though. I did it a couple of times this weekend, and this is HostnameMap thing is just one example of something I found. But maybe some more testing it required to make sure we capture everything.","commit_id":"d412b3913940d52b01408778ce5908be917cddb3"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"0a2bc255eadec8d3332a7f3390d638fef719a23e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56c9d280_456eb16e","updated":"2023-03-29 19:10:43.000000000","message":"After talking to brendan we need testing.","commit_id":"eb971c4c7013208dab00e620a8358efcde10d7a2"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"3cb23beab9284fe108fc35b3c4ba68b385016516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6560248f_d73f0ac5","updated":"2023-03-22 13:31:47.000000000","message":"Brendan comments were not resolved.","commit_id":"eb971c4c7013208dab00e620a8358efcde10d7a2"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"c5e3bad77550e5c6e937b82175dba4de8ddee008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"baf47631_12ad8305","updated":"2023-05-04 08:57:28.000000000","message":"The patch is not merged it, we can abandon it and only merge the wallaby one.","commit_id":"412dc69e14bb800bb108022557f9fdfaae86b48a"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"507383d174d021f03685dbd756f2d8d050c24e36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"24f656d6_143af4c9","updated":"2023-04-17 09:22:47.000000000","message":"recheck","commit_id":"412dc69e14bb800bb108022557f9fdfaae86b48a"}],"tools/baremetal_transition.py":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"9aa41ba4e2b49ff4320929ac5200fe77c2b06a01","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            role_dst[\u0027instances\u0027] \u003d []"},{"line_number":60,"context_line":"            role_dst[\u0027name\u0027] \u003d opts.dst_role"},{"line_number":61,"context_line":"            baremetal.add(role_dst)"},{"line_number":62,"context_line":"    else:"},{"line_number":63,"context_line":"        for node2move in opts.nodes:"},{"line_number":64,"context_line":"            for node in role_src[\u0027instances\u0027]:"},{"line_number":65,"context_line":"                if (node[\u0027hostname\u0027] \u003d\u003d node2move):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d483c86b_13a95c0b","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":9},"updated":"2023-03-22 11:49:59.000000000","message":"This needs to be removed.","commit_id":"d412b3913940d52b01408778ce5908be917cddb3"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"ec26856ed7bf3723f5bc74aa963a2a6cd553c0ce","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            role_dst[\u0027instances\u0027] \u003d []"},{"line_number":60,"context_line":"            role_dst[\u0027name\u0027] \u003d opts.dst_role"},{"line_number":61,"context_line":"            baremetal.add(role_dst)"},{"line_number":62,"context_line":"    else:"},{"line_number":63,"context_line":"        for node2move in opts.nodes:"},{"line_number":64,"context_line":"            for node in role_src[\u0027instances\u0027]:"},{"line_number":65,"context_line":"                if (node[\u0027hostname\u0027] \u003d\u003d node2move):"},{"line_number":66,"context_line":"                    role_dst[\u0027count\u0027] \u003d role_dst[\u0027count\u0027] + 1"},{"line_number":67,"context_line":"                    role_dst[\u0027instances\u0027].append(node)"},{"line_number":68,"context_line":"                    role_src[\u0027instances\u0027].remove(node)"},{"line_number":69,"context_line":"                    role_src[\u0027count\u0027] \u003d role_src[\u0027count\u0027] - 1"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"if role_src is not None:"},{"line_number":72,"context_line":"    with open(opts.baremetal_deployment, \"w\") as file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3474748b_e1f24805","line":69,"range":{"start_line":62,"start_character":0,"end_line":69,"end_character":61},"updated":"2023-03-08 10:41:59.000000000","message":"I think we need to address the Hostname Map as well to make sure our nodes hostname isn\u0027t changed as part of the deployment:\n\n```\n- name: ComputeRHEL8\n  count: 1\n  hostname_format: computerhel8-%index%\n  defaults:\n    profile: compute\n    network_config:\n      template: /home/stack/virt/network/three-nics-vlans/compute-dvr.j2\n  instances:\n  - hostname: compute-1\n    name: computerhel8-0\n```\n\nBecause, ultimately we need the HostnameMap to look like this:\n```\n  HostnameMap:\n    ceph-0: ceph-0\n    ceph-1: ceph-1\n    ceph-2: ceph-2\n    compute-0: compute-0\n    computerhel8-0: compute-1\n    controller-0: controller-0\n    controller-1: controller-1\n    controller-2: controller-2\n```\n\nSo, the node we\u0027re moving in this case is `compute-1`. We\u0027re moving it over to the `ComputeRHEL8` role, so we need to match the index Heat will reference this node by in the new role. \n\nThis ensures the node maintains the same hostname after the migration to avoid any issues with Nova.","commit_id":"d412b3913940d52b01408778ce5908be917cddb3"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"4e77f68311533f79e843f953ff7b2234d42f0cae","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            role_dst[\u0027instances\u0027] \u003d []"},{"line_number":60,"context_line":"            role_dst[\u0027name\u0027] \u003d opts.dst_role"},{"line_number":61,"context_line":"            baremetal.add(role_dst)"},{"line_number":62,"context_line":"    else:"},{"line_number":63,"context_line":"        for node2move in opts.nodes:"},{"line_number":64,"context_line":"            for node in role_src[\u0027instances\u0027]:"},{"line_number":65,"context_line":"                if (node[\u0027hostname\u0027] \u003d\u003d node2move):"},{"line_number":66,"context_line":"                    role_dst[\u0027count\u0027] \u003d role_dst[\u0027count\u0027] + 1"},{"line_number":67,"context_line":"                    role_dst[\u0027instances\u0027].append(node)"},{"line_number":68,"context_line":"                    role_src[\u0027instances\u0027].remove(node)"},{"line_number":69,"context_line":"                    role_src[\u0027count\u0027] \u003d role_src[\u0027count\u0027] - 1"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"if role_src is not None:"},{"line_number":72,"context_line":"    with open(opts.baremetal_deployment, \"w\") as file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d4d5097_d656a63e","line":69,"range":{"start_line":62,"start_character":0,"end_line":69,"end_character":61},"in_reply_to":"3474748b_e1f24805","updated":"2023-03-22 13:40:22.000000000","message":"Why should we need to have in the hostnameMap changed?\n\n..\ncomputerhel8-0: compute-1\n..\n\nOn upgrades we didnt need to change neither the name or the hostname.","commit_id":"d412b3913940d52b01408778ce5908be917cddb3"}]}