)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"63b58cd61cad6a83eecfd5a6a17277ce37656354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"535ff65c_52f475fa","updated":"2023-03-30 10:42:19.000000000","message":"recheck","commit_id":"059d55b874a5b97254526e7c68333e24a43395bf"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"44de2d0b1ef6e7daa38ca6632b9be48f28030795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a30cef0_3701398a","updated":"2023-03-29 13:18:29.000000000","message":"recheck","commit_id":"059d55b874a5b97254526e7c68333e24a43395bf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e00c7e498fd8d1f6a2db8faf06ca273dd8c1bf93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"806e9d86_72017cf9","updated":"2023-04-05 15:56:06.000000000","message":"FYI https://lists.openstack.org/pipermail/openstack-discuss/2023-April/033198.html","commit_id":"647ce829f8b657ecc47d49ce43fb8eb1b3de532d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ea5b3f283ab7c6b60dbf8614938f5f52dcc2df8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c7b08f5_c91db9f3","updated":"2023-04-05 12:17:33.000000000","message":"no nonger a cherry-pick, as no longer supported for Zed","commit_id":"647ce829f8b657ecc47d49ce43fb8eb1b3de532d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"31890039cac627f4fe9b7a0f1d20fe060cfd61e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d9254bb_9236b2c3","updated":"2023-04-11 12:07:46.000000000","message":"recheck prov","commit_id":"647ce829f8b657ecc47d49ce43fb8eb1b3de532d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e999859476c20b2694d55b88d3094e18a69280d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b4f0bdd_f7aa78b4","updated":"2023-04-25 15:47:17.000000000","message":"recheck","commit_id":"69034a2ee7daf2df56d41662f310f0b1a0eae48b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"628d9a2ccef1398597b8e92acd70d8ef773b9097","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3a581da6_a726b857","updated":"2023-04-28 11:50:18.000000000","message":"the tmpfiles part of it needss futher work (no such user on the host, but only in kolla containers)","commit_id":"f89b509f65c886c70b0558fc3cc48748769b0685"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c54c5cd98b6b7c1006dfa54720c7da59caca4bd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"29538ac3_673752b8","updated":"2023-05-15 11:49:10.000000000","message":"PTAL","commit_id":"fec7ae11511e0b6fffa1bffb719b17e6e627e34e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2f9f82d2f3325029b23b21ac8e13881ee1b84b30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9cc2dda9_c1e7411e","updated":"2023-05-18 11:00:34.000000000","message":"recheck","commit_id":"457c489548a1e784e316d817ca2e9a9bed5360f1"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23bd46e1e5f88e732ffb25ba751308e494ac965e","unresolved":true,"context_lines":[{"line_number":1467,"context_line":"            copy:"},{"line_number":1468,"context_line":"              dest: /etc/tmpfiles.d/run-nova.conf"},{"line_number":1469,"context_line":"              content: |"},{"line_number":1470,"context_line":"                d /run/nova 0777 root root - -"},{"line_number":1471,"context_line":"          - name: create tempfiles"},{"line_number":1472,"context_line":"            command: systemd-tmpfiles --create"},{"line_number":1473,"context_line":"          - name: Mount Nova NFS Share"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"795cc7e8_67e5b18c","line":1470,"range":{"start_line":1470,"start_character":18,"end_line":1470,"end_character":27},"updated":"2023-05-15 13:05:46.000000000","message":"Are we sure the directory can be accessible from the script inside container ? Because /run is mounted without z flag the directory is not relabeled with container_file_t.\n\nI\u0027d like to make sure that this is tested with selinux enforced.","commit_id":"fec7ae11511e0b6fffa1bffb719b17e6e627e34e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a8d3563d18341ba329b266e242f7df047003dc8b","unresolved":false,"context_lines":[{"line_number":1467,"context_line":"            copy:"},{"line_number":1468,"context_line":"              dest: /etc/tmpfiles.d/run-nova.conf"},{"line_number":1469,"context_line":"              content: |"},{"line_number":1470,"context_line":"                d /run/nova 0777 root root - -"},{"line_number":1471,"context_line":"          - name: create tempfiles"},{"line_number":1472,"context_line":"            command: systemd-tmpfiles --create"},{"line_number":1473,"context_line":"          - name: Mount Nova NFS Share"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"90d5aaf3_ac4b941c","line":1470,"range":{"start_line":1470,"start_character":18,"end_line":1470,"end_character":27},"in_reply_to":"4eab9995_3a512c66","updated":"2023-05-16 11:40:23.000000000","message":"\u003e This is a good point. I think I missed that we need /run/nova:/run/nova:z for the compute container as well","commit_id":"fec7ae11511e0b6fffa1bffb719b17e6e627e34e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d26b1027d2ac6b3390a9f0c6963c8cdf346a2972","unresolved":true,"context_lines":[{"line_number":1467,"context_line":"            copy:"},{"line_number":1468,"context_line":"              dest: /etc/tmpfiles.d/run-nova.conf"},{"line_number":1469,"context_line":"              content: |"},{"line_number":1470,"context_line":"                d /run/nova 0777 root root - -"},{"line_number":1471,"context_line":"          - name: create tempfiles"},{"line_number":1472,"context_line":"            command: systemd-tmpfiles --create"},{"line_number":1473,"context_line":"          - name: Mount Nova NFS Share"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4eab9995_3a512c66","line":1470,"range":{"start_line":1470,"start_character":18,"end_line":1470,"end_character":27},"in_reply_to":"795cc7e8_67e5b18c","updated":"2023-05-16 11:36:03.000000000","message":"This is a good point. I think I missed that we need /run/nova:/run/nova:z for the compute container as well","commit_id":"fec7ae11511e0b6fffa1bffb719b17e6e627e34e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81b359eb4027eb63e7bd012a76afe436382b7a86","unresolved":true,"context_lines":[{"line_number":1409,"context_line":"                      - /dev:/dev"},{"line_number":1410,"context_line":"                      - /lib/modules:/lib/modules:ro"},{"line_number":1411,"context_line":"                      - /run:/run"},{"line_number":1412,"context_line":"                      - /run/nova:/run/nova:z"},{"line_number":1413,"context_line":"                      - /var/lib/iscsi:/var/lib/iscsi:z"},{"line_number":1414,"context_line":"                      - /var/lib/libvirt:/var/lib/libvirt:shared"},{"line_number":1415,"context_line":"                      - /sys/class/net:/sys/class/net"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"73b06791_406e6a92","line":1412,"range":{"start_line":1412,"start_character":24,"end_line":1412,"end_character":45},"updated":"2023-05-17 02:32:56.000000000","message":"I doublt this nested mount works. We probably should test it https://review.opendev.org/c/openstack/tripleo-heat-templates/+/883323/","commit_id":"457c489548a1e784e316d817ca2e9a9bed5360f1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b79f42158675d7c1f0c7b29525fd172871b9a32a","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"                      - /dev:/dev"},{"line_number":1410,"context_line":"                      - /lib/modules:/lib/modules:ro"},{"line_number":1411,"context_line":"                      - /run:/run"},{"line_number":1412,"context_line":"                      - /run/nova:/run/nova:z"},{"line_number":1413,"context_line":"                      - /var/lib/iscsi:/var/lib/iscsi:z"},{"line_number":1414,"context_line":"                      - /var/lib/libvirt:/var/lib/libvirt:shared"},{"line_number":1415,"context_line":"                      - /sys/class/net:/sys/class/net"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ab3f0655_084476cd","line":1412,"range":{"start_line":1412,"start_character":24,"end_line":1412,"end_character":45},"in_reply_to":"73b06791_406e6a92","updated":"2023-05-17 11:32:22.000000000","message":"Ok that test change passed CI.","commit_id":"457c489548a1e784e316d817ca2e9a9bed5360f1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc486ab7ce89c7964ef9061a3daf1d98eb3b9fb0","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"                      - /dev:/dev"},{"line_number":1410,"context_line":"                      - /lib/modules:/lib/modules:ro"},{"line_number":1411,"context_line":"                      - /run:/run"},{"line_number":1412,"context_line":"                      - /run/nova:/run/nova:z"},{"line_number":1413,"context_line":"                      - /var/lib/iscsi:/var/lib/iscsi:z"},{"line_number":1414,"context_line":"                      - /var/lib/libvirt:/var/lib/libvirt:shared"},{"line_number":1415,"context_line":"                      - /sys/class/net:/sys/class/net"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c3e4258b_aa14cff5","line":1412,"range":{"start_line":1412,"start_character":24,"end_line":1412,"end_character":45},"in_reply_to":"ab3f0655_084476cd","updated":"2023-05-17 14:15:41.000000000","message":"yea, it should work, I tested with some podman CLIs locally and it worked :)","commit_id":"457c489548a1e784e316d817ca2e9a9bed5360f1"}],"scripts/delay-nova-compute":[{"author":{"_account_id":15206,"name":"Marian Krcmarik","email":"mkrcmari@redhat.com","username":"mvk"},"change_message_id":"bb5068c93315abdd47ca221ba48635cc4389ce43","unresolved":true,"context_lines":[{"line_number":45,"context_line":"if not os.path.isfile(state_file_name):"},{"line_number":46,"context_line":"    logging.info(\"Delaying nova-compute startup by %s seconds\" % args.delay)"},{"line_number":47,"context_line":"    time.sleep(args.delay)"},{"line_number":48,"context_line":"    open(args.state_file_name, \u0027a\u0027).close()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"logging.info(\"Executing %s\" % real_args)"},{"line_number":51,"context_line":"os.execv(args.nova_binary, real_args)"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"a52673b5_867ff265","line":48,"updated":"2023-05-05 01:15:12.000000000","message":"I think It should be:\nopen(state_file_name, \u0027a\u0027).close()","commit_id":"284808c54523b2daf4fa8fa771352d84d84792cf"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"deeae3d82514f11cd7fdd5634df1f5d32c782187","unresolved":false,"context_lines":[{"line_number":45,"context_line":"if not os.path.isfile(state_file_name):"},{"line_number":46,"context_line":"    logging.info(\"Delaying nova-compute startup by %s seconds\" % args.delay)"},{"line_number":47,"context_line":"    time.sleep(args.delay)"},{"line_number":48,"context_line":"    open(args.state_file_name, \u0027a\u0027).close()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"logging.info(\"Executing %s\" % real_args)"},{"line_number":51,"context_line":"os.execv(args.nova_binary, real_args)"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1314aef3_f1e6834c","line":48,"in_reply_to":"a52673b5_867ff265","updated":"2023-05-11 12:38:08.000000000","message":"yes, thanks!","commit_id":"284808c54523b2daf4fa8fa771352d84d84792cf"}]}