)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"de8cd37fc06368d2b0c0a4775d68c5efc8994630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"95a393c1_a4a02179","updated":"2023-05-03 16:37:54.000000000","message":"LGTM","commit_id":"9ce5d7081770702482dbd65cabb20be3d747c00e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"055e8aa4eafce6b19886c032ba19689ae69ca589","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28929d86_2e63ead7","updated":"2023-05-03 17:02:42.000000000","message":"There\u0027s been enough positive review feedback for me to push this one along.","commit_id":"9ce5d7081770702482dbd65cabb20be3d747c00e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"ebcab569051856bce5167923fbc4d482238a3aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5f3b1b5_f677192d","updated":"2023-05-04 07:25:53.000000000","message":"openstack-tox-pep8 job passed during check but strange to see it failed in gate [1], i see it is never passed in master in recent times [2]\n\n[1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_l[…]/878517/3/gate/openstack-tox-pep8/5c28954/job-output.txt\n\n[2] https://zuul.opendev.org/t/openstack/builds?job_name\u003dopenstack-tox-pep8\u0026project\u003dopenstack/tripleo-heat-templates\n\n\nAs we know Tripleo master branch is deprecated and it\u0027s CI lines will be teared down. I think we should propose this patch to stable/wallaby directly.","commit_id":"9ce5d7081770702482dbd65cabb20be3d747c00e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a03bc3255b3d236d52cc34d38f61d8c88b75e14f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"911dbb30_d70def04","updated":"2023-04-07 12:54:44.000000000","message":"recheck","commit_id":"9ce5d7081770702482dbd65cabb20be3d747c00e"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"92ca032ba70c8f38c7509c6e89ec82bdc02e7ba7","unresolved":true,"context_lines":[{"line_number":648,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":649,"context_line":"                - str_replace:"},{"line_number":650,"context_line":"                    template:"},{"line_number":651,"context_line":"                      \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:9292\""},{"line_number":652,"context_line":"                    params:"},{"line_number":653,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, GlanceApiNetwork]}"},{"line_number":654,"context_line":"                - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71cb9bba_b558ac75","line":651,"range":{"start_line":651,"start_character":57,"end_line":651,"end_character":61},"updated":"2023-03-24 15:01:02.000000000","message":"You shouldn\u0027t use hardcoded port numbers, especially now that we run two variants of the service on different ports. See [1] for how I think this should be handled.\n\nOtherwise, the change looks reasonable. However, I recommend seeing if this can be tested in a more real-world downstream deployment, just to verify the feature works as intended.\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/haproxy/haproxy-edge-container-puppet.yaml#L61","commit_id":"770b08394152661791ebf30ff5a90ea11558d1ea"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"ad93bd5ff2462fedb929f23cbf31d25444d10176","unresolved":true,"context_lines":[{"line_number":648,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":649,"context_line":"                - str_replace:"},{"line_number":650,"context_line":"                    template:"},{"line_number":651,"context_line":"                      \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:9292\""},{"line_number":652,"context_line":"                    params:"},{"line_number":653,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, GlanceApiNetwork]}"},{"line_number":654,"context_line":"                - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e12b8403_904acdd7","line":651,"range":{"start_line":651,"start_character":57,"end_line":651,"end_character":61},"in_reply_to":"71cb9bba_b558ac75","updated":"2023-04-05 06:01:53.000000000","message":"Alan, thanks for the review.\n\nI\u0027ve tested this in downstream HA environment along with QE and image import works as expected with this change.","commit_id":"770b08394152661791ebf30ff5a90ea11558d1ea"}]}