)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"79bc15676e5b6c4b0a6c64c5b00c5fa2bc898e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d178b35b_29a7256f","updated":"2023-05-24 06:49:50.000000000","message":"this looks like a good idea","commit_id":"fd3d57f39c746e2aad9937567944eaa2c1ac9b36"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"23dc4f136040ac7ec990c80fed85f1c531cf8b48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"50822916_db934b4e","updated":"2023-05-31 12:52:25.000000000","message":"This change may still need some investigation about what the performance impact is, because we don\u0027t know the limits of FreeIPA and the way throttle works on blocks https://github.com/ansible/ansible/issues/64659","commit_id":"fde4038f0628c35332dd30df2a7b24a771311704"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"1cb9bf3b3b5e94e4c65e28e31997db37de0147a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6549917f_53daccf0","in_reply_to":"0d81b3e3_ec7a781b","updated":"2023-07-10 07:39:40.000000000","message":"We tested the patch with a deployment above 200 nodes, it handled the workload well. We also were able to test the throttle setting, which didn\u0027t have any noticeable impact on the deployment time.","commit_id":"fde4038f0628c35332dd30df2a7b24a771311704"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"e706418d22b26007c43606a89e38e6862103c334","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0d81b3e3_ec7a781b","in_reply_to":"50822916_db934b4e","updated":"2023-05-31 13:25:20.000000000","message":"From internal tests w know that with a non-replicated FreeIPA instancea, it can handle around 130 or so servers being enrolled successfully at the same time.","commit_id":"fde4038f0628c35332dd30df2a7b24a771311704"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2f27413e28c1f552d403c671d827adfb1fd0303f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8a1ed72d_aad25ae4","updated":"2023-07-11 12:52:49.000000000","message":"I\u0027ll leave a couple of comments but would not block this assuming this is tested in actual large deployment.","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"4868a82ac2db7bcbf860f57aaf009592a42b9e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3f242ba0_8fd30f63","updated":"2023-07-11 10:06:26.000000000","message":"This really improves the performance for the tls-e related tasks.\nAs an example, with a test with 200 nodes, overall configuration time savings due to this patch is about 2 hours!","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2989c8ffeb3b192e461a8096ab5046d8a29f13c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fd985b46_43c27c9e","updated":"2023-07-11 21:10:37.000000000","message":"largely, this seems to just copy the existing code from external_tasks in to its own section. The main addition appears to be the delegate_to. Takashi has already mentioned it, but I think we have seen issues with this in the past at scale when the tripleo_free strategy is used. I know you have tested this at 200 node scale already, but we might want to keep that in mind if we start to see issues. I believe Rabi will have more information about that problem.\n\nI’m ok with it, we can debate the delegate_to thing further as required.","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c38b9b2e28ea8d9ec7433b8b8291926cc7b00b6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0a8edd98_58030b74","in_reply_to":"8a1ed72d_aad25ae4","updated":"2023-07-11 13:04:30.000000000","message":"This was tested in a 200 compute node environment - and it works wonderfully.  Reduces the deploy time by about 2 hours!","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"}],"deployment/ipa/ipaservices-baremetal-ansible.yaml":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"bcf4fb36a2b16e0f2191dfcc567664157e6988c6","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                tripleo_ipa_delegate_server: \"{{ item }}\""},{"line_number":116,"context_line":"                tripleo_ipa_base_server_fqdn:  \"{{ hostvars[item][\u0027fqdn_canonical\u0027] }}\""},{"line_number":117,"context_line":"                tripleo_ipa_server_metadata: \"{{ hostvars[item][\u0027service_metadata_settings\u0027] | to_json }}\""},{"line_number":118,"context_line":"              loop: \"{{ groups[\u0027ipaservice\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""},{"line_number":119,"context_line":"            - include_role:"},{"line_number":120,"context_line":"                name: tripleo_ipa_dns"},{"line_number":121,"context_line":"                apply:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6f18d898_c942d679","line":118,"range":{"start_line":118,"start_character":14,"end_line":118,"end_character":91},"updated":"2023-05-26 12:35:34.000000000","message":"I think the way to get around the current problems is to restructure so we do not have a loop here.  Rather, we just execute this on the machines in this loop - and each server just executes the role to add itself.  Then, we don\u0027t need to add run_once.","commit_id":"fd3d57f39c746e2aad9937567944eaa2c1ac9b36"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"26cedf275bdc3b103f739b65b9ff0bfeef71e95d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                tripleo_ipa_delegate_server: \"{{ item }}\""},{"line_number":116,"context_line":"                tripleo_ipa_base_server_fqdn:  \"{{ hostvars[item][\u0027fqdn_canonical\u0027] }}\""},{"line_number":117,"context_line":"                tripleo_ipa_server_metadata: \"{{ hostvars[item][\u0027service_metadata_settings\u0027] | to_json }}\""},{"line_number":118,"context_line":"              loop: \"{{ groups[\u0027ipaservice\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""},{"line_number":119,"context_line":"            - include_role:"},{"line_number":120,"context_line":"                name: tripleo_ipa_dns"},{"line_number":121,"context_line":"                apply:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9cb125b0_e4b8f3e4","line":118,"range":{"start_line":118,"start_character":14,"end_line":118,"end_character":91},"in_reply_to":"2bc1ad44_70784c7d","updated":"2023-05-31 06:29:04.000000000","message":"Done","commit_id":"fd3d57f39c746e2aad9937567944eaa2c1ac9b36"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7fa208f98d6f4041ba20b4aaa958046865709fd2","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                tripleo_ipa_delegate_server: \"{{ item }}\""},{"line_number":116,"context_line":"                tripleo_ipa_base_server_fqdn:  \"{{ hostvars[item][\u0027fqdn_canonical\u0027] }}\""},{"line_number":117,"context_line":"                tripleo_ipa_server_metadata: \"{{ hostvars[item][\u0027service_metadata_settings\u0027] | to_json }}\""},{"line_number":118,"context_line":"              loop: \"{{ groups[\u0027ipaservice\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}\""},{"line_number":119,"context_line":"            - include_role:"},{"line_number":120,"context_line":"                name: tripleo_ipa_dns"},{"line_number":121,"context_line":"                apply:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"2bc1ad44_70784c7d","line":118,"range":{"start_line":118,"start_character":14,"end_line":118,"end_character":91},"in_reply_to":"6f18d898_c942d679","updated":"2023-05-26 12:37:00.000000000","message":"Of course, we\u0027re going to need to throttle the whole thing here to not overload ipa.","commit_id":"fd3d57f39c746e2aad9937567944eaa2c1ac9b36"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"bcf4fb36a2b16e0f2191dfcc567664157e6988c6","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":136,"context_line":"              - if:"},{"line_number":137,"context_line":"                - idm_server_provided"},{"line_number":138,"context_line":"                - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":139,"context_line":"        # TODO(alee) make sure this next bit executes on on nodes in"},{"line_number":140,"context_line":"        # {{ groups[\u0027ipaservice\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}"},{"line_number":141,"context_line":"        - name: enroll the node as an ipa client"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"286456fc_b3e52979","line":138,"updated":"2023-05-26 12:35:34.000000000","message":"This is interesting because we don\u0027t have a loop here.  So, we will need run_once here to make sure this only runs once.  But if run_once doesn\u0027t work, we can just do this in the external_deploy_tasks -- i.e it can be added later.","commit_id":"fd3d57f39c746e2aad9937567944eaa2c1ac9b36"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"26cedf275bdc3b103f739b65b9ff0bfeef71e95d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":136,"context_line":"              - if:"},{"line_number":137,"context_line":"                - idm_server_provided"},{"line_number":138,"context_line":"                - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":139,"context_line":"        # TODO(alee) make sure this next bit executes on on nodes in"},{"line_number":140,"context_line":"        # {{ groups[\u0027ipaservice\u0027] | difference(groups[\u0027excluded_overcloud\u0027]) }}"},{"line_number":141,"context_line":"        - name: enroll the node as an ipa client"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6542cd73_015dd888","line":138,"in_reply_to":"286456fc_b3e52979","updated":"2023-05-31 06:29:04.000000000","message":"Done","commit_id":"fd3d57f39c746e2aad9937567944eaa2c1ac9b36"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2f27413e28c1f552d403c671d827adfb1fd0303f","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      service_name: ipaservice"},{"line_number":96,"context_line":"      upgrade_tasks: []"},{"line_number":97,"context_line":"      step_config: \u0027\u0027"},{"line_number":98,"context_line":"      ipa_registration_tasks:"},{"line_number":99,"context_line":"        - name: Get undercloud FQDN"},{"line_number":100,"context_line":"          delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":101,"context_line":"          set_fact:"},{"line_number":102,"context_line":"            undercloud_fqdn: \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":103,"context_line":"        - include_role:"},{"line_number":104,"context_line":"            name: tripleo_ipa_registration"},{"line_number":105,"context_line":"            apply:"},{"line_number":106,"context_line":"              delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":107,"context_line":"              environment:"},{"line_number":108,"context_line":"                map_merge:"},{"line_number":109,"context_line":"                  - IPA_USER: \"nova/{{ undercloud_fqdn }}\""},{"line_number":110,"context_line":"                    KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":111,"context_line":"                    KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":112,"context_line":"                  - if:"},{"line_number":113,"context_line":"                    - idm_server_provided"},{"line_number":114,"context_line":"                    - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":115,"context_line":"          vars:"},{"line_number":116,"context_line":"            tripleo_ipa_enroll_base_server: {get_param: IdMEnrollBaseServer}"},{"line_number":117,"context_line":"            tripleo_ipa_delegate_server: \"{{ inventory_hostname }}\""},{"line_number":118,"context_line":"            tripleo_ipa_base_server_fqdn:  \"{{ fqdn_canonical }}\""},{"line_number":119,"context_line":"            tripleo_ipa_server_metadata: \"{{ service_metadata_settings | to_json }}\""},{"line_number":120,"context_line":"          when: \"\u0027ipaservice\u0027 in group_names and \u0027excluded_overcloud\u0027 not in group_names\""},{"line_number":121,"context_line":"        - name: Enroll the node as an ipa client"},{"line_number":122,"context_line":"          vars:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e49c3a37_3ddb2e1c","line":119,"range":{"start_line":98,"start_character":28,"end_line":119,"end_character":84},"updated":"2023-07-11 12:52:49.000000000","message":"delegate_to does not control concurrency even if the task is delegated to the same host. Should we add serial: to avoid running this task in too many processes ? I\u0027m not too sure what is the throttling you are referring to.","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"159fed2a66dd8610a0b95a3e592d3146ff7ec6d8","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      service_name: ipaservice"},{"line_number":96,"context_line":"      upgrade_tasks: []"},{"line_number":97,"context_line":"      step_config: \u0027\u0027"},{"line_number":98,"context_line":"      ipa_registration_tasks:"},{"line_number":99,"context_line":"        - name: Get undercloud FQDN"},{"line_number":100,"context_line":"          delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":101,"context_line":"          set_fact:"},{"line_number":102,"context_line":"            undercloud_fqdn: \"{{ ansible_facts[\u0027fqdn\u0027] }}\""},{"line_number":103,"context_line":"        - include_role:"},{"line_number":104,"context_line":"            name: tripleo_ipa_registration"},{"line_number":105,"context_line":"            apply:"},{"line_number":106,"context_line":"              delegate_to: \"{{ groups[\u0027Undercloud\u0027] | first }}\""},{"line_number":107,"context_line":"              environment:"},{"line_number":108,"context_line":"                map_merge:"},{"line_number":109,"context_line":"                  - IPA_USER: \"nova/{{ undercloud_fqdn }}\""},{"line_number":110,"context_line":"                    KRB5_CLIENT_KTNAME: {get_param: IdMNovaKeytab}"},{"line_number":111,"context_line":"                    KRB5CCNAME: {get_param: IdMNovaCredentialCache}"},{"line_number":112,"context_line":"                  - if:"},{"line_number":113,"context_line":"                    - idm_server_provided"},{"line_number":114,"context_line":"                    - IPA_HOST: {get_param: [IdMServer, 0]}"},{"line_number":115,"context_line":"          vars:"},{"line_number":116,"context_line":"            tripleo_ipa_enroll_base_server: {get_param: IdMEnrollBaseServer}"},{"line_number":117,"context_line":"            tripleo_ipa_delegate_server: \"{{ inventory_hostname }}\""},{"line_number":118,"context_line":"            tripleo_ipa_base_server_fqdn:  \"{{ fqdn_canonical }}\""},{"line_number":119,"context_line":"            tripleo_ipa_server_metadata: \"{{ service_metadata_settings | to_json }}\""},{"line_number":120,"context_line":"          when: \"\u0027ipaservice\u0027 in group_names and \u0027excluded_overcloud\u0027 not in group_names\""},{"line_number":121,"context_line":"        - name: Enroll the node as an ipa client"},{"line_number":122,"context_line":"          vars:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a323fd13_63bd13fd","line":119,"range":{"start_line":98,"start_character":28,"end_line":119,"end_character":84},"in_reply_to":"e49c3a37_3ddb2e1c","updated":"2023-07-11 13:00:50.000000000","message":"We tested throttling in a previous patch, we actually want it to run concurrently and we tested that running it in this way doesn\u0027t break FreeIPA/IDM","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2f27413e28c1f552d403c671d827adfb1fd0303f","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            tripleo_ipa_delegate_server: \"{{ inventory_hostname }}\""},{"line_number":118,"context_line":"            tripleo_ipa_base_server_fqdn:  \"{{ fqdn_canonical }}\""},{"line_number":119,"context_line":"            tripleo_ipa_server_metadata: \"{{ service_metadata_settings | to_json }}\""},{"line_number":120,"context_line":"          when: \"\u0027ipaservice\u0027 in group_names and \u0027excluded_overcloud\u0027 not in group_names\""},{"line_number":121,"context_line":"        - name: Enroll the node as an ipa client"},{"line_number":122,"context_line":"          vars:"},{"line_number":123,"context_line":"            ipaclient_install_packages: {get_param: IdMInstallClientPackages}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e19f2722_f4b1f41d","line":120,"range":{"start_line":120,"start_character":17,"end_line":120,"end_character":44},"updated":"2023-07-11 12:52:49.000000000","message":"I think you don\u0027t really need this because these tasks are associated with roles which contains ipaservice.","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2f27413e28c1f552d403c671d827adfb1fd0303f","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                        yaql:"},{"line_number":186,"context_line":"                          expression: $.data.toUpper()"},{"line_number":187,"context_line":"                          data: {get_param: IdMDomain}"},{"line_number":188,"context_line":"          when: \"\u0027ipaservice\u0027 in group_names and \u0027excluded_overcloud\u0027 not in group_names\""},{"line_number":189,"context_line":"      external_deploy_tasks:"},{"line_number":190,"context_line":"        - name: add the DNS entries into IPA in step 1"},{"line_number":191,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"b0a3d79b_e2491999","line":188,"range":{"start_line":188,"start_character":17,"end_line":188,"end_character":44},"updated":"2023-07-11 12:52:49.000000000","message":"I think you don\u0027t really need this because these tasks are associated with roles which contains ipaservice.","commit_id":"09e149f7f2ad0157f3158e77f97ce54699d19c8a"}]}