)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"02ddd6a075aa033d2c18b5a3f0adecdf1e3ea194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64974681_df4bdcef","updated":"2023-05-08 08:56:57.000000000","message":"Thanks for the review!","commit_id":"03a4949043ab93a7803b117c0c211ae705ab4bce"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"20d429a73fba9ce3cd766607a34527cba572caab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39991a53_5b6db908","updated":"2023-05-10 05:43:16.000000000","message":"recheck","commit_id":"03a4949043ab93a7803b117c0c211ae705ab4bce"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"9eda7110e3576e58173e398bf63db3294250c7e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"033586d3_e94c0884","updated":"2023-05-08 16:57:21.000000000","message":"recheck multiple failures","commit_id":"03a4949043ab93a7803b117c0c211ae705ab4bce"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"5df352e18af163587aa3556107fae391eca6fa7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c42c00db_61eae5d0","updated":"2023-05-10 15:17:19.000000000","message":"recheck undercloud-ff-wallaby post-failure","commit_id":"03a4949043ab93a7803b117c0c211ae705ab4bce"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e54fe1e281ebb78bf82028b393df078bb7573125","unresolved":true,"context_lines":[{"line_number":660,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":661,"context_line":"                - str_replace:"},{"line_number":662,"context_line":"                    template:"},{"line_number":663,"context_line":"                      \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:PORT\""},{"line_number":664,"context_line":"                    params:"},{"line_number":665,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, GlanceApiNetwork]}"},{"line_number":666,"context_line":"                      PORT: {get_param: [EndpointMap, GlanceInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6b8fa99a_92ac333b","line":663,"range":{"start_line":663,"start_character":33,"end_line":663,"end_character":39},"updated":"2023-05-05 14:55:58.000000000","message":"Wallaby uses \u0027hiera\u0027 not \u0027lookup\u0027, so this needs to be changed here and again on L669. The problem with pep8 is the yaml validation tool [1] is specifically looking for \"hiera\". \n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/wallaby/tools/yaml-validate.py#L1125\n\nI suspect the tool needs to be fixed on master for pep8 to work on master, and I don\u0027t know why yaml validation on master isn\u0027t failing for everyone.","commit_id":"12e74c01070087bcf0bdb1dfd0073f0efa8951c3"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"02ddd6a075aa033d2c18b5a3f0adecdf1e3ea194","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":661,"context_line":"                - str_replace:"},{"line_number":662,"context_line":"                    template:"},{"line_number":663,"context_line":"                      \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:PORT\""},{"line_number":664,"context_line":"                    params:"},{"line_number":665,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, GlanceApiNetwork]}"},{"line_number":666,"context_line":"                      PORT: {get_param: [EndpointMap, GlanceInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"187347e2_0890b0a1","line":663,"range":{"start_line":663,"start_character":33,"end_line":663,"end_character":39},"in_reply_to":"3277cc45_2f4bfd62","updated":"2023-05-08 08:56:57.000000000","message":"Ohh I directly cherry-picked to stable/wallaby from the browser and missed to replace \u0027lookup\u0027 with \u0027hiera\u0027","commit_id":"12e74c01070087bcf0bdb1dfd0073f0efa8951c3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2ee202e1f5e1ef8ac97bd2b0f87c2bcb43200a19","unresolved":true,"context_lines":[{"line_number":660,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":661,"context_line":"                - str_replace:"},{"line_number":662,"context_line":"                    template:"},{"line_number":663,"context_line":"                      \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:PORT\""},{"line_number":664,"context_line":"                    params:"},{"line_number":665,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, GlanceApiNetwork]}"},{"line_number":666,"context_line":"                      PORT: {get_param: [EndpointMap, GlanceInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf86659e_cec4a262","line":663,"range":{"start_line":663,"start_character":33,"end_line":663,"end_character":39},"in_reply_to":"6b8fa99a_92ac333b","updated":"2023-05-05 15:03:46.000000000","message":"The yaml tool on master is using \u0027lookup\u0027 [1], so I don\u0027t know why the master version of this patch [2] was failing pep8. I\u0027m not inclined to investigate further, though, because we\u0027re no longer maintaining master|zed.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/tools/yaml-validate.py#L1064\n[2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/878517","commit_id":"12e74c01070087bcf0bdb1dfd0073f0efa8951c3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a96bc704ba346db729159dd8e6037a95c2aacdd9","unresolved":true,"context_lines":[{"line_number":660,"context_line":"                - {get_param: EnableInternalTLS}"},{"line_number":661,"context_line":"                - str_replace:"},{"line_number":662,"context_line":"                    template:"},{"line_number":663,"context_line":"                      \"https://%{lookup(\u0027fqdn_NETWORK\u0027)}:PORT\""},{"line_number":664,"context_line":"                    params:"},{"line_number":665,"context_line":"                      NETWORK: {get_param: [ServiceNetMap, GlanceApiNetwork]}"},{"line_number":666,"context_line":"                      PORT: {get_param: [EndpointMap, GlanceInternal, port]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3277cc45_2f4bfd62","line":663,"range":{"start_line":663,"start_character":33,"end_line":663,"end_character":39},"in_reply_to":"bf86659e_cec4a262","updated":"2023-05-05 15:23:05.000000000","message":"master version is failing as ansible-lint not compatible with ansible-compat version used https://github.com/ansible/ansible-compat/pull/245\n\ncompatibility fix in ansible-lint https://github.com/ansible/ansible-lint/commit/2fca3fed958702a2b40dd454511ea1b9f624c740\nso we have to pin ansible-compat too(as ansible-lint is pinned) in stable/wallaby but separate patch.\n\n+1 to fix use of hiera","commit_id":"12e74c01070087bcf0bdb1dfd0073f0efa8951c3"}]}