)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"305bc31c85c831d71da2e2495d4ac34bfc3c4a1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ade31b5e_84ced393","updated":"2023-05-23 16:02:03.000000000","message":"why do wee need to remove these?","commit_id":"ab2722e38589f2738d4446ce251a8218dfc7a64b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d480919cf9efbc9e59ba0b7700c8dbf5d097806c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"281a8500_f6c8b063","in_reply_to":"ade31b5e_84ced393","updated":"2023-06-15 16:37:09.000000000","message":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d2196288","commit_id":"ab2722e38589f2738d4446ce251a8218dfc7a64b"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"668f33675dfb76f0118eba7869727de141819b0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f64c2978_545629d6","updated":"2023-06-10 09:26:34.000000000","message":"recheck","commit_id":"424693cd0d49357db3480484877da03d47593bb8"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7f30cdf2c3a7537b2c1ac7cc8a7c7e22f4d11079","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1fa166b2_4149d603","updated":"2023-06-12 11:52:48.000000000","message":"nit: release notes please?","commit_id":"60389dd84b7a0722ba08265bb8a0a525a08c4710"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"ef6a2f2dae9ae0f39621edbc9c844a7db1f94a1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"186a0b73_b7e47361","in_reply_to":"1fa166b2_4149d603","updated":"2023-06-14 15:01:15.000000000","message":"done","commit_id":"60389dd84b7a0722ba08265bb8a0a525a08c4710"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"2796aa35717517289c273860a2137995a82f8bcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1f82ac4_f657ff67","updated":"2023-06-15 15:24:27.000000000","message":"I am against it as it should be run before leapp or during the leapp. This change is very disruptive as leapp may act differently from what we expect.","commit_id":"302f463a66d288355a7020f3a29b78c1d37391e8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d480919cf9efbc9e59ba0b7700c8dbf5d097806c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ceaaf878_e78d5c07","in_reply_to":"b1f82ac4_f657ff67","updated":"2023-06-15 16:37:09.000000000","message":"This patch provides a facility to execute something after leapp has run and before the reboot. I don\u0027t see how this facility is disruptive. Sure, how it is used could be disruptive, but that is different from having a facility/hook to run at this point in the execution.\n\nThis is a clear need. Do you have an alternative suggestion for how this can be facilitated?","commit_id":"302f463a66d288355a7020f3a29b78c1d37391e8"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"a5f57da4604aaeda960488cd7c487b559c44fc09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf92e9bc_c64cf2b6","in_reply_to":"ceaaf878_e78d5c07","updated":"2023-06-16 12:37:48.000000000","message":"Leapp run should be taken as single transaction including reboot. Running leapp upgrade, then hack, then reboot makes almost impossible to debug when and why system is stuck during reboot. If we want to hack anything, we should do that before \"leapp upgrade\", if we want to do changes during leapp (which includes reboot), we should add changes to leapp\u0027s actor.","commit_id":"302f463a66d288355a7020f3a29b78c1d37391e8"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"f67a901f2137cb51331c6e52536d450d5fd37e9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"662b5284_73463d10","updated":"2023-06-27 20:10:32.000000000","message":"recheck","commit_id":"a2c07f0526496678ce69949143bb99c79bc6a536"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8b5ea45f68d4a0e961000ed23538a8ff2d211e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cc83ebee_ca6fa6d4","updated":"2023-06-28 08:16:21.000000000","message":"recheck","commit_id":"a2c07f0526496678ce69949143bb99c79bc6a536"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"908eb69e62e224f6d1da6392ab8ba5262912f271","unresolved":true,"context_lines":[{"line_number":358,"context_line":"            - name: Remove console on kernel parameters"},{"line_number":359,"context_line":"              shell: |"},{"line_number":360,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0"},{"line_number":361,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0,115200n81"},{"line_number":362,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":363,"context_line":"              reboot:"},{"line_number":364,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8292d0cc_565f91bc","line":361,"updated":"2023-05-23 12:55:49.000000000","message":"Would it make better sense to do something like:\n\n  check if the argument exists\n  capture the whole argument (eg: console\u003dttyS0,115200n81)\n  remove the whole argument\n\nThis would make it idempotent.","commit_id":"ab2722e38589f2738d4446ce251a8218dfc7a64b"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b1a8f41dfdd78578a3a35b3abfc1ca85b3aaf3af","unresolved":true,"context_lines":[{"line_number":358,"context_line":"            - name: Remove console on kernel parameters"},{"line_number":359,"context_line":"              shell: |"},{"line_number":360,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0"},{"line_number":361,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0,115200n81"},{"line_number":362,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":363,"context_line":"              reboot:"},{"line_number":364,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d744bb5e_077fcb51","line":361,"in_reply_to":"199e15a4_9e696e4c","updated":"2023-05-25 07:30:21.000000000","message":"Both me and Steve has commented on the Bz. There is not enough details to understand the root cause. We would like to avoid removing ttyS0, especially now that tty0 was removed. Let\u0027s continue discussions in bugzilla.","commit_id":"ab2722e38589f2738d4446ce251a8218dfc7a64b"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"2a2c0572d7880d1bafd73d39a6beea9b0f382baa","unresolved":true,"context_lines":[{"line_number":358,"context_line":"            - name: Remove console on kernel parameters"},{"line_number":359,"context_line":"              shell: |"},{"line_number":360,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0"},{"line_number":361,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0,115200n81"},{"line_number":362,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":363,"context_line":"              reboot:"},{"line_number":364,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"199e15a4_9e696e4c","line":361,"in_reply_to":"27a1b5b2_88381517","updated":"2023-05-23 21:32:59.000000000","message":"https://bugzilla.redhat.com/show_bug.cgi?id\u003d2196288 is a bz filed.","commit_id":"ab2722e38589f2738d4446ce251a8218dfc7a64b"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8b8b8a2a525b45ff3e3903fa510a80c54971dd35","unresolved":true,"context_lines":[{"line_number":358,"context_line":"            - name: Remove console on kernel parameters"},{"line_number":359,"context_line":"              shell: |"},{"line_number":360,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0"},{"line_number":361,"context_line":"                grubby --update-kernel\u003dALL --remove-args\u003dconsole\u003dttyS0,115200n81"},{"line_number":362,"context_line":"            - name: reboot to perform the upgrade"},{"line_number":363,"context_line":"              reboot:"},{"line_number":364,"context_line":"                reboot_timeout: \"{{upgrade_leapp_reboot_timeout}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"27a1b5b2_88381517","line":361,"in_reply_to":"8292d0cc_565f91bc","updated":"2023-05-23 20:20:15.000000000","message":"We need some details on why ttyS0 needs to be removed from the kernel args. We\u0027re already proposing to remove tty0[1] and that has a linked bug and a bunch of discussion about the options.\n\nAlso I\u0027d have a strong preference for keeping any kernel arg manipulation in the tripleo-ansible tripleo_kernel role. Speaking of which, [1] could do with some reviews, since it has been proposed for removing tty0 during upgrade.\n\n[1] https://review.opendev.org/c/openstack/tripleo-ansible/+/880901","commit_id":"ab2722e38589f2738d4446ce251a8218dfc7a64b"}]}